rspec-html-matchers 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8be66d725f89beeac9807e254253f19f9a4f9309
-  data.tar.gz: 0652146df0dca81d60e2f1b420660ebcc0307d8a
+  metadata.gz: be58541a3ca3493891f55b4edfb8d92aeec1bb70
+  data.tar.gz: 6496944bc83e1fde56b17327e42bebaf95f2e926
 SHA512:
-  metadata.gz: 134663281de1d4af000d01ecd68eee731941e1f20c132f0a9e1fb4a3294dc0968f34dceb701ff836c907a664a95cf561bcd2692537afd67fe688d5bd5bdf1f5e
-  data.tar.gz: 599a0dd8096dbc6c1e19d8524d8b81351e1c37386a84a9dde242af9769e00d1a5066fbce7692df9e7030008c5dd525ab2aa855665404cf3343ef3d5295b39686
+  metadata.gz: 31cf7e98ae6ce59d5a01c9ebf18aa4f142d1d87840c07baeb4ec6663f2d2caa95a740d542a2b2034e53e0a773a5011cb8645adcb4e56bb4bbca9eb001d1de4bd
+  data.tar.gz: b1d6768ffd9475d0aded6f7205a5aa8ff377eb01b6963c826c81853419c86558d7190c805902074c7349aebb4397160f42925b20d221d76ca9936afc04b9128e

data/CHANGELOG.md

@@ -11,6 +11,12 @@ unreleased(TODO)
 * order matching
 * improve documentation, add more usage examples (look at changelog and code!)
 
+0.7.2
+-----
+
+* add support for `frozen_string_literals`
+* fix for rdoc links and not only
+
 0.7.1
 -----
 

data/README.md

@@ -14,9 +14,9 @@ Goals
   * [matchers provided out of the box in rspec-rails](https://www.relishapp.com/rspec/rspec-rails/v/2-11/docs/view-specs/view-spec)
   * [matchers provided by capybara](http://rdoc.info/github/jnicklas/capybara/Capybara/Node/Matchers)
 * developer-firendly output in error messages
-* built on top of [nokogiri](nokogiri.org)
+* built on top of [nokogiri](http://www.nokogiri.org/)
 * has support for [capybara](https://github.com/jnicklas/capybara), see below
-* syntax is similar to [have_tag](http://old.rspec.info/rails/writing/views.html) matcher from old-school rspec-rails, but with own syntactic sugar
+* syntax is similar to have_tag matcher from rspec-rails 1.x, but with own syntactic sugar
 * framework agnostic, as input should be String(or capybara's page, see below)
 
 Install
@@ -85,7 +85,7 @@ expect(rendered).to have_tag('form', :with => { :action => '/users', :method =>
 end
 ```
 
-Example about should be self-descriptive, but if not refer to [have_tag](http://rdoc.info/github/kucaahbe/rspec-html-matchers/RSpec/Matchers:have_tag) documentation
+Example about should be self-descriptive, if not, please refer to [have_tag](http://www.rubydoc.info/gems/rspec-html-matchers/RSpecHtmlMatchers%3Ahave_tag) documentation
 
 Input could be any html string. Let's take a look at these examples:
 
@@ -166,25 +166,26 @@ where `page` is an instance of Capybara::Session
 
 * also included shorthand matchers for form inputs:
 
-  - [have\_form](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:have_form)
-  - [with\_checkbox](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_checkbox)
-  - [with\_email\_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_email_field)
-  - [with\_file\_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_file_field)
-  - [with\_hidden\_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_hidden_field)
-  - [with\_option](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_option)
-  - [with\_password_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_password_field)
-  - [with\_radio\_button](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_radio_button)
-  - [with\_button](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_button)
-  - [with\_select](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_select)
-  - [with\_submit](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_submit)
-  - [with\_text\_area](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_text_area)
-  - [with\_text\_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_text_field)
-  - [with\_url\_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_url_field)
-  - [with\_number\_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_number_field)
-  - [with\_range\_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_range_field)
-  - [with\_date\_field](http://rdoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers:with_date_field)
-
-and of course you can use the `without_` matchers (see the documentation).
+  - have\_form
+  - with\_checkbox
+  - with\_email\_field
+  - with\_file\_field
+  - with\_hidden\_field
+  - with\_option
+  - with\_password\_field
+  - with\_radio\_button
+  - with\_button
+  - with\_select
+  - with\_submit
+  - with\_text\_area
+  - with\_text\_field
+  - with\_url\_field
+  - with\_number\_field
+  - with\_range\_field
+  - with\_date\_field
+
+and of course you can use the `without_` matchers,
+for more info take a look at [documentation](http://www.rubydoc.info/gems/rspec-html-matchers/RSpecHtmlMatchers)
 
 ### rspec 1 partial backwards compatibility:
 
@@ -200,9 +201,9 @@ expect(response).to have_tag('div', /regexp matching expected content/)
 More info
 ---------
 
-You can find more on [RubyDoc](http://rubydoc.info/github/kucaahbe/rspec-html-matchers/master/RSpec/Matchers), take a look at [have_tag](http://rdoc.info/github/kucaahbe/rspec-html-matchers/RSpec/Matchers#have_tag-instance_method) method.
+You can find more on [documentation](http://www.rubydoc.info/gems/rspec-html-matchers/RSpecHtmlMatchers)
 
-Also, please read [CHANGELOG](https://github.com/kucaahbe/rspec-html-matchers/blob/master/CHANGELOG.md), it might be helpful.
+Also, please read [CHANGELOG](https://github.com/kucaahbe/rspec-html-matchers/blob/master/CHANGELOG.md) and [issues](https://github.com/kucaahbe/rspec-html-matchers/issues), might be helpful.
 
 Contribution
 ============

data/lib/rspec-html-matchers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # encoding: UTF-8
 require 'rspec'
 require 'nokogiri'
@@ -79,18 +80,18 @@ module RSpecHtmlMatchers
 
       if with_attrs = @options.delete(:with)
         if classes = with_attrs.delete(:class)
-          @tag << '.' + classes_to_selector(classes)
+          @tag += '.' + classes_to_selector(classes)
         end
         selector = with_attrs.inject('') do |html_attrs_string, (k, v)|
-          html_attrs_string << "[#{k}='#{v}']"
+          html_attrs_string += "[#{k}='#{v}']"
         html_attrs_string
         end
-        @tag << selector
+        @tag += selector
       end
 
       if without_attrs = @options.delete(:without)
         if classes = without_attrs.delete(:class)
-          @tag << ":not(.#{classes_to_selector(classes)})"
+          @tag += ":not(.#{classes_to_selector(classes)})"
         end
       end
 
@@ -275,6 +276,10 @@ module RSpecHtmlMatchers
     @__current_scope_for_nokogiri_matcher = HaveTag.new(tag, options, &block)
   end
 
+  def have_empty_tag tag, options={}
+    have_tag(tag, options.merge(text: ""))
+  end
+
   def with_text text
     raise StandardError, 'this matcher should be used inside "have_tag" matcher block' unless defined?(@__current_scope_for_nokogiri_matcher)
     raise ArgumentError, 'this matcher does not accept block' if block_given?
@@ -315,13 +320,13 @@ module RSpecHtmlMatchers
   def have_form action_url, method, options={}, &block
     options[:with] ||= {}
     id = options[:with].delete(:id)
-    tag = 'form'; tag << '#'+id if id
+    tag = 'form'; tag += '#'+id if id
     options[:with].merge!(:action => action_url)
     options[:with].merge!(:method => method.to_s)
     have_tag tag, options, &block
   end
 
-  #TODO fix code duplications
+  #@TODO fix code duplications
 
   def with_hidden_field name, value=nil
     options = form_tag_options('hidden',name,value)
@@ -403,8 +408,8 @@ module RSpecHtmlMatchers
     should_not_have_input(options)
   end
 
-  # TODO add ability to explicitly say that value should be empty
   def with_password_field name, value=nil
+    # TODO add ability to explicitly say that value should be empty
     options = form_tag_options('password',name,value)
     should_have_input(options)
   end
@@ -424,13 +429,15 @@ module RSpecHtmlMatchers
     should_not_have_input(options)
   end
 
-  def with_text_area name#TODO, text=nil
+  def with_text_area name
+    # TODO, should be: with_text_area name, text=nil
     #options = form_tag_options('text',name,value)
     options = { :with => { :name => name } }
     expect(@__current_scope_for_nokogiri_matcher).to have_tag('textarea', options)
   end
 
-  def without_text_area name#TODO, text=nil
+  def without_text_area name
+    # TODO, should be: without_text_area name, text=nil
     #options = form_tag_options('text',name,value)
     options = { :with => { :name => name } }
     expect(@__current_scope_for_nokogiri_matcher).to_not have_tag('textarea', options)
@@ -459,7 +466,7 @@ module RSpecHtmlMatchers
   def with_select name, options={}, &block
     options[:with] ||= {}
     id = options[:with].delete(:id)
-    tag='select'; tag << '#'+id if id
+    tag='select'; tag += '#'+id if id
     options[:with].merge!(:name => name)
     expect(@__current_scope_for_nokogiri_matcher).to have_tag(tag, options, &block)
   end
@@ -467,7 +474,7 @@ module RSpecHtmlMatchers
   def without_select name, options={}, &block
     options[:with] ||= {}
     id = options[:with].delete(:id)
-    tag='select'; tag << '#'+id if id
+    tag='select'; tag += '#'+id if id
     options[:with].merge!(:name => name)
     expect(@__current_scope_for_nokogiri_matcher).to_not have_tag(tag, options, &block)
   end

data/spec/have_empty_tag_spec.rb

@@ -0,0 +1,29 @@
+# encoding: UTF-8
+require 'spec_helper'
+
+describe 'have_empty_tag' do
+  context 'when single element' do
+    asset 'single_element'
+
+    it { expect(rendered).to have_empty_tag('div') }
+    it { expect(rendered).to have_empty_tag('div', class: "foo") }
+    it { expect(rendered).to have_empty_tag('div', class: "bar") }
+    it { expect(rendered).to have_empty_tag('div', class: "foo bar") }
+  end
+
+  context 'when paragraphs' do
+    asset 'paragraphs'
+
+    it { expect(rendered).to_not have_empty_tag('p') }
+  end
+
+  context 'when ordered list' do
+    asset 'ordered_list'
+
+    it { expect(rendered).to_not have_empty_tag('html') }
+    it { expect(rendered).to_not have_empty_tag('body') }
+    it { expect(rendered).to_not have_empty_tag('ol') }
+    it { expect(rendered).to_not have_empty_tag('ol', class: 'menu') }
+    it { expect(rendered).to_not have_empty_tag('li') }
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-html-matchers
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - kucaahbe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-17 00:00:00.000000000 Z
+date: 2016-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -142,6 +142,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 'Nokogiri based ''have_tag'' and ''with_tag'' matchers for rspec 3. Does
   not depend on assert_select matcher, provides useful error messages.
 
@@ -161,6 +175,7 @@ files:
 - features/support/env.rb
 - lib/rspec-html-matchers.rb
 - spec/form_matchers_spec.rb
+- spec/have_empty_tag_spec.rb
 - spec/have_tag_spec.rb
 - spec/spec_helper.rb
 - spec/support/asset_helpers.rb
@@ -191,6 +206,7 @@ specification_version: 4
 summary: Nokogiri based 'have_tag' and 'with_tag' matchers for rspec 3
 test_files:
 - spec/form_matchers_spec.rb
+- spec/have_empty_tag_spec.rb
 - spec/have_tag_spec.rb
 - spec/spec_helper.rb
 - spec/support/asset_helpers.rb
@@ -198,3 +214,4 @@ test_files:
 - features/step_definitions/steps.rb
 - features/support/env.rb
 - features/js_generated_content.feature
+has_rdoc: