rspec-expectations 3.8.3 → 3.8.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 35a04d20c51a45fbf58b5bf8ccdcd5d86f4e2c106aee9906afd3d3bb8e417b62
-  data.tar.gz: 3c8218a13a68549fc5df77a74584d87fa71d954058f61bd1710bc8aeeddc2bfd
+  metadata.gz: c3287d393bfe1d8bb47a19be373b09d965c86541f96844a6ee20666eac8e3b22
+  data.tar.gz: 498320228bbe272e0b1c41e86f15b3c434e418c0c3d1f5afcb3630e6f450cdaf
 SHA512:
-  metadata.gz: f196ef51fc2f48e4d5dd5a685b0847f797c5ef8e0de9b294873dbcadbcb2f2fb1574ef1662052f2e127083195a149ae604a95f5725cd879f912d586be2b37d8f
-  data.tar.gz: 93a6786e1205e5baddad562b0162de3452b9659a73f7a566e40a1c7c7b93d60637b64db27a366056b93a1a6187436feddd3a0eb80507ed69a37b8a6747bc23e2
+  metadata.gz: cc82b0fde107519cd587adc48435e9cdd11d563bae144a4a45ac78b625eb0ea36bad76a7c0d7cfb4514d81d78f9029087b76ef4a89cd208f0610c53ee0a887e4
+  data.tar.gz: 2b5c42079a2f100d9ce9b0e6046b392350df1064977d4a56c78696459deecd279ab85a3b9d5b392828d60b44ba0aad1de9ee320c5bcb040d4bcf7bd079756c5f

data/Changelog.md

@@ -1,5 +1,10 @@
-### Development
-[Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.3...3-8-maintenance)
+### 3.8.4 / 2019-06-10
+[Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.3...v3.8.4)
+
+Bug Fixes:
+
+* Prevent false negatives when checking objects for the methods required to run the
+  the `be_an_instance_of` and `be_kind_of` matchers. (Nazar Matus, #1112)
 
 ### 3.8.3 / 2019-04-20
 [Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.2...v3.8.3)

data/lib/rspec/expectations/version.rb

@@ -2,7 +2,7 @@ module RSpec
   module Expectations
     # @private
     module Version
-      STRING = '3.8.3'
+      STRING = '3.8.4'
     end
   end
 end

data/lib/rspec/matchers/built_in/be_instance_of.rb

@@ -14,17 +14,11 @@ module RSpec
       private
 
         def match(expected, actual)
-          if actual_object_respond_to?(actual, :instance_of?)
-            actual.instance_of?(expected)
-          else
-            raise ::ArgumentError, "The #{matcher_name} matcher requires that " \
-                                   "the actual object responds to #instance_of? method " \
-                                   "but it does not respond to the method."
-          end
-        end
-
-        def actual_object_respond_to?(actual, method)
-          ::Kernel.instance_method(:respond_to?).bind(actual).call(method)
+          actual.instance_of?(expected)
+        rescue NoMethodError
+          raise ::ArgumentError, "The #{matcher_name} matcher requires that " \
+                                 "the actual object responds to #instance_of? method " \
+                                 "but a `NoMethodError` was encountered instead."
         end
       end
     end

data/lib/rspec/matchers/built_in/be_kind_of.rb

@@ -8,19 +8,11 @@ module RSpec
       private
 
         def match(expected, actual)
-          if actual_object_respond_to?(actual, :kind_of?)
-            actual.kind_of?(expected)
-          elsif actual_object_respond_to?(actual, :is_a?)
-            actual.is_a?(expected)
-          else
-            raise ::ArgumentError, "The #{matcher_name} matcher requires that " \
-                                   "the actual object responds to either #kind_of? or #is_a? methods "\
-                                   "but it responds to neigher of two methods."
-          end
-        end
-
-        def actual_object_respond_to?(actual, method)
-          ::Kernel.instance_method(:respond_to?).bind(actual).call(method)
+          actual.kind_of?(expected)
+        rescue NoMethodError
+          raise ::ArgumentError, "The #{matcher_name} matcher requires that " \
+                                 "the actual object responds to #kind_of? method " \
+                                 "but a `NoMethodError` was encountered instead."
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-expectations
 version: !ruby/object:Gem::Version
-  version: 3.8.3
+  version: 3.8.4
 platform: ruby
 authors:
 - Steven Baker
@@ -45,7 +45,7 @@ cert_chain:
   ZsVDj6a7lH3cNqtWXZxrb2wO38qV5AkYj8SQK7Hj3/Yui9myUX3crr+PdetazSqQ
   F3MdtaDehhjC
   -----END CERTIFICATE-----
-date: 2019-04-21 00:00:00.000000000 Z
+date: 2019-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-support
@@ -202,7 +202,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rspec/rspec-expectations/issues
-  changelog_uri: https://github.com/rspec/rspec-expectations/blob/v3.8.3/Changelog.md
+  changelog_uri: https://github.com/rspec/rspec-expectations/blob/v3.8.4/Changelog.md
   documentation_uri: https://rspec.info/documentation/
   mailing_list_uri: https://groups.google.com/forum/#!forum/rspec
   source_code_uri: https://github.com/rspec/rspec-expectations
@@ -225,5 +225,5 @@ requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: rspec-expectations-3.8.3
+summary: rspec-expectations-3.8.4
 test_files: []