rspec-core 3.3.1 → 3.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 87afec860d1dd3babbfce0db2ae19280a96b2ae8
-  data.tar.gz: ba04ec0a5494006db9f7acb76bdf0522ab775801
+  metadata.gz: ed490eba43a1bc1c89b22c0fa7af696ad9871c95
+  data.tar.gz: 6920d6d13e2a80cf8a07730a874776e405693833
 SHA512:
-  metadata.gz: 80a5347f44415ebac75f1d32cb5c162d7f3514fdad43b9b806e5081faa350fbe17b0b37884367a5258c9e1126b16c397aa038fe653fe3c81fbbecf868d1018c8
-  data.tar.gz: acb47e5a2aa11bbb38fde5e139798e8e20c33ab4dfcfa37ff99e36bf16c5b8758fc61f6fa1e9d19bfd0e61ffd0399bdb1f3bda75438f0f2c1ac7f137c315af82
+  metadata.gz: d488e49c9e089b44e33fbc0a3842d10208a0fec083b2bfe34f3b5de099df78b4c11b033edf6b097189059ba975b1cb4159c3205e21f5301dc68d2103b7280a0a
+  data.tar.gz: f51830dffbc16c9baf5170dcccba7b969578627154e1cca492a8aaad29f37832ea1fc5d31f16bd39e558beb28fdf52f2121a4fc5394ed2b1c5b9ff52144f65d5

data/Changelog.md

@@ -1,3 +1,13 @@
+### 3.3.2 / 2015-07-15
+[Full Changelog](http://github.com/rspec/rspec-core/compare/v3.3.1...v3.3.2)
+
+Bug Fixes:
+
+* Fix formatters to handle exceptions for which `backtrace` returns `nil`.
+  (Myron Marston, #2023)
+* Fix duplicate formatter detection so that it allows subclasses of formatters
+  to be added. (Sebastián Tello, #2019)
+
 ### 3.3.1 / 2015-06-18
 [Full Changelog](http://github.com/rspec/rspec-core/compare/v3.3.0...v3.3.1)
 

data/lib/rspec/core/formatters.rb

@@ -182,7 +182,7 @@ module RSpec::Core::Formatters
 
     def duplicate_formatter_exists?(new_formatter)
       @formatters.any? do |formatter|
-        formatter.class === new_formatter && formatter.output == new_formatter.output
+        formatter.class == new_formatter.class && formatter.output == new_formatter.output
       end
     end
 

data/lib/rspec/core/formatters/exception_presenter.rb

@@ -31,7 +31,7 @@ module RSpec
         end
 
         def formatted_backtrace
-          backtrace_formatter.format_backtrace(exception.backtrace, example.metadata)
+          backtrace_formatter.format_backtrace(exception_backtrace, example.metadata)
         end
 
         def colorized_formatted_backtrace(colorizer=::RSpec::Core::Formatters::ConsoleCodes)
@@ -129,7 +129,7 @@ module RSpec
 
         def find_failed_line
           example_path = example.metadata[:absolute_file_path].downcase
-          exception.backtrace.find do |line|
+          exception_backtrace.find do |line|
             next unless (line_path = line[/(.+?):(\d+)(|:\d+)/, 1])
             File.expand_path(line_path).downcase == example_path
           end
@@ -147,6 +147,10 @@ module RSpec
           formatted
         end
 
+        def exception_backtrace
+          exception.backtrace || []
+        end
+
         # @private
         # Configuring the `ExceptionPresenter` with the right set of options to handle
         # pending vs failed vs skipped and aggregated (or not) failures is not simple.

data/lib/rspec/core/formatters/html_formatter.rb

@@ -138,7 +138,7 @@ module RSpec
         # produced during the specs.
         def extra_failure_content(failure)
           RSpec::Support.require_rspec_core "formatters/snippet_extractor"
-          backtrace = failure.exception.backtrace.map do |line|
+          backtrace = (failure.exception.backtrace || []).map do |line|
             RSpec.configuration.backtrace_formatter.backtrace_line(line)
           end
           backtrace.compact!

data/lib/rspec/core/version.rb

@@ -3,7 +3,7 @@ module RSpec
     # Version information for RSpec Core.
     module Version
       # Current version of RSpec Core, in semantic versioning format.
-      STRING = '3.3.1'
+      STRING = '3.3.2'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-core
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.3.2
 platform: ruby
 authors:
 - Steven Baker
@@ -46,7 +46,7 @@ cert_chain:
   ZsVDj6a7lH3cNqtWXZxrb2wO38qV5AkYj8SQK7Hj3/Yui9myUX3crr+PdetazSqQ
   F3MdtaDehhjC
   -----END CERTIFICATE-----
-date: 2015-06-18 00:00:00.000000000 Z
+date: 2015-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-support
@@ -110,14 +110,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: 0.6.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: 0.6.2
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -307,6 +307,6 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: rspec-core-3.3.1
+summary: rspec-core-3.3.2
 test_files: []
 has_rdoc: