rspec-core 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee058acded3da2b270f4643a7cbf909f86a708ce
-  data.tar.gz: 88eaf5e071b90d31c28ce0d9ec9f92722a25bc88
+  metadata.gz: 4a9a15be489ed8cc9a0d6877e0ed6861db70e7ba
+  data.tar.gz: 5768b35b9e8a678a5d062ac78157a4bff738e5d9
 SHA512:
-  metadata.gz: 3ce2c03aa04796bc5fd6414bd84ebde8b80ba3f0e7ec379b00fdb1fc53210c953b6758ee618e16b6969658a15536c217cc02b952263215df4a398d85b128e789
-  data.tar.gz: 7c554927f21c2eb43b24b423950ffeb0c7239943f3871be8b2f86cb5beb433693bfa252f97ac7fc574246f8e97f10e3064a13658a6ec2acb20933d2b13bd2f70
+  metadata.gz: ae03bdb13bb6d53643fc746e5d1010710d9fd7fe142aad30dd975044f3cfadfe5a72e25c3fbb9dde4ef206545ef3e0663cb18fb4bd18b6eb6475b42a6e719b3e
+  data.tar.gz: a6778ff8bdbf5cf1cf8744c81b86e243d9965ecf9b6dcebef35bf64730b90dc943ce778346dfdde548542a492a355b57d21608c0070b210019380c836d633429

data/Changelog.md

@@ -1,3 +1,13 @@
+### 3.1.1 / 2014-09-05
+[Full Changelog](http://github.com/rspec/rspec-core/compare/v3.1.0...v3.1.1)
+
+Bug Fixes:
+
+* Fix a regression in rake task pattern handling, so that `rake_task.pattern = array`
+  works again. While we never intended to support array values (or even knew that worked!),
+  the implementation from 3.0 and earlier used `FileList` internally, which allows arrays.
+  The fix restores the old behavior. (Myron Marston, #1694)
+
 ### 3.1.0 / 2014-09-04
 [Full Changelog](http://github.com/rspec/rspec-core/compare/v3.0.4...v3.1.0)
 

data/lib/rspec/core/rake_task.rb

@@ -114,15 +114,25 @@ module RSpec
       def file_inclusion_specification
         if ENV['SPEC']
           FileList[ ENV['SPEC']].sort
-        elsif File.exist?(pattern)
-          # The provided pattern is a directory or a file, not a file glob. Historically, this
-          # worked because `FileList[some_dir]` would return `[some_dir]` which would
-          # get passed to `rspec` and cause it to load files under that dir that match
-          # the default pattern. To continue working, we need to pass it on to `rspec`
-          # directly rather than treating it as a `--pattern` option.
+        elsif Array === pattern || File.exist?(pattern)
+          # Before RSpec 3.1, we used `FileList` to get the list of matched files, and
+          # then pass that along to the `rspec` command. Starting with 3.1, we prefer to
+          # pass along the pattern as-is to the `rspec` command, for 3 reasons:
+          #
+          #   * It's *much* less verbose to pass one `--pattern` option than a long list of files.
+          #   * It ensures `task.pattern` and `--pattern` have the same behavior.
+          #   * It fixes a bug, where `task.pattern = pattern_that_matches_no_files` would run
+          #     *all* files because it would cause no pattern or file args to get passed to `rspec`,
+          #     which causes all files to get run.
+          #
+          # However, `FileList` is *far* more flexible than the `--pattern` option. Specifically, it
+          # supports individual files and directories, as well as arrays of files, directories and globs.
+          #
+          # For backwards compatibility, we have to fall back to using FileList if the user has passed
+          # a `pattern` option that will not work with `--pattern`.
           #
           # TODO: consider deprecating support for this and removing it in RSpec 4.
-          pattern.shellescape
+          FileList[pattern].sort.map(&:shellescape)
         else
           "--pattern #{pattern.shellescape}"
         end

data/lib/rspec/core/version.rb

@@ -3,7 +3,7 @@ module RSpec
     # Version information for RSpec Core.
     module Version
       # Current version of RSpec Core, in semantic versioning format.
-      STRING = '3.1.0'
+      STRING = '3.1.1'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-core
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Steven Baker
@@ -266,6 +266,6 @@ rubyforge_project: rspec
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: rspec-core-3.1.0
+summary: rspec-core-3.1.1
 test_files: []
 has_rdoc: 

metadata.gz.sig

@@ -1,2 +1,2 @@
-aƯ
��9t�g"e�s��TG�(��ك�G���?L*���� �b
- ��V�����@��s�D.��㱖,6�s��1ן�,ͥ�
I�� ��Y��/S	P�h�`><!�.L�醒���t��)]%���"��6<A†	5d�1@m�}�D���I�hրRkIu/Cr�=�A�����N:%�L��D"�%~z>h=ӽ�K�r)=�i$.�-���IT��v�~�i�{�!S���z�'��/.�����7D@�
+�2�9�ޏji_����K��>��h���YMp��Ɠ�)�s|a.���x/M��E���D26�7��B�#�j�̰�,��8*��͆���R\a���	���^Ÿκ:<���r«��1��4���}A��EF�ff�.��&���J�i_<�:��Q�
+��f%wR��JTJ�7𵫳m~^�92�����{pV��1.�5#[�S�.T��d!��L�O�L�Y�x�#v_b;E���=�9倭���m&,�}�B�r��Z