rspec-core 2.14.1 → 2.14.2

data/Changelog.md

@@ -1,10 +1,24 @@
+### 2.14.2 / 2013-07-09
+[full changelog](http://github.com/rspec/rspec-core/compare/v2.14.1...v2.14.2)
+
+Bug fixes
+
+* Fix regression caused by 2.14.1 release: formatters that
+  report that they `respond_to?` a notification, but had
+  no corresponding method would raise an error when registered.
+  The new fix is to just implement `start` on the deprecation
+  formatter to fix the original JRuby/ruby-debug issue.
+  (Jon Rowe)
+
 ### 2.14.1 / 2013-07-08
 [full changelog](http://github.com/rspec/rspec-core/compare/v2.14.0...v2.14.1)
 
 Bug fixes
 
-* Implement `#start` on the Deprecation Formatter to prevent collision with
-  `ruby-debug` on JRuby (Alex Portnov, Jon Rowe)
+* Address deprecation formatter failure when using `ruby-debug` on
+  JRuby: fix `RSpec::Core::Reporter` to not send a notification
+  when the formatter's implementation of the notification method
+  comes from `Kernel` (Alex Portnov, Jon Rowe).
 
 ### 2.14.0 / 2013-07-06
 [full changelog](http://github.com/rspec/rspec-core/compare/v2.14.0.rc1...v2.14.0)

data/lib/rspec/core/formatters/deprecation_formatter.rb

@@ -8,6 +8,10 @@ module RSpec
           @count = 0
         end
 
+        def start(example_count=nil)
+          #no-op to fix #966
+        end
+
         def deprecation(data)
           @count += 1
           if data[:message]

data/lib/rspec/core/reporter.rb

@@ -21,7 +21,7 @@ module RSpec::Core
     # events to all registered listeners
     def register_listener(listener, *notifications)
       notifications.each do |notification|
-        @listeners[notification.to_sym] << listener if understands(listener, notification)
+        @listeners[notification.to_sym] << listener if listener.respond_to?(notification)
       end
       true
     end
@@ -128,18 +128,5 @@ module RSpec::Core
       end
     end
 
-    private
-      if Method.method_defined?(:owner) # 1.8.6 lacks Method#owner
-        def understands(listener, notification)
-          listener.respond_to?(notification) && listener.method(notification).owner != ::Kernel
-        end
-      else
-        def understands(listener, notification)
-          # Hack for 1.8.6
-          # {}.method(:=~).to_s # => "#<Method: Hash(Kernel)#=~>"
-          listener.respond_to?(notification) && !listener.method(notification).to_s.include('(Kernel)')
-        end
-      end
-
   end
 end

data/lib/rspec/core/version.rb

@@ -1,7 +1,7 @@
 module RSpec
   module Core
     module Version
-      STRING = '2.14.1'
+      STRING = '2.14.2'
     end
   end
 end

data/spec/rspec/core/formatters/deprecation_formatter_spec.rb

@@ -4,12 +4,29 @@ require 'tempfile'
 
 module RSpec::Core::Formatters
   describe DeprecationFormatter do
+    let(:deprecation_stream) { StringIO.new }
+    let(:summary_stream)     { StringIO.new }
+    let(:formatter) { DeprecationFormatter.new deprecation_stream, summary_stream }
 
-    describe "#deprecation" do
-      let(:deprecation_stream) { StringIO.new }
-      let(:summary_stream)     { StringIO.new }
-      let(:formatter) { DeprecationFormatter.new deprecation_stream, summary_stream }
+    def with_start_defined_on_kernel
+      return yield if ::Kernel.method_defined?(:start)
+
+      begin
+        ::Kernel.module_eval { def start(*); raise "boom"; end }
+        yield
+      ensure
+        ::Kernel.module_eval { undef start }
+      end
+    end
 
+    it 'does not blow up when `Kernel` defines `start`' do
+      with_start_defined_on_kernel do
+        reporter = ::RSpec::Core::Reporter.new(formatter)
+        reporter.start(3)
+      end
+    end
+
+    describe "#deprecation" do
       it "includes the method" do
         formatter.deprecation(:deprecated => "i_am_deprecated")
         deprecation_stream.rewind

data/spec/rspec/core/reporter_spec.rb

@@ -120,28 +120,6 @@ module RSpec::Core
       end
     end
 
-    describe 'when message implemented on kernel' do
-      def with_message_defined_on_kernel
-        return yield if ::Kernel.method_defined?(:start)
-
-        begin
-          ::Kernel.module_eval { def start(*); raise "boom"; end }
-          yield
-        ensure
-          ::Kernel.module_eval { undef start }
-        end
-      end
-
-      let(:formatter) { double("formatter") }
-
-      it 'does not blow up when `Kernel` defines message instead of a formatter' do
-        with_message_defined_on_kernel do
-          reporter = ::RSpec::Core::Reporter.new(formatter)
-          reporter.start(3)
-        end
-      end
-    end
-
     describe "timing" do
       it "uses RSpec::Core::Time as to not be affected by changes to time in examples" do
         formatter = double(:formatter)

metadata

@@ -2,7 +2,7 @@
 name: rspec-core
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 2.14.1
+  version: 2.14.2
 platform: ruby
 authors:
 - Steven Baker
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2013-07-09 00:00:00.000000000 Z
+date: 2013-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
@@ -383,7 +383,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3036495542605689821
+      hash: 2476861130541035807
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
@@ -392,14 +392,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3036495542605689821
+      hash: 2476861130541035807
   none: false
 requirements: []
 rubyforge_project: rspec
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: rspec-core-2.14.1
+summary: rspec-core-2.14.2
 test_files:
 - features/Autotest.md
 - features/README.md