rspec-core 2.13.0 → 2.13.1

data/Changelog.md

@@ -1,3 +1,33 @@
+### 2.13.1 / 2013-03-12
+[full changelog](http://github.com/rspec/rspec-core/compare/v2.13.0...v2.13.1)
+
+Bug fixes
+
+* Use hook classes as proxies rather than extending hook blocks to support
+  lambdas for before/after/around hooks. (David Chelimsky)
+* Fix regression in 2.13.0 that caused confusing behavior when overriding
+  a named subject with an unnamed subject in an inner group and then
+  referencing the outer group subject's name. The fix for this required
+  us to disallow using `super` in a named subject (which is confusing,
+  anyway -- named subjects create 2 methods, so which method on the
+  parent example group are you `super`ing to?) but `super` in an unnamed
+  subject continues to work (Myron Marston).
+* Do not allow a referenced `let` or `subject` in `before(:all)` to cause
+  other `let` declarations to leak across examples (Myron Marston).
+* Work around odd ruby 1.9 bug with `String#match` that was triggered
+  by passing it a regex from a `let` declaration. For more info, see
+  http://bugs.ruby-lang.org/issues/8059 (Aaron Kromer).
+* Add missing `require 'set'` to `base_text_formatter.rb` (Tom
+  Anderson).
+
+Deprecations
+
+* Deprecate accessing `let` or `subject` declarations in `before(:all)`.
+  These were not intended to be called in a `before(:all)` hook, as
+  they exist to define state that is reset between each example, while
+  `before(:all)` exists to define state that is shared across examples
+  in an example group (Myron Marston).
+
 ### 2.13.0 / 2013-02-23
 [full changelog](http://github.com/rspec/rspec-core/compare/v2.12.2...v2.13.0)
 
@@ -14,6 +44,8 @@ Enhancements
   method. (Myron Marston)
 * Allow output colors to be configured individually.
   (Charlie Maffitt)
+* Always dump slow examples when `--profile` option is given,
+  even when an example failed (Myron Marston).
 
 Bug fixes
 

data/README.md

@@ -198,8 +198,10 @@ this before you write any implementation code:
 ```ruby
 # in spec/calculator_spec.rb
 describe Calculator do
-  it "add(x,y) returns the sum of its arguments" do
-    expect(Calculator.new.add(1, 2)).to eq(3)
+  describe '#add' do
+    it 'returns the sum of its arguments' do
+      expect(Calculator.new.add(1, 2)).to eq(3)
+    end
   end
 end
 ```
@@ -244,8 +246,9 @@ Use the `documentation` formatter to see the resulting spec:
 
 ```
 $ rspec spec/calculator_spec.rb --format doc
-Calculator add
-  returns the sum of its arguments
+Calculator
+  #add
+    returns the sum of its arguments
 
 Finished in 0.000379 seconds
 1 example, 0 failures

data/features/step_definitions/additional_cli_steps.rb

@@ -31,10 +31,6 @@ Then /^the process should succeed even though no examples were run$/ do
   step %q{the exit status should be 0}
 end
 
-Then /^the file "([^"]*)" should contain:$/ do |file, partial_content|
-  check_file_content(file, partial_content, true)
-end
-
 Then /^the backtrace\-normalized output should contain:$/ do |partial_output|
   # ruby 1.9 includes additional stuff in the backtrace,
   # so we need to normalize it to compare it with our expected output.

data/features/support/env.rb

@@ -1,12 +1,14 @@
 require 'aruba/cucumber'
 
+timeouts = { 'java' => 60 }
+
 Before do
-  if RUBY_PLATFORM =~ /java/
-    # ideas taken from: http://blog.headius.com/2010/03/jruby-startup-time-tips.html
-    set_env('JRUBY_OPTS', '-X-C') # disable JIT since these processes are so short lived
-    set_env('JAVA_OPTS', '-d32') # force jRuby to use client JVM for faster startup times
-    @aruba_timeout_seconds = 60
-  else
-    @aruba_timeout_seconds = 10
-  end
+  @aruba_timeout_seconds = timeouts.fetch(RUBY_PLATFORM) { 10 }
 end
+
+Aruba.configure do |config|
+  config.before_cmd do |cmd|
+    set_env('JRUBY_OPTS', "-X-C #{ENV['JRUBY_OPTS']}") # disable JIT since these processes are so short lived
+  end
+end if RUBY_PLATFORM == 'java'
+

data/lib/rspec/core/example_group.rb

@@ -299,6 +299,7 @@ module RSpec
       # @private
       def self.store_before_all_ivars(example_group_instance)
         return if example_group_instance.instance_variables.empty?
+
         example_group_instance.instance_variables.each { |ivar|
           before_all_ivars[ivar] = example_group_instance.instance_variable_get(ivar)
         }
@@ -314,7 +315,10 @@ module RSpec
         return if descendant_filtered_examples.empty?
         begin
           assign_before_all_ivars(superclass.before_all_ivars, example_group_instance)
-          run_hook(:before, :all, example_group_instance)
+
+          BeforeAllMemoizedHash.isolate_for_before_all(example_group_instance) do
+            run_hook(:before, :all, example_group_instance)
+          end
         ensure
           store_before_all_ivars(example_group_instance)
         end

data/lib/rspec/core/formatters/base_text_formatter.rb

@@ -1,4 +1,5 @@
 require 'rspec/core/formatters/base_formatter'
+require 'set'
 
 module RSpec
   module Core

data/lib/rspec/core/hooks.rb

@@ -3,12 +3,12 @@ module RSpec
     module Hooks
       include MetadataHashBuilder::WithConfigWarning
 
-      module HookExtension
-        attr_reader :options
+      class Hook
+        attr_reader :block, :options
 
-        def with(options)
+        def initialize(block, options)
+          @block = block
           @options = options
-          self
         end
 
         def options_apply?(example_or_group)
@@ -16,11 +16,9 @@ module RSpec
         end
       end
 
-      module BeforeHookExtension
-        include HookExtension
-
+      class BeforeHook < Hook
         def run(example)
-          example.instance_eval(&self)
+          example.instance_eval(&block)
         end
 
         def display_name
@@ -28,11 +26,9 @@ module RSpec
         end
       end
 
-      module AfterHookExtension
-        include HookExtension
-
+      class AfterHook < Hook
         def run(example)
-          example.instance_eval_with_rescue("in an after hook", &self)
+          example.instance_eval_with_rescue("in an after hook", &block)
         end
 
         def display_name
@@ -40,9 +36,7 @@ module RSpec
         end
       end
 
-      module AroundHookExtension
-        include HookExtension
-
+      class AroundHook < Hook
         def display_name
           "around hook"
         end
@@ -90,7 +84,7 @@ module RSpec
         def run
           inject(@initial_procsy) do |procsy, around_hook|
             Example.procsy(procsy.metadata) do
-              @example.instance_eval_with_args(procsy, &around_hook)
+              @example.instance_eval_with_args(procsy, &around_hook.block)
             end
           end.call
         end
@@ -433,10 +427,10 @@ module RSpec
 
       SCOPES = [:each, :all, :suite]
 
-      EXTENSIONS = {
-        :before => BeforeHookExtension,
-        :after  => AfterHookExtension,
-        :around => AroundHookExtension
+      HOOK_TYPES = {
+        :before => BeforeHook,
+        :after  => AfterHook,
+        :around => AroundHook
       }
 
       def before_all_hooks_for(group)
@@ -457,7 +451,7 @@ module RSpec
 
       def register_hook prepend_or_append, hook, *args, &block
         scope, options = scope_and_options_from(*args)
-        hooks[hook][scope].send(prepend_or_append, block.extend(EXTENSIONS[hook]).with(options))
+        hooks[hook][scope].send(prepend_or_append, HOOK_TYPES[hook].new(block, options))
       end
 
       def find_hook(hook, scope, example_or_group, initial_procsy)

data/lib/rspec/core/memoized_helpers.rb

@@ -78,6 +78,66 @@ module RSpec
         @__memoized ||= {}
       end
 
+      # Used internally to customize the behavior of the
+      # memoized hash when used in a `before(:all)` hook.
+      #
+      # @private
+      class BeforeAllMemoizedHash
+        def initialize(example_group_instance)
+          @example_group_instance = example_group_instance
+          @hash = {}
+        end
+
+        def self.isolate_for_before_all(example_group_instance)
+          example_group_instance.instance_eval do
+            @__memoized = BeforeAllMemoizedHash.new(self)
+
+            begin
+              yield
+            ensure
+              @__memoized.preserve_accessed_lets
+              @__memoized = nil
+            end
+          end
+        end
+
+        def fetch(key, &block)
+          description = if key == :subject
+            "subject"
+          else
+            "let declaration `#{key}`"
+          end
+
+          ::RSpec.warn_deprecation <<-EOS
+WARNING: #{description} accessed in a `before(:all)` hook at:
+  #{caller[1]}
+
+This is deprecated behavior that will not be supported in RSpec 3.
+
+`let` and `subject` declarations are not intended to be called
+in a `before(:all)` hook, as they exist to define state that
+is reset between each example, while `before(:all)` exists to
+define state that is shared across examples in an example group.
+EOS
+
+          @hash.fetch(key, &block)
+        end
+
+        def []=(key, value)
+          @hash[key] = value
+        end
+
+        def preserve_accessed_lets
+          hash = @hash
+
+          @example_group_instance.class.class_eval do
+            hash.each do |key, value|
+              define_method(key) { value }
+            end
+          end
+        end
+      end
+
       def self.included(mod)
         mod.extend(ClassMethods)
 
@@ -117,12 +177,12 @@ module RSpec
         def let(name, &block)
           # We have to pass the block directly to `define_method` to
           # allow it to use method constructs like `super` and `return`.
-          ::RSpec::Core::MemoizedHelpers.module_for(self).define_method(name, &block)
+          MemoizedHelpers.module_for(self).define_method(name, &block)
 
           # Apply the memoization. The method has been defined in an ancestor
           # module so we can use `super` here to get the value.
           define_method(name) do
-            __memoized.fetch(name) { |k| __memoized[k] = super() }
+            __memoized.fetch(name) { |k| __memoized[k] = super(&nil) }
           end
         end
 
@@ -214,8 +274,16 @@ module RSpec
         #
         # @see MemoizedHelpers#should
         def subject(name=nil, &block)
-          let(:subject, &block)
-          alias_method name, :subject if name
+          if name
+            let(name, &block)
+            subject { __send__ name }
+
+            self::NamedSubjectPreventSuper.define_method(name) do
+              raise NotImplementedError, "`super` in named subjects is not supported"
+            end
+          else
+            let(:subject, &block)
+          end
         end
 
         # Just like `subject`, except the block is invoked by an implicit `before`
@@ -381,9 +449,17 @@ module RSpec
       # in order to get the value to memoize.
       def self.module_for(example_group)
         get_constant_or_yield(example_group, :LetDefinitions) do
-          # Expose `define_method` as a public method, so we can
-          # easily use it below.
-          mod = Module.new { public_class_method :define_method }
+          mod = Module.new do
+            include Module.new {
+              public_class_method :define_method
+              example_group.const_set(:NamedSubjectPreventSuper, self)
+            }
+
+            # Expose `define_method` as a public method, so we can
+            # easily use it below.
+            public_class_method :define_method
+          end
+
           example_group.__send__(:include, mod)
           example_group.const_set(:LetDefinitions, mod)
           mod

data/lib/rspec/core/version.rb

@@ -1,7 +1,7 @@
 module RSpec
   module Core
     module Version
-      STRING = '2.13.0'
+      STRING = '2.13.1'
     end
   end
 end

data/spec/rspec/core/configuration_spec.rb

@@ -992,7 +992,7 @@ module RSpec::Core
 
     describe "#output=" do
       it "sets the output" do
-        output = mock("output")
+        output = double("output")
         config.output = output
         expect(config.output).to equal(output)
       end

data/spec/rspec/core/example_spec.rb

@@ -330,7 +330,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
       it 'does not print mock expectation errors' do
         group = RSpec::Core::ExampleGroup.describe do
           example do
-            foo = mock
+            foo = double
             foo.should_receive(:bar)
             raise "boom"
           end

data/spec/rspec/core/formatters/base_formatter_spec.rb

@@ -28,21 +28,21 @@ describe RSpec::Core::Formatters::BaseFormatter do
 
   describe "read_failed_line" do
     it "deals gracefully with a heterogeneous language stack trace" do
-      exception = mock(:Exception, :backtrace => [
+      exception = double(:Exception, :backtrace => [
         "at Object.prototypeMethod (foo:331:18)",
         "at Array.forEach (native)",
         "at a_named_javascript_function (/some/javascript/file.js:39:5)",
         "/some/line/of/ruby.rb:14"
       ])
-      example = mock(:Example, :file_path => __FILE__)
+      example = double(:Example, :file_path => __FILE__)
       expect {
         formatter.send(:read_failed_line, exception, example)
       }.not_to raise_error
     end
 
     it "deals gracefully with a security error" do
-      exception = mock(:Exception, :backtrace => [ "#{__FILE__}:#{__LINE__}"])
-      example = mock(:Example, :file_path => __FILE__)
+      exception = double(:Exception, :backtrace => [ "#{__FILE__}:#{__LINE__}"])
+      example = double(:Example, :file_path => __FILE__)
       safely do
         expect {
           formatter.send(:read_failed_line, exception, example)
@@ -52,8 +52,8 @@ describe RSpec::Core::Formatters::BaseFormatter do
 
     context "when ruby reports a bogus line number in the stack trace" do
       it "reports the filename and that it was unable to find the matching line" do
-        exception = mock(:Exception, :backtrace => [ "#{__FILE__}:10000000" ])
-        example = mock(:Example, :file_path => __FILE__)
+        exception = double(:Exception, :backtrace => [ "#{__FILE__}:10000000" ])
+        example = double(:Example, :file_path => __FILE__)
 
         msg = formatter.send(:read_failed_line, exception, example)
         expect(msg).to include("Unable to find matching line")
@@ -75,11 +75,11 @@ describe RSpec::Core::Formatters::BaseFormatter do
 
       it "doesn't hang when file exists" do
         pending("This issue still exists on JRuby, but should be resolved shortly: https://github.com/rspec/rspec-core/issues/295", :if => RUBY_PLATFORM == 'java')
-        exception = mock(:Exception, :backtrace => [ "#{__FILE__}:#{__LINE__}"])
+        exception = double(:Exception, :backtrace => [ "#{__FILE__}:#{__LINE__}"])
 
-        example = mock(:Example, :file_path => __FILE__)
+        example = double(:Example, :file_path => __FILE__)
         expect(formatter.send(:read_failed_line, exception, example)).to eql(
-          %Q{        exception = mock(:Exception, :backtrace => [ "\#{__FILE__}:\#{__LINE__}"])\n})
+          %Q{        exception = double(:Exception, :backtrace => [ "\#{__FILE__}:\#{__LINE__}"])\n})
       end
 
     end
@@ -101,7 +101,7 @@ describe RSpec::Core::Formatters::BaseFormatter do
     end
 
     it "removes lines from rspec and lines that come before the invocation of the at_exit autorun hook" do
-      expect(formatter.format_backtrace(backtrace, stub.as_null_object)).to eq(["./my_spec.rb:5"])
+      expect(formatter.format_backtrace(backtrace, double.as_null_object)).to eq(["./my_spec.rb:5"])
     end
   end
 

data/spec/rspec/core/hooks_spec.rb

@@ -246,5 +246,22 @@ module RSpec::Core
         end
       end
     end
+
+    describe "lambda" do
+      it "can be used as a hook" do
+        messages = []
+        count = 0
+        hook = lambda {|e| messages << "hook #{count = count + 1}"; e.run }
+
+        RSpec.configure do |c|
+          c.around(:each, &hook)
+          c.around(:each, &hook)
+        end
+
+        group = ExampleGroup.describe { example { messages << "example" } }
+        group.run
+        expect(messages).to eq ["hook 1", "hook 2", "example"]
+      end
+    end
   end
 end

data/spec/rspec/core/memoized_helpers_spec.rb

@@ -120,6 +120,67 @@ module RSpec::Core
 
           expect(subject_value).to eq([4, 5, 6, :override])
         end
+
+        context 'when referenced in a `before(:all)` hook' do
+          before do
+            expect(::RSpec).to respond_to(:warn_deprecation)
+            ::RSpec.stub(:warn_deprecation)
+          end
+
+          def define_and_run_group
+            values = { :reference_lines => [] }
+
+            ExampleGroup.describe do
+              subject { [1, 2] }
+              let(:list) { %w[ a b ] }
+
+              before(:all) do
+                subject << 3; values[:reference_lines] << __LINE__
+                values[:final_subject_value_in_before_all] = subject; values[:reference_lines] << __LINE__
+              end
+
+              example do
+                list << '1'
+                values[:list_in_ex_1] = list
+                values[:subject_value_in_example] = subject
+              end
+
+              example do
+                list << '2'
+                values[:list_in_ex_2] = list
+              end
+            end.run
+
+            values
+          end
+
+          it 'memoizes the value within the before(:all) hook' do
+            values = define_and_run_group
+            expect(values.fetch(:final_subject_value_in_before_all)).to eq([1, 2, 3])
+          end
+
+          it 'preserves the memoization into the individual examples' do
+            values = define_and_run_group
+            expect(values.fetch(:subject_value_in_example)).to eq([1, 2, 3])
+          end
+
+          it 'does not cause other lets to be shared across examples' do
+            values = define_and_run_group
+            expect(values.fetch(:list_in_ex_1)).to eq(%w[ a b 1 ])
+            expect(values.fetch(:list_in_ex_2)).to eq(%w[ a b 2 ])
+          end
+
+          it 'prints a warning since `subject` declarations are not intended to be used in :all hooks' do
+            msgs = []
+            ::RSpec.stub(:warn_deprecation) { |msg| msgs << msg }
+
+            values = define_and_run_group
+
+            expect(msgs).to include(*values[:reference_lines].map { |line|
+              match(/subject accessed.*#{__FILE__}:#{line}/m)
+            })
+          end
+        end
       end
 
       describe "with a name" do
@@ -157,21 +218,75 @@ module RSpec::Core
           expect(inner_subject_value).to eq(1)
         end
 
+        it 'can continue to be referenced by the name even when an inner group redefines the subject' do
+          named_value = nil
+
+          ExampleGroup.describe do
+            subject(:named) { :outer }
+
+            describe "inner" do
+              subject { :inner }
+              example do
+                subject # so the inner subject method is run and memoized
+                named_value = self.named
+              end
+            end
+          end.run
+
+          expect(named_value).to eq(:outer)
+        end
+
+        it 'can continue to reference an inner subject after the outer subject name is referenced' do
+          subject_value = nil
+
+          ExampleGroup.describe do
+            subject(:named) { :outer }
+
+            describe "inner" do
+              subject { :inner }
+              example do
+                named # so the outer subject method is run and memoized
+                subject_value = self.subject
+              end
+            end
+          end.run
+
+          expect(subject_value).to eq(:inner)
+        end
+
         context 'when `super` is used' do
-          it "delegates to the parent context's `subject`, not the named mehtod" do
-            inner_subject_value = nil
+          def should_raise_not_supported_error(&block)
+            ex = nil
 
             ExampleGroup.describe do
               let(:list) { ["a", "b", "c"] }
               subject { [1, 2, 3] }
 
               describe 'first' do
+                module_eval(&block) if block
+
                 subject(:list) { super().first(2) }
-                example { inner_subject_value = subject }
+                ex = example { subject }
               end
             end.run
 
-            expect(inner_subject_value).to eq([1, 2])
+            expect(ex.execution_result[:status]).to eq("failed")
+            expect(ex.execution_result[:exception].message).to match(/super.*not supported/)
+          end
+
+          it 'raises a "not supported" error' do
+            should_raise_not_supported_error
+          end
+
+          context 'with a `let` definition before the named subject' do
+            it 'raises a "not supported" error' do
+              should_raise_not_supported_error do
+                # My first pass implementation worked unless there was a `let`
+                # declared before the named subject -- this let is in place to
+                # ensure that bug doesn't return.
+                let(:foo) { 3 }
+              end
+            end
           end
         end
       end
@@ -386,6 +501,13 @@ module RSpec::Core
       expect(@nil_value_count).to eq(1)
     end
 
+    let(:regex_with_capture) { %r[RegexWithCapture(\d)] }
+
+    it 'does not pass the block up the ancestor chain' do
+      # Test for Ruby bug http://bugs.ruby-lang.org/issues/8059
+      expect("RegexWithCapture1".match(regex_with_capture)[1]).to eq('1')
+    end
+
     let(:a_value) { "a string" }
 
     context 'when overriding let in a nested context' do
@@ -412,6 +534,67 @@ module RSpec::Core
         expect(value).to eq(:late_exit)
       end
     end
+
+    context 'when referenced in a `before(:all)` hook' do
+      before do
+        expect(::RSpec).to respond_to(:warn_deprecation)
+        ::RSpec.stub(:warn_deprecation)
+      end
+
+      def define_and_run_group
+        values = { :reference_lines => [] }
+
+        ExampleGroup.describe do
+          let(:list) { [1, 2] }
+          subject { %w[ a b ] }
+
+          before(:all) do
+            list << 3; values[:reference_lines] << __LINE__
+            values[:final_list_value_in_before_all] = list; values[:reference_lines] << __LINE__
+          end
+
+          example do
+            subject << "1"
+            values[:subject_in_ex_1] = subject
+            values[:list_value_in_example] = list
+          end
+
+          example do
+            subject << "2"
+            values[:subject_in_ex_2] = subject
+          end
+        end.run
+
+        values
+      end
+
+      it 'memoizes the value within the before(:all) hook' do
+        values = define_and_run_group
+        expect(values.fetch(:final_list_value_in_before_all)).to eq([1, 2, 3])
+      end
+
+      it 'preserves the memoized value into the examples' do
+        values = define_and_run_group
+        expect(values.fetch(:list_value_in_example)).to eq([1, 2, 3])
+      end
+
+      it 'does not cause the subject to be shared across examples' do
+        values = define_and_run_group
+        expect(values.fetch(:subject_in_ex_1)).to eq(%w[ a b 1 ])
+        expect(values.fetch(:subject_in_ex_2)).to eq(%w[ a b 2 ])
+      end
+
+      it 'prints a warning since `let` declarations are not intended to be used in :all hooks' do
+        msgs = []
+        ::RSpec.stub(:warn_deprecation) { |msg| msgs << msg }
+
+        values = define_and_run_group
+
+        expect(msgs).to include(*values[:reference_lines].map { |line|
+          match(/let declaration `list` accessed.*#{__FILE__}:#{line}/m)
+        })
+      end
+    end
   end
 
   describe "#let!" do
@@ -456,3 +639,4 @@ module RSpec::Core
     end
   end
 end
+

data/spec/rspec/core/pending_example_spec.rb

@@ -18,7 +18,7 @@ describe "an example" do
         end
       end
       example = group.examples.first
-      example.run(group.new, stub.as_null_object)
+      example.run(group.new, double.as_null_object)
       expect(example).to be_pending_with('just because')
     end
 
@@ -28,7 +28,7 @@ describe "an example" do
         end
       end
       example = group.examples.first
-      example.run(group.new, stub.as_null_object)
+      example.run(group.new, double.as_null_object)
       expect(example).to be_pending_with('No reason given')
     end
   end
@@ -39,7 +39,7 @@ describe "an example" do
         it "has no block"
       end
       example = group.examples.first
-      example.run(group.new, stub.as_null_object)
+      example.run(group.new, double.as_null_object)
       expect(example).to be_pending_with('Not yet implemented')
     end
   end
@@ -52,7 +52,7 @@ describe "an example" do
         end
       end
       example = group.examples.first
-      example.run(group.new, stub.as_null_object)
+      example.run(group.new, double.as_null_object)
       expect(example).to be_pending_with(RSpec::Core::Pending::NO_REASON_GIVEN)
     end
   end
@@ -69,7 +69,7 @@ describe "an example" do
           end
         end
         example = group.examples.last
-        example.run(group.new, stub.as_null_object)
+        example.run(group.new, double.as_null_object)
         expect(example.description).to match(/example at/)
       end
     end
@@ -85,7 +85,7 @@ describe "an example" do
           end
         end
         example = group.examples.last
-        example.run(group.new, stub.as_null_object)
+        example.run(group.new, double.as_null_object)
         expect(example.description).to match(/example at/)
       end
     end
@@ -99,7 +99,7 @@ describe "an example" do
         end
       end
       example = group.examples.first
-      example.run(group.new, stub.as_null_object)
+      example.run(group.new, double.as_null_object)
       expect(example).to be_pending_with('just because')
     end
   end
@@ -112,7 +112,7 @@ describe "an example" do
         end
       end
       example = group.examples.first
-      example.run(group.new, stub.as_null_object)
+      example.run(group.new, double.as_null_object)
       example
     end
 

data/spec/rspec/core/reporter_spec.rb

@@ -30,7 +30,7 @@ module RSpec::Core
       it "passes example_group_started and example_group_finished messages to that formatter in that order" do
         order = []
 
-        formatter = stub("formatter").as_null_object
+        formatter = double("formatter").as_null_object
         formatter.stub(:example_group_started) { |group| order << "Started: #{group.description}" }
         formatter.stub(:example_group_finished) { |group| order << "Finished: #{group.description}" }
 
@@ -57,7 +57,7 @@ module RSpec::Core
 
     context "given an example group with no examples" do
       it "does not pass example_group_started or example_group_finished to formatter" do
-        formatter = stub("formatter").as_null_object
+        formatter = double("formatter").as_null_object
         formatter.should_not_receive(:example_group_started)
         formatter.should_not_receive(:example_group_finished)
 

metadata

@@ -2,7 +2,7 @@
 name: rspec-core
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 2.13.0
+  version: 2.13.1
 platform: ruby
 authors:
 - Steven Baker
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2013-02-23 00:00:00.000000000 Z
+date: 2013-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
@@ -50,7 +50,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.4.11
+        version: '0.5'
     none: false
   prerelease: false
   name: aruba
@@ -58,23 +58,23 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.4.11
+        version: '0.5'
     none: false
   type: :development
 - !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 4.6.2
+        version: '4.6'
     none: false
   prerelease: false
   name: ZenTest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 4.6.2
+        version: '4.6'
     none: false
   type: :development
 - !ruby/object:Gem::Dependency
@@ -372,7 +372,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3060570395561359548
+      hash: 4384848023819144247
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
@@ -381,14 +381,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3060570395561359548
+      hash: 4384848023819144247
   none: false
 requirements: []
 rubyforge_project: rspec
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: rspec-core-2.13.0
+summary: rspec-core-2.13.1
 test_files:
 - features/Autotest.md
 - features/README.md