rspec-core 2.0.0.beta.22 → 2.0.0.rc

data/Gemfile

@@ -1,8 +1,8 @@
 source "http://rubygems.org"
 
 gem "rake"
-gem "cucumber"
-gem "aruba", ">= 0.2.0"
+gem "cucumber", "0.8.5"
+gem "aruba", "0.2.2"
 gem "autotest"
 gem "watchr"
 gem "rcov"

data/{History.md → History.markdown}

@@ -1,5 +1,27 @@
 ## rspec-core release history (incomplete)
 
+### 2.0.0.rc / 2010-10-05
+
+[full changelog](http://github.com/rspec/rspec-core/compare/v2.0.0.beta.22...v2.0.0.rc)
+
+* Enhancements
+  * implicitly require unknown formatters so you don't have to require the
+    file explicitly on the commmand line (Michael Grosser) 
+  * add --out/-o option to assign output target
+  * added fail_fast configuration option to abort on first failure
+  * support a Hash subject (its([:key]) { should == value }) (Josep M. Bach)
+
+* Bug fixes
+  * Explicitly require rspec version to fix broken rdoc task (Hans de Graaff)
+  * Ignore backtrace lines that come from other languages, like Java or
+    Javascript (Charles Lowell)
+  * Rake task now does what is expected when setting (or not setting)
+    fail_on_error and verbose
+  * Fix bug in which before/after(:all) hooks were running on excluded nested
+    groups (Myron Marston)
+  * Fix before(:all) error handling so that it fails examples in nested groups,
+    too (Myron Marston)
+
 ### 2.0.0.beta.22 / 2010-09-12
 
 [full changelog](http://github.com/rspec/rspec-core/compare/v2.0.0.beta.20...v2.0.0.beta.22)
@@ -15,12 +37,12 @@
     * deprecated redundant options
   * run 'bundle exec autotest' when Gemfile is present
   * support ERB in .rspec options files (Justin Ko)
-  * depend on bundler for development tasks (Myron Marsten)
+  * depend on bundler for development tasks (Myron Marston)
   * add example_group_finished to formatters and reporter (Roman Chernyatchik)
 
 * Bug fixes
   * support paths with spaces when using autotest (Andreas Neuhaus)
-  * fix module_exec with ruby 1.8.6 (Myron Marsten)
+  * fix module_exec with ruby 1.8.6 (Myron Marston)
   * remove context method from top-level
     * was conflicting with irb, for example
   * errors in before(:all) are now reported correctly (Chad Humphries)

data/Rakefile

@@ -7,6 +7,7 @@ require "yaml"
 
 require "rake/rdoctask"
 require "rspec/core/rake_task"
+require "rspec/core/version"
 require "cucumber/rake/task"
 
 RSpec::Core::RakeTask.new(:spec)

data/Upgrade.markdown

@@ -14,6 +14,15 @@ The RSpec rake task has moved to:
 
     'rspec/core/rake_task'
 
+RCov options are now set directly on the Rake task:
+
+    RSpec::Core::RakeTask.new(:rcov) do |t|
+      t.rcov_opts =  %q[--exclude "spec"]
+    end
+
+In RSpec-1, the rake task would read in rcov options from an `rcov.opts`
+file. This is ignored by RSpec-2.
+
 ### autotest
 
 RSpec-2 works with autotest as follows:
@@ -26,17 +35,17 @@ This adds `./autotest/discover.rb` with:
 
 Now, on the command line just type:
 
-    $ autotest
+    autotest
 
 Or, if you're using bundler:
 
-    $ bundle exec autotest
+    bundle exec autotest
 
 The `autospec` command is a thing of the past. 
 
 ### RSpec
 
-The root namespace (top level module ) is now `RSpec` instead of `Spec`, and
+The root namespace (top level module) is now `RSpec` instead of `Spec`, and
 the root directory under `lib` within all of the `rspec` gems is `rspec` instead of `spec`.
 
 ### Configuration
@@ -57,6 +66,30 @@ options. Precedence is:
     ./.rspec
     ~/.rspec
 
+### `context` is no longer a top-level method
+
+We removed `context` from the main object because it was creating conflicts with
+IRB and some users who had `Context` domain objects. `describe` is still there,
+so if you want to use `context` at the top level, just alias it:
+
+    alias :context :describe
+
+Of course, you can still use `context` to declare a nested group:
+
+    describe "something" do
+      context "in some context" do
+        it "does something" do
+          # ...
+        end
+      end
+    end
+
+### `$KCODE` no longer set implicitly to `'u'`
+
+In RSpec-1, the runner set `$KCODE` to `'u'`, which impacts, among other
+things, the behaviour of Regular Expressions when applied to non-ascii
+characters. This is no longer the case in RSpec-2.
+
 ## What's new
 
 ### Runner

data/bin/rspec

@@ -1,3 +1,2 @@
 #!/usr/bin/env ruby
-require 'rspec/core'
-exit RSpec::Core::Runner.run(ARGV, $stderr, $stdout)
+require 'rspec/autorun'

data/features/command_line/configure.feature

@@ -2,15 +2,15 @@ Feature: configure
 
   Use --configure to generate configuration files.
 
-  Currently, the only supported argument is "autotest", which creates
-  a autotest/discover.rb file in your project root directory.
+  The only supported argument, so far, is "autotest", which creates an
+  autotest/discover.rb file in your project root directory.
 
   Background:
     Given a directory named "rspec_project"
-    And I cd to "rspec_project"
 
   Scenario: generate autotest directory and discover file
-    When I run "rspec --configure autotest"
+    When I cd to "rspec_project"
+    And I run "rspec --configure autotest"
     Then the following directories should exist:
       | autotest |
     And the following files should exist:

data/features/command_line/example_name_option.feature

@@ -17,14 +17,14 @@ Feature: example name option
         it "second example in first group" do; end
       end
       """
-    Given a file named "second_spec.rb" with:
+    And a file named "second_spec.rb" with:
       """
       describe "second group" do
         it "first example in second group" do; end
         it "second example in second group" do; end
       end
       """
-    Given a file named "third_spec.rb" with:
+    And a file named "third_spec.rb" with:
       """
       describe "third group" do
         it "first example in third group" do; end
@@ -34,6 +34,16 @@ Feature: example name option
         end
       end
       """
+    And a file named "fourth_spec.rb" with:
+      """
+      describe Array do
+        describe "#length" do
+          it "is the number of items" do
+            Array.new([1,2,3]).length.should eq 3
+          end
+        end
+      end
+      """
 
   Scenario: no matches
     When I run "rspec . --example nothing_like_this"
@@ -69,4 +79,8 @@ Feature: example name option
 
   Scenario: all examples in one group including examples in nested groups
     When I run "rspec . --example 'third group'"
-    Then the output should contain "3 examples, 0 failures"
+    Then the output should contain "3 examples, 0 failures"
+
+  Scenario: Object#method
+    When I run "rspec . --example 'Array#length'"
+    Then the output should contain "1 example, 0 failures"

data/features/command_line/exit_status.feature

@@ -1,6 +1,7 @@
 Feature: exit status
-  In order to fail the build when it should,
-  the spec CLI exits with an appropriate exit status
+
+  In order to fail the build when it should, the spec CLI exits with an
+  appropriate exit status
 
   Scenario: exit with 0 when all examples pass
     Given a file named "ok_spec.rb" with:
@@ -11,10 +12,8 @@ Feature: exit status
       end
       """
     When I run "rspec ok_spec.rb"
-    Then it should pass with:
-      """
-      1 example, 0 failures
-      """
+    Then the exit status should be 0
+    And the stdout should contain "1 example, 0 failures"
 
   Scenario: exit with 1 when one example fails
     Given a file named "ko_spec.rb" with:
@@ -26,10 +25,8 @@ Feature: exit status
       end
       """
     When I run "rspec ko_spec.rb"
-    Then it should fail with:
-      """
-      1 example, 1 failure
-      """
+    Then the exit status should be 1
+    And the stdout should contain "1 example, 1 failure"
 
   Scenario: exit with 1 when a nested examples fails
     Given a file named "nested_ko_spec.rb" with:
@@ -43,25 +40,13 @@ Feature: exit status
       end
       """
     When I run "rspec nested_ko_spec.rb"
-    Then it should fail with:
-      """
-      1 example, 1 failure
-      """
+    Then the exit status should be 1
+    And the stdout should contain "1 example, 1 failure"
       
   Scenario: exit with 0 when no examples are run
-    Given a file named "spec/a_no_examples_spec.rb" with:
-      """
-      """
-    And a file named "spec/b_one_example_spec.rb" with:
-      """
-      describe "something" do
-        it "does something" do
-        end
-      end
-      """
-          
-    When I run "rspec spec"
-    Then it should pass with:
+    Given a file named "a_no_examples_spec.rb" with:
       """
-      1 example, 0 failures
       """
+    When I run "rspec a_no_examples_spec.rb"
+    Then the exit status should be 0
+    And the stdout should contain "0 examples, 0 failures"

data/features/command_line/line_number_appended_to_path.feature

@@ -1,8 +1,6 @@
 Feature: line number appended to file path
 
-  As an RSpec user
-  I want to run one example identified by the 
-    line number appended to the filepath
+  Append a line number to the path to run a single example, or a single group.
   
   Background:
     Given a file named "example_spec.rb" with:
@@ -29,80 +27,78 @@ Feature: line number appended to file path
       """
 
   Scenario: nested groups - outer group on declaration line
-    When I run "rspec ./example_spec.rb:1 --format doc"
+    When I run "rspec example_spec.rb:1 --format doc"
     Then the output should contain "3 examples, 0 failures"
     And the output should contain "second example in outer group"
     And the output should contain "first example in outer group"
     And the output should contain "example in nested group"
 
   Scenario: nested groups - outer group inside block before example
-    When I run "rspec ./example_spec.rb:2 --format doc"
+    When I run "rspec example_spec.rb:2 --format doc"
     Then the output should contain "3 examples, 0 failures"
     And the output should contain "second example in outer group"
     And the output should contain "first example in outer group"
     And the output should contain "example in nested group"
 
   Scenario: nested groups - inner group on declaration line
-    When I run "rspec ./example_spec.rb:11 --format doc"
+    When I run "rspec example_spec.rb:11 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "example in nested group"
     And the output should not contain "second example in outer group"
     And the output should not contain "first example in outer group"
 
   Scenario: nested groups - inner group inside block before example
-    When I run "rspec ./example_spec.rb:12 --format doc"
+    When I run "rspec example_spec.rb:12 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "example in nested group"
     And the output should not contain "second example in outer group"
     And the output should not contain "first example in outer group"
 
   Scenario: two examples - first example on declaration line
-    When I run "rspec ./example_spec.rb:3 --format doc"
+    When I run "rspec example_spec.rb:3 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "first example in outer group"
     But the output should not contain "second example in outer group"
     And the output should not contain "example in nested group"
 
   Scenario: two examples - first example inside block
-    When I run "rspec ./example_spec.rb:4 --format doc"
+    When I run "rspec example_spec.rb:4 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "first example in outer group"
     But the output should not contain "second example in outer group"
     And the output should not contain "example in nested group"
 
   Scenario: two examples - first example on end
-    When I run "rspec ./example_spec.rb:5 --format doc"
+    When I run "rspec example_spec.rb:5 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "first example in outer group"
     But the output should not contain "second example in outer group"
     And the output should not contain "example in nested group"
 
   Scenario: two examples - first example after end but before next example
-    When I run "rspec ./example_spec.rb:6 --format doc"
+    When I run "rspec example_spec.rb:6 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "first example in outer group"
     But the output should not contain "second example in outer group"
     And the output should not contain "example in nested group"
 
   Scenario: two examples - second example on declaration line
-    When I run "rspec ./example_spec.rb:7 --format doc"
+    When I run "rspec example_spec.rb:7 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "second example in outer group"
     But the output should not contain "first example in outer group"
     And the output should not contain "example in nested group"
 
   Scenario: two examples - second example inside block
-    When I run "rspec ./example_spec.rb:7 --format doc"
+    When I run "rspec example_spec.rb:7 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "second example in outer group"
     But the output should not contain "first example in outer group"
     And the output should not contain "example in nested group"
 
   Scenario: two examples - second example on end
-    When I run "rspec ./example_spec.rb:7 --format doc"
+    When I run "rspec example_spec.rb:7 --format doc"
     Then the output should contain "1 example, 0 failures"
     And the output should contain "second example in outer group"
     But the output should not contain "first example in outer group"
     And the output should not contain "example in nested group"
-
-

data/features/command_line/line_number_option.feature

@@ -1,8 +1,7 @@
 Feature: line number option
 
-  As an RSpec user
-  I want to run one example identified by the line number
-  
+  Use the line number option to run a single example, or a single group.
+
   Scenario: standard examples
     Given a file named "example_spec.rb" with:
       """
@@ -20,7 +19,7 @@ Feature: line number option
         
       end
       """
-    When I run "rspec ./example_spec.rb --line 5 --format doc"
+    When I run "rspec example_spec.rb --line 5 --format doc"
     Then the output should contain "1 example, 0 failures"
     Then the output should contain "should be > 8"
     But the stdout should not contain "should be < 10"
@@ -38,7 +37,7 @@ Feature: line number option
         
       end
       """
-    When I run "rspec ./example_spec.rb --line 5 --format doc"
+    When I run "rspec example_spec.rb --line 5 --format doc"
     Then the output should contain "1 example, 0 failures"
     Then the output should contain "should be > 8"
     But the stdout should not contain "should be < 10"

data/features/command_line/rake_task.feature

@@ -0,0 +1,68 @@
+Feature: rake task
+  
+  RSpec ships with a rake task with a number of useful options
+
+  Scenario: default options with passing spec (prints command and exit status is 0)
+    Given a file named "Rakefile" with:
+      """
+      require 'rspec/core/rake_task'
+
+      RSpec::Core::RakeTask.new(:spec)
+
+      task :default => :spec
+      """
+    And a file named "spec/thing_spec.rb" with:
+      """
+      describe "something" do
+        it "does something" do
+          # pass
+        end
+      end
+      """
+    When I run "rake"
+    Then the stderr should contain "ruby -S rspec"
+    Then the exit status should be 0
+
+  Scenario: default options with failing spec (exit status is 1)
+    Given a file named "Rakefile" with:
+      """
+      require 'rspec/core/rake_task'
+
+      RSpec::Core::RakeTask.new(:spec)
+
+      task :default => :spec
+      """
+    And a file named "spec/thing_spec.rb" with:
+      """
+      describe "something" do
+        it "does something" do
+          fail
+        end
+      end
+      """
+    When I run "rake"
+    Then the exit status should be 1
+      
+  Scenario: fail_on_error = false with failing spec (exit status is 0)
+    Given a file named "Rakefile" with:
+      """
+      require 'rspec/core/rake_task'
+
+      RSpec::Core::RakeTask.new(:spec) do |t|
+        t.fail_on_error = false
+      end
+
+      task :default => :spec
+      """
+    And a file named "spec/thing_spec.rb" with:
+      """
+      describe "something" do
+        it "does something" do
+          fail
+        end
+      end
+      """
+    When I run "rake"
+    Then the exit status should be 0
+      
+