rspec-conductor 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ef8f45a737aff80987f79da1904c6c5bf208eb633dff2ba893b690369534901
-  data.tar.gz: f8905660585569d61e9c939130a6e3ba6ae7f63b1821ea263f3d2a64fec76db2
+  metadata.gz: 53a28166d7b4df7bb4cfa3433a706ba3a5f892f4011535bb801718bc7886a638
+  data.tar.gz: 360ea91cb2e087b0f561616af2d37442bdbdb572b54520658a638feb2d7ebba4
 SHA512:
-  metadata.gz: 46a26446160ea0de967ce28421077bc792cd0bdbe5ce1f772890f7104b2ae57fd3444d257d1564ea5067926c211d98b32bc002c23a8e54dda93ad4380dcbf9d6
-  data.tar.gz: 145ae95cbdd382066b8ba7ccd909ec849a1a19b283d896f86db5584cafdb8cf88b0aa5ad45270a8dce427932f38cc79d9a2f803e1f29a9333a9a160f725e0286
+  metadata.gz: db723da5eb4be4e544bb4890427a83f96944b6c2fb293845fa5a892cb356d030d407ea246f46331d52f231a7158565e3ce18d4c0127adefe8a38fe515e0d738a
+  data.tar.gz: 3ceb9915c3da36f68c499cbe5d65787b9f88f46ed049e51c619b0b479d7e101fc963a2b90e62da0afba174e9960c07426d71b10cf13e8324edebf11df33a61ac

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [1.0.6] - 2026-02-14
+
+- Better RSpec arguments handling, for example, --pattern and --exclude-pattern should be supported better (reported by @cb341)
+- Add support for RSpec path inclusion filters (e.g. spec/hello_spec.rb:123 or spec/hello_spec.rb[1:2:1])
+
 ## [1.0.5] - 2026-02-13
 
 - Missed one more place where unqualified `Rails` was still shadowed by `RSpec::Rails`

data/CONTRIBUTING.md

@@ -0,0 +1,3 @@
+* Bug reports are always appreciated! I'll try to address them as soon as I can
+* For the time being, I _will not_ accept code contributions. While it may sound weird at first, this here is not a large library, so I should be able to address all of the issues myself. There is also a question of code ownership, contributor agreements, etc etc, things I simply don't need in my life
+* I _might_ accept and implement feature requests that make sense to me. My goal here is to keep a minimalistic zero-dependency kind of library and not expand the scope too much

data/Gemfile

@@ -11,3 +11,4 @@ else
   gem "rspec", "~> #{ENV["RSPEC_VERSION"]}"
 end
 gem "benchmark-ips"
+gem "irb"

data/README.md

@@ -35,6 +35,23 @@ rspec-conductor --workers 10 spec
 
 Server process preloads the `rails_helper`, prepares a list of files to work, then spawns the workers, each with `ENV['TEST_ENV_NUMBER'] = <worker_number>` (same as parallel-tests). The two communicate over a standard unix socket. Message format is basically a tuple of `(size, json_payload)`. It should also be possible to run this process over the network, but I haven't found a solid usecase for this yet.
 
+## Formatters
+
+rspec-conductor comes with 3 formatters out of the box:
+
+* `--formatter plain` displays a bunch of dots, like `rspec --format progress`
+* `--formatter ci` displays current progress every 10 seconds, useful in CI environments, especially if the output isn't flushed automatically for whatever reason (jenkins does that), looks like this:
+```
+--------------------------------
+Current status [17:37:11]:
+Processed: 24 / 159 (15%)
+322 passed, 0 failed, 0 pending
+--------------------------------
+```
+* `--formatter fancy` is the formatter shown in the gif above, it displays a list of workers, a row of dots and the last error message (if any). Useful for local development.
+
+When launched without an explicitly specified formatter option, rspec-conductor defaults to either `plain` or `fancy` depending on the terminal parameters.
+
 ## Setting up the databases in Rails
 
 If you want ten workers, you're going to need ten databases. Something like this in your `database.yml` file:
@@ -66,9 +83,11 @@ rails rspec_conductor:setup # assumes [10]
 
 ```
 
-## Development notes
+## Development philosophy
+
+This library is very minimalistic by design. While there is a dependency on rspec-core, obviously, but there are no dependencies beyond that. Even the TUI stuff is handled internally.
 
-* In order to make the CLI executable load and run fast, do not add any dependencies. That includes `active_support`.
+I will also try my best to keep supporting as many rubies / rspec versions as I can, which is, currently, ruby 2.6.0+ (released in 2018) and rspec 3.8.0+ (also released in 2018), although that is more of a soft promise than a blood vow.
 
 ## Troubleshooting
 

data/lib/rspec/conductor/cli.rb

@@ -47,7 +47,6 @@ module RSpec
 
         parse_conductor_options(conductor_args)
         @rspec_args.prepend(*conductor_args) # can use spec paths as positional arguments before -- for convenience
-        apply_rspec_defaults
       end
 
       def parse_conductor_options(args)
@@ -109,11 +108,6 @@ module RSpec
         end.parse!(args)
       end
 
-      def apply_rspec_defaults
-        has_paths = @rspec_args.any? { |arg| !arg.start_with?("-") }
-        @rspec_args << File.join(Conductor.root, "spec/") unless has_paths
-      end
-
       def start_server
         Server.new(
           worker_count: @conductor_options[:workers],

data/lib/rspec/conductor/server.rb

@@ -46,6 +46,8 @@ module RSpec
                        (!@verbose && Formatters::Fancy.recommended?) ? Formatters::Fancy.new(worker_count: worker_count) : Formatters::Plain.new
                      end
         @results = Results.new
+
+        Dir.chdir(Conductor.root)
       end
 
       def run
@@ -73,7 +75,7 @@ module RSpec
           return
         end
 
-        preload = File.expand_path(@prefork_require, Conductor.root)
+        preload = File.expand_path(@prefork_require)
 
         if File.exist?(preload)
           debug "Preloading #{@prefork_require}..."
@@ -102,24 +104,19 @@ module RSpec
       end
 
       def build_spec_queue
-        paths = extract_paths_from_args
-
+        config_options = RSpec::Core::ConfigurationOptions.new(@rspec_args)
+        if config_options.options[:files_or_directories_to_run].empty?
+          config_options.options[:files_or_directories_to_run] = ["spec"]
+        end
         config = RSpec::Core::Configuration.new
-        config.files_or_directories_to_run = paths
-
+        debug "RSpec config options: #{config_options.inspect}"
+        config_options.configure(config)
+        debug "RSpec config: #{config.inspect}"
+        debug "Files to run: #{config.files_to_run}"
         @spec_queue = config.files_to_run.shuffle(random: Random.new(@seed))
         @results.spec_files_total = @spec_queue.size
       end
 
-      def parsed_rspec_args
-        @parsed_rspec_args ||= RSpec::Core::ConfigurationOptions.new(@rspec_args)
-      end
-
-      def extract_paths_from_args
-        files = parsed_rspec_args.options[:files_or_directories_to_run] || []
-        files.empty? ? [File.join(Conductor.root, "spec/")] : files
-      end
-
       def start_workers
         @worker_count.times do |i|
           spawn_worker(@worker_number_offset + i + 1)

data/lib/rspec/conductor/version.rb

@@ -2,6 +2,6 @@
 
 module RSpec
   module Conductor
-    VERSION = "1.0.5"
+    VERSION = "1.0.6"
   end
 end

data/lib/rspec/conductor/worker.rb

@@ -60,7 +60,7 @@ module RSpec
       def setup_load_path
         parsed_options.configure(RSpec.configuration)
         @default_path = RSpec.configuration.default_path || "spec"
-        @default_full_path = File.expand_path(@default_path, Conductor.root)
+        @default_full_path = File.expand_path(@default_path)
 
         if Dir.exist?(@default_full_path) && !$LOAD_PATH.include?(@default_full_path)
           $LOAD_PATH.unshift(@default_full_path)
@@ -106,12 +106,14 @@ module RSpec
 
       def run_spec(file)
         RSpec.world.reset
-        RSpec.configuration.reset_reporter
-        RSpec.configuration.files_or_directories_to_run = []
+        RSpec.configuration.reset
+        RSpec.configuration.files_or_directories_to_run = [file]
         RSpec.configuration.output_stream = null_io_out
         RSpec.configuration.error_stream = null_io_out
         RSpec.configuration.formatter_loader.formatters.clear
         RSpec.configuration.add_formatter(RSpecSubscriber.new(@socket, file, -> { check_for_shutdown }))
+        parsed_options.configure(RSpec.configuration)
+        RSpec.configuration.files_to_run # this seemingly random line is necessary for rspec to set up the inclusion filters (e.g. hello_spec.rb:123 -> the :123 part is an inclusion filter)
 
         begin
           debug "Loading spec file: #{file}"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-conductor
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Mark Abramov
@@ -33,6 +33,7 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md