rspec-conductor 1.0.9 → 1.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57c9a96bb487176dd0c40d962ef210ca3caf316fd5135d032cccded1a9726cae
-  data.tar.gz: 976c271c89bb8847a0e1cbcd2b80f544054fd8467e701225f1f146f14c081d2f
+  metadata.gz: 9de36557f5b670ac37493d920d186e4dcbcaca0c958d59914448b91aa5e6e488
+  data.tar.gz: 9d2371b5598a12adbc6ac907d80dfc4fbbe5f9c7d1c2b0f75cb17337345f51e4
 SHA512:
-  metadata.gz: d4efec9193e711ff163176ef03edcd0a4566eb75f77b528d8a931d1e93c6718810c455d79c595c1c8c55fcddca00a60c40e65104439203605655ec5ae25e9026
-  data.tar.gz: 9ed9595a493bd54fe6d51d029a5bf693f166dad3d5a6144d0b2bd34f26824173056bae85b0a78ee04e12f4883640b007700e5d3a45e0e7946450c69c21b6c1d4
+  metadata.gz: cb67874bb0e5f84176ac601588d7931c97d70e3f8f6caff111e7cc1607b15007fcbc17f0053ff2c92f8e438cdad343530c91667de4d99f4fc7b95ac504f868fd
+  data.tar.gz: 4cb10a52cf0a0a6f9948c36287f2b6c5d35183df0ce6370196f9342e67c29ce5332780d8da8172d585be264170958fcbb317d77f03f3c23cb4ff70394b6e4cbe

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [1.0.10] - 2026-03-08
+
+- Add --print-slowest cli param to display the slowest specs in the suite
+
 ## [1.0.9] - 2026-03-01
 
 - Handle workers stdout/stderr better. It is no longer necessary to use --verbose to see worker output. Verbose now only controls whether you see the debug output of the workers

data/lib/rspec/conductor/cli.rb

@@ -15,6 +15,7 @@ module RSpec
         display_retry_backtraces: false,
         prefork_require: 'config/application.rb',
         postfork_require: :spec_helper,
+        print_slowest_count: nil,
       }.freeze
 
       def self.run(argv)
@@ -97,6 +98,10 @@ module RSpec
             @conductor_options[:display_retry_backtraces] = true
           end
 
+          opts.on("--print-slowest COUNT", Integer, "Print slowest specs with their execution times") do |n|
+            @conductor_options[:print_slowest_count] = n
+          end
+
           opts.on("--verbose", "Enable debug output") do
             @conductor_options[:verbose] = true
           end
@@ -120,6 +125,7 @@ module RSpec
           rspec_args: @rspec_args,
           formatter: @conductor_options[:formatter],
           display_retry_backtraces: @conductor_options[:display_retry_backtraces],
+          print_slowest_count: @conductor_options[:print_slowest_count],
           verbose: @conductor_options[:verbose],
         ).run
       end

data/lib/rspec/conductor/formatters/base.rb

@@ -9,7 +9,7 @@ module RSpec
         def initialize(**_kwargs)
         end
 
-        def handle_worker_message(_worker_process, _message, _results)
+        def handle_worker_message(_worker_process, _message, _suite_run)
         end
 
         def print_startup_banner(worker_count:, seed:, spec_files_count:)
@@ -17,15 +17,15 @@ module RSpec
           puts "Running #{spec_files_count} spec files\n\n"
         end
 
-        def print_summary(results, seed:, success:)
+        def print_summary(suite_run, seed:, success:)
           puts "\n\n"
           puts "Randomized with seed #{seed}"
-          puts "#{colorize("#{results.examples_passed} passed", :green)}, #{colorize("#{results.examples_failed} failed", :red)}, #{colorize("#{results.examples_pending} pending", :yellow)}"
-          puts colorize("Worker crashes: #{results.worker_crashes}", :red) if results.worker_crashes.positive?
+          puts "#{colorize("#{suite_run.examples_passed} passed", :green)}, #{colorize("#{suite_run.examples_failed} failed", :red)}, #{colorize("#{suite_run.examples_pending} pending", :yellow)}"
+          puts colorize("Worker crashes: #{suite_run.worker_crashes}", :red) if suite_run.worker_crashes.positive?
 
-          if results.errors.any?
+          if suite_run.errors.any?
             puts "\nFailures:\n\n"
-            results.errors.each_with_index do |error, i|
+            suite_run.errors.each_with_index do |error, i|
               puts "  #{i + 1}) #{error[:description]}"
               puts colorize("     #{error[:message]}", :red) if error[:message]
               puts colorize("     #{error[:location]}", :cyan)
@@ -37,14 +37,22 @@ module RSpec
             end
           end
 
-          puts "Specs took: #{results.specs_runtime.round(2)}s"
-          puts "Total runtime: #{results.total_runtime.round(2)}s"
+          puts "Specs took: #{suite_run.specs_runtime.round(2)}s"
+          puts "Total runtime: #{suite_run.total_runtime.round(2)}s"
           puts "Suite: #{success ? colorize("PASSED", :green) : colorize("FAILED", :red)}"
 
-          if results.errors.any?
+          if suite_run.errors.any?
             puts ""
             puts "To rerun failed examples:"
-            puts "  rspec #{results.errors.map { |e| e[:location] }.join(" ")}"
+            puts "  rspec #{suite_run.errors.map { |e| e[:location] }.join(" ")}"
+          end
+        end
+
+        def print_slowest(suite_run, n)
+          puts "\n\n"
+          puts "Slowest #{n} specs:"
+          suite_run.example_stats.sort_by { |e| -e[:run_time] }.take(n).each_with_index do |e, i|
+            puts "%3d. (%8.2fms) %s @ %s" % [i + 1, e[:run_time] * 1000, colorize(e[:description], :dim), colorize(e[:location], :cyan)]
           end
         end
 

data/lib/rspec/conductor/formatters/ci.rb

@@ -14,22 +14,22 @@ module RSpec
           super(**kwargs)
         end
 
-        def handle_worker_message(_worker_process, message, results)
+        def handle_worker_message(_worker_process, message, suite_run)
           public_send(message[:type], message) if respond_to?(message[:type])
-          print_status(results) if @last_printout + @printout_interval < Time.now
+          print_status(suite_run) if @last_printout + @printout_interval < Time.now
         end
 
-        def print_status(results)
+        def print_status(suite_run)
           @last_printout = Time.now
-          pct = results.spec_file_processed_percentage
+          pct = suite_run.spec_file_processed_percentage
 
           puts "-" * tty_width
           puts "Current status [#{Time.now.strftime("%H:%M:%S")}]:"
-          puts "Processed: #{results.spec_files_processed} / #{results.spec_files_total} (#{(pct * 100).floor}%)"
-          puts "#{results.examples_passed} passed, #{results.examples_failed} failed, #{results.examples_pending} pending"
-          if results.errors.any?
+          puts "Processed: #{suite_run.spec_files_processed} / #{suite_run.spec_files_total} (#{(pct * 100).floor}%)"
+          puts "#{suite_run.examples_passed} passed, #{suite_run.examples_failed} failed, #{suite_run.examples_pending} pending"
+          if suite_run.errors.any?
             puts "Failures:\n"
-            results.errors.each_with_index do |error, i|
+            suite_run.errors.each_with_index do |error, i|
               puts "  #{i + 1}) #{error[:description]}"
               puts "     #{error[:location]}"
               puts "     #{error[:message]}" if error[:message]

data/lib/rspec/conductor/formatters/fancy.rb

@@ -30,9 +30,9 @@ module RSpec
           super(**kwargs)
         end
 
-        def handle_worker_message(worker_process, message, results)
+        def handle_worker_message(worker_process, message, suite_run)
           public_send(message[:type], worker_process, message) if respond_to?(message[:type])
-          redraw(worker_process, results)
+          redraw(worker_process, suite_run)
         end
 
         def example_passed(_worker_process, _message)
@@ -66,9 +66,9 @@ module RSpec
 
         private
 
-        def redraw(worker_process, results)
+        def redraw(worker_process, suite_run)
           update_worker_status_line(worker_process)
-          update_results_line(results)
+          update_suite_run_line(suite_run)
           update_errors_line
           @terminal.redraw
           @terminal.scroll_to_bottom
@@ -94,13 +94,13 @@ module RSpec
           @worker_lines[worker_process.number].update(status, redraw: false)
         end
 
-        def update_results_line(results)
-          pct = results.spec_file_processed_percentage
+        def update_suite_run_line(suite_run)
+          pct = suite_run.spec_file_processed_percentage
           bar_width = [tty_width - 20, 20].max
           filled = (pct * bar_width).floor
           empty = bar_width - filled
 
-          percentage = " %3d%% (%d/%d)" % [(pct * 100).floor, results.spec_files_processed, results.spec_files_total]
+          percentage = " %3d%% (%d/%d)" % [(pct * 100).floor, suite_run.spec_files_processed, suite_run.spec_files_total]
           bar = colorize("[", :reset) + colorize("▓", :green) * filled + colorize(" ", :reset) * empty + colorize("]", :reset)
 
           @progress_bar_line.update(bar + percentage, redraw: false)

data/lib/rspec/conductor/formatters/plain.rb

@@ -4,7 +4,7 @@ module RSpec
   module Conductor
     module Formatters
       class Plain < Base
-        def handle_worker_message(_worker_process, message, _results)
+        def handle_worker_message(_worker_process, message, _suite_run)
           public_send(message[:type], message) if respond_to?(message[:type])
         end
 

data/lib/rspec/conductor/server.rb

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-require "English"
-require "socket"
-require "json"
-
 module RSpec
   module Conductor
     class Server
@@ -21,6 +17,7 @@ module RSpec
       # @option formatter [String] Use a certain formatter
       # @option verbose [Boolean] Use especially verbose output
       # @option display_retry_backtraces [Boolean] Display backtraces for specs retried via rspec-retry
+      # @option print_slowest_count [Integer] Print slowest specs in the end of the suite
       def initialize(worker_count:, rspec_args:, **opts)
         @worker_count = worker_count
         @worker_number_offset = opts.fetch(:worker_number_offset, 0)
@@ -30,11 +27,11 @@ module RSpec
         @seed = opts[:seed] || (Random.new_seed % MAX_SEED)
         @fail_fast_after = opts[:fail_fast_after]
         @display_retry_backtraces = opts.fetch(:display_retry_backtraces, false)
+        @print_slowest_count = opts.fetch(:print_slowest_count, nil)
         @verbose = opts.fetch(:verbose, false)
 
         @rspec_args = rspec_args
         @worker_processes = []
-        @dead_worker_processes = []
         @spec_queue = []
         @formatter_class = case opts[:formatter]
                            when "ci"
@@ -47,7 +44,7 @@ module RSpec
                              (!@verbose && Formatters::Fancy.recommended?) ? Formatters::Fancy : Formatters::Plain
                            end
         @formatter = @formatter_class.new(worker_count: @worker_count)
-        @results = Results.new
+        @suite_run = SuiteRun.new
 
         $stdout.sync = true
         $stdin.echo = false if $stdin.tty?
@@ -65,9 +62,10 @@ module RSpec
         start_workers
         run_event_loop
         wait_for_workers_to_exit
-        @results.suite_complete
+        @suite_run.suite_complete
 
-        @formatter.print_summary(@results, seed: @seed, success: success?)
+        @formatter.print_summary(@suite_run, seed: @seed, success: success?)
+        @formatter.print_slowest(@suite_run, @print_slowest_count) if @print_slowest_count
         exit_with_status
       end
 
@@ -95,7 +93,7 @@ module RSpec
         debug "RSpec config: #{config.inspect}"
         debug "Files to run: #{config.files_to_run}"
         @spec_queue = config.files_to_run.shuffle(random: Random.new(@seed))
-        @results.spec_files_total = @spec_queue.size
+        @suite_run.spec_files_total = @spec_queue.size
       end
 
       def preload_application
@@ -127,21 +125,18 @@ module RSpec
             @shutdown_status = :shutdown_messages_sent
             @formatter.print_shutdown_banner
             @worker_processes.select(&:running?).each do |worker_process|
-              worker_process.socket.send_message({ type: :shutdown })
+              worker_process.send_message({ type: :shutdown })
               cleanup_worker_process(worker_process)
             end
           end
 
-          worker_processes_by_io = @worker_processes.select(&:running?).to_h { |w| [w.socket.io, w] }
-          readable_ios, = IO.select(worker_processes_by_io.keys, nil, nil, 0)
-          readable_ios&.each { |io| handle_worker_message(worker_processes_by_io.fetch(io)) }
-          Util::ChildProcess.tick_all(@worker_processes.map(&:child_process))
+          WorkerProcess.tick_all(@worker_processes)
           reap_workers
         end
       end
 
       def wait_for_workers_to_exit
-        Util::ChildProcess.wait_all(@worker_processes.map(&:child_process))
+        WorkerProcess.wait_all(@worker_processes)
       end
 
       def spawn_worker(worker_number)
@@ -150,6 +145,7 @@ module RSpec
         worker_process = WorkerProcess.spawn(
           number: worker_number,
           test_env_number: (@first_is_1 || worker_number != 1) ? worker_number.to_s : "",
+          on_message: ->(worker_process, message) { handle_worker_message(worker_process, message) },
           on_stdout: ->(string) { @formatter.handle_worker_stdout(worker_number, string) },
           on_stderr: ->(string) { @formatter.handle_worker_stderr(worker_number, string) },
           debug_io: @verbose ? $stderr : nil,
@@ -160,37 +156,34 @@ module RSpec
         worker_process
       end
 
-      def handle_worker_message(worker_process)
-        message = worker_process.socket.receive_message
-        return unless message
-
+      def handle_worker_message(worker_process, message)
         debug "Worker #{worker_process.number}: #{message[:type]}"
 
         case message[:type].to_sym
         when :example_passed
-          @results.example_passed
+          @suite_run.example_passed(message)
         when :example_failed
-          @results.example_failed(message)
+          @suite_run.example_failed(message)
 
-          if @fail_fast_after && @results.examples_failed >= @fail_fast_after
-            debug "Shutting down after #{@results.examples_failed} failures"
+          if @fail_fast_after && @suite_run.examples_failed >= @fail_fast_after
+            debug "Shutting down after #{@suite_run.examples_failed} failures"
             initiate_shutdown
           end
         when :example_pending
-          @results.example_pending
+          @suite_run.example_pending
         when :example_retried
           @formatter.print_retry_message(message) if @display_retry_backtraces
         when :spec_complete
-          @results.spec_file_complete
+          @suite_run.spec_file_complete
           worker_process.current_spec = nil
           assign_work(worker_process)
         when :spec_error
-          @results.spec_file_error(message)
+          @suite_run.spec_file_error(message)
           debug "Spec error details: #{message[:error]}"
           worker_process.current_spec = nil
           assign_work(worker_process)
         end
-        @formatter.handle_worker_message(worker_process, message, @results)
+        @formatter.handle_worker_message(worker_process, message, @suite_run)
       end
 
       def assign_work(worker_process)
@@ -198,21 +191,21 @@ module RSpec
 
         if shutting_down? || !spec_file
           debug "No more work for worker #{worker_process.number}, sending shutdown"
-          worker_process.socket.send_message({ type: :shutdown })
+          worker_process.send_message({ type: :shutdown })
           cleanup_worker_process(worker_process)
         else
-          @results.spec_file_assigned
+          @suite_run.spec_file_assigned
           worker_process.current_spec = spec_file
           debug "Assigning #{spec_file} to worker #{worker_process.number}"
           message = { type: :worker_assigned_spec, file: spec_file }
-          worker_process.socket.send_message(message)
-          @formatter.handle_worker_message(worker_process, message, @results)
+          worker_process.send_message(message)
+          @formatter.handle_worker_message(worker_process, message, @suite_run)
         end
       end
 
       def cleanup_worker_process(worker_process, status: :shut_down)
         worker_process.shut_down(status)
-        @formatter.handle_worker_message(worker_process, { type: :worker_shut_down }, @results)
+        @formatter.handle_worker_message(worker_process, { type: :worker_shut_down }, @suite_run)
       end
 
       def reap_workers
@@ -224,7 +217,7 @@ module RSpec
 
         dead_worker_processes.each do |worker_process, exitstatus|
           cleanup_worker_process(worker_process, status: :terminated)
-          @results.worker_crashed
+          @suite_run.worker_crashed
           debug "Worker #{worker_process.number} exited with status #{exitstatus.exitstatus}, signal #{exitstatus.termsig}"
         end
       end
@@ -243,7 +236,7 @@ module RSpec
       end
 
       def success?
-        @results.success? && !shutting_down?
+        @suite_run.success? && !shutting_down?
       end
 
       def exit_with_status

data/lib/rspec/conductor/{results.rb → suite_run.rb}

@@ -2,8 +2,8 @@
 
 module RSpec
   module Conductor
-    class Results
-      attr_accessor :examples_passed, :examples_failed, :examples_pending, :worker_crashes, :errors, :started_at, :spec_files_total, :spec_files_processed
+    class SuiteRun
+      attr_accessor :examples_passed, :examples_failed, :examples_pending, :worker_crashes, :errors, :started_at, :spec_files_total, :spec_files_processed, :example_stats
 
       def initialize
         @examples_passed = 0
@@ -16,17 +16,20 @@ module RSpec
         @specs_completed_at = nil
         @spec_files_total = 0
         @spec_files_processed = 0
+        @example_stats = []
       end
 
       def success?
         @examples_failed.zero? && @errors.empty? && @worker_crashes.zero? && @spec_files_total == @spec_files_processed
       end
 
-      def example_passed
+      def example_passed(message)
+        @example_stats << message.slice(:location, :run_time, :description)
         @examples_passed += 1
       end
 
       def example_failed(message)
+        @example_stats << message.slice(:location, :run_time, :description)
         @examples_failed += 1
         @errors << message
       end

data/lib/rspec/conductor/version.rb

@@ -2,6 +2,6 @@
 
 module RSpec
   module Conductor
-    VERSION = "1.0.9"
+    VERSION = "1.0.10"
   end
 end

data/lib/rspec/conductor/worker_process.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
+require "socket"
+
 module RSpec
   module Conductor
-    WorkerProcess = Struct.new(:pid, :child_process, :number, :status, :socket, :current_spec, keyword_init: true) do
-      def self.spawn(number:, test_env_number:, on_stdout: nil, on_stderr: nil, **worker_init_args)
+    WorkerProcess = Struct.new(:pid, :child_process, :number, :on_message, :status, :socket, :current_spec, keyword_init: true) do
+      def self.spawn(number:, test_env_number:, on_message:, on_stdout: nil, on_stderr: nil, **worker_init_args)
         parent_socket, child_socket = Socket.pair(:UNIX, :STREAM, 0)
         child_process = Util::ChildProcess.fork(on_stdout: on_stdout, on_stderr: on_stderr) do
           ENV["TEST_ENV_NUMBER"] = test_env_number
@@ -19,6 +21,7 @@ module RSpec
         new(
           pid: child_process.pid,
           child_process: child_process,
+          on_message: on_message,
           number: number,
           status: :running,
           socket: Protocol::Socket.new(parent_socket),
@@ -26,6 +29,32 @@ module RSpec
         )
       end
 
+      def self.tick_all(worker_processes)
+        worker_processes_by_io = worker_processes.select(&:running?).to_h { |w| [w.socket.io, w] }
+        readable_ios, = IO.select(worker_processes_by_io.keys, nil, nil, 0)
+        readable_ios&.each { |io| worker_processes_by_io.fetch(io).handle_message }
+        Util::ChildProcess.tick_all(worker_processes.map(&:child_process))
+      end
+
+      def self.wait_all(worker_processes)
+        Util::ChildProcess.wait_all(worker_processes.map(&:child_process))
+      end
+
+      def handle_message
+        message = receive_message
+        return unless message && on_message
+
+        on_message.call(self, message)
+      end
+
+      def send_message(message)
+        socket.send_message(message)
+      end
+
+      def receive_message
+        socket.receive_message
+      end
+
       def shut_down(status)
         return unless running?
 

data/lib/rspec/conductor.rb

@@ -35,7 +35,7 @@ require_relative "conductor/version"
 require_relative "conductor/protocol"
 require_relative "conductor/server"
 require_relative "conductor/worker"
-require_relative "conductor/results"
+require_relative "conductor/suite_run"
 require_relative "conductor/worker_process"
 require_relative "conductor/cli"
 require_relative "conductor/rspec_subscriber"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-conductor
 version: !ruby/object:Gem::Version
-  version: 1.0.9
+  version: 1.0.10
 platform: ruby
 authors:
 - Mark Abramov
@@ -48,9 +48,9 @@ files:
 - lib/rspec/conductor/formatters/plain.rb
 - lib/rspec/conductor/protocol.rb
 - lib/rspec/conductor/railtie.rb
-- lib/rspec/conductor/results.rb
 - lib/rspec/conductor/rspec_subscriber.rb
 - lib/rspec/conductor/server.rb
+- lib/rspec/conductor/suite_run.rb
 - lib/rspec/conductor/util/ansi.rb
 - lib/rspec/conductor/util/child_process.rb
 - lib/rspec/conductor/util/screen_buffer.rb