rspec-benchmark 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 798bc5d4e03d43057fe769a612d69c7b9e94c1d6cf00cb119ff343f184c2dcc2
-  data.tar.gz: 437e723c5984d44d2af9e24dc2eab5a952d4be2531f86d1e5a67de6edfcd122c
+  metadata.gz: 5d86ffbdf2e75f6789264a4206e3caf39f32927f5ad751eb6f02b69fc72743dc
+  data.tar.gz: '096f74a7d6ac5b64b347c38f19757ddd7b870e9dc80996e2dcb09ad13bdacfe2'
 SHA512:
-  metadata.gz: 48a31057edbf78fc8f535110e9a99ccc1bf7a3f7e2ce044eb99cfb3dd1322fe75ce00996acec8b5759b15e9622ef39b6b5cfa4fb678055dda0a8cfd943d1e1cf
-  data.tar.gz: 755534b8baf828aad86a8659bd59c123a2056a3f8b169699db0de5e19468476637f83c093fbd12a1db153c24a29039dacbecd648c67aba7df351b4f15906c492
+  metadata.gz: 673740a08e95e8d0790a9200e30400bb0f2fc0b1ec5f12a4665b709363f0687af9a35a767b336d24aba13d21b25fea334e68011d8572b8c2a0de9e90e845c3e3
+  data.tar.gz: e5a4fd2ffa45d39980edfd900d385f8df95083ef7d6741cea8fc1a885ce34008feec1d13ad602123861f07acb8a5b1fb1fe1f41f12b150cfe037c2d6aa2e5ffe

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change log
 
+## [v0.5.1] - 2019-09-11
+
+### Fixed
+* Fix perform_slower_than matcher the at_least & exact comparisons
+
 ## [v0.5.0] - 2019-04-21
 
 ## Added
@@ -49,6 +54,7 @@
 
 Initial release
 
+[v0.5.1]: https://github.com/peter-murach/rspec-benchmark/compare/v0.5.0...v0.5.1
 [v0.5.0]: https://github.com/peter-murach/rspec-benchmark/compare/v0.4.0...v0.5.0
 [v0.4.0]: https://github.com/peter-murach/rspec-benchmark/compare/v0.3.0...v0.4.0
 [v0.3.0]: https://github.com/peter-murach/rspec-benchmark/compare/v0.2.0...v0.3.0

data/lib/rspec/benchmark/comparison_matcher.rb

@@ -179,23 +179,27 @@ module RSpec
           @count = convert_count(n)
         end
 
-        # @return [Boolean]
+        # At most comparison
+        #
         # @example
-        #   @actual = 40
-        #   @count = 41
+        #   @ratio = 3
+        #   @count = 4
         #   perform_faster_than { ... }.at_most(@count).times # => true
         #
-        #   @actual = 40
-        #   @count = 41
+        #   @ratio = 3
+        #   @count = 2
         #   perform_faster_than { ... }.at_most(@count).times # => false
         #
-        #   @actual = 1/40
-        #   @count = 41
+        #   @ratio = 1/4
+        #   @count = 5
         #   perform_slower_than { ... }.at_most(@count).times # => true
         #
-        #   @actual = 1/40
-        #   @count = 41
+        #   @ratio = 1/4
+        #   @count = 3
         #   perform_slower_than { ... }.at_most(@count).times # => false
+        #
+        # @return [Boolean]
+        #
         # @api private
         def at_most_comparison
           if @comparison_type == :faster
@@ -209,44 +213,52 @@ module RSpec
         # exactly number of counts.
         #
         # @example
-        #   @actual = 40.1
-        #   @count = 40
+        #   @ratio = 3.5
+        #   @count = 3
         #   perform_faster_than { ... }.exact(@count).times # => true
         #
-        #   @actual = 40.1
-        #   @count = 41
-        #   perform_faster_than { ... }.exact(@count).times # => true
+        #   @ratio = 1/4
+        #   @count = 4
+        #   perform_slower_than { ... }.exact(@count).times # => true
         #
         # @return [Boolean]
         #
         # @api private
         def exact_comparison
-          @count == @ratio.round
+          if @comparison_type == :faster
+            @count == @ratio.round
+          else
+            @count == (1.0 / @ratio).round
+          end
         end
 
-        # @return [Boolean]
+        # At least comparison, meaning more than expected count
+        #
         # @example
-        #   @actual = 41
-        #   @count = 40
+        #   @ratio = 4
+        #   @count = 3
         #   perform_faster_than { ... } # => true
         #
-        #   @actual = 41
-        #   @count = 40
+        #   @ratio = 4
+        #   @count = 3
         #   perform_faster_than { ... }.at_least(@count).times # => true
         #
-        #   @actual = 1/40
-        #   @count = 41
+        #   @ratio = 1/4
+        #   @count = 3
         #   perform_slower_than { ... }.at_least(@count).times # => false
         #
-        #   @actual = 1/41
-        #   @count = 40
+        #   @ratio = 1/3
+        #   @count = 4
         #   perform_slower_than { ... }.at_least(@count).times # => true
+        #
+        # @return [Boolean]
+        #
         # @api private
         def default_comparison
           if @comparison_type == :faster
-            @ratio / @count > 1
+            @ratio > @count
           else
-            @ratio / @count < 1 / @count.to_f
+            @ratio < (1.0 / @count)
           end
         end
 

data/lib/rspec/benchmark/version.rb

@@ -2,6 +2,6 @@
 
 module RSpec
   module Benchmark
-    VERSION = "0.5.0"
+    VERSION = "0.5.1"
   end # Benchmark
 end # RSpec

data/spec/unit/comparison_matcher_spec.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 RSpec.describe RSpec::Benchmark::ComparisonMatcher::Matcher do
 
@@ -167,10 +167,18 @@ RSpec.describe RSpec::Benchmark::ComparisonMatcher::Matcher do
       it "passes if the block does performs slower than sample" do
         expect {
           'x' * 10 * 1024
-        }.to perform_slower_than { 1 << 1 }.at_least(20).times
+        }.to perform_slower_than { 1 << 1 }.at_least(15).times
       end
 
-      it "fails if the block does performs faster than sample" do
+      it "fails if the block count compared with sample is too high" do
+        expect {
+          expect {
+            'x' * 10 * 1024
+          }.to perform_slower_than { 1 << 1 }.at_least(200).times
+        }.to raise_error(/expected given block to perform slower than comparison block by at_least 200 times, but performed slower by \d+.\d+ time/)
+      end
+
+      it "fails if the block does perform faster than sample" do
         expect {
           expect {
             1 << 1

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-benchmark
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Piotr Murach
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-21 00:00:00.000000000 Z
+date: 2019-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-malloc