rspec-activerecord-formatter 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 796768aef6b284e761135f02bf4fde2991c6542905abd5084fc77e3fb8005f2b
-  data.tar.gz: 459eab6e0f667b0c683d465a335d9f6f21ee3976d75440fc1c53a4c75c04e0f0
+  metadata.gz: 3eaf70a87ed79a750607124b849bc8f75325f3cbd8b27c6c6c378008bec7d058
+  data.tar.gz: 339da336745315f324dcac1a71ae2ec9800623b250c1f1cbb3e2bf7f7c1c2461
 SHA512:
-  metadata.gz: fe56977ad258d136496454cdca232bb1516dd8e265fd6b5e3239ca6bba9b34286b3785a47e4bb8e42272cf1ed9fc69d4bc760b44c3e28ec0a8daeef16086e3ba
-  data.tar.gz: bd6ed8ff7fa849d319d2e1bccfd9893fa7f6e647c71224279242849788bdaef46e1567ae002cbe43a468d7292cd11338d2713422b22fd9550d4e407b7441bc8b
+  metadata.gz: 671d5e6dc1b7a4abf41c831a26fe6d7f0e599babfb95bcdca2cc5e08e9704bfef855fc9327a349bbd5f5ad9e81032f529ca50d8cb09344589c35bd04c63a22ca
+  data.tar.gz: 27dd9d446ebf122ce2ef1fb442440a36965557e99f34e4fe730bcaa18607470b23dbb24dc0e0a8405961ea582bc9920817e9ac193d1dff33b19690a32b5f4cd1

data/lib/rspec/activerecord/helpers/collector.rb

@@ -3,12 +3,14 @@ require 'active_support/notifications'
 module ActiveRecordFormatterHelpers
   class Collector
     attr_reader :query_count, :objects_count, :total_queries, :total_objects,
-                :query_names, :active_groups, :group_counts
+                :query_names, :active_groups, :group_counts, :groups_encountered
 
     SKIP_QUERIES = ["SELECT tablename FROM pg_tables", "select sum(ct) from (select count(*) ct from"]
 
     def initialize
+      #@unnamed_queries = []
       @query_count    = 0
+      @groups_encountered = 0
       @objects_count  = 0
       @total_queries  = 0
       @total_objects  = 0
@@ -41,6 +43,8 @@ module ActiveRecordFormatterHelpers
     end
 
     def group_started(group)
+      @groups_encountered += 1
+
       return unless group.parent_groups.length > 1
 
       active_groups.push(group_path(group))
@@ -77,8 +81,33 @@ module ActiveRecordFormatterHelpers
       if data[:name] == "SQL" && query_is_an_insert?(data[:sql])
         table = data[:sql].scan(/INSERT INTO "(\w+)"/).first.first
         name = "#{table} Create"
+      elsif query_is_a_full_table_delete?(data[:sql])
+        table = data[:sql].scan(/DELETE FROM "(\w+)"/).first.first
+        name = "Full Delete Table"
+      # TODO: truncate table
+      elsif query_is_transaction_management?(data[:sql])
+        name = "Transaction Management"
+      elsif query_is_schema_detection?(data[:sql])
+        name = "SCHEMA"
+      elsif query_is_trigger_management?(data[:sql])
+        name = "Trigger Management"
+      elsif query_refreshes_materialized_view?(data[:sql])
+        name = "Refresh Materialized View"
       end
 
+
+      # In older versions of Rails, insert statements are just counted as SQL
+      # queries, which means that all the queries are just bunchedup at the top.
+      # Makes this data pretty useless. So anyway, try to suss out a name for
+      # at least those insertions (which are much more frequent than, say,
+      # updates in a test suite anyway).
+      #if data[:name].nil? && query_is_a_delete?(data[:sql])
+      #  table = data[:sql].scan(/DELETE FROM "(\w+)"/).first.first
+      #  name = "#{table} Delete"
+      #end
+
+      #@unnamed_queries << data if name == "Unnamed"
+
       query_names[name] += 1
     end
 
@@ -89,7 +118,32 @@ module ActiveRecordFormatterHelpers
     # TODO: what happens if we try to create many records at once?
     # TODO: are there any false positives we need to worry about? false negatives?
     def query_is_an_insert?(query)
-      query =~ /INSERT INTO/
+      query =~ /^INSERT INTO/
+    end
+
+    def query_is_a_delete?(query)
+      query =~ /^DELETE FROM/
+    end
+
+    def query_is_a_full_table_delete?(query)
+      query =~ /^DELETE FROM [a-z_\."]*;$/i
+    end
+
+    def query_is_transaction_management?(query)
+      query =~ /^(COMMIT|BEGIN|ROLLBACK|SAVEPOINT|RELEASE SAVEPOINT)/
+    end
+
+    def query_is_schema_detection?(query)
+      query =~ /SELECT .* FROM pg_tables/m ||
+        query =~ /SELECT .* FROM information_schema.views/
+    end
+
+    def query_is_trigger_management?(query)
+      query =~ /(DISABLE|ENABLE) TRIGGER ALL/m
+    end
+
+    def query_refreshes_materialized_view?(query)
+      query =~ /REFRESH MATERIALIZED VIEW/m
     end
   end
 end

data/lib/rspec/activerecord/helpers/report.rb

@@ -26,6 +26,7 @@ module ActiveRecordFormatterHelpers
 
       File.open(file_path, "wb") do |f|
         f.puts "#{collector.total_objects} AR objects, #{collector.total_queries} AR queries"
+        f.puts "#{collector.groups_encountered} example groups executed"
 
         f.puts ""
         f.puts "Worst Example Groups by Object Creation"

data/rspec-activerecord-formatter.gemspec

@@ -6,7 +6,7 @@ $LOAD_PATH << lib_dir unless $LOAD_PATH.include?(lib_dir)
 Gem::Specification.new do |gem|
 
   gem.name    = "rspec-activerecord-formatter"
-  gem.version = "2.0.0"
+  gem.version = "2.1.0"
 
   gem.summary     = "Adds object creations and queries to Rspec output."
   gem.description = "Creates a new formatter for ActiveRecord that can help you diagnose performance issues in RSpec"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-activerecord-formatter
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Joseph Mastey
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-07-31 00:00:00.000000000 Z
+date: 2020-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -86,7 +86,7 @@ homepage: http://github.com/jmmastey/rspec-activerecord-formatter
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -101,9 +101,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Adds object creations and queries to Rspec output.
 test_files: []