rqrcode_core 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 242d8334444a28e044ff06c6401471ffbff28178738dd03eb0d099262b22861e
-  data.tar.gz: dc9028113f82e6ee86d5f1ee4511912daa2ed902354a2257a8689b7ca058d32e
+  metadata.gz: 8882bf435375ba687cabacd9f79ec6e8ee6d820264e24375ce3cc69f5ac3cde2
+  data.tar.gz: 5b7e795cdcc8ec3e232fd586157612c8fe72174ae6a31bd7a1b07201e25e64ed
 SHA512:
-  metadata.gz: a8882d2e4b9ecf2d578621499789bfe36c147bc25f8b58f5ff056016be3d0d53218d84bb6931ba25ae4b10d7010d98f189d9166ea6aaebd5e4f33d064f964085
-  data.tar.gz: 77cde43fe0d5b4405001a229447a9a891e606a938b425b6eabdae4b086b2aeeda3b9f81d41a7f1b899250b06e1a2b1f9b45cfd9a4f754eb60d62d64175ae2e1c
+  metadata.gz: 7de9ae7b15f8a102e1bc9529dc0bdd4147b3e1f11b3098eb4ca4e89c041ea19a7931f8ccf959ff1aed252f62682a80577771229e75a187b36be94f25a63921e8
+  data.tar.gz: 1b986e1ba66995331c545d840ed358945a6ef7c6f94e483df5ee2f1b3954e59238f39de3aac25ad92b45b91c0a45f0aebfa7ec69ae257dcc4414a18264e81b6a

data/.github/workflows/ruby.yml

@@ -10,22 +10,20 @@ on:
     - master
 
 jobs:
-  build:
-    name: Test Ruby ${{ matrix.ruby_version }} on ${{ matrix.os }}
-    runs-on: ${{ matrix.os }}
+  Build:
     strategy:
+      fail-fast: false
       matrix:
-        ruby_version: [2.5.x, 2.6.x]
-        os: [ubuntu-latest]
-
+        os: [ubuntu-latest, macos-latest]
+        ruby: [2.5, 2.6, 2.7, 3.0]
+    runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v1
-    - name: Use Ruby ${{ matrix.ruby_version }}
-      uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: ${{ matrix.ruby_version }}
-    - name: Gem install and test
-      run: |
-        gem install bundler
-        bundle install --jobs 4 --retry 3
-        bundle exec rake test
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run Tests
+      run: bundle exec rake test
+    - name: StandardRB Check
+      run: bundle exec standardrb --format progress

data/.gitignore

@@ -7,3 +7,4 @@
 /spec/reports/
 /tmp/
 /.devcontainer/
+*.gem

data/CHANGELOG.md

@@ -0,0 +1,30 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## [1.0.0] - 2021-04-23
+
+### Changed
+
+- README updated
+- Small documentation clarification [@smnscp](https://github.com/smnscp).
+- Rakefile cleaned up. You can now just run `rake` which will run specs and fix linting using `standardrb`
+
+### Breaking Changes
+
+- Very niche but a breaking change never the less. The `to_s` method *no longer* accepts the `:true` and `:false` arguments, but prefers `:dark` and `:light`.
+
+## [0.2.0] - 2020-12-26
+
+### Changed
+
+- fix `required_ruby_version` for Ruby 3 support
+
+[unreleased]: https://github.com/whomwah/rqrcode_core/compare/v1.0.0...HEAD
+[1.0.0]: https://github.com/whomwah/rqrcode_core/compare/v0.2.0...v1.0.0
+[0.2.0]: https://github.com/whomwah/rqrcode_core/compare/v0.1.2...v0.2.0

data/Gemfile.lock

@@ -1,22 +1,51 @@
 PATH
   remote: .
   specs:
-    rqrcode_core (0.2.0)
+    rqrcode_core (1.0.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    minitest (5.11.3)
-    rake (13.0.1)
+    ast (2.4.2)
+    minitest (5.14.4)
+    parallel (1.20.1)
+    parser (3.0.1.0)
+      ast (~> 2.4.1)
+    rainbow (3.0.0)
+    rake (13.0.3)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
+    rubocop (1.12.1)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.2.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.4.1)
+      parser (>= 2.7.1.5)
+    rubocop-performance (1.10.1)
+      rubocop (>= 0.90.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
+    ruby-progressbar (1.11.0)
+    standard (1.0.5)
+      rubocop (= 1.12.1)
+      rubocop-performance (= 1.10.1)
+    standardrb (1.0.0)
+      standard
+    unicode-display_width (2.0.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (>= 2.0)
+  bundler (~> 2.0)
   minitest (~> 5.0)
   rake (~> 13.0)
   rqrcode_core!
+  standardrb (~> 1.0)
 
 BUNDLED WITH
-   2.2.3
+   2.2.15

data/README.md

@@ -1,4 +1,4 @@
-![](https://github.com/whomwah/rqrcode_core/workflows/rqrcode_core/badge.svg)
+![](https://github.com/whomwah/rqrcode_core/actions/workflows/ruby.yml/badge.svg)
 
 # RQRCodeCore
 
@@ -18,7 +18,7 @@ Features:
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rqrcode_core'
+gem "rqrcode_core"
 ```
 
 And then execute:
@@ -32,8 +32,8 @@ Or install it yourself as:
 ## Basic Usage
 
 ```ruby
-$ require 'rqrcode_core'
-$ qr = RQRCodeCore::QRCode.new('my string to generate', size: 4, level: :h)
+$ require "rqrcode_core"
+$ qr = RQRCodeCore::QRCode.new("https://kyan.com")
 $ puts qr.to_s
 ```
 
@@ -49,12 +49,12 @@ x xxx x  xxxxx x       xx x xxx x
 ## Doing your own rendering
 
 ```ruby
-require 'rqrcode_core'
+require "rqrcode_core"
 
-qr = RQRCodeCore::QRCode.new('my string to generate', size: 4, level: :h)
-qr.modules.each do |row|
+qr = RQRCodeCore::QRCode.new("https://kyan.com")
+qr.rows.each do |row|
   row.each do |col|
-    print col ? '#' : ' '
+    print col ? "#" : " "
   end
 
   print "\n"
@@ -68,7 +68,7 @@ The library expects a string to be parsed in, other args are optional.
 ```
 string - the string you wish to encode
 
-size   - the size of the qrcode (default 4)
+size   - the size (integer) of the qrcode (defaults to smallest size needed to encode the string)
 
 level  - the error correction level, can be:
   * Level :l 7%  of code can be restored
@@ -85,13 +85,36 @@ mode   - the mode of the qrcode (defaults to alphanumeric or byte_8bit, dependin
 
 #### Example
 
-```
-qr = RQRCodeCore::QRCode.new('hello world', size: 1, level: :m, mode: :alphanumeric)
+```ruby
+RQRCodeCore::QRCode.new("http://kyan.com", size: 1, level: :m, mode: :alphanumeric)
 ```
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+### Tests
+
+You can run the test suite using:
+
+```
+$ ./bin/setup
+$ rake
+```
+
+or try the project from the console with:
+
+```
+$ ./bin/console
+```
+
+### Linting
+
+The project uses [standardrb](https://github.com/testdouble/standard) and can be run with:
+
+```
+$ ./bin/setup
+$ rake standard # check
+$ rake standard:fix # fix
+```
 
 ## Contributing
 

data/Rakefile

@@ -1,10 +1,14 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+begin
+  require "rake/testtask"
+  require "standard/rake"
 
-Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList["test/**/*_test.rb"]
-end
+  Rake::TestTask.new(:test) do |t|
+    t.libs << "test"
+    t.libs << "lib"
+    t.test_files = FileList["test/**/*_test.rb"]
+  end
 
-task :default => :test
+  task default: [:test, "standard:fix"]
+rescue LoadError
+  # no standard/rspec available
+end

data/lib/rqrcode_core/qrcode.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require 'rqrcode_core/qrcode/qr_8bit_byte'
-require 'rqrcode_core/qrcode/qr_alphanumeric'
-require 'rqrcode_core/qrcode/qr_bit_buffer'
-require 'rqrcode_core/qrcode/qr_code'
-require 'rqrcode_core/qrcode/qr_math'
-require 'rqrcode_core/qrcode/qr_numeric'
-require 'rqrcode_core/qrcode/qr_polynomial'
-require 'rqrcode_core/qrcode/qr_rs_block'
-require 'rqrcode_core/qrcode/qr_util'
+require "rqrcode_core/qrcode/qr_8bit_byte"
+require "rqrcode_core/qrcode/qr_alphanumeric"
+require "rqrcode_core/qrcode/qr_bit_buffer"
+require "rqrcode_core/qrcode/qr_code"
+require "rqrcode_core/qrcode/qr_math"
+require "rqrcode_core/qrcode/qr_numeric"
+require "rqrcode_core/qrcode/qr_polynomial"
+require "rqrcode_core/qrcode/qr_rs_block"
+require "rqrcode_core/qrcode/qr_util"

data/lib/rqrcode_core/qrcode/qr_8bit_byte.rb

@@ -4,18 +4,16 @@ module RQRCodeCore
   class QR8bitByte
     attr_reader :mode
 
-    def initialize( data )
+    def initialize(data)
       @mode = QRMODE[:mode_8bit_byte]
-      @data = data;
+      @data = data
     end
 
-
     def get_length
       @data.bytesize
     end
 
-
-    def write( buffer)
+    def write(buffer)
       buffer.byte_encoding_start(get_length)
       @data.each_byte do |b|
         buffer.put(b, 8)

data/lib/rqrcode_core/qrcode/qr_alphanumeric.rb

@@ -1,20 +1,19 @@
 # frozen_string_literal: true
 
 module RQRCodeCore
-  ALPHANUMERIC = ['0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z',' ','$','%','*','+','-','.','/',':']
+  ALPHANUMERIC = ["0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V", "W", "X", "Y", "Z", " ", "$", "%", "*", "+", "-", ".", "/", ":"]
 
   class QRAlphanumeric
     attr_reader :mode
 
-    def initialize( data )
+    def initialize(data)
       @mode = QRMODE[:mode_alpha_numk]
 
       raise QRCodeArgumentError, "Not a alpha numeric uppercase string `#{data}`" unless QRAlphanumeric.valid_data?(data)
 
-      @data = data;
+      @data = data
     end
 
-
     def get_length
       @data.size
     end
@@ -26,18 +25,17 @@ module RQRCodeCore
       true
     end
 
-
-    def write( buffer)
+    def write(buffer)
       buffer.alphanumeric_encoding_start(get_length)
 
-      (@data.size).times do |i|
+      @data.size.times do |i|
         if i % 2 == 0
           if i == (@data.size - 1)
             value = ALPHANUMERIC.index(@data[i])
-            buffer.put( value, 6 )
+            buffer.put(value, 6)
           else
-            value = (ALPHANUMERIC.index(@data[i]) * 45) + ALPHANUMERIC.index(@data[i+1])
-            buffer.put( value, 11 )
+            value = (ALPHANUMERIC.index(@data[i]) * 45) + ALPHANUMERIC.index(@data[i + 1])
+            buffer.put(value, 11)
           end
         end
       end

data/lib/rqrcode_core/qrcode/qr_bit_buffer.rb

@@ -13,74 +13,64 @@ module RQRCodeCore
       @length = 0
     end
 
-
-    def get( index )
+    def get(index)
       buf_index = (index / 8).floor
-      (( QRUtil.rszf(@buffer[buf_index], 7 - index % 8)) & 1) == 1
+      ((QRUtil.rszf(@buffer[buf_index], 7 - index % 8)) & 1) == 1
     end
 
-
-    def put( num, length )
-      ( 0...length ).each do |i|
+    def put(num, length)
+      (0...length).each do |i|
         put_bit(((QRUtil.rszf(num, length - i - 1)) & 1) == 1)
       end
     end
 
-
     def get_length_in_bits
       @length
     end
 
-
-    def put_bit( bit )
-      buf_index = ( @length / 8 ).floor
+    def put_bit(bit)
+      buf_index = (@length / 8).floor
       if @buffer.size <= buf_index
         @buffer << 0
       end
 
       if bit
-        @buffer[buf_index] |= (QRUtil.rszf(0x80, @length % 8))
+        @buffer[buf_index] |= QRUtil.rszf(0x80, @length % 8)
       end
 
       @length += 1
     end
 
     def byte_encoding_start(length)
-
-      put( QRMODE[:mode_8bit_byte], 4 )
+      put(QRMODE[:mode_8bit_byte], 4)
       put(length, QRUtil.get_length_in_bits(QRMODE[:mode_8bit_byte], @version))
-
     end
 
     def alphanumeric_encoding_start(length)
-
-      put( QRMODE[:mode_alpha_numk], 4 )
+      put(QRMODE[:mode_alpha_numk], 4)
       put(length, QRUtil.get_length_in_bits(QRMODE[:mode_alpha_numk], @version))
-
     end
 
     def numeric_encoding_start(length)
-
-      put( QRMODE[:mode_number], 4 )
+      put(QRMODE[:mode_number], 4)
       put(length, QRUtil.get_length_in_bits(QRMODE[:mode_number], @version))
-
     end
 
     def pad_until(prefered_size)
       # Align on byte
       while get_length_in_bits % 8 != 0
-        put_bit( false )
+        put_bit(false)
       end
 
       # Pad with padding code words
       while get_length_in_bits < prefered_size
-        put( QRBitBuffer::PAD0, 8 )
-        put( QRBitBuffer::PAD1, 8 ) if get_length_in_bits < prefered_size
+        put(QRBitBuffer::PAD0, 8)
+        put(QRBitBuffer::PAD1, 8) if get_length_in_bits < prefered_size
       end
     end
 
     def end_of_message(max_data_bits)
-      put( 0, 4 ) unless get_length_in_bits+4 > max_data_bits
+      put(0, 4) unless get_length_in_bits + 4 > max_data_bits
     end
   end
 end

data/lib/rqrcode_core/qrcode/qr_code.rb

@@ -2,141 +2,142 @@
 
 module RQRCodeCore
   QRMODE = {
-    :mode_number        => 1 << 0,
-    :mode_alpha_numk    => 1 << 1,
-    :mode_8bit_byte     => 1 << 2,
+    mode_number: 1 << 0,
+    mode_alpha_numk: 1 << 1,
+    mode_8bit_byte: 1 << 2
   }
 
   QRMODE_NAME = {
-    :number        => :mode_number,
-    :alphanumeric  => :mode_alpha_numk,
-    :byte_8bit     => :mode_8bit_byte
+    number: :mode_number,
+    alphanumeric: :mode_alpha_numk,
+    byte_8bit: :mode_8bit_byte
   }
 
   QRERRORCORRECTLEVEL = {
-    :l => 1,
-    :m => 0,
-    :q => 3,
-    :h => 2
+    l: 1,
+    m: 0,
+    q: 3,
+    h: 2
   }
 
   QRMASKPATTERN = {
-    :pattern000 => 0,
-    :pattern001 => 1,
-    :pattern010 => 2,
-    :pattern011 => 3,
-    :pattern100 => 4,
-    :pattern101 => 5,
-    :pattern110 => 6,
-    :pattern111 => 7
+    pattern000: 0,
+    pattern001: 1,
+    pattern010: 2,
+    pattern011: 3,
+    pattern100: 4,
+    pattern101: 5,
+    pattern110: 6,
+    pattern111: 7
   }
 
   QRMASKCOMPUTATIONS = [
-        Proc.new { |i,j| (i + j) % 2 == 0 },
-        Proc.new { |i,j| i % 2 == 0 },
-        Proc.new { |i,j| j % 3 == 0 },
-        Proc.new { |i,j| (i + j) % 3 == 0 },
-        Proc.new { |i,j| ((i / 2).floor + (j / 3).floor) % 2 == 0 },
-        Proc.new { |i,j| (i * j) % 2 + (i * j) % 3 == 0 },
-        Proc.new { |i,j| ((i * j) % 2 + (i * j) % 3) % 2 == 0 },
-        Proc.new { |i,j| ((i * j) % 3 + (i + j) % 2) % 2 == 0 },
+    proc { |i, j| (i + j) % 2 == 0 },
+    proc { |i, j| i % 2 == 0 },
+    proc { |i, j| j % 3 == 0 },
+    proc { |i, j| (i + j) % 3 == 0 },
+    proc { |i, j| ((i / 2).floor + (j / 3).floor) % 2 == 0 },
+    proc { |i, j| (i * j) % 2 + (i * j) % 3 == 0 },
+    proc { |i, j| ((i * j) % 2 + (i * j) % 3) % 2 == 0 },
+    proc { |i, j| ((i * j) % 3 + (i + j) % 2) % 2 == 0 }
   ]
 
   QRPOSITIONPATTERNLENGTH = (7 + 1) * 2 + 1
   QRFORMATINFOLENGTH = 15
 
-  #http://web.archive.org/web/20110710094955/http://www.denso-wave.com/qrcode/vertable1-e.html
-  #http://web.archive.org/web/20110710094955/http://www.denso-wave.com/qrcode/vertable2-e.html
-  #http://web.archive.org/web/20110710094955/http://www.denso-wave.com/qrcode/vertable3-e.html
-  #http://web.archive.org/web/20110710094955/http://www.denso-wave.com/qrcode/vertable4-e.html
+  # http://web.archive.org/web/20110710094955/http://www.denso-wave.com/qrcode/vertable1-e.html
+  # http://web.archive.org/web/20110710094955/http://www.denso-wave.com/qrcode/vertable2-e.html
+  # http://web.archive.org/web/20110710094955/http://www.denso-wave.com/qrcode/vertable3-e.html
+  # http://web.archive.org/web/20110710094955/http://www.denso-wave.com/qrcode/vertable4-e.html
   # Each array contains levels max chars from level 1 to level 40
   QRMAXDIGITS = {
-      l: {
-          mode_number: [
-              41, 77, 127, 187, 255, 322, 370, 461, 552, 652, 772,
-              883, 1022, 1101, 1250, 1408, 1548, 1725, 1903, 2061,
-              2232, 2409, 2620, 2812, 3057, 3283, 3514, 3669, 3909, 4158,
-              4417, 4686, 4965, 5253, 5529, 5836, 6153, 6479, 6743, 7089
-          ],
-          mode_alpha_numk: [
-              25, 47, 77, 114, 154, 195, 224, 279, 335, 395,
-              468, 535, 619, 667, 758, 854, 938, 1046, 1153, 1249,
-              1352, 1460, 1588, 1704, 1853, 1990, 2132, 2223, 2369, 2520,
-              2677, 2840, 3009, 3183, 3351, 3537, 3729, 3927, 4087, 4296
-          ],
-          mode_8bit_byte: [
-              17, 32, 53, 78, 106, 134, 154, 192, 230, 271,
-              321, 367, 425, 458, 520, 586, 644, 718, 792, 858,
-              929, 1003, 1091, 1171, 1273, 1367, 1465, 1528, 1628, 1732,
-              1840, 1952, 2068, 2188, 2303, 2431, 2563, 2699, 2809, 2953
-          ],
-      },
-      m: {
-          mode_number: [
-              34, 63, 101, 149, 202, 255, 293, 365, 432, 513,
-              604, 691, 796, 871, 991, 1082, 1212, 1346, 1500, 1600,
-              1708, 1872, 2059, 2188, 2395, 2544, 2701, 2857, 3035, 3289,
-              3486, 3693, 3909, 4134, 4343, 4588, 4775, 5039, 5313, 5596,
-          ],
-          mode_alpha_numk: [
-              20, 38, 61, 90, 122, 154, 178, 221, 262, 311,
-              366, 419, 483, 528, 600, 656, 734, 816, 909, 970,
-              1035, 1134, 1248, 1326, 1451, 1542, 1637, 1732, 1839, 1994,
-              2113, 2238, 2369, 2506, 2632, 2780, 2894, 3054, 3220, 3391
-          ],
-          mode_8bit_byte: [
-              14, 26, 42, 62, 84, 106, 122, 152, 180, 213,
-              251, 287, 331, 362, 412, 450, 504, 560, 624, 666,
-              711, 779, 857, 911, 997, 1059, 1125, 1190, 1264, 1370,
-              1452, 1538, 1628, 1722, 1809, 1911, 1989, 2099, 2213, 2331
-          ],
-      },
-      q: {
-          mode_number: [
-              27, 48, 77, 111, 144, 178, 207, 259, 312, 364,
-              427, 489, 580, 621, 703, 775, 876, 948, 1063, 1159,
-              1224, 1358, 1468, 1588, 1718, 1804, 1933, 2085, 2181, 2358,
-              2473, 2670, 2805, 2949, 3081, 3244, 3417, 3599, 3791, 3993
-          ],
-          mode_alpha_numk: [
-              16, 29, 47, 67, 87, 108, 125, 157, 189, 221,
-              259, 296, 352, 376, 426, 470, 531, 574, 644, 702,
-              742, 823, 890, 963, 1041, 1094, 1172, 1263, 1322, 1429,
-              1499, 1618, 1700, 1787, 1867, 1966, 2071, 2181, 2298, 2420
-          ],
-          mode_8bit_byte: [
-              11, 20, 32, 46, 60, 74, 86, 108, 130, 151,
-              177, 203, 241, 258, 292, 22, 364, 394, 442, 482,
-              509, 565, 611, 661, 715, 751, 805, 868, 908, 982,
-              1030, 1112, 1168, 1228, 1283, 1351, 1423, 1499, 1579, 1663
-          ],
-      },
-      h: {
-          mode_number: [
-              17, 34, 58, 82, 106, 139, 154, 202, 235, 288, 331, 374, 427, 468, 530, 602, 674,
-              331, 374, 427, 468, 530, 602, 674, 746, 813, 919,
-              969, 1056, 1108, 1228, 1286, 1425, 1501, 1581, 1677, 1782,
-              1897, 2022, 2157, 2301, 2361, 2524, 2625, 2735, 2927, 3057
-
-          ],
-          mode_alpha_numk: [
-              10, 20, 35, 50, 64, 84, 93, 122, 143, 174, 200,
-              200, 227, 259, 283, 321, 365, 408, 452, 493, 557,
-              587, 640, 672, 744, 779, 864, 910, 958, 1016, 1080,
-              1150, 1226, 1307, 1394, 1431, 1530, 1591, 1658, 1774, 1852
-          ],
-          mode_8bit_byte: [
-              7, 14, 24, 34, 44, 58, 64, 84, 98, 119,
-              137, 155, 177, 194, 220, 250, 280, 310, 338, 382,
-              403, 439, 461, 511, 535, 593, 625, 658, 698, 742,
-              790, 842, 898, 958, 983, 1051, 1093, 1139, 1219, 1273
-          ],
-      },
+    l: {
+      mode_number: [
+        41, 77, 127, 187, 255, 322, 370, 461, 552, 652, 772,
+        883, 1022, 1101, 1250, 1408, 1548, 1725, 1903, 2061,
+        2232, 2409, 2620, 2812, 3057, 3283, 3514, 3669, 3909, 4158,
+        4417, 4686, 4965, 5253, 5529, 5836, 6153, 6479, 6743, 7089
+      ],
+      mode_alpha_numk: [
+        25, 47, 77, 114, 154, 195, 224, 279, 335, 395,
+        468, 535, 619, 667, 758, 854, 938, 1046, 1153, 1249,
+        1352, 1460, 1588, 1704, 1853, 1990, 2132, 2223, 2369, 2520,
+        2677, 2840, 3009, 3183, 3351, 3537, 3729, 3927, 4087, 4296
+      ],
+      mode_8bit_byte: [
+        17, 32, 53, 78, 106, 134, 154, 192, 230, 271,
+        321, 367, 425, 458, 520, 586, 644, 718, 792, 858,
+        929, 1003, 1091, 1171, 1273, 1367, 1465, 1528, 1628, 1732,
+        1840, 1952, 2068, 2188, 2303, 2431, 2563, 2699, 2809, 2953
+      ]
+    },
+    m: {
+      mode_number: [
+        34, 63, 101, 149, 202, 255, 293, 365, 432, 513,
+        604, 691, 796, 871, 991, 1082, 1212, 1346, 1500, 1600,
+        1708, 1872, 2059, 2188, 2395, 2544, 2701, 2857, 3035, 3289,
+        3486, 3693, 3909, 4134, 4343, 4588, 4775, 5039, 5313, 5596
+      ],
+      mode_alpha_numk: [
+        20, 38, 61, 90, 122, 154, 178, 221, 262, 311,
+        366, 419, 483, 528, 600, 656, 734, 816, 909, 970,
+        1035, 1134, 1248, 1326, 1451, 1542, 1637, 1732, 1839, 1994,
+        2113, 2238, 2369, 2506, 2632, 2780, 2894, 3054, 3220, 3391
+      ],
+      mode_8bit_byte: [
+        14, 26, 42, 62, 84, 106, 122, 152, 180, 213,
+        251, 287, 331, 362, 412, 450, 504, 560, 624, 666,
+        711, 779, 857, 911, 997, 1059, 1125, 1190, 1264, 1370,
+        1452, 1538, 1628, 1722, 1809, 1911, 1989, 2099, 2213, 2331
+      ]
+    },
+    q: {
+      mode_number: [
+        27, 48, 77, 111, 144, 178, 207, 259, 312, 364,
+        427, 489, 580, 621, 703, 775, 876, 948, 1063, 1159,
+        1224, 1358, 1468, 1588, 1718, 1804, 1933, 2085, 2181, 2358,
+        2473, 2670, 2805, 2949, 3081, 3244, 3417, 3599, 3791, 3993
+      ],
+      mode_alpha_numk: [
+        16, 29, 47, 67, 87, 108, 125, 157, 189, 221,
+        259, 296, 352, 376, 426, 470, 531, 574, 644, 702,
+        742, 823, 890, 963, 1041, 1094, 1172, 1263, 1322, 1429,
+        1499, 1618, 1700, 1787, 1867, 1966, 2071, 2181, 2298, 2420
+      ],
+      mode_8bit_byte: [
+        11, 20, 32, 46, 60, 74, 86, 108, 130, 151,
+        177, 203, 241, 258, 292, 22, 364, 394, 442, 482,
+        509, 565, 611, 661, 715, 751, 805, 868, 908, 982,
+        1030, 1112, 1168, 1228, 1283, 1351, 1423, 1499, 1579, 1663
+      ]
+    },
+    h: {
+      mode_number: [
+        17, 34, 58, 82, 106, 139, 154, 202, 235, 288, 331, 374, 427, 468, 530, 602, 674,
+        331, 374, 427, 468, 530, 602, 674, 746, 813, 919,
+        969, 1056, 1108, 1228, 1286, 1425, 1501, 1581, 1677, 1782,
+        1897, 2022, 2157, 2301, 2361, 2524, 2625, 2735, 2927, 3057
+
+      ],
+      mode_alpha_numk: [
+        10, 20, 35, 50, 64, 84, 93, 122, 143, 174, 200,
+        200, 227, 259, 283, 321, 365, 408, 452, 493, 557,
+        587, 640, 672, 744, 779, 864, 910, 958, 1016, 1080,
+        1150, 1226, 1307, 1394, 1431, 1530, 1591, 1658, 1774, 1852
+      ],
+      mode_8bit_byte: [
+        7, 14, 24, 34, 44, 58, 64, 84, 98, 119,
+        137, 155, 177, 194, 220, 250, 280, 310, 338, 382,
+        403, 439, 461, 511, 535, 593, 625, 658, 698, 742,
+        790, 842, 898, 958, 983, 1051, 1093, 1139, 1219, 1273
+      ]
+    }
   }
 
   # StandardErrors
 
   class QRCodeArgumentError < ArgumentError; end
+
   class QRCodeRunTimeError < RuntimeError; end
 
   # == Creation
@@ -154,7 +155,7 @@ module RQRCodeCore
     # Expects a string to be parsed in, other args are optional
     #
     #   # string - the string you wish to encode
-    #   # size   - the size of the qrcode (default 4)
+    #   # size   - the size (Integer) of the qrcode (defaults to smallest size needed to encode the string)
     #   # level  - the error correction level, can be:
     #      * Level :l 7%  of code can be restored
     #      * Level :m 15% of code can be restored
@@ -169,54 +170,53 @@ module RQRCodeCore
     #   qr = RQRCodeCore::QRCode.new('hello world', size: 1, level: :m, mode: :alphanumeric)
     #
 
-    def initialize( string, *args )
+    def initialize(string, *args)
       if !string.is_a? String
         raise QRCodeArgumentError, "The passed data is #{string.class}, not String"
       end
 
-      options               = extract_options!(args)
-      level                 = (options[:level] || :h).to_sym
+      options = extract_options!(args)
+      level = (options[:level] || :h).to_sym
 
       if !QRERRORCORRECTLEVEL.has_key?(level)
         raise QRCodeArgumentError, "Unknown error correction level `#{level.inspect}`"
       end
 
-      @data                 = string
+      @data = string
 
-      mode                  = QRMODE_NAME[(options[:mode] || '').to_sym]
+      mode = QRMODE_NAME[(options[:mode] || "").to_sym]
       # If mode is not explicitely given choose mode according to data type
-      mode ||= case
-        when RQRCodeCore::QRNumeric.valid_data?(@data)
-          QRMODE_NAME[:number]
-        when QRAlphanumeric.valid_data?(@data)
-          QRMODE_NAME[:alphanumeric]
-        else
-          QRMODE_NAME[:byte_8bit]
+      mode ||= if RQRCodeCore::QRNumeric.valid_data?(@data)
+        QRMODE_NAME[:number]
+      elsif QRAlphanumeric.valid_data?(@data)
+        QRMODE_NAME[:alphanumeric]
+      else
+        QRMODE_NAME[:byte_8bit]
       end
 
-      max_size_array        = QRMAXDIGITS[level][mode]
-      size                  = options[:size] || smallest_size_for(string, max_size_array)
+      max_size_array = QRMAXDIGITS[level][mode]
+      size = options[:size] || smallest_size_for(string, max_size_array)
 
       if size > QRUtil.max_size
         raise QRCodeArgumentError, "Given size greater than maximum possible size of #{QRUtil.max_size}"
       end
 
-      @error_correct_level  = QRERRORCORRECTLEVEL[level]
-      @version              = size
-      @module_count         = @version * 4 + QRPOSITIONPATTERNLENGTH
-      @modules              = Array.new( @module_count )
-      @data_list            =
+      @error_correct_level = QRERRORCORRECTLEVEL[level]
+      @version = size
+      @module_count = @version * 4 + QRPOSITIONPATTERNLENGTH
+      @modules = Array.new(@module_count)
+      @data_list =
         case mode
         when :mode_number
-          QRNumeric.new( @data )
+          QRNumeric.new(@data)
         when :mode_alpha_numk
-          QRAlphanumeric.new( @data )
+          QRAlphanumeric.new(@data)
         else
-          QR8bitByte.new( @data )
+          QR8bitByte.new(@data)
         end
 
-      @data_cache           = nil
-      self.make
+      @data_cache = nil
+      make
     end
 
     # <tt>checked?</tt> is called with a +col+ and +row+ parameter. This will
@@ -227,7 +227,7 @@ module RQRCodeCore
     #  instance.checked?( 10, 10 ) => true
     #
 
-    def checked?( row, col )
+    def checked?(row, col)
       if !row.between?(0, @module_count - 1) || !col.between?(0, @module_count - 1)
         raise QRCodeRunTimeError, "Invalid row/column pair: #{row}, #{col}"
       end
@@ -241,7 +241,7 @@ module RQRCodeCore
     # generated as a string. It will not be able to be read
     # in this format by a QR Code reader, but will give you an
     # idea if the final outout. It takes two optional args
-    # +:true+ and +:false+ which are there for you to choose
+    # +:dark+ and +:light+ which are there for you to choose
     # how the output looks. Here's an example of it's use:
     #
     #  instance.to_s =>
@@ -255,11 +255,11 @@ module RQRCodeCore
     #  EQEEEQEQQEEEEEQEQQQQQQQEEQEQEEEQE
     #
 
-    def to_s( *args )
-      options                = extract_options!(args)
-      dark                   = options[:dark] || options[:true] || 'x'
-      light                  = options[:light] || options[:false] || ' '
-      quiet_zone_size        = options[:quiet_zone_size] || 0
+    def to_s(*args)
+      options = extract_options!(args)
+      dark = options[:dark] || "x"
+      light = options[:light] || " "
+      quiet_zone_size = options[:quiet_zone_size] || 0
 
       rows = []
 
@@ -309,7 +309,7 @@ module RQRCodeCore
 
     def make #:nodoc:
       prepare_common_patterns
-      make_impl( false, get_best_mask_pattern )
+      make_impl(false, get_best_mask_pattern)
     end
 
     private
@@ -326,7 +326,7 @@ module RQRCodeCore
       @common_patterns = @modules.map(&:clone)
     end
 
-    def make_impl( test, mask_pattern ) #:nodoc:
+    def make_impl(test, mask_pattern) #:nodoc:
       @modules = @common_patterns.map(&:clone)
 
       place_format_info(test, mask_pattern)
@@ -338,20 +338,19 @@ module RQRCodeCore
         )
       end
 
-      map_data( @data_cache, mask_pattern )
+      map_data(@data_cache, mask_pattern)
     end
 
-
-    def place_position_probe_pattern( row, col ) #:nodoc:
+    def place_position_probe_pattern(row, col) #:nodoc:
       (-1..7).each do |r|
-        next if !(row + r).between?(0, @module_count - 1)
+        next unless (row + r).between?(0, @module_count - 1)
 
         (-1..7).each do |c|
-          next if !(col + c).between?(0, @module_count - 1)
+          next unless (col + c).between?(0, @module_count - 1)
 
           is_vert_line = (r.between?(0, 6) && (c == 0 || c == 6))
           is_horiz_line = (c.between?(0, 6) && (r == 0 || r == 6))
-          is_square = r.between?(2,4) && c.between?(2, 4)
+          is_square = r.between?(2, 4) && c.between?(2, 4)
 
           is_part_of_probe = is_vert_line || is_horiz_line || is_square
           @modules[row + r][col + c] = is_part_of_probe
@@ -359,14 +358,13 @@ module RQRCodeCore
       end
     end
 
-
     def get_best_mask_pattern #:nodoc:
       min_lost_point = 0
       pattern = 0
 
-      ( 0...8 ).each do |i|
-        make_impl( true, i )
-        lost_point = QRUtil.get_lost_points(self.modules)
+      (0...8).each do |i|
+        make_impl(true, i)
+        lost_point = QRUtil.get_lost_points(modules)
 
         if i == 0 || min_lost_point > lost_point
           min_lost_point = lost_point
@@ -376,14 +374,12 @@ module RQRCodeCore
       pattern
     end
 
-
     def place_timing_pattern #:nodoc:
-      ( 8...@module_count - 8 ).each do |i|
+      (8...@module_count - 8).each do |i|
         @modules[i][6] = @modules[6][i] = i % 2 == 0
       end
     end
 
-
     def place_position_adjust_pattern #:nodoc:
       positions = QRUtil.get_pattern_positions(@version)
 
@@ -391,9 +387,9 @@ module RQRCodeCore
         positions.each do |col|
           next unless @modules[row][col].nil?
 
-          ( -2..2 ).each do |r|
-            ( -2..2 ).each do |c|
-              is_part_of_pattern = (r.abs == 2 || c.abs == 2 || ( r == 0 && c == 0 ))
+          (-2..2).each do |r|
+            (-2..2).each do |c|
+              is_part_of_pattern = (r.abs == 2 || c.abs == 2 || (r == 0 && c == 0))
               @modules[row + r][col + c] = is_part_of_pattern
             end
           end
@@ -401,69 +397,65 @@ module RQRCodeCore
       end
     end
 
-
     def place_version_info(test) #:nodoc:
       bits = QRUtil.get_bch_version(@version)
 
-      ( 0...18 ).each do |i|
-        mod = ( !test && ( (bits >> i) & 1) == 1 )
-        @modules[ (i / 3).floor ][ i % 3 + @module_count - 8 - 3 ] = mod
-        @modules[ i % 3 + @module_count - 8 - 3 ][ (i / 3).floor ] = mod
+      (0...18).each do |i|
+        mod = (!test && ((bits >> i) & 1) == 1)
+        @modules[(i / 3).floor][ i % 3 + @module_count - 8 - 3 ] = mod
+        @modules[i % 3 + @module_count - 8 - 3][ (i / 3).floor ] = mod
       end
     end
 
-
     def place_format_info(test, mask_pattern) #:nodoc:
       data = (@error_correct_level << 3 | mask_pattern)
       bits = QRUtil.get_bch_format_info(data)
 
       QRFORMATINFOLENGTH.times do |i|
-        mod = (!test && ( (bits >> i) & 1) == 1)
+        mod = (!test && ((bits >> i) & 1) == 1)
 
         # vertical
-        if i < 6
-          row = i
+        row = if i < 6
+          i
         elsif i < 8
-          row = i + 1
+          i + 1
         else
-          row = @module_count - 15 + i
+          @module_count - 15 + i
         end
         @modules[row][8] = mod
 
         # horizontal
-        if i < 8
-          col = @module_count - i - 1
+        col = if i < 8
+          @module_count - i - 1
         elsif i < 9
-          col = 15 - i - 1 + 1
+          15 - i - 1 + 1
         else
-          col = 15 - i - 1
+          15 - i - 1
         end
         @modules[8][col] = mod
       end
 
       # fixed module
-      @modules[ @module_count - 8 ][8] = !test
+      @modules[@module_count - 8][8] = !test
     end
 
-
-    def map_data( data, mask_pattern ) #:nodoc:
+    def map_data(data, mask_pattern) #:nodoc:
       inc = -1
       row = @module_count - 1
       bit_index = 7
       byte_index = 0
 
-      ( @module_count - 1 ).step( 1, -2 ) do |col|
-        col = col - 1 if col <= 6
+      (@module_count - 1).step(1, -2) do |col|
+        col -= 1 if col <= 6
 
-        while true do
-          ( 0...2 ).each do |c|
-
-            if @modules[row][ col - c ].nil?
+        loop do
+          (0...2).each do |c|
+            if @modules[row][col - c].nil?
               dark = false
               if byte_index < data.size && !data[byte_index].nil?
-                dark = (( QRUtil.rszf(data[byte_index], bit_index) & 1) == 1 )
+                dark = ((QRUtil.rszf(data[byte_index], bit_index) & 1) == 1)
               end
-              mask = QRUtil.get_mask( mask_pattern, row, col - c )
+              mask = QRUtil.get_mask(mask_pattern, row, col - c)
               dark = !dark if mask
               @modules[row][ col - c ] = dark
               bit_index -= 1
@@ -488,8 +480,8 @@ module RQRCodeCore
 
     def smallest_size_for(string, max_size_array) #:nodoc:
       l = string.bytesize
-      ver = max_size_array.index{|i| i >= l}
-      raise QRCodeRunTimeError,"code length overflow. (#{l} digits > any version capacity)" unless ver
+      ver = max_size_array.index { |i| i >= l }
+      raise QRCodeRunTimeError, "code length overflow. (#{l} digits > any version capacity)" unless ver
       ver + 1
     end
 
@@ -497,90 +489,91 @@ module RQRCodeCore
       arr.last.is_a?(::Hash) ? arr.pop : {}
     end
 
-    def QRCode.count_max_data_bits(rs_blocks)
-      max_data_bytes = rs_blocks.reduce(0) do |sum, rs_block|
-        sum + rs_block.data_count
-      end
-
-      return max_data_bytes * 8
-    end
-
-    def QRCode.create_data(version, error_correct_level, data_list) #:nodoc:
-      rs_blocks = QRRSBlock.get_rs_blocks(version, error_correct_level)
-      max_data_bits = QRCode.count_max_data_bits(rs_blocks)
-      buffer = QRBitBuffer.new(version)
-
-      data_list.write(buffer)
-      buffer.end_of_message(max_data_bits)
+    class << self
+      def count_max_data_bits(rs_blocks)
+        max_data_bytes = rs_blocks.reduce(0) do |sum, rs_block|
+          sum + rs_block.data_count
+        end
 
-      if buffer.get_length_in_bits > max_data_bits
-        raise QRCodeRunTimeError, "code length overflow. (#{buffer.get_length_in_bits}>#{max_data_bits}). (Try a larger size!)"
+        max_data_bytes * 8
       end
 
-      buffer.pad_until(max_data_bits)
+      def create_data(version, error_correct_level, data_list) #:nodoc:
+        rs_blocks = QRRSBlock.get_rs_blocks(version, error_correct_level)
+        max_data_bits = QRCode.count_max_data_bits(rs_blocks)
+        buffer = QRBitBuffer.new(version)
 
-      QRCode.create_bytes( buffer, rs_blocks )
-    end
+        data_list.write(buffer)
+        buffer.end_of_message(max_data_bits)
 
+        if buffer.get_length_in_bits > max_data_bits
+          raise QRCodeRunTimeError, "code length overflow. (#{buffer.get_length_in_bits}>#{max_data_bits}). (Try a larger size!)"
+        end
 
-    def QRCode.create_bytes( buffer, rs_blocks ) #:nodoc:
-      offset = 0
-      max_dc_count = 0
-      max_ec_count = 0
-      dcdata = Array.new( rs_blocks.size )
-      ecdata = Array.new( rs_blocks.size )
+        buffer.pad_until(max_data_bits)
 
-      rs_blocks.each_with_index do |rs_block, r|
-        dc_count = rs_block.data_count
-        ec_count = rs_block.total_count - dc_count
-        max_dc_count = [ max_dc_count, dc_count ].max
-        max_ec_count = [ max_ec_count, ec_count ].max
+        QRCode.create_bytes(buffer, rs_blocks)
+      end
 
-        dcdata_block = Array.new(dc_count)
-        dcdata_block.size.times do |i|
-          dcdata_block[i] = 0xff & buffer.buffer[ i + offset ]
-        end
-        dcdata[r] = dcdata_block
+      def create_bytes(buffer, rs_blocks) #:nodoc:
+        offset = 0
+        max_dc_count = 0
+        max_ec_count = 0
+        dcdata = Array.new(rs_blocks.size)
+        ecdata = Array.new(rs_blocks.size)
+
+        rs_blocks.each_with_index do |rs_block, r|
+          dc_count = rs_block.data_count
+          ec_count = rs_block.total_count - dc_count
+          max_dc_count = [max_dc_count, dc_count].max
+          max_ec_count = [max_ec_count, ec_count].max
+
+          dcdata_block = Array.new(dc_count)
+          dcdata_block.size.times do |i|
+            dcdata_block[i] = 0xff & buffer.buffer[i + offset]
+          end
+          dcdata[r] = dcdata_block
 
-        offset = offset + dc_count
-        rs_poly = QRUtil.get_error_correct_polynomial( ec_count )
-        raw_poly = QRPolynomial.new( dcdata[r], rs_poly.get_length - 1 )
-        mod_poly = raw_poly.mod( rs_poly )
+          offset += dc_count
+          rs_poly = QRUtil.get_error_correct_polynomial(ec_count)
+          raw_poly = QRPolynomial.new(dcdata[r], rs_poly.get_length - 1)
+          mod_poly = raw_poly.mod(rs_poly)
 
-        ecdata_block = Array.new(rs_poly.get_length - 1)
-        ecdata_block.size.times do |i|
-          mod_index = i + mod_poly.get_length - ecdata_block.size
-          ecdata_block[i] = mod_index >= 0 ? mod_poly.get( mod_index ) : 0
+          ecdata_block = Array.new(rs_poly.get_length - 1)
+          ecdata_block.size.times do |i|
+            mod_index = i + mod_poly.get_length - ecdata_block.size
+            ecdata_block[i] = mod_index >= 0 ? mod_poly.get(mod_index) : 0
+          end
+          ecdata[r] = ecdata_block
         end
-        ecdata[r] = ecdata_block
-      end
 
-      total_code_count = rs_blocks.reduce(0) do |sum, rs_block|
-        sum + rs_block.total_count
-      end
+        total_code_count = rs_blocks.reduce(0) do |sum, rs_block|
+          sum + rs_block.total_count
+        end
 
-      data = Array.new( total_code_count )
-      index = 0
+        data = Array.new(total_code_count)
+        index = 0
 
-      max_dc_count.times do |i|
-        rs_blocks.size.times do |r|
-          if i < dcdata[r].size
-            data[index] = dcdata[r][i]
-            index += 1
+        max_dc_count.times do |i|
+          rs_blocks.size.times do |r|
+            if i < dcdata[r].size
+              data[index] = dcdata[r][i]
+              index += 1
+            end
           end
         end
-      end
 
-      max_ec_count.times do |i|
-        rs_blocks.size.times do |r|
-          if i < ecdata[r].size
-            data[index] = ecdata[r][i]
-            index += 1
+        max_ec_count.times do |i|
+          rs_blocks.size.times do |r|
+            if i < ecdata[r].size
+              data[index] = ecdata[r][i]
+              index += 1
+            end
           end
         end
-      end
 
-      data
+        data
+      end
     end
   end
 end