rprogram 0.1.4 → 0.1.5

data/History.txt

@@ -1,9 +1,21 @@
-== 0.1.4 / 2009-01-07
+=== 0.1.5 / 2009-01-14
+
+* Use Kernel.system in RProgram::Program#run, instead of Open3.popen3:
+  * popen3 is not well supported on Windows.
+  * win32-open3 does not allow for the execution of single programs with
+    separate command-line arguments. Instead, it merely executes a command
+    string in command.com. This seems to allow arbitrary command injection
+    via command-line arguments.
+  * RProgram::Program#run will now return either +true+ or +false+,
+    depending on the exit status of the program.
+* Added some missing documentation.
+
+=== 0.1.4 / 2009-01-07
 
 * Added <tt>lib/rprogram/rprogram.rb</tt> to the Manifest.
 * Added more documentation.
 
-== 0.1.3 / 2008-01-27
+=== 0.1.3 / 2008-01-27
 
 * Renamed <tt>Program.create_from_path</tt> to
   <tt>Program.find_with_path</tt>.
@@ -12,14 +24,14 @@
 * Renamed <tt>Program.create</tt> to <tt>Program.find</tt>.
 * Renamed <tt>Program.run_with_task</tt> to <tt>Program.run_task</tt>.
 
-== 0.1.2 / 2008-01-18
+=== 0.1.2 / 2008-01-18
 
 * DRY'ed up lib/rprogram/task.
   * Added Task.define_option.
 * Added OptionList so that Option may contain sub-options.
 * Touched up documenation.
 
-== 0.1.1 / 2008-01-18
+=== 0.1.1 / 2008-01-18
 
 * Added support for the Option argument separators.
 
@@ -32,7 +44,7 @@
 
 * Fixed lib/rprogram.rb file.
 
-== 0.1.0 / 2008-01-17
+=== 0.1.0 / 2008-01-17
 
 * Removed redundent methods in Program:
   * Program.find_by_name
@@ -41,7 +53,7 @@
 * Made Program Nameable by default.
 * Prevented arbitrary command-injection in Program#run.
 
-== 0.0.9 / 2008-01-09
+=== 0.0.9 / 2008-01-09
 
 * Initial release.
 * Provides cross-platform access to the PATH variable.

data/README.txt

@@ -12,6 +12,8 @@ system.
 
 == FEATURES/PROBLEMS:
 
+* Uses Kernel.system for safe execution of individual programs and their
+  separate command-line arguments.
 * Provides cross-platform access to the PATH variable.
 * Supports leading/tailing non-options.
 * Supports long-options and short-options.

data/lib/rprogram/non_option.rb

@@ -33,6 +33,10 @@ module RProgram
       @multiple = options[:multiple] || false
     end
 
+    #
+    # Returns an +Array+ of the arguments for the non-option with the
+    # specified _value_.
+    #
     def arguments(value)
       return [] if (value==nil || value==false)
 

data/lib/rprogram/options.rb

@@ -37,7 +37,9 @@ module RProgram
 
           ancestors.each do |base|
             if base.include?(Options)
-              return base.non_options[name] if base.non_options.has_key?(name)
+              if base.non_options.has_key?(name)
+                return base.non_options[name]
+              end
             end
           end
 

data/lib/rprogram/program.rb

@@ -90,21 +90,22 @@ module RProgram
 
     #
     # Runs the program with the specified _args_ and returns
-    # an Array of the programs output.
+    # either +true+ or +false+, depending on the exit status of the
+    # program.
     #
     #   echo = Program.find_by_name('echo')
-    #   echo.run("hello") # => ["hello\n"]
+    #   echo.run('hello')
+    #   # hello
+    #   # => true
     #
     def run(*args)
       args = args.map { |arg| arg.to_s }
 
       if RProgram.debug
-        $stderr << ">>> #{@path} #{args.join(' ')}\n"
+        STDERR.puts ">>> #{@path} #{args.join(' ')}"
       end
 
-      Open3.popen3(@path,*args) do |stdin,stdout,stderr|
-        return stdout.readlines
-      end
+      return Kernel.system(@path,*args)
     end
 
     #
@@ -117,9 +118,8 @@ module RProgram
     #
     # Returns the path of the program.
     #
-    #   puts Program.find_by_name('echo')
-    #   /usr/bin/echo
-    #   # => nil
+    #   Program.find_by_name('echo').to_s
+    #   # => "/usr/bin/echo"
     #
     def to_s
       @path.to_s

data/lib/rprogram/version.rb

@@ -1,3 +1,3 @@
 module RProgram
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rprogram
 version: !ruby/object:Gem::Version 
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors: 
 - Postmodern
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-01-07 00:00:00 -08:00
+date: 2009-01-14 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency