royw-tmdb 0.1.6 → 0.1.7

data/Rakefile

@@ -22,6 +22,7 @@ require 'spec/rake/spectask'
 Spec::Rake::SpecTask.new(:spec) do |spec|
   spec.libs << 'lib' << 'spec'
   spec.spec_files = FileList['spec/**/*_spec.rb']
+  spec.spec_opts = ["--color", "--format nested"]
 end
 
 Spec::Rake::SpecTask.new(:rcov) do |spec|

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:patch: 6
-:major: 0
 :minor: 1
+:patch: 7
+:major: 0

data/spec/tmdb_image_spec.rb

@@ -28,96 +28,102 @@ describe "TmdbImage" do
     @image.should_not == nil
   end
 
-  it "should find image via profile" do
-    profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :logger => @logger)
-    profile.image.imdb_id.should == 'tt0465234'
-  end
+  describe "Image finds" do
+    it "should find image via profile" do
+      profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :logger => @logger)
+      profile.image.imdb_id.should == 'tt0465234'
+    end
 
-  it "should find image via movie" do
-    profile = TmdbMovie.new('0465234', TMDB_API_KEY, @logger)
-    profile.image.imdb_id.should == 'tt0465234'
+    it "should find image via movie" do
+      profile = TmdbMovie.new('0465234', TMDB_API_KEY, @logger)
+      profile.image.imdb_id.should == 'tt0465234'
+    end
   end
 
-  it "should find original size fanart" do
-    src_url = nil
-    src_url = @image.fanart_original unless @image.nil?
-    src_url.should_not be_nil
-  end
+  describe "Image contents" do
+    it "should find original size fanart" do
+      src_url = nil
+      src_url = @image.fanart_original unless @image.nil?
+      src_url.should_not be_nil
+    end
 
-  it "should find mid size fanart" do
-    src_url = nil
-    src_url = @image.fanart_mid unless @image.nil?
-    src_url.should_not be_nil
-  end
+    it "should find mid size fanart" do
+      src_url = nil
+      src_url = @image.fanart_mid unless @image.nil?
+      src_url.should_not be_nil
+    end
 
-  it "should find thumb size fanart" do
-    src_url = nil
-    src_url = @image.fanart_thumb unless @image.nil?
-    src_url.should_not be_nil
-  end
+    it "should find thumb size fanart" do
+      src_url = nil
+      src_url = @image.fanart_thumb unless @image.nil?
+      src_url.should_not be_nil
+    end
 
-  it "should find original size poster" do
-    src_url = nil
-    src_url = @image.poster_original unless @image.nil?
-    src_url.should_not be_nil
-  end
+    it "should find original size poster" do
+      src_url = nil
+      src_url = @image.poster_original unless @image.nil?
+      src_url.should_not be_nil
+    end
 
-  it "should find mid size poster" do
-    src_url = nil
-    src_url = @image.poster_mid unless @image.nil?
-    src_url.should_not be_nil
-  end
+    it "should find mid size poster" do
+      src_url = nil
+      src_url = @image.poster_mid unless @image.nil?
+      src_url.should_not be_nil
+    end
 
-  it "should find thumb size poster" do
-    src_url = nil
-    src_url = @image.poster_thumb unless @image.nil?
-    src_url.should_not be_nil
-  end
+    it "should find thumb size poster" do
+      src_url = nil
+      src_url = @image.poster_thumb unless @image.nil?
+      src_url.should_not be_nil
+    end
 
-  it "should find cover size poster" do
-    src_url = nil
-    src_url = @image.poster_cover unless @image.nil?
-    src_url.should_not be_nil
-  end
+    it "should find cover size poster" do
+      src_url = nil
+      src_url = @image.poster_cover unless @image.nil?
+      src_url.should_not be_nil
+    end
 
-  it "should find all fanarts" do
-    buf = []
-    @image.fanart_sizes.each do |size|
-      buf << "fanart(#{size}) returned nil" if @image.fanart(size).nil?
+    it "should find all fanarts" do
+      buf = []
+      @image.fanart_sizes.each do |size|
+        buf << "fanart(#{size}) returned nil" if @image.fanart(size).nil?
+      end
+      puts buf.join("\n") unless buf.empty?
+      buf.empty?.should be_true
     end
-    puts buf.join("\n") unless buf.empty?
-    buf.empty?.should be_true
-  end
 
-  it "should find all posters" do
-    buf = []
-    @image.poster_sizes.each do |size|
-      buf << "poster(#{size}) returned nil" if @image.poster(size).nil?
+    it "should find all posters" do
+      buf = []
+      @image.poster_sizes.each do |size|
+        buf << "poster(#{size}) returned nil" if @image.poster(size).nil?
+      end
+      puts buf.join("\n") unless buf.empty?
+      buf.empty?.should be_true
     end
-    puts buf.join("\n") unless buf.empty?
-    buf.empty?.should be_true
-  end
 
-  # the same routine is used by all the getters to fetch the image so only
-  # need to test one case
-  it "should fetch fanart" do
-    filespec = get_temp_filename
-    src_url = @image.fanart_original(filespec)
-    filespec += File.extname(src_url)
-    (File.exist?(filespec).should be_true) && (File.size(filespec).should > 0)
+    # the same routine is used by all the getters to fetch the image so only
+    # need to test one case
+    it "should fetch fanart" do
+      filespec = get_temp_filename
+      src_url = @image.fanart_original(filespec)
+      filespec += File.extname(src_url)
+      (File.exist?(filespec).should be_true) && (File.size(filespec).should > 0)
+    end
   end
 
-  # these are a couple of white box tests to show a bug where
-  # src_url was nil but copy_image was trying to copy from it anyway.
+  describe "bug tests" do
+    # these are a couple of white box tests to show a bug where
+    # src_url was nil but copy_image was trying to copy from it anyway.
 
-  it "should not attempt to copy if src_url is blank" do
-    dest_filespec = get_temp_filename
-    @image.send('copy_image', nil, dest_filespec).should be_nil
-  end
+    it "should not attempt to copy if src_url is blank" do
+      dest_filespec = get_temp_filename
+      @image.send('copy_image', nil, dest_filespec).should be_nil
+    end
 
-  it "should not attempt to copy if dest_filespec is blank" do
-    src_url = @image.send('image_url', 'tt0465234', 'fanarts', 'original')
-    @image.send('copy_image', src_url, nil).should be_nil
+    it "should not attempt to copy if dest_filespec is blank" do
+      src_url = @image.send('image_url', 'tt0465234', 'fanarts', 'original')
+      @image.send('copy_image', src_url, nil).should be_nil
+    end
   end
 
   def get_temp_filename

data/spec/tmdb_movie_spec.rb

@@ -20,58 +20,63 @@ describe "TmdbMovie" do
     Dir.glob(File.join(TMPDIR,'tmdb_movie_spec*')).each { |filename| File.delete(filename) }
   end
 
-  it "should find by imdb_id" do
-    @profile.should_not == nil
+  describe "Find movie" do
+    it "should find by imdb_id" do
+      @profile.should_not == nil
+    end
   end
 
-  it "should find tmdb id" do
-    @profile.idents.first.should == '6637'
-  end
+  describe "Movie contents" do
+    it "should find tmdb id" do
+      @profile.idents.first.should == '6637'
+    end
 
-  it "should find fanarts" do
-    @profile.fanarts.size.should == 3
-  end
+    it "should find fanarts" do
+      @profile.fanarts.size.should == 3
+    end
 
-  it "should find posters" do
-    @profile.posters.size.should == 4
-  end
+    it "should find posters" do
+      @profile.posters.size.should == 4
+    end
 
-  it "should find the tmdb url" do
-    @profile.urls.first.should == 'http://www.themoviedb.org/movie/6637'
-  end
+    it "should find the tmdb url" do
+      @profile.urls.first.should == 'http://www.themoviedb.org/movie/6637'
+    end
 
-  it "should find the imdb_id" do
-    @profile.imdb_ids.first.should == 'tt0465234'
-  end
+    it "should find the imdb_id" do
+      @profile.imdb_ids.first.should == 'tt0465234'
+    end
 
-  it "should find the title" do
-    @profile.titles.first.should == 'National Treasure: Book of Secrets'
-  end
+    it "should find the title" do
+      @profile.titles.first.should == 'National Treasure: Book of Secrets'
+    end
 
-  it "should find the short_overview" do
-    @profile.short_overviews.first.should =~ /Benjamin Franklin Gates/
-  end
+    it "should find the short_overview" do
+      @profile.short_overviews.first.should =~ /Benjamin Franklin Gates/
+    end
 
-  it "should find the type" do
-    @profile.types.first.should == 'movie'
-  end
+    it "should find the type" do
+      @profile.types.first.should == 'movie'
+    end
 
-  it "should find the alternative_titles" do
-    @profile.alternative_titles.first.should == 'National Treasure 2'
-  end
+    it "should find the alternative_titles" do
+      @profile.alternative_titles.first.should == 'National Treasure 2'
+    end
 
-  it "should find the release" do
-    @profile.releases.first.should == '2007-12-13'
-  end
+    it "should find the release" do
+      @profile.releases.first.should == '2007-12-13'
+    end
 
-  it "should find the  score" do
-    @profile.scores.first.should == '1.0'
+    it "should find the  score" do
+      @profile.scores.first.should == '1.0'
+    end
   end
 
-  it "should handle The Sand Pebble" do
-    profile = TmdbMovie.new('tt0060934', TMDB_API_KEY, @logger)
-    profile.idents.should be_nil
+  describe "bug tests" do
+    it "should handle The Sand Pebble" do
+      profile = TmdbMovie.new('tt0060934', TMDB_API_KEY, @logger)
+      profile.idents.should be_nil
+    end
   end
-
 end
 

data/spec/tmdb_profile_spec.rb

@@ -21,115 +21,110 @@ describe "TmdbProfile" do
     Dir.glob(File.join(TMPDIR,'tmdb_profile_spec*')).each { |filename| File.delete(filename) }
   end
 
-  it "should find by imdb_id" do
-    @profile.should_not == nil
+  describe "Finder" do
+    it "should find by imdb_id" do
+      @profile.should_not == nil
+    end
   end
 
-  it "should save the profile to a file" do
-    filespec = get_temp_filename
-    profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :filespec => filespec)
-    (File.exist?(filespec).should be_true) && (File.size(filespec).should > 0)
-  end
+  describe "Contents" do
+    it "should find tmdb id" do
+      @profile.movie['idents'].first.should == '6637'
+    end
 
-  it "should be able to convert to xml" do
-    xml = @profile.to_xml
-    (xml.should_not be_nil) && (xml.length.should > 0)
-  end
+    it "should find fanarts" do
+      @profile.movie['fanarts'].size.should == 3
+    end
 
-  it "should be able to convert to xml and then from xml" do
-    hash = nil
-    begin
-      xml = @profile.to_xml
-      hash = XmlSimple.xml_in(xml)
-    rescue
-      hash = nil
+    it "should find posters" do
+      @profile.movie['posters'].size.should == 4
     end
-    hash.should_not be_nil
-  end
 
-  it "should find tmdb id" do
-    @profile.movie['idents'].first.should == '6637'
-  end
+    it "should find the tmdb url" do
+      @profile.movie['urls'].first.should == 'http://www.themoviedb.org/movie/6637'
+    end
 
-  it "should find fanarts" do
-    @profile.movie['fanarts'].size.should == 3
-  end
+    it "should find the imdb_id" do
+      @profile.movie['imdb_ids'].first.should == 'tt0465234'
+    end
 
-  it "should find posters" do
-    @profile.movie['posters'].size.should == 4
-  end
+    it "should find the title" do
+      @profile.movie['titles'].first.should == 'National Treasure: Book of Secrets'
+    end
 
-  it "should find the tmdb url" do
-    @profile.movie['urls'].first.should == 'http://www.themoviedb.org/movie/6637'
-  end
+    it "should find the short_overview" do
+      @profile.movie['short_overviews'].first.should =~ /Benjamin Franklin Gates/
+    end
 
-  it "should find the imdb_id" do
-    @profile.movie['imdb_ids'].first.should == 'tt0465234'
-  end
+    it "should find the type" do
+      @profile.movie['types'].first.should == 'movie'
+    end
 
-  it "should find the title" do
-    @profile.movie['titles'].first.should == 'National Treasure: Book of Secrets'
-  end
+    it "should find the alternative_titles" do
+      @profile.movie['alternative_titles'].first.should == 'National Treasure 2'
+    end
 
-  it "should find the short_overview" do
-    @profile.movie['short_overviews'].first.should =~ /Benjamin Franklin Gates/
-  end
+    it "should find the release" do
+      @profile.movie['releases'].first.should == '2007-12-13'
+    end
 
-  it "should find the type" do
-    @profile.movie['types'].first.should == 'movie'
+    it "should find the  score" do
+      @profile.movie['scores'].first.should == '1.0'
+    end
   end
 
-  it "should find the alternative_titles" do
-    @profile.movie['alternative_titles'].first.should == 'National Treasure 2'
-  end
+  describe "XML" do
+    it "should be able to convert to xml" do
+      xml = @profile.to_xml
+      (xml.should_not be_nil) && (xml.length.should > 0)
+    end
 
-  it "should find the release" do
-    @profile.movie['releases'].first.should == '2007-12-13'
+    it "should be able to convert to xml and then from xml" do
+      hash = nil
+      begin
+        xml = @profile.to_xml
+        hash = XmlSimple.xml_in(xml)
+      rescue
+        hash = nil
+      end
+      hash.should_not be_nil
+    end
   end
 
-  it "should find the  score" do
-    @profile.movie['scores'].first.should == '1.0'
-  end
+  describe "File" do
+    it "should save the profile to a file" do
+      filespec = get_temp_filename
+      profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :filespec => filespec)
+      (File.exist?(filespec).should be_true) && (File.size(filespec).should > 0)
+    end
 
-    # let's make sure the generated xml from to_xml() is valid
+    # now let's test caching the profile to/from a file
 
-  it "should be able to convert to xml and then from xml" do
-    hash = nil
-    begin
-      profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY)
-      xml = profile.to_xml
-      hash = XmlSimple.xml_in(xml)
-    rescue
-      hash = nil
+    it "should not create a file if a :filespec option is passed that is nil" do
+      profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :filespec => nil)
+      Dir.glob(File.join(TMPDIR, "imdb_profile_spec*")).empty?.should be_true
     end
-    hash.should_not be_nil
-  end
-
-  # now let's test caching the profile to/from a file
 
-  it "should not create a file if a :filespec option is passed that is nil" do
-    profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :filespec => nil)
-    Dir.glob(File.join(TMPDIR, "imdb_profile_spec*")).empty?.should be_true
-  end
+    it "should create a file if a :filespec option is passed" do
+      filespec = get_temp_filename
+      profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :filespec => filespec)
+      (File.exist?(filespec) && (File.size(filespec) > 0)).should be_true
+    end
 
-  it "should create a file if a :filespec option is passed" do
-    filespec = get_temp_filename
-    profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :filespec => filespec)
-    (File.exist?(filespec) && (File.size(filespec) > 0)).should be_true
-  end
+    it "should load from a file if a :filespec option is passed and the file exists" do
+      filespec = get_temp_filename
+      profile1 = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :filespec => filespec)
+      profile2 = TmdbProfile.first(:api_key => TMDB_API_KEY, :filespec => filespec)
+      profile1.imdb_id.should == profile2.imdb_id
+    end
 
-  it "should load from a file if a :filespec option is passed and the file exists" do
-    filespec = get_temp_filename
-    profile1 = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :filespec => filespec)
-    profile2 = TmdbProfile.first(:api_key => TMDB_API_KEY, :filespec => filespec)
-    profile1.imdb_id.should == profile2.imdb_id
+    it "should not load from a file if a :filespec option is passed and the file does not exists" do
+      filespec = get_temp_filename
+      profile = TmdbProfile.first(:api_key => TMDB_API_KEY, :filespec => filespec)
+      profile.should be_nil
+    end
   end
 
-  it "should not load from a file if a :filespec option is passed and the file does not exists" do
-    filespec = get_temp_filename
-    profile = TmdbProfile.first(:api_key => TMDB_API_KEY, :filespec => filespec)
-    profile.should be_nil
-  end
 
   def get_temp_filename
     outfile = Tempfile.new('tmdb_profile_spec', TMPDIR)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: royw-tmdb
 version: !ruby/object:Gem::Version 
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors: 
 - Roy Wright
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-21 00:00:00 -07:00
+date: 2009-04-24 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency