royw-tmdb 0.1.1 → 0.1.2

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:patch: 1
+:patch: 2
 :major: 0
 :minor: 1

data/lib/tmdb/tmdb_image.rb

@@ -4,8 +4,8 @@ class TmdbImage
   # imdb_id => String IMDB ID either with or without the 'tt' prefix
   # api_key => String containing the themovieDb.com API key
   # logger => nil or logger instance
-  def initialize(imdb_id, api_key, logger)
-    @imdb_id = imdb_id
+  def initialize(ident, api_key, logger)
+    @imdb_id = 'tt' + ident.gsub(/^tt/, '') unless ident.blank?
     @api_key = api_key
     @logger = OptionalLogger.new(logger)
   end

data/lib/tmdb/tmdb_movie.rb

@@ -10,7 +10,7 @@ class TmdbMovie
   end
 
   def image
-    TmdbImage.new(@imdb_id, @api_key, @logger)
+    TmdbImage.new(@imdb_id.gsub(/^tt/, ''), @api_key, @logger) rescue nil
   end
 
   def fanarts

data/lib/tmdb/tmdb_profile.rb

@@ -37,7 +37,7 @@ class TmdbProfile
   end
 
   def initialize(ident, key, filespec, logger)
-    @imdb_id = ident
+    @imdb_id = 'tt' + ident.gsub(/^tt/, '') unless ident.blank?
     @api_key = key
     @filespec = filespec
     @logger = OptionalLogger.new(logger)
@@ -62,7 +62,7 @@ class TmdbProfile
 
   # return the TmdbImage for this profile
   def image
-    TmdbImage.new(@imdb_id.gsub(/^tt/, ''), @api_key, @logger)
+    TmdbImage.new(@imdb_id.gsub(/^tt/, ''), @api_key, @logger) rescue nil
   end
 
   protected

data/spec/cache_extensions.rb

@@ -3,7 +3,7 @@
 # override the classes' read_page method and replace with one
 # that will cache pages in spec/samples/{url}
 
-class ImdbMovie
+class TmdbMovie
   private
   def read_page(page)
     html = nil
@@ -32,7 +32,7 @@ class ImdbMovie
   end
 end
 
-class ImdbSearch
+class TmdbSearch
   private
   def read_page(page)
     html = nil
@@ -61,11 +61,11 @@ class ImdbSearch
   end
 end
 
-class ImdbImage
+class TmdbImage
   private
   def read_page(page)
     html = nil
-    filespec = page.gsub(/^http:\//, 'spec/samples').gsub(/\/$/, '.html')
+    filespec = page.gsub(/^http:\//, 'spec/samples')
     if File.exist?(filespec)
       html = open(filespec).read
     else
@@ -78,7 +78,7 @@ class ImdbImage
   # this is used to save imdb pages so they may be used by rspec
   def cache_html_files(page, html)
     begin
-      filespec = page.gsub(/^http:\//, 'spec/samples').gsub(/\/$/, '.html')
+      filespec = page.gsub(/^http:\//, 'spec/samples')
       unless File.exist?(filespec)
         puts "caching #{filespec}"
         File.mkdirs(File.dirname(filespec))

data/spec/samples/api.themoviedb.org/2.0/Movie.imdbLookup?imdb_id=tt0060934&api_key=7a2f6eb9b6aa01651000f0a9324db835

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<results for="tt0060934" xmlns:opensearch="http://a9.com/-/spec/opensearch/1.1/">
+<opensearch:Query searchTerms="tt0060934"/>
+<opensearch:totalResults>0</opensearch:totalResults>
+<moviematches>
+<movie>Your query didn't return any results.</movie>
+</moviematches>
+</results>

data/spec/samples/api.themoviedb.org/2.0/Movie.imdbLookup?imdb_id=tt0465234&api_key=7a2f6eb9b6aa01651000f0a9324db835

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8"?>
+<results for="tt0465234" xmlns:opensearch="http://a9.com/-/spec/opensearch/1.1/">
+<opensearch:Query searchTerms="tt0465234"/>
+<opensearch:totalResults>1</opensearch:totalResults>
+<moviematches>
+<movie>
+<score>1.0</score>
+<popularity>4</popularity>
+<title>National Treasure: Book of Secrets</title>
+<alternative_title>National Treasure 2</alternative_title>
+<type>movie</type>
+<id>6637</id>
+<imdb>tt0465234</imdb>
+<url>http://www.themoviedb.org/movie/6637</url>
+<short_overview>Treasure hunter Benjamin Franklin Gates looks to discover the truth behind the assassination of Abraham Lincoln, by uncovering the mystery within the 18 pages missing from assassin John Wilkes Booth&apos;s diary.</short_overview>
+<release>2007-12-13</release>
+<poster size="original">http://www.themoviedb.org/image/posters/6577/National_Treasure_Book_Of_Secrets_-_Poster_1__2007_.jpg</poster>
+<poster size="mid">http://www.themoviedb.org/image/posters/6577/National_Treasure_Book_Of_Secrets_-_Poster_1__2007__mid.jpg</poster>
+<poster size="cover">http://www.themoviedb.org/image/posters/6577/National_Treasure_Book_Of_Secrets_-_Poster_1__2007__cover.jpg</poster>
+<poster size="thumb">http://www.themoviedb.org/image/posters/6577/National_Treasure_Book_Of_Secrets_-_Poster_1__2007__thumb.jpg</poster>
+<backdrop size="original">http://www.themoviedb.org/image/backdrops/14621/National_Treasure_-_Book_Of_Secrets__XVID___2007_-fanart.jpg</backdrop>
+<backdrop size="mid">http://www.themoviedb.org/image/backdrops/14621/National_Treasure_-_Book_Of_Secrets__XVID___2007_-fanart_poster.jpg</backdrop>
+<backdrop size="thumb">http://www.themoviedb.org/image/backdrops/14621/National_Treasure_-_Book_Of_Secrets__XVID___2007_-fanart_thumb.jpg</backdrop>
+</movie>
+</moviematches>
+</results>

data/spec/tmdb_image_spec.rb

@@ -30,11 +30,11 @@ describe "TmdbImage" do
 
   it "should find image via profile" do
     profile = TmdbProfile.first(:imdb_id => 'tt0465234', :api_key => TMDB_API_KEY, :logger => @logger)
-    profile.image.imdb_id.should == '0465234'
+    profile.image.imdb_id.should == 'tt0465234'
   end
 
   it "should find image via movie" do
-    profile = TmdbMovie.new('tt0465234', TMDB_API_KEY, @logger)
+    profile = TmdbMovie.new('0465234', TMDB_API_KEY, @logger)
     profile.image.imdb_id.should == 'tt0465234'
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: royw-tmdb
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Roy Wright
@@ -37,6 +37,9 @@ files:
 - lib/tmdb/tmdb_movie.rb
 - lib/tmdb/tmdb_profile.rb
 - spec/cache_extensions.rb
+- spec/samples/api.themoviedb.org/2.0/Movie.imdbLookup?imdb_id=tt0060934&api_key=7a2f6eb9b6aa01651000f0a9324db835
+- spec/samples/api.themoviedb.org/2.0/Movie.imdbLookup?imdb_id=tt0465234&api_key=7a2f6eb9b6aa01651000f0a9324db835
+- spec/samples/www.themoviedb.org/image/backdrops/14621/National_Treasure_-_Book_Of_Secrets__XVID___2007_-fanart.jpg
 - spec/spec_helper.rb
 - spec/tmdb_image_spec.rb
 - spec/tmdb_movie_spec.rb