royw-imdb 0.1.5 → 0.1.6

data/Rakefile

@@ -8,6 +8,7 @@ task :default => :spec
 Spec::Rake::SpecTask.new(:spec) do |spec|
   spec.libs << 'lib' << 'spec'
   spec.spec_files = FileList['spec/**/*_spec.rb']
+  spec.spec_opts = ["--color", "--format nested"]
 end
 
 Spec::Rake::SpecTask.new('spec:html') do |spec|

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 1
-:patch: 5
+:patch: 6
 :major: 0

data/spec/imdb_movie_spec.rb

@@ -10,7 +10,6 @@ describe ImdbMovie do
     end
 
     it "should query IMDB url" do
-#       @imdb_movie.should_receive(:open).with("http://www.imdb.com/title/tt0050562/").and_return(open("#{$samples_dir}/sample_jet_pilot.html"))
       @imdb_movie.should_receive(:fetch).with("http://www.imdb.com/title/tt0050562/").and_return(open("#{$samples_dir}/www.imdb.com/title/tt0050562.html"))
       @imdb_movie.send(:document)
     end
@@ -31,14 +30,8 @@ describe ImdbMovie do
 
     before(:each) do
       @imdb_movie = ImdbMovie.new('0097576')
-#       @imdb_movie.stub!(:open).and_return(open("#{$samples_dir}/sample_movie.html"))
     end
 
-#     it "should query IMDB url" do
-#       @imdb_movie.should_receive(:open).with("http://www.imdb.com/title/tt0097576/").and_return(open("#{$samples_dir}/www.imdb.com/title/tt0097576.html"))
-#       @imdb_movie.send(:document)
-#     end
-
     it "should get the title" do
       @imdb_movie.title.should == "Indiana Jones and the Last Crusade"
     end
@@ -157,15 +150,8 @@ describe ImdbMovie do
 
     before(:each) do
       @imdb_movie = ImdbMovie.new('0054961')
-#       @imdb_movie.stub!(:open).and_return(open("#{$samples_dir}/sample_incomplete_movie.html"))
     end
 
-#     it "should query IMDB url" do
-#       @imdb_movie.should_receive(:open).with("http://www.imdb.com/title/tt0054961/").and_return(open("#{$samples_dir}/sample_incomplete_movie.html"))
-#       @imdb_movie.should_receive(:open).with("http://www.imdb.com/title/tt0054961/").and_return(open("#{$samples_dir}/www.imdb.com/title/tt0054961.html"))
-#       @imdb_movie.send(:document)
-#     end
-
     it "should get the title" do
       @imdb_movie.title.should == "Han robado una estrella"
     end

data/spec/imdb_profile_spec.rb

@@ -17,205 +17,211 @@ describe "ImdbProfile" do
     Dir.glob(File.join(TMPDIR, "imdb_profile_spec*")).each { |filename| File.delete(filename) }
   end
 
-  it "should find by imdb_id that is prefixed with a 'tt'" do
-    profile = ImdbProfile.first(:imdb_id => 'tt0465234')
-    profile.should_not == nil
-  end
+  describe "Simple finds using ImdbProfile.first" do
+    it "should find by imdb_id that is prefixed with a 'tt'" do
+      profile = ImdbProfile.first(:imdb_id => 'tt0465234')
+      profile.should_not == nil
+    end
 
-  it "should find by imdb_id that is not prefixed with 'tt'" do
-    profile = ImdbProfile.first(:imdb_id => '0465234')
-    profile.should_not == nil
-  end
+    it "should find by imdb_id that is not prefixed with 'tt'" do
+      profile = ImdbProfile.first(:imdb_id => '0465234')
+      profile.should_not == nil
+    end
 
-  it "should find by single title" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'])
-    profile.should_not == nil
-  end
+    it "should find by single title" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'])
+      profile.should_not == nil
+    end
 
-  it "should find by multiple title" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets', 'National Treasure 2'])
-    profile.should_not == nil
-  end
+    it "should find by multiple title" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets', 'National Treasure 2'])
+      profile.should_not == nil
+    end
 
-  it "should find by multiple title embedded in arrays" do
-    profile = ImdbProfile.first(:titles => [['National Treasure: Book of Secrets'], 'National Treasure 2'])
-    profile.should_not == nil
-  end
+    it "should find by multiple title embedded in arrays" do
+      profile = ImdbProfile.first(:titles => [['National Treasure: Book of Secrets'], 'National Treasure 2'])
+      profile.should_not == nil
+    end
 
-  it "should find by AKA title" do
-    profile = ImdbProfile.first(:titles => ['National Treasure 2'])
-    profile.should_not == nil
+    it "should find by AKA title" do
+      profile = ImdbProfile.first(:titles => ['National Treasure 2'])
+      profile.should_not == nil
+    end
   end
 
-  # We use two versions of "The Alamo" to test for year discrimination
-  #  John Wayne's The Alamo produced and released in 1960, IMDB ID => tt0053580
-  #  John Lee Hancock's The Alamo produced and released in 2004, IMDB ID => tt0318974
+  describe "multiple finds using ImdbProfile.all" do
+    # We use two versions of "The Alamo" to test for year discrimination
+    #  John Wayne's The Alamo produced and released in 1960, IMDB ID => tt0053580
+    #  John Lee Hancock's The Alamo produced and released in 2004, IMDB ID => tt0318974
 
-  # test all()
-  it "should find multiple versions of The Alamo" do
-    profiles = ImdbProfile.all(:titles => ['The Alamo'])
-    profiles.length.should > 1
-  end
+    # test all()
+    it "should find multiple versions of The Alamo" do
+      profiles = ImdbProfile.all(:titles => ['The Alamo'])
+      profiles.length.should > 1
+    end
 
-  it "should find the two versions of The Alamo that we are interested in" do
-    profiles = ImdbProfile.all(:titles => ['The Alamo'])
-    imdb_ids = profiles.collect{|profile| profile.imdb_id}
-    imdb_ids = imdb_ids.select{|ident| ident == 'tt0053580' || ident == 'tt0318974'}
-    imdb_ids.uniq.compact.length.should == 2
+    it "should find the two versions of The Alamo that we are interested in" do
+      profiles = ImdbProfile.all(:titles => ['The Alamo'])
+      imdb_ids = profiles.collect{|profile| profile.imdb_id}
+      imdb_ids = imdb_ids.select{|ident| ident == 'tt0053580' || ident == 'tt0318974'}
+      imdb_ids.uniq.compact.length.should == 2
+    end
   end
 
-  # find first using title and media year
-
-  it "should find John Wayne's The Alamo by title with media year" do
-    profile = ImdbProfile.first(:titles => ['The Alamo'], :media_years => [1960])
-    profile.imdb_id.should == 'tt0053580'
-  end
+  describe "find first using title and media year" do
+    it "should find John Wayne's The Alamo by title with media year" do
+      profile = ImdbProfile.first(:titles => ['The Alamo'], :media_years => [1960])
+      profile.imdb_id.should == 'tt0053580'
+    end
 
-  it "should find John Lee Hancock's The Alamo by title with media year" do
-    profile = ImdbProfile.first(:titles => ['The Alamo'], :media_years => [2004])
-    profile.imdb_id.should == 'tt0318974'
+    it "should find John Lee Hancock's The Alamo by title with media year" do
+      profile = ImdbProfile.first(:titles => ['The Alamo'], :media_years => [2004])
+      profile.imdb_id.should == 'tt0318974'
+    end
   end
 
-  # find first using title and production year
-
-  it "should find John Wayne's The Alamo by title with production year" do
-    profile = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1960])
-    profile.imdb_id.should == 'tt0053580'
-  end
+  describe "find first using title and production year" do
+    it "should find John Wayne's The Alamo by title with production year" do
+      profile = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1960])
+      profile.imdb_id.should == 'tt0053580'
+    end
 
-  it "should find John Lee Hancock's The Alamo by title with production year" do
-    profile = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [2004])
-    profile.imdb_id.should == 'tt0318974'
+    it "should find John Lee Hancock's The Alamo by title with production year" do
+      profile = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [2004])
+      profile.imdb_id.should == 'tt0318974'
+    end
   end
 
-  # find first using title and released year
-
-  it "should find John Wayne's The Alamo by title with released year" do
-    profile = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1960])
-    profile.imdb_id.should == 'tt0053580'
-  end
+  describe "find first using title and released year" do
+    it "should find John Wayne's The Alamo by title with released year" do
+      profile = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1960])
+      profile.imdb_id.should == 'tt0053580'
+    end
 
-  it "should find John Lee Hancock's The Alamo by title with released year" do
-    profile = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [2004])
-    profile.imdb_id.should == 'tt0318974'
+    it "should find John Lee Hancock's The Alamo by title with released year" do
+      profile = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [2004])
+      profile.imdb_id.should == 'tt0318974'
+    end
   end
 
-  # here we test fuzzy year matching (plus or minus a year)
-  # fuzzy years are only supported for production and released years, not media years
-
-  it "should not find John Wayne's The Alamo by title with the media year off by a year" do
-    profile1 = ImdbProfile.first(:titles => ['The Alamo'], :media_years => [1959])
-    profile2 = ImdbProfile.first(:titles => ['The Alamo'], :media_years => [1961])
-    (profile1.should be_nil) && (profile2.should be_nil)
-  end
+  describe "fuzzy year matching (plus or minus a year)" do
+    # fuzzy years are only supported for production and released years, not media years
+    it "should not find John Wayne's The Alamo by title with the media year off by a year" do
+      profile1 = ImdbProfile.first(:titles => ['The Alamo'], :media_years => [1959])
+      profile2 = ImdbProfile.first(:titles => ['The Alamo'], :media_years => [1961])
+      (profile1.should be_nil) && (profile2.should be_nil)
+    end
 
-  it "should find John Wayne's The Alamo by title with the production year off by a year" do
-    profile1 = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1959])
-    profile2 = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1961])
-    (profile1.imdb_id.should == 'tt0053580') && (profile2.imdb_id.should == 'tt0053580')
-  end
+    it "should find John Wayne's The Alamo by title with the production year off by a year" do
+      profile1 = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1959])
+      profile2 = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1961])
+      (profile1.imdb_id.should == 'tt0053580') && (profile2.imdb_id.should == 'tt0053580')
+    end
 
-  it "should find John Wayne's The Alamo by title with the released year off by a year" do
-    profile1 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1959])
-    profile2 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1961])
-    (profile1.imdb_id.should == 'tt0053580') && (profile2.imdb_id.should == 'tt0053580')
-  end
+    it "should find John Wayne's The Alamo by title with the released year off by a year" do
+      profile1 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1959])
+      profile2 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1961])
+      (profile1.imdb_id.should == 'tt0053580') && (profile2.imdb_id.should == 'tt0053580')
+    end
 
-  it "should not find John Wayne's The Alamo by title with the production year off by two years" do
-    profile1 = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1958])
-    profile2 = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1962])
-    (profile1.should be_nil) && (profile2.should be_nil)
-  end
+    it "should not find John Wayne's The Alamo by title with the production year off by two years" do
+      profile1 = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1958])
+      profile2 = ImdbProfile.first(:titles => ['The Alamo'], :production_years => [1962])
+      (profile1.should be_nil) && (profile2.should be_nil)
+    end
 
-  it "should not find John Wayne's The Alamo by title with the released year off by two years" do
-    profile1 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1958])
-    profile2 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1962])
-    (profile1.should be_nil) && (profile2.should be_nil)
+    it "should not find John Wayne's The Alamo by title with the released year off by two years" do
+      profile1 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1958])
+      profile2 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1962])
+      (profile1.should be_nil) && (profile2.should be_nil)
+    end
   end
 
-  # let's make sure the generated xml from to_xml() is valid
-
-  it "should be able to convert to xml and then from xml" do
-    hash = nil
-    begin
-      profile = ImdbProfile.first(:imdb_id => 'tt0465234')
-      xml = profile.to_xml
-      hash = XmlSimple.xml_in(xml)
-    rescue
+  describe "let's make sure the generated xml from to_xml() is valid" do
+    it "should be able to convert to xml and then from xml" do
       hash = nil
+      begin
+        profile = ImdbProfile.first(:imdb_id => 'tt0465234')
+        xml = profile.to_xml
+        hash = XmlSimple.xml_in(xml)
+      rescue
+        hash = nil
+      end
+      hash.should_not be_nil
     end
-    hash.should_not be_nil
   end
 
-  # now let's test caching the profile to/from a file
-
-  it "should not create a file if a :filespec option is passed that is nil" do
-    profile = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1960], :filespec => nil)
-    Dir.glob(File.join(TMPDIR, "imdb_profile_spec*")).empty?.should be_true
-  end
+  describe "test caching the profile to/from a file" do
+    it "should not create a file if a :filespec option is passed that is nil" do
+      profile = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1960], :filespec => nil)
+      Dir.glob(File.join(TMPDIR, "imdb_profile_spec*")).empty?.should be_true
+    end
 
-  it "should create a file if a :filespec option is passed" do
-    filespec = get_temp_filename
-    profile = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1960], :filespec => filespec)
-    (File.exist?(filespec) && (File.size(filespec) > 0)).should be_true
-  end
+    it "should create a file if a :filespec option is passed" do
+      filespec = get_temp_filename
+      profile = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1960], :filespec => filespec)
+      (File.exist?(filespec) && (File.size(filespec) > 0)).should be_true
+    end
 
-  it "should load from a file if a :filespec option is passed and the file exists" do
-    filespec = get_temp_filename
-    profile1 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1960], :filespec => filespec)
-    profile2 = ImdbProfile.first(:filespec => filespec)
-    profile1.imdb_id.should == profile2.imdb_id
-  end
+    it "should load from a file if a :filespec option is passed and the file exists" do
+      filespec = get_temp_filename
+      profile1 = ImdbProfile.first(:titles => ['The Alamo'], :released_years => [1960], :filespec => filespec)
+      profile2 = ImdbProfile.first(:filespec => filespec)
+      profile1.imdb_id.should == profile2.imdb_id
+    end
 
-  it "should not load from a file if a :filespec option is passed and the file does not exists" do
-    filespec = get_temp_filename
-    profile = ImdbProfile.first(:filespec => filespec)
-    profile.should be_nil
+    it "should not load from a file if a :filespec option is passed and the file does not exists" do
+      filespec = get_temp_filename
+      profile = ImdbProfile.first(:filespec => filespec)
+      profile.should be_nil
+    end
   end
 
-  it "should handle media year == nil" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => [nil])
-    profile.should_not == nil
-  end
+  describe "When years are invalid (nil, 0, or '0')" do
+    it "should handle media year == nil" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => [nil])
+      profile.should_not == nil
+    end
 
-  it "should handle media year == 0" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => [0])
-    profile.should_not == nil
-  end
+    it "should handle media year == 0" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => [0])
+      profile.should_not == nil
+    end
 
-  it "should handle media year == '0'" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => ['0'])
-    profile.should_not == nil
-  end
+    it "should handle media year == '0'" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => ['0'])
+      profile.should_not == nil
+    end
 
-  it "should handle production year == nil" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => [nil])
-    profile.should_not == nil
-  end
+    it "should handle production year == nil" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => [nil])
+      profile.should_not == nil
+    end
 
-  it "should handle media production == 0" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => [0])
-    profile.should_not == nil
-  end
+    it "should handle media production == 0" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => [0])
+      profile.should_not == nil
+    end
 
-  it "should handle production year == '0'" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => ['0'])
-    profile.should_not == nil
-  end
+    it "should handle production year == '0'" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => ['0'])
+      profile.should_not == nil
+    end
 
-  it "should handle released year == nil" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => [nil])
-    profile.should_not == nil
-  end
+    it "should handle released year == nil" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => [nil])
+      profile.should_not == nil
+    end
 
-  it "should handle released year == 0" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => [0])
-    profile.should_not == nil
-  end
+    it "should handle released year == 0" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => [0])
+      profile.should_not == nil
+    end
 
-  it "should handle released year == '0'" do
-    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => ['0'])
-    profile.should_not == nil
+    it "should handle released year == '0'" do
+      profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => ['0'])
+      profile.should_not == nil
+    end
   end
 
   def get_temp_filename

data/spec/imdb_search_spec.rb

@@ -6,15 +6,8 @@ describe ImdbSearch do
 
     before(:each) do
       @imdb_search = ImdbSearch.new('indiana jones')
-#       @imdb_search.stub!(:open).and_return(open("#{$samples_dir}/sample_search.html"))
-#       ImdbMovie.stub!(:use_html_cache).and_return(true)
     end
 
-#     it "should query IMDB url" do
-#       @imdb_search.should_receive(:open).with("http://www.imdb.com/find?q=indiana+jones;s=tt").and_return(open("#{$samples_dir}/sample_search.html"))
-#       @imdb_search.send(:document)
-#     end
-
     describe "movies" do
 
       it "should be a collection of ImdbMovie instances" do
@@ -71,24 +64,6 @@ describe ImdbSearch do
 
   end
 
-  describe 'searches with potential encoding issues' do
-
-    before(:each) do
-      @imdb_search = ImdbSearch.new('torrente')
-      @imdb_search.stub!(:open).and_return(open("#{$samples_dir}/sample_spanish_search.html"))
-      ImdbMovie.stub!(:use_html_cache).and_return(true)
-    end
-
-    describe "movies" do
-
-      # it "should include 'Misión en Marbella'" do
-      #   @imdb_search.movies.map { |m| m.title }.should include('Misión en Marbella')
-      # end
-
-    end
-
-  end
-
   describe 'searches that match on AKA title' do
 
     before(:each) do
@@ -115,23 +90,24 @@ describe ImdbSearch do
 
   end
 
-  # this is the failure test for AKA matching
-  describe 'searches that match on AKA title but without search_aka enabled' do
-    before(:each) do
-      @imdb_search = ImdbSearch.new('Who Am I?', false)
-      @imdb_search.stub!(:open).and_return(open("#{$samples_dir}/sample_who_am_i_search.html"))
-      ImdbMovie.stub!(:use_html_cache).and_return(true)
-    end
+  describe "failure test for AKA matching" do
+    describe 'searches that match on AKA title but without search_aka enabled' do
+      before(:each) do
+        @imdb_search = ImdbSearch.new('Who Am I?', false)
+        @imdb_search.stub!(:open).and_return(open("#{$samples_dir}/sample_who_am_i_search.html"))
+        ImdbMovie.stub!(:use_html_cache).and_return(true)
+      end
 
-    describe "movies" do
+      describe "movies" do
 
-      it "should have multiple movies" do
-        @imdb_search.movies.size.should > 1
-      end
+        it "should have multiple movies" do
+          @imdb_search.movies.size.should > 1
+        end
 
-      it "should have no movies from 1998 because title is an aka" do
-        films = @imdb_search.movies.select{|m| m.year.to_i == 1998}
-        films.length.should == 0
+        it "should have no movies from 1998 because title is an aka" do
+          films = @imdb_search.movies.select{|m| m.year.to_i == 1998}
+          films.length.should == 0
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: royw-imdb
 version: !ruby/object:Gem::Version 
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors: 
 - Roy Wright
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-22 00:00:00 -07:00
+date: 2009-04-24 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -73,7 +73,6 @@ files:
 - spec/samples/www.imdb.com/find?q=some+extremely+specific+search+for+indiana+jones;s=tt
 - spec/samples/www.imdb.com/rg/action-box-title/primary-photo/media/rm1203608832/tt0097576
 - spec/spec_helper.rb
-- spec/string_extensions_spec.rb
 - README
 has_rdoc: true
 homepage: http://github.com/royw/imdb
@@ -106,5 +105,4 @@ test_files:
 - spec/spec_helper.rb
 - spec/imdb_search_spec.rb
 - spec/imdb_image_spec.rb
-- spec/string_extensions_spec.rb
 - spec/imdb_profile_spec.rb

data/spec/string_extensions_spec.rb

@@ -1,25 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
-describe String do
-  
-  describe "unescape_html" do
-    
-    it "should convert & to &" do
-      "M&M".unescape_html.should == 'M&M'
-    end
-    
-    it "should convert ó to ó" do
-      "ósmosis".unescape_html.should == 'ósmosis'
-    end
-    
-  end
-  
-  describe "strip_tags" do
-    
-    it "should strip HTML tags" do
-      "<em>Hola</em> hola".strip_tags.should == 'Hola hola'
-    end
-    
-  end
-  
-end