royw-dvdprofiler_collection 0.1.4 → 0.1.5

data/Rakefile

@@ -30,6 +30,7 @@ require 'spec/rake/spectask'
 Spec::Rake::SpecTask.new(:spec) do |spec|
   spec.libs << 'lib' << 'spec'
   spec.spec_files = FileList['spec/**/*_spec.rb']
+  spec.spec_opts = ["--color", "--format nested"]
 end
 
 Spec::Rake::SpecTask.new(:rcov) do |spec|

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:patch: 4
-:major: 0
 :minor: 1
+:patch: 5
+:major: 0

data/spec/collection_spec.rb

@@ -13,113 +13,121 @@ describe "Collection" do
 
   before(:all) do
     File.mkdirs(TMPDIR)
-    puts "\nCollection Specs"
   end
 
-  it 'should build Collection.yaml when Collection.yaml does not exist' do
-    File.delete(COLLECTION_YAML) if File.exist?(COLLECTION_YAML)
-    collection = Collection.new(COLLECTION_XML)
-    File.exist?(COLLECTION_YAML).should be_true
-  end
+  describe "Parsing Collection.xml/yaml" do
+    it 'should build Collection.yaml when Collection.yaml does not exist' do
+      File.delete(COLLECTION_YAML) if File.exist?(COLLECTION_YAML)
+      collection = Collection.new(COLLECTION_XML)
+      File.exist?(COLLECTION_YAML).should be_true
+    end
 
-  it 'should build Collection.yaml when Collection.xml is newer than existing Collection.yaml' do
-    File.delete(COLLECTION_YAML) if File.exist?(COLLECTION_YAML)
-    Collection.new(COLLECTION_XML)
-    old_yaml_mtime = File.mtime(COLLECTION_YAML)
-    old_xml_mtime = File.mtime(COLLECTION_XML)
+    it 'should build Collection.yaml when Collection.xml is newer than existing Collection.yaml' do
+      File.delete(COLLECTION_YAML) if File.exist?(COLLECTION_YAML)
+      Collection.new(COLLECTION_XML)
+      old_yaml_mtime = File.mtime(COLLECTION_YAML)
+      old_xml_mtime = File.mtime(COLLECTION_XML)
 
-    sleep(2)  # make sure there will be a difference between old yaml and new xml
-    FileUtils.touch(COLLECTION_XML)
-    new_xml_mtime = File.mtime(COLLECTION_XML)
+      sleep(2)  # make sure there will be a difference between old yaml and new xml
+      FileUtils.touch(COLLECTION_XML)
+      new_xml_mtime = File.mtime(COLLECTION_XML)
 
-    Collection.new(COLLECTION_XML)
-    new_yaml_mtime = File.mtime(COLLECTION_YAML)
+      Collection.new(COLLECTION_XML)
+      new_yaml_mtime = File.mtime(COLLECTION_YAML)
 
-    old_yaml_mtime.should < new_yaml_mtime
-  end
+      old_yaml_mtime.should < new_yaml_mtime
+    end
 
-  it 'should not build Collection.yaml when existing Collection.yaml is newer than Collection.xml' do
-    File.delete(COLLECTION_YAML) if File.exist?(COLLECTION_YAML)
-    Collection.new(COLLECTION_XML)
-    old_yaml_mtime = File.mtime(COLLECTION_YAML)
-    sleep(2)
+    it 'should not build Collection.yaml when existing Collection.yaml is newer than Collection.xml' do
+      File.delete(COLLECTION_YAML) if File.exist?(COLLECTION_YAML)
+      Collection.new(COLLECTION_XML)
+      old_yaml_mtime = File.mtime(COLLECTION_YAML)
+      sleep(2)
 
-    Collection.new(COLLECTION_XML)
-    new_yaml_mtime = File.mtime(COLLECTION_YAML)
+      Collection.new(COLLECTION_XML)
+      new_yaml_mtime = File.mtime(COLLECTION_YAML)
 
-    old_yaml_mtime.should == new_yaml_mtime
+      old_yaml_mtime.should == new_yaml_mtime
+    end
   end
 
-  it 'should have values in isbn_title_hash' do
-    collection = Collection.new(COLLECTION_XML)
-    collection.isbn_title_hash.empty?.should be_false
-  end
+  describe "Collection contents" do
+    it 'should have values in isbn_title_hash' do
+      collection = Collection.new(COLLECTION_XML)
+      collection.isbn_title_hash.empty?.should be_false
+    end
 
-  it 'should have values in title_isbh_hash' do
-    collection = Collection.new(COLLECTION_XML)
-    collection.title_isbn_hash.empty?.should be_false
-  end
+    it 'should have values in title_isbh_hash' do
+      collection = Collection.new(COLLECTION_XML)
+      collection.title_isbn_hash.empty?.should be_false
+    end
 
-  it 'should have values in isbn_dvd_hash' do
-    collection = Collection.new(COLLECTION_XML)
-    collection.isbn_dvd_hash.empty?.should be_false
+    it 'should have values in isbn_dvd_hash' do
+      collection = Collection.new(COLLECTION_XML)
+      collection.isbn_dvd_hash.empty?.should be_false
+    end
   end
 
-  # dynamically create a set of specs for various title pattern generations
-  {
-    'Extra   Spaces'                             => 'extra spaces',
-    '  leading spaces'                           => 'leading spaces',
-    'trailing spaces  '                          => 'trailing spaces',
-    'multiple : * [] () {} ~!@#$%^; punctuation' => 'multiple punctuation',
-    'replace & with and'                         => 'replace and with and',
-    'remove [foo] square brackets'               => 'remove square brackets',
-    'remove {foo} curly brackets'                => 'remove curly brackets',
-    'remove (foo) parens'                        => 'remove parens',
-    'remove &amp; html escapes'                  => 'remove html escapes',
-    'remove widescreen'                          => 'remove',
-    'remove special edition'                     => 'remove',
-   }.each do |title, pattern|
-    it "should replace '#{title}' with '#{pattern}'" do
-      Collection.title_pattern(title).should == pattern
+  describe "Title patterns" do
+    # dynamically create a set of specs for various title pattern generations
+    {
+      'Extra   Spaces'                             => 'extra spaces',
+      '  leading spaces'                           => 'leading spaces',
+      'trailing spaces  '                          => 'trailing spaces',
+      'multiple : * [] () {} ~!@#$%^; punctuation' => 'multiple punctuation',
+      'replace & with and'                         => 'replace and with and',
+      'remove [foo] square brackets'               => 'remove square brackets',
+      'remove {foo} curly brackets'                => 'remove curly brackets',
+      'remove (foo) parens'                        => 'remove parens',
+      'remove &amp; html escapes'                  => 'remove html escapes',
+      'remove widescreen'                          => 'remove',
+      'remove special edition'                     => 'remove',
+    }.each do |title, pattern|
+      it "should replace '#{title}' with '#{pattern}'" do
+        Collection.title_pattern(title).should == pattern
+      end
     end
   end
 
-  # dynamically create a set of specs to test title permutations
-  [
-    'foobar',
-    'a foobar',
-    'an foobar',
-    'the foobar'
-  ].each do |title|
-    it "should create proper title permutations for '#{title}'" do
-      Collection.title_permutations(title).sort.should == ['foobar', 'a foobar', 'an foobar', 'the foobar'].sort
+  describe "Title permutations" do
+    # dynamically create a set of specs to test title permutations
+    [
+      'foobar',
+      'a foobar',
+      'an foobar',
+      'the foobar'
+    ].each do |title|
+      it "should create proper title permutations for '#{title}'" do
+        Collection.title_permutations(title).sort.should == ['foobar', 'a foobar', 'an foobar', 'the foobar'].sort
+      end
     end
   end
 
-  it 'should use title patterns in title_isbn_hash' do
-    collection = Collection.new(COLLECTION_XML)
-    buf = []
-    collection.title_isbn_hash.each do |title, isbn|
-      buf << title unless title == Collection.title_pattern(title)
+  describe "Hash contents" do
+    it 'should use title patterns in title_isbn_hash' do
+      collection = Collection.new(COLLECTION_XML)
+      buf = []
+      collection.title_isbn_hash.each do |title, isbn|
+        buf << title unless title == Collection.title_pattern(title)
+      end
+      puts buf.join("\n") unless buf.empty?
+      buf.empty?.should be_true
     end
-    puts buf.join("\n") unless buf.empty?
-    buf.empty?.should be_true
-  end
 
-  it 'should use actual titles in isbn_title_hash' do
-    collection = Collection.new(COLLECTION_XML)
-    buf = []
-    # collection.isbn_title_hash's value is the actual title
-    # collection.title_isbn_hash uses the title pattern as the key
-    # and returns an array of possible isbns, one of which should
-    # match the key from collection.isbn_title_hash
-    collection.isbn_title_hash.each do |isbn, actual_title|
-      title_pattern = Collection.title_pattern(actual_title)
-      isbns = collection.title_isbn_hash[title_pattern]
-      buf << actual_title unless isbns.include?(isbn)
+    it 'should use actual titles in isbn_title_hash' do
+      collection = Collection.new(COLLECTION_XML)
+      buf = []
+      # collection.isbn_title_hash's value is the actual title
+      # collection.title_isbn_hash uses the title pattern as the key
+      # and returns an array of possible isbns, one of which should
+      # match the key from collection.isbn_title_hash
+      collection.isbn_title_hash.each do |isbn, actual_title|
+        title_pattern = Collection.title_pattern(actual_title)
+        isbns = collection.title_isbn_hash[title_pattern]
+        buf << actual_title unless isbns.include?(isbn)
+      end
+      puts buf.join("\n") unless buf.empty?
+      buf.empty?.should be_true
     end
-    puts buf.join("\n") unless buf.empty?
-    buf.empty?.should be_true
   end
-
 end

data/spec/dvdprofiler_profile_spec.rb

@@ -14,7 +14,6 @@ describe "DvdprofilerProfile" do
 #     Log4r::Outputter[:console].formatter  = Log4r::PatternFormatter.new(:pattern => "%m")
 #     @logger.level = Log4r::DEBUG
     File.mkdirs(TMPDIR)
-    puts "\nDvdprofilerProfile Specs"
   end
 
   before(:each) do
@@ -26,56 +25,62 @@ describe "DvdprofilerProfile" do
     Dir.glob(File.join(TMPDIR, "dvdprofiler_profile_spec*")).each { |filename| File.delete(filename) }
   end
 
-  it "should find by imdb_id" do
-    @profile.should_not == nil
-  end
+  describe "Finders" do
+    it "should find by imdb_id" do
+      @profile.should_not == nil
+    end
 
-  it "should find by title" do
-    profile = DvdprofilerProfile.first(:title => 'National Treasure 2: Book of Secrets')
-    profile.should_not == nil
-  end
+    it "should find by title" do
+      profile = DvdprofilerProfile.first(:title => 'National Treasure 2: Book of Secrets')
+      profile.should_not == nil
+    end
 
-  it "should find find by fuzzy title" do
-    profile = DvdprofilerProfile.first(:title => 'National Treasure 2 Book of Secrets')
-    profile.should_not == nil
-  end
+    it "should find find by fuzzy title" do
+      profile = DvdprofilerProfile.first(:title => 'National Treasure 2 Book of Secrets')
+      profile.should_not == nil
+    end
 
-  it "should find by case insensitive title" do
-    profile = DvdprofilerProfile.first(:title => 'national treasure 2: book of secrets')
-    profile.should_not == nil
-  end
+    it "should find by case insensitive title" do
+      profile = DvdprofilerProfile.first(:title => 'national treasure 2: book of secrets')
+      profile.should_not == nil
+    end
 
-  it "should be able to convert to xml and then from xml" do
-    hash = nil
-    begin
-      xml = @profile.to_xml
-      hash = XmlSimple.xml_in(xml)
-    rescue
-      hash = nil
+    it "should find multiple movies with the same title" do
+      profiles = DvdprofilerProfile.all(:title => 'Sabrina')
+      profiles.length.should == 2
     end
-    hash.should_not be_nil
-  end
 
-  it "should find multiple movies with the same title" do
-    profiles = DvdprofilerProfile.all(:title => 'Sabrina')
-    profiles.length.should == 2
-  end
+    it "should find a single movie using the year when multiple movies have the same title" do
+      profiles = DvdprofilerProfile.all(:title => 'Sabrina', :year => '1995')
+      (profiles.length.should == 1) && (profiles.first.isbn.should == '097363304340')
+    end
 
-  it "should find a single movie using the year when multiple movies have the same title" do
-    profiles = DvdprofilerProfile.all(:title => 'Sabrina', :year => '1995')
-    (profiles.length.should == 1) && (profiles.first.isbn.should == '097363304340')
+    it "should find the other single movie using the year when multiple movies have the same title" do
+      profiles = DvdprofilerProfile.all(:title => 'Sabrina', :year => '1954')
+      (profiles.length.should == 1) && (profiles.first.isbn.should == '097360540246')
+    end
   end
 
-  it "should find the other single movie using the year when multiple movies have the same title" do
-    profiles = DvdprofilerProfile.all(:title => 'Sabrina', :year => '1954')
-    (profiles.length.should == 1) && (profiles.first.isbn.should == '097360540246')
+  describe "XML" do
+    it "should be able to convert to xml and then from xml" do
+      hash = nil
+      begin
+        xml = @profile.to_xml
+        hash = XmlSimple.xml_in(xml)
+      rescue
+        hash = nil
+      end
+      hash.should_not be_nil
+    end
   end
 
-  it "should save to a file" do
-    filespec = get_temp_filename
-    profile = DvdprofilerProfile.first(:title => 'Sabrina', :year => '1995')
-    profile.save(filespec)
-    (File.exist?(filespec) && (File.size(filespec) > 0)).should be_true
+  describe "File" do
+    it "should save to a file" do
+      filespec = get_temp_filename
+      profile = DvdprofilerProfile.first(:title => 'Sabrina', :year => '1995')
+      profile.save(filespec)
+      (File.exist?(filespec) && (File.size(filespec) > 0)).should be_true
+    end
   end
 
   def get_temp_filename

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: royw-dvdprofiler_collection
 version: !ruby/object:Gem::Version 
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors: 
 - Roy Wright
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-22 00:00:00 -07:00
+date: 2009-04-24 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency