routemaster-drain 3.6.3 → 3.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68cd91502559ade561ad65e6440cd1609134a380
-  data.tar.gz: d9c8c31b7d24f5d56f831b49a42bcf1e09c86a43
+  metadata.gz: 8751ba11d3ecc6376887aca2600adf850839d0ab
+  data.tar.gz: 3bcbd8c7cdeefdbe07deb264f196a987e7adeda1
 SHA512:
-  metadata.gz: 9250edbe5107293bab6a4b5ec81eaa61b6e35483223c2af4548b1dce04afc7948c010092fb3dd831b11947ce463700702a1586228f3c110d2c7407bdbb535b4f
-  data.tar.gz: 8ed05bfc0b1cc2d39353612f18a3f123c13298c222cf77c25ba9873e43eb9f8002091e5eb5a0e8e4f25f4286947b56fa6e36182418fa4e8ad3f9c67a4087126a
+  metadata.gz: d30f96275f9ed9785088da2e7d231e7a9f79073bca0f427f796e7a8cc0c42905bd5e1e1d4ef6e97a00f9f665d9433e59d2ee7e04c7e3577a693fb13c4a994cde
+  data.tar.gz: e82794bf28ddfc30c60a489020a3d14f652bbbc6e6c476015863cd3a067a6282e9e541dee123e39b159d72296e1d4642a3ef53a74f9cded123d5461676eb9eb0

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 _A description of your awesome changes here!_
 
+### 3.6.4 (2018-10-23)
+
+Features:
+
+- Allow specification of User-Agent through environment variable
+- Add fallback values for User-Agent header in API client
+
 ### 3.6.3 (2018-10-17)
 
 Bug fix:

data/README.md

@@ -264,6 +264,9 @@ configure it using `client_options`:
 $cache = Routemaster::Cache.new(client_options: {source_peer: "<your user agent>"})
 ```
 
+You can specify your user agent with the `ROUTEMASTER_API_CLIENT_USER_AGENT` environment
+variable as well.
+
 ### Expire Cache data for all notified resources
 
 You may wish to maintain a coherent cache, but don't need the cache to be warmed

data/lib/routemaster/api_client.rb

@@ -30,6 +30,7 @@ require 'hashie/mash'
 
 module Routemaster
   class APIClient
+    DEFAULT_USER_AGENT = ENV.fetch('ROUTEMASTER_API_CLIENT_USER_AGENT') { "RoutemasterDrain - Faraday v#{Faraday::VERSION}" }.freeze
 
     # Memoize the root resources at Class level so that we don't hit the cache
     # all the time to fetch the root resource before doing anything else.
@@ -157,8 +158,7 @@ module Routemaster
     end
 
     def user_agent_header
-      agent = @source_peer || "Faraday v#{Faraday::VERSION}"
-      { 'User-Agent' => agent }
+      { 'User-Agent' => @source_peer || DEFAULT_USER_AGENT }
     end
 
     def response_cache_opt_headers(value)

data/lib/routemaster/drain.rb

@@ -1,5 +1,5 @@
 module Routemaster
   module Drain
-    VERSION = '3.6.3'.freeze
+    VERSION = '3.6.4'.freeze
   end
 end

data/spec/routemaster/api_client_spec.rb

@@ -52,7 +52,8 @@ describe Routemaster::APIClient do
       headers['x-custom-header'] = 'why do you even'
       subject.status
       assert_requested(:get, /example/) do |req|
-        expect(req.headers).to include('X-Custom-Header')
+        expect(req.headers.keys).to include('X-Custom-Header')
+        expect(req.headers['User-Agent']).to eql "RoutemasterDrain - Faraday v0.15.3"
       end
     end
 
@@ -76,7 +77,7 @@ describe Routemaster::APIClient do
         it 'should set the user agent header to the faraday version' do
           subject.status
           assert_requested(:get, /example/) do |req|
-            expect(req.headers).to include('User-Agent' => "Faraday v#{Faraday::VERSION}" )
+            expect(req.headers).to include('User-Agent' => "RoutemasterDrain - Faraday v#{Faraday::VERSION}" )
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: routemaster-drain
 version: !ruby/object:Gem::Version
-  version: 3.6.3
+  version: 3.6.4
 platform: ruby
 authors:
 - Julien Letessier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-17 00:00:00.000000000 Z
+date: 2018-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable