routemaster-drain 3.3.0 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a0520ca5a0cdb1daad87055a37684ddf6bc80477
-  data.tar.gz: 8cd339befc65768cb048fedd8484fde9db05e8e0
+SHA256:
+  metadata.gz: 276a80759ce3d7e91723078a885714ae5878a29ac8a013e619274966075bdef8
+  data.tar.gz: 04b65e8136d765138f618dffd3121ff9c1e045b80cabf6da6af2073ca2ebe58f
 SHA512:
-  metadata.gz: fc439ada70fc173308616b83490fea38d3c2705372fc29705aa9c3ae36b1b0bb309f73a64766a86e71e65d66b93b43b01b5bfe10b92101f9e749f48c604675b3
-  data.tar.gz: f500448852c281cf3098e5eb6a3bc413be90d26aea533fedb19f99574e274027e81be48bf2b07064364fa8b939b0703018ea44116027bfd0260c9d3c56e1c1fb
+  metadata.gz: 90fe430dacad9cdac42c97998ccad99a73459237b486e23f0f0bb422399853b96a75d94a911690c1d8e98343370d68a5bd421a41cb0bbc4ff7312be7dd52af98
+  data.tar.gz: 1282d36973a326638171e6f9010d212802fc1babb30faef951386601a7e1136590abd1fd8afb609177c0584ef5509c220d5432a108b6e385a3a0bbb5de420c12

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+### 3.4.0 (2017-11-16)
+
+Features:
+
+- Raises error on 405 and 503
+
 ### 3.3.0 (2017-11-16)
 
 Features:

data/lib/routemaster/drain.rb

@@ -1,5 +1,5 @@
 module Routemaster
   module Drain
-    VERSION = '3.3.0'.freeze
+    VERSION = '3.4.0'.freeze
   end
 end

data/lib/routemaster/errors.rb

@@ -69,5 +69,17 @@ module Routemaster
         "Resource Throttling Error"
       end
     end
+
+    class MethodNotAllowed < BaseError
+      def message
+        "Method Not Allowed"
+      end
+    end
+
+    class ServiceNotAvailable < BaseError
+      def message
+        "Service Not Available"
+      end
+    end
   end
 end

data/lib/routemaster/middleware/error_handling.rb

@@ -9,11 +9,13 @@ module Routemaster
         (401..401) => Errors::UnauthorizedResourceAccess,
         (403..403) => Errors::UnauthorizedResourceAccess,
         (404..404) => Errors::ResourceNotFound,
+        (405..405) => Errors::MethodNotAllowed,
         (409..409) => Errors::ConflictResource,
         (412..412) => Errors::IncompatibleVersion,
         (413..413) => Errors::InvalidResource,
         (429..429) => Errors::ResourceThrottling,
-        (407..500) => Errors::FatalResource
+        (407..500) => Errors::FatalResource,
+        (503..503) => Errors::ServiceNotAvailable
       }.freeze
 
       def on_complete(env)

data/spec/routemaster/integration/api_client_spec.rb

@@ -21,7 +21,7 @@ describe Routemaster::APIClient do
   let(:port) { 8080 }
   let(:service) do
     TestServer.new(port) do |server|
-      [400, 401, 403, 404, 409, 412, 413, 429, 500].each do |status_code|
+      [400, 401, 403, 404, 405, 409, 412, 413, 429, 500, 503].each do |status_code|
         server.mount_proc "/#{status_code}" do |req, res|
           res.status = status_code
           res.body = { field: 'test' }.to_json
@@ -139,6 +139,10 @@ describe Routemaster::APIClient do
         expect { perform.(host + '/403') }.to raise_error(Routemaster::Errors::UnauthorizedResourceAccess)
       end
 
+      it 'raises a MethodNotAllowed on 405' do
+        expect { perform.(host + '/405') }.to raise_error(Routemaster::Errors::MethodNotAllowed)
+      end
+
       it 'raises an ConflictResource on 409' do
         expect { perform.(host + '/409') }.to raise_error(Routemaster::Errors::ConflictResource)
       end
@@ -158,6 +162,10 @@ describe Routemaster::APIClient do
       it 'raises an FatalResource on 500' do
         expect { perform.(host + '/500') }.to raise_error(Routemaster::Errors::FatalResource)
       end
+
+      it 'raises a ServiceNotAvailable on 503' do
+        expect { perform.(host + '/503') }.to raise_error(Routemaster::Errors::ServiceNotAvailable)
+      end
     end
 
     describe '#get' do

data/spec/support/server.rb

@@ -7,6 +7,7 @@ module WEBrick
   module HTTPServlet
     class ProcHandler
       alias do_PATCH do_GET
+      alias do_DELETE do_GET
     end
   end
 end
@@ -25,7 +26,7 @@ class TestServer
         DocumentRoot: Dir.pwd,
         Logger: WEBrick::Log.new('/dev/null'),
         AccessLog: [nil, nil]
-      ).tap do |server|  
+      ).tap do |server|
         @setup.call(server)
         server.start
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: routemaster-drain
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.4.0
 platform: ruby
 authors:
 - Julien Letessier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-16 00:00:00.000000000 Z
+date: 2017-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -286,7 +286,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.0
 signing_key: 
 specification_version: 4
 summary: Event receiver for the Routemaster bus