route_mechanic 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: edfa9dd2a475e94ffb5131cfb367f430a838ecc12d001e45414955b1f0d84ec5
-  data.tar.gz: '039c3bbbc1f86d16336db76fb1e6b0879ee3e2d2b8bc8f64731988c64301c48c'
+  metadata.gz: 7a45e646ff04b613cb52b102ff6d47ef3b02750fe4455eab2d081e549c37313f
+  data.tar.gz: 4df4c8d6bc5dee7e15338a93e1a8f1f468e3e76dd7299b80baf14922322ca0bd
 SHA512:
-  metadata.gz: ae134daadd7209a3d67e5e3c9b7e2615b168693f034d3abd34915568de2333b5ef0955f0b7f57a76734c0e06d56145cc8bf861f156567f9437ed5bd02199e1fd
-  data.tar.gz: 97d0c73f8d437837742470795f4f9414c73af178f911d27e49eb5c5edbba5ebf51a9f7e0b0d1155e66f1f348a1aaf8ba1333513d48de6c41fe36afe8c0ac0e7f
+  metadata.gz: f2dbdb3b471fc9d47686fb4b924f3a32843a3d5dce778a64706fe72b4127a84cdaa09dcc3b0bc2527ff6b6b77b393d8af5124595bd62d17fc10651e82fef2978
+  data.tar.gz: b47585e146f2e8aa6af03802794c3cb8206057adb216fb54581871baba4a820b0103bfbe45885491de8aaaf0f54c52279885ff1fef30fa58c585cd743c3434f6

data/README.md

@@ -33,7 +33,7 @@ Just add a test file which has only one test case using `have_valid_routes` matc
 ```ruby
 RSpec.describe 'Rails.application', type: :routing do
   it "fails if application does not have valid routes" do
-   expect(Rails.application).to have_valid_routes
+    expect(Rails.application).to have_valid_routes
   end
 end
 ```

data/fixtures/fake_app/lib/engine.rb

@@ -0,0 +1,5 @@
+module FakeEngine
+  class Engine < ::Rails::Engine
+    isolate_namespace FakeEngine
+  end
+end

data/fixtures/fake_app/rails_app.rb

@@ -1,6 +1,8 @@
 require 'rails/application'
 require "action_controller/railtie"
 
+require_relative './lib/engine'
+
 FakeApp = Class.new(Rails::Application)
 FakeApp.config.eager_load = false
 FakeApp.config.hosts << 'www.example.com' if FakeApp.config.respond_to?(:hosts)
@@ -10,5 +12,6 @@ FakeApp.initialize!
 FakeApp.routes.draw do
   resources :users do
     get 'friends', to: :friends
+    mount FakeEngine::Engine, at: "/fake_engine", fake_default_param: 'FAKE'
   end
 end

data/lib/route_mechanic/testing/methods.rb

@@ -78,7 +78,7 @@ module RouteMechanic
           # Skip internals, endpoints that Rails adds by default
           # Also Engines should be skipped since Engine's tests should be done in Engine
           wrapper = RouteWrapper.new(journey_route)
-          wrapper.internal? || wrapper.required_defaults.empty? || wrapper.path.start_with?('/rails/')
+          wrapper.internal? || !wrapper.defaults[:controller] || !wrapper.defaults[:action] || wrapper.path.start_with?('/rails/')
         end
       end
     end

data/lib/route_mechanic/version.rb

@@ -1,3 +1,3 @@
 module RouteMechanic
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: route_mechanic
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - ohbarye
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-09-19 00:00:00.000000000 Z
+date: 2020-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -51,6 +51,7 @@ files:
 - bin/setup
 - fixtures/fake_app/app/controllers/application_controller.rb
 - fixtures/fake_app/app/controllers/users_controller.rb
+- fixtures/fake_app/lib/engine.rb
 - fixtures/fake_app/rails_app.rb
 - lib/route_mechanic.rb
 - lib/route_mechanic/rspec/matchers.rb