rouster 0.62 → 0.63

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8bce9804eb72b059c106b689793f06a26a55dcdb
-  data.tar.gz: 278dadb5f13e14a71ea84adecc751989f74ee810
+  metadata.gz: 2f6f24bd67f15a77eb224c1d7113697ddf655644
+  data.tar.gz: e12f55be25bb6e83b69df057f6f9b5aca70d364e
 SHA512:
-  metadata.gz: ae9a583d9d11112ada1f3a17295f41f6d8d5563af4e389af2b1a090f9327a6b5441929199d205bcca341b770e68128cf0514ed7953b154f861651e5d0ab6067e
-  data.tar.gz: 2f012c9ca78fb82ff64c079ad5e262b77203021e74de3d0e20a1444a20d62633ba7119dbd962b57577fba4f77896930199cd61ba76e9555b85ec1787418fcc23
+  metadata.gz: 1dbdd864b27dae6c8de015f027c4935e1ef328ff8a03b22ad6812f6d7b3ee64c99dfe106da9e427e6c7d53d83b09e82484d382df72c2e7c29c4b8a577cfcb515
+  data.tar.gz: ce7bbaa357a902683f9ac0d3e2bf5eba3f48c60c50aa9dde5e0d5b7145939ec62d7790ff65eabf6c72c737a28c8bf638bb7feac23a76fa5ffd66618cde0e3e2b

data/Gemfile

@@ -6,6 +6,7 @@ gem 'json'
 gem 'log4r', '~> 1.1.9'
 gem 'net-scp'
 gem 'net-ssh'
+gem 'rake', '= 10.4.2'
 
 group :development do
   gem 'test-unit', '~> 3.0.0'

data/Gemfile.lock

@@ -52,6 +52,7 @@ GEM
     nokogiri (1.6.3.1)
       mini_portile (= 0.6.0)
     power_assert (0.1.4)
+    rake (10.4.2)
     test-unit (3.0.2)
       power_assert
 
@@ -64,4 +65,8 @@ DEPENDENCIES
   log4r (~> 1.1.9)
   net-scp
   net-ssh
+  rake (= 10.4.2)
   test-unit (~> 3.0.0)
+
+BUNDLED WITH
+   1.10.6

data/lib/rouster.rb

@@ -12,7 +12,7 @@ require 'rouster/vagrant'
 class Rouster
 
   # sporadically updated version number
-  VERSION = 0.62
+  VERSION = 0.63
 
   # custom exceptions -- what else do we want them to include/do?
   class ArgumentError        < StandardError; end # thrown by methods that take parameters from users
@@ -24,7 +24,7 @@ class Rouster
   class PassthroughError     < StandardError; end # thrown by anything Passthrough related (mostly vagrant.rb)
   class SSHConnectionError   < StandardError; end # thrown by available_via_ssh() -- and potentially _run()
 
-  attr_accessor :facts
+  attr_accessor :facts, :last_puppet_run
   attr_reader :cache, :cache_timeout, :deltas, :exitcode, :logger, :name, :output, :passthrough, :retries, :sshkey, :unittest, :vagrantbinary, :vagrantfile
 
   ##
@@ -360,7 +360,7 @@ class Rouster
     if @ssh.nil? or @ssh.closed?
       begin
         res = self.connect_ssh_tunnel()
-      rescue Rouster::InternalError, Net::SSH::Disconnect => e
+      rescue Rouster::InternalError, Net::SSH::Disconnect, Errno::ECONNREFUSED, Errno::ECONNRESET => e
         res = false
       end
 
@@ -518,9 +518,9 @@ class Rouster
       :osx     => '/System/Library/CoreServices/SystemVersion.plist',
     }
 
-    res   = nil
+    res = :invalid
 
-    files.each do |os,file|
+    files.each do |os, file|
       if self.is_file?(file)
         @logger.debug(sprintf('determined OS to be[%s] via[%s]', os, file))
         res = os
@@ -528,7 +528,7 @@ class Rouster
       end
     end
 
-    @logger.error(sprintf('unable to determine OS, looking for[%s]', files)) if res.nil?
+    @logger.error(sprintf('unable to determine OS, looking for[%s]', files)) if res.eql?(:invalid)
 
     @ostype = res
     res
@@ -640,7 +640,7 @@ class Rouster
 
     if wait
       inc = wait.to_i / 10
-      0..wait.each do |e|
+      0.upto(9) do |e|
         @logger.debug(sprintf('waiting for reboot: round[%s], step[%s], total[%s]', e, inc, wait))
         return true if self.is_available_via_ssh?()
         sleep inc

data/lib/rouster/deltas.rb

@@ -476,6 +476,10 @@ class Rouster
         :systemv => '/sbin/service --status-all',
         :upstart => 'initctl list',
       },
+
+      :invalid => {
+        :invalid => 'invalid',
+      },
     }
 
     if type.eql?(:all)
@@ -486,7 +490,7 @@ class Rouster
 
     type.each do |provider|
 
-      raise InternalError.new(sprintf('unable to get service information from VM operating system[%s]', os)) unless commands.has_key?(os)
+      raise InternalError.new(sprintf('unable to get service information from VM operating system[%s]', os)) if provider.eql?(:invalid)
       raise ArgumentError.new(sprintf('unable to find command provider[%s] for [%s]', provider, os))  if commands[os][provider].nil?
 
       @logger.info(sprintf('get_services using provider [%s] on [%s]', provider, os))
@@ -665,10 +669,11 @@ class Rouster
           end
 
         end
-
-        # end of os casing
+      else
+        raise InternalError.new(sprintf('unable to get service information from VM operating system[%s]', os))
       end
 
+
       # end of provider processing
     end
 

data/lib/rouster/puppet.rb

@@ -46,6 +46,27 @@ class Rouster
     res
   end
 
+  ##
+  # did_exec_fire?
+  #
+  # given the name of an Exec resource, parse the output from the most recent puppet run
+  # and return true/false based on whether the exec in question was fired
+  def did_exec_fire?(resource_name, puppet_run = self.last_puppet_run)
+    # Notice: /Stage[main]//Exec[foo]/returns: executed successfully
+    # Error: /Stage[main]//Exec[bar]/returns: change from notrun to 0 failed: Could not find command '/bin/bar'
+    matchers = [
+      'Notice: /Stage\[.*\]//Exec\[%s\]/returns: executed successfully',
+      'Error: /Stage\[.*\]//Exec\[%s\]/returns: change from notrun to 0 failed'
+    ]
+
+    matchers.each do |m|
+      matcher = sprintf(m, resource_name)
+      return true if puppet_run.match(matcher)
+    end
+
+    false
+  end
+
   ##
   # get_catalog
   #
@@ -468,7 +489,7 @@ class Rouster
           cmd << sprintf(' %s', opts[:additional_options]) unless opts[:additional_options].nil?
           cmd << sprintf(' %s', file)
 
-          self.run(cmd, opts[:expected_exitcode])
+          self.last_puppet_run = self.run(cmd, opts[:expected_exitcode])
         end
       end
 
@@ -490,7 +511,7 @@ class Rouster
             cmd << sprintf(' %s', opts[:additional_options]) unless opts[:additional_options].nil?
             cmd << sprintf(' %s', m)
 
-            self.run(cmd, opts[:expected_exitcode])
+            self.last_puppet_run = self.run(cmd, opts[:expected_exitcode])
           end
 
         end

data/lib/rouster/testing.rb

@@ -581,13 +581,17 @@ class Rouster
 
         when :address
           lr = Array.new
-          addresses = ports[expectations[:protocol]][number][:address]
-          addresses.each_key do |address|
-            lr.push(address.eql?(v.to_s))
-          end
-
-          local = ! lr.find{|e| e.true? }.nil? # this feels jankity
+          if ports[expectations[:protocol]][number]
+            addresses = ports[expectations[:protocol]][number][:address]
+            addresses.each_key do |address|
+              lr.push(address.eql?(v.to_s))
+            end
 
+            local = ! lr.find{|e| e.true? }.nil? # this feels jankity
+          else
+            # this port isn't open in the first place, won't match any addresses we expect to see it on
+            local = false
+          end
         else
           raise InternalError.new(sprintf('unknown expectation[%s / %s]', k, v))
       end

data/test/functional/deltas/test_get_os.rb

@@ -0,0 +1,68 @@
+require sprintf('%s/../../../path_helper', File.dirname(File.expand_path(__FILE__)))
+
+require 'rouster'
+require 'rouster/puppet'
+require 'rouster/testing'
+require 'test/unit'
+
+class TestValidateFileFunctional < Test::Unit::TestCase
+
+  # TODO this should probably be further abstracted into the implementation, but this is fine for now
+  FLAG_FILES = {
+    :ubuntu  => '/etc/os-release', # debian too
+    :solaris => '/etc/release',
+    :redhat  => '/etc/redhat-release', # centos too
+    :osx     => '/System/Library/CoreServices/SystemVersion.plist',
+  }
+
+  def setup
+    # expose private methods
+    Rouster.send(:public, *Rouster.private_instance_methods)
+    Rouster.send(:public, *Rouster.protected_instance_methods)
+
+    @app = Rouster.new(:name => 'app')
+  end
+
+  def teardown
+    # put the flag file back in place
+    FLAG_FILES.each_pair do |_os, ff|
+      bkup = sprintf('%s.bkup', ff)
+      if @app.is_file?(bkup)
+        @app.run(sprintf('mv %s %s', bkup, ff))
+      end
+    end
+  end
+
+  def test_happy_path
+
+    type = @app.os_type
+    assert_not_nil(type, sprintf('unable to determine vm[%s] OS', @app))
+    assert_not_equal(:invalid, type)
+
+    assert_nothing_raised do
+      @app.get_services
+    end
+
+  end
+
+  def test_unhappy_path
+    # move the flag file out of the way
+    FLAG_FILES.each_pair do |_os, ff|
+      if @app.is_file?(ff)
+        @app.run(sprintf('mv %s %s.bkup', ff, ff))
+      end
+    end
+
+    type = @app.os_type
+
+    assert_equal(:invalid, type, sprintf('got wrong value for unmarked OS[%s]', type))
+
+    e = assert_raise do
+        @app.get_services
+    end
+
+    assert_equal(Rouster::InternalError, e.class, sprintf('wrong exception raised[%s] [%s]', e.class, e.message))
+
+  end
+
+end

data/test/unit/puppet/resources/puppet_run_with_failed_exec

@@ -0,0 +1,59 @@
+Debug: Creating default schedules
+Debug: Using settings: adding file resource 'clientyamldir': 'File[/home/vagrant/.puppet/var/client_yaml]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/client_yaml"}'
+Debug: Using settings: adding file resource 'lastrunreport': 'File[/home/vagrant/.puppet/var/state/last_run_report.yaml]{:loglevel=>:debug, :links=>:follow, :ensure=>:file, :backup=>false, :mode=>"640", :path=>"/home/vagrant/.puppet/var/state/last_run_report.yaml"}'
+Debug: Using settings: adding file resource 'confdir': 'File[/home/vagrant/.puppet]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet"}'
+Debug: Using settings: adding file resource 'ssldir': 'File[/home/vagrant/.puppet/ssl]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"771", :path=>"/home/vagrant/.puppet/ssl"}'
+Debug: Using settings: adding file resource 'privatekeydir': 'File[/home/vagrant/.puppet/ssl/private_keys]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/ssl/private_keys"}'
+Debug: Using settings: adding file resource 'client_datadir': 'File[/home/vagrant/.puppet/var/client_data]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/client_data"}'
+Debug: Using settings: adding file resource 'statedir': 'File[/home/vagrant/.puppet/var/state]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"1755", :path=>"/home/vagrant/.puppet/var/state"}'
+Debug: Using settings: adding file resource 'vardir': 'File[/home/vagrant/.puppet/var]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/var"}'
+Debug: Using settings: adding file resource 'libdir': 'File[/home/vagrant/.puppet/var/lib]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/var/lib"}'
+Debug: Using settings: adding file resource 'publickeydir': 'File[/home/vagrant/.puppet/ssl/public_keys]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/ssl/public_keys"}'
+Debug: Using settings: adding file resource 'rundir': 'File[/home/vagrant/.puppet/var/run]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"755", :path=>"/home/vagrant/.puppet/var/run"}'
+Debug: Using settings: adding file resource 'privatedir': 'File[/home/vagrant/.puppet/ssl/private]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/ssl/private"}'
+Debug: Using settings: adding file resource 'statefile': 'File[/home/vagrant/.puppet/var/state/state.yaml]{:loglevel=>:debug, :links=>:follow, :ensure=>:file, :backup=>false, :mode=>"660", :path=>"/home/vagrant/.puppet/var/state/state.yaml"}'
+Debug: Using settings: adding file resource 'clientbucketdir': 'File[/home/vagrant/.puppet/var/clientbucket]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/clientbucket"}'
+Debug: Using settings: adding file resource 'lastrunfile': 'File[/home/vagrant/.puppet/var/state/last_run_summary.yaml]{:loglevel=>:debug, :links=>:follow, :ensure=>:file, :backup=>false, :mode=>"644", :path=>"/home/vagrant/.puppet/var/state/last_run_summary.yaml"}'
+Debug: Using settings: adding file resource 'logdir': 'File[/home/vagrant/.puppet/var/log]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/log"}'
+Debug: Using settings: adding file resource 'certdir': 'File[/home/vagrant/.puppet/ssl/certs]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/ssl/certs"}'
+Debug: Using settings: adding file resource 'graphdir': 'File[/home/vagrant/.puppet/var/state/graphs]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/var/state/graphs"}'
+Debug: Using settings: adding file resource 'requestdir': 'File[/home/vagrant/.puppet/ssl/certificate_requests]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/ssl/certificate_requests"}'
+Debug: /File[/home/vagrant/.puppet/var]: Autorequiring File[/home/vagrant/.puppet]
+Debug: /File[/home/vagrant/.puppet/ssl/certs]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/var/state]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/var/state/graphs]: Autorequiring File[/home/vagrant/.puppet/var/state]
+Debug: /File[/home/vagrant/.puppet/var/state/last_run_report.yaml]: Autorequiring File[/home/vagrant/.puppet/var/state]
+Debug: /File[/home/vagrant/.puppet/var/run]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/ssl/certificate_requests]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/ssl]: Autorequiring File[/home/vagrant/.puppet]
+Debug: /File[/home/vagrant/.puppet/var/state/last_run_summary.yaml]: Autorequiring File[/home/vagrant/.puppet/var/state]
+Debug: /File[/home/vagrant/.puppet/ssl/private_keys]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/var/client_data]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/var/client_yaml]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/var/clientbucket]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/ssl/private]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/ssl/public_keys]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/var/log]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/var/state/state.yaml]: Autorequiring File[/home/vagrant/.puppet/var/state]
+Debug: /File[/home/vagrant/.puppet/var/lib]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: Finishing transaction 69859761088440
+Debug: Loaded state in 0.00 seconds
+Debug: Loaded state in 0.00 seconds
+Info: Applying configuration version '1427151219'
+Debug: /Schedule[daily]: Skipping device resources because running on a host
+Debug: /Schedule[monthly]: Skipping device resources because running on a host
+Debug: /Schedule[hourly]: Skipping device resources because running on a host
+Error: Could not find command '/bin/bar'
+Error: /Stage[main]//Exec[bar]/returns: change from notrun to 0 failed: Could not find command '/bin/bar'
+Debug: /Schedule[never]: Skipping device resources because running on a host
+Debug: /Schedule[weekly]: Skipping device resources because running on a host
+Debug: /Schedule[puppet]: Skipping device resources because running on a host
+Debug: Class[Main]: The container Stage[main] will propagate my refresh event
+Debug: Finishing transaction 69859760392420
+Debug: Storing state
+Debug: Stored state in 0.01 seconds
+Notice: Finished catalog run in 0.10 seconds
+Debug: Using settings: adding file resource 'rrddir': 'File[/home/vagrant/.puppet/var/rrd]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/rrd"}'
+Debug: Finishing transaction 69859760156920
+Debug: Received report to process from centos6.internal.salesforce.com
+Debug: Processing report from centos6.internal.salesforce.com with processor Puppet::Reports::Store

data/test/unit/puppet/resources/puppet_run_with_successful_exec

@@ -0,0 +1,61 @@
+Debug: Creating default schedules
+Debug: Using settings: adding file resource 'clientyamldir': 'File[/home/vagrant/.puppet/var/client_yaml]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/client_yaml"}'
+Debug: Using settings: adding file resource 'lastrunreport': 'File[/home/vagrant/.puppet/var/state/last_run_report.yaml]{:loglevel=>:debug, :links=>:follow, :ensure=>:file, :backup=>false, :mode=>"640", :path=>"/home/vagrant/.puppet/var/state/last_run_report.yaml"}'
+Debug: Using settings: adding file resource 'confdir': 'File[/home/vagrant/.puppet]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet"}'
+Debug: Using settings: adding file resource 'ssldir': 'File[/home/vagrant/.puppet/ssl]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"771", :path=>"/home/vagrant/.puppet/ssl"}'
+Debug: Using settings: adding file resource 'privatekeydir': 'File[/home/vagrant/.puppet/ssl/private_keys]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/ssl/private_keys"}'
+Debug: Using settings: adding file resource 'client_datadir': 'File[/home/vagrant/.puppet/var/client_data]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/client_data"}'
+Debug: Using settings: adding file resource 'statedir': 'File[/home/vagrant/.puppet/var/state]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"1755", :path=>"/home/vagrant/.puppet/var/state"}'
+Debug: Using settings: adding file resource 'vardir': 'File[/home/vagrant/.puppet/var]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/var"}'
+Debug: Using settings: adding file resource 'libdir': 'File[/home/vagrant/.puppet/var/lib]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/var/lib"}'
+Debug: Using settings: adding file resource 'publickeydir': 'File[/home/vagrant/.puppet/ssl/public_keys]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/ssl/public_keys"}'
+Debug: Using settings: adding file resource 'rundir': 'File[/home/vagrant/.puppet/var/run]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"755", :path=>"/home/vagrant/.puppet/var/run"}'
+Debug: Using settings: adding file resource 'privatedir': 'File[/home/vagrant/.puppet/ssl/private]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/ssl/private"}'
+Debug: Using settings: adding file resource 'statefile': 'File[/home/vagrant/.puppet/var/state/state.yaml]{:loglevel=>:debug, :links=>:follow, :ensure=>:file, :backup=>false, :mode=>"660", :path=>"/home/vagrant/.puppet/var/state/state.yaml"}'
+Debug: Using settings: adding file resource 'clientbucketdir': 'File[/home/vagrant/.puppet/var/clientbucket]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/clientbucket"}'
+Debug: Using settings: adding file resource 'lastrunfile': 'File[/home/vagrant/.puppet/var/state/last_run_summary.yaml]{:loglevel=>:debug, :links=>:follow, :ensure=>:file, :backup=>false, :mode=>"644", :path=>"/home/vagrant/.puppet/var/state/last_run_summary.yaml"}'
+Debug: Using settings: adding file resource 'logdir': 'File[/home/vagrant/.puppet/var/log]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/log"}'
+Debug: Using settings: adding file resource 'certdir': 'File[/home/vagrant/.puppet/ssl/certs]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/ssl/certs"}'
+Debug: Using settings: adding file resource 'graphdir': 'File[/home/vagrant/.puppet/var/state/graphs]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/var/state/graphs"}'
+Debug: Using settings: adding file resource 'requestdir': 'File[/home/vagrant/.puppet/ssl/certificate_requests]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :path=>"/home/vagrant/.puppet/ssl/certificate_requests"}'
+Debug: /File[/home/vagrant/.puppet/var]: Autorequiring File[/home/vagrant/.puppet]
+Debug: /File[/home/vagrant/.puppet/ssl/certs]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/var/state]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/var/state/graphs]: Autorequiring File[/home/vagrant/.puppet/var/state]
+Debug: /File[/home/vagrant/.puppet/var/state/last_run_report.yaml]: Autorequiring File[/home/vagrant/.puppet/var/state]
+Debug: /File[/home/vagrant/.puppet/var/run]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/ssl/certificate_requests]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/ssl]: Autorequiring File[/home/vagrant/.puppet]
+Debug: /File[/home/vagrant/.puppet/var/state/last_run_summary.yaml]: Autorequiring File[/home/vagrant/.puppet/var/state]
+Debug: /File[/home/vagrant/.puppet/ssl/private_keys]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/var/client_data]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/var/client_yaml]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/var/clientbucket]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/ssl/private]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/ssl/public_keys]: Autorequiring File[/home/vagrant/.puppet/ssl]
+Debug: /File[/home/vagrant/.puppet/var/log]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: /File[/home/vagrant/.puppet/var/state/state.yaml]: Autorequiring File[/home/vagrant/.puppet/var/state]
+Debug: /File[/home/vagrant/.puppet/var/lib]: Autorequiring File[/home/vagrant/.puppet/var]
+Debug: Finishing transaction 69859761088440
+Debug: Loaded state in 0.00 seconds
+Debug: Loaded state in 0.00 seconds
+Info: Applying configuration version '1427151219'
+Debug: /Schedule[daily]: Skipping device resources because running on a host
+Debug: /Schedule[monthly]: Skipping device resources because running on a host
+Debug: /Schedule[hourly]: Skipping device resources because running on a host
+Debug: Exec[foo](provider=posix): Executing '/bin/echo foo'
+Debug: Executing '/bin/echo foo'
+Notice: /Stage[main]//Exec[foo]/returns: executed successfully
+Debug: /Stage[main]//Exec[foo]: The container Class[Main] will propagate my refresh event
+Debug: /Schedule[never]: Skipping device resources because running on a host
+Debug: /Schedule[weekly]: Skipping device resources because running on a host
+Debug: /Schedule[puppet]: Skipping device resources because running on a host
+Debug: Class[Main]: The container Stage[main] will propagate my refresh event
+Debug: Finishing transaction 69859760392420
+Debug: Storing state
+Debug: Stored state in 0.01 seconds
+Notice: Finished catalog run in 0.10 seconds
+Debug: Using settings: adding file resource 'rrddir': 'File[/home/vagrant/.puppet/var/rrd]{:loglevel=>:debug, :links=>:follow, :ensure=>:directory, :backup=>false, :mode=>"750", :path=>"/home/vagrant/.puppet/var/rrd"}'
+Debug: Finishing transaction 69859760156920
+Debug: Received report to process from centos6.internal.salesforce.com
+Debug: Processing report from centos6.internal.salesforce.com with processor Puppet::Reports::Store

data/test/unit/puppet/test_puppet_parsing.rb

@@ -0,0 +1,44 @@
+require sprintf('%s/../../../path_helper', File.dirname(File.expand_path(__FILE__)))
+
+require 'rouster'
+require 'rouster/puppet'
+require 'test/unit'
+
+# this is a unit test, no need for a real Rouster VM
+
+class TestGetPuppetStar < Test::Unit::TestCase
+
+  def setup
+    assert_nothing_raised do
+      @app = Rouster.new(:name => 'app', :unittest => true)
+    end
+
+    # expose private methods
+    Rouster.send(:public, *Rouster.protected_instance_methods)
+  end
+
+  def test_with_successful_exec
+    title = 'foo'
+    input = File.read(sprintf('%s/../../../test/unit/puppet/resources/puppet_run_with_successful_exec', File.dirname(File.expand_path(__FILE__))))
+
+
+    assert(@app.did_exec_fire?(title, input))
+  end
+
+  def test_with_failed_exec
+    title = 'bar'
+    input = File.read(sprintf('%s/../../../test/unit/puppet/resources/puppet_run_with_failed_exec', File.dirname(File.expand_path(__FILE__))))
+
+    assert(@app.did_exec_fire?(title, input))
+  end
+
+  def test_looking_for_nonexistent_exec
+    title = 'fizzbang'
+    input = File.read(sprintf('%s/../../../test/unit/puppet/resources/puppet_run_with_successful_exec', File.dirname(File.expand_path(__FILE__))))
+
+    assert_false(@app.did_exec_fire?(title, input))
+  end
+
+
+end
+

data/test/unit/testing/test_validate_port.rb

@@ -91,6 +91,11 @@ class TestValidatePort < Test::Unit::TestCase
 
   end
 
+  def test_negative_port_dne
+    assert_equal(false, @app.validate_port(4567, { :ensure => true, :address => '*' }))
+    assert_equal(false, @app.validate_port(4567, { :ensure => true, :address => '127.0.0.1' }))
+  end
+
   def teardown
     # noop
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rouster
 version: !ruby/object:Gem::Version
-  version: '0.62'
+  version: '0.63'
 platform: ruby
 authors:
 - Conor Horan-Kates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-14 00:00:00.000000000 Z
+date: 2016-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -141,6 +141,7 @@ files:
 - test/basic.rb
 - test/functional/deltas/test_get_crontab.rb
 - test/functional/deltas/test_get_groups.rb
+- test/functional/deltas/test_get_os.rb
 - test/functional/deltas/test_get_packages.rb
 - test/functional/deltas/test_get_ports.rb
 - test/functional/deltas/test_get_services.rb
@@ -172,7 +173,10 @@ files:
 - test/puppet/modules/role/manifests/ui.pp
 - test/puppet/test_apply.rb
 - test/tunnel_vs_scp.rb
+- test/unit/puppet/resources/puppet_run_with_failed_exec
+- test/unit/puppet/resources/puppet_run_with_successful_exec
 - test/unit/puppet/test_get_puppet_star.rb
+- test/unit/puppet/test_puppet_parsing.rb
 - test/unit/test_generate_unique_mac.rb
 - test/unit/test_new.rb
 - test/unit/test_parse_ls_string.rb
@@ -209,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: Rouster
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Rouster is an abstraction layer for Vagrant