roust 1.7.1 → 1.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c102bb99b7d456ca07bf00247fbaa73bb59d478f
-  data.tar.gz: b27166baced2282c39f4abb164852e865815c88c
+  metadata.gz: d0fd7ec9d960d69cac7e4728a7fed55ee4cdd0bb
+  data.tar.gz: 170095fffdbaf6911552314acda4cd04f71698fb
 SHA512:
-  metadata.gz: e305f5117a6a07a034699cf5644362c05815bc7d903041ea4325cc652164d12101348f876dbf4b5970712880244fe0f021ba822393f450bc53f8ec392d54bffb
-  data.tar.gz: b646a7d5c1fcd8e5614292f575964a2b89d16204e6ac38a54a7eb207bb6cb364cdbc437662aec048c25adca1ce4e95560336927391b8312d9bd0c3f6d7b4451e
+  metadata.gz: f986a4c50c33eb97157162d367e5ecfc9273c572146d3fa429dca28a4346bf88fbe14c03ff24f679534c9af560cf67ff80246fcecf84054c5d0557f5ea62154a
+  data.tar.gz: 419951703eaad4a2813cad671f50710f87da264981b4de72e92b0cbd85b5d05e4f69a5a408cbec10f138e3f4cfff8eda231336eaf872df45f0d4962d635be8c3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    roust (1.7.1)
+    roust (1.7.2)
       activesupport (>= 4.1.0)
       httparty (>= 0.13.1)
       mail (>= 2.5.4)
@@ -43,18 +43,18 @@ GEM
       slop (~> 3.4)
     rainbow (2.0.0)
     rake (10.1.0)
-    rspec (3.0.0)
-      rspec-core (~> 3.0.0)
-      rspec-expectations (~> 3.0.0)
-      rspec-mocks (~> 3.0.0)
-    rspec-core (3.0.2)
-      rspec-support (~> 3.0.0)
-    rspec-expectations (3.0.2)
+    rspec (3.1.0)
+      rspec-core (~> 3.1.0)
+      rspec-expectations (~> 3.1.0)
+      rspec-mocks (~> 3.1.0)
+    rspec-core (3.1.1)
+      rspec-support (~> 3.1.0)
+    rspec-expectations (3.1.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.0.0)
-    rspec-mocks (3.0.2)
-      rspec-support (~> 3.0.0)
-    rspec-support (3.0.2)
+      rspec-support (~> 3.1.0)
+    rspec-mocks (3.1.0)
+      rspec-support (~> 3.1.0)
+    rspec-support (3.1.0)
     rubocop (0.24.1)
       json (>= 1.7.7, < 2)
       parser (>= 2.2.0.pre.3, < 3.0)

data/lib/roust/ticket.rb

@@ -25,7 +25,8 @@ class Roust
       #
       # Delete it from the ticket we are creating, and we'll update the ticket
       # after we've created.
-      admincc = attrs.delete('AdminCc')
+      key, admincc = attrs.detect {|k,v| k =~ /admincc/i }
+      attrs.delete(key)
 
       content = compose_content('ticket', attrs['id'], attrs)
 
@@ -43,10 +44,10 @@ class Roust
         id = $1
         # Add the AdminCc after the ticket is created, because we can't set it
         # on ticket creation.
-        update(id, 'AdminCc' => admincc) if admincc
+        ticket_update(id, 'AdminCc' => admincc) if admincc
 
         # Return the whole ticket, not just the id.
-        show(id)
+        ticket_show(id)
       when /^# Could not create ticket/
         raise BadRequest, body
       when /^# Syntax error/
@@ -71,7 +72,7 @@ class Roust
         case body
         when /^# Ticket (\d+) updated/
           id = $1
-          show(id)
+          ticket_show(id)
         when /^# You are not allowed to modify ticket \d+/
           raise Unauthorized, body
         when /^# Syntax error/
@@ -175,6 +176,9 @@ class Roust
       end
     end
 
+    # parse_ticket_attributes decodes a response body of ticket metadata.
+    #
+    # Used by ticket_show and verbose ticket_search.
     def parse_ticket_attributes(body)
       # Replace CF spaces with underscores
       while body.match(/CF\.\{[\w_ ]*[ ]+[\w ]*\}/)

data/lib/roust/version.rb

@@ -1,3 +1,3 @@
 class Roust
-  VERSION = '1.7.1'
+  VERSION = '1.7.2'
 end

data/lib/roust.rb

@@ -87,6 +87,7 @@ class Roust
             k
           end
 
+      k = sanitize_content_key(k)
       v = v.join(', ') if v.respond_to?(:join)
 
       "#{k}: #{v}"
@@ -95,6 +96,19 @@ class Roust
     content.join("\n")
   end
 
+  def sanitize_content_key(k)
+    case k.downcase
+    when 'requestors'
+      'Requestors'
+    when 'cc'
+      'Cc'
+    when 'admincc'
+      'AdminCc'
+    else
+      k
+    end
+  end
+
   # explode_response separates RT's response content from the response status.
   #
   # All HTTP-level response codes from RT are a lie. The only way to check if

data/spec/mocks/ticket-100-show.txt

@@ -0,0 +1,19 @@
+RT/3.4.6 200 Ok
+
+id: ticket/100
+Queue: sales
+Subject: test ticket
+Status: new
+Priority: 101
+InitialPriority: 101
+FinalPriority: 100
+Created: Tue Dec 11 07:59:31 2012
+Starts: Not set
+Started: Not set
+Due: Wed Dec 12 20:58:48 2012
+Resolved: Wed Jan 16 16:33:15 2013
+Told: Mon Jan 07 15:27:09 2013
+LastUpdated: Wed Nov 06 09:33:43 2013
+TimeEstimated: 0
+TimeWorked: 12 hours
+TimeLeft: 0

data/spec/mocks/ticket-100-update.txt

@@ -0,0 +1,4 @@
+RT/3.4.6 200 Ok
+
+# Ticket 100 updated.
+

data/spec/roust/ticket_spec.rb

@@ -50,6 +50,21 @@ describe Roust do
                  :body    => mocks_path.join('ticket-99-show.txt').read,
                  :headers => {})
 
+    stub_request(:post, "http://rt.example.org/REST/1.0/ticket/100/edit")
+      .with { |request|
+        query = WebMock::Util::QueryMapper.query_to_values(request.body)
+        require 'pry'
+
+        true
+      }.to_return(:status => 200,
+                  :body    => mocks_path.join('ticket-100-update.txt').read,
+                  :headers => {})
+
+    stub_request(:get, 'http://rt.example.org/REST/1.0/ticket/100/show')
+      .to_return(:status  => 200,
+                 :body    => mocks_path.join('ticket-100-show.txt').read,
+                 :headers => {})
+
     @rt = Roust.new(credentials)
     expect(@rt.authenticated?).to eq(true)
   end
@@ -153,5 +168,22 @@ describe Roust do
         expect(ticket[k]).to eq(v)
       end
     end
+
+    it 'transforms attribute case when creating or updating tickets' do
+      attrs = {
+        'requestors' => 'alice@them.example,bob@them.example',
+        'cc'         => 'charlie@them.example',
+        'admincc'    => 'daisy@us.example,eleanor@us.example',
+      }
+      ticket = @rt.ticket_update(100, attrs)
+
+      expect(WebMock).to have_requested(:post, "rt.example.org/REST/1.0/ticket/100/edit")
+        .with { |request|
+          query = WebMock::Util::QueryMapper.query_to_values(request.body)
+          query['content'] =~ /Requestors:/ &&
+          query['content'] =~ /Cc:/ &&
+          query['content'] =~ /AdminCc:/
+        }
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roust
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.7.2
 platform: ruby
 authors:
 - Lindsay Holmwood
@@ -84,6 +84,8 @@ files:
 - spec/mocks/ticket-1-history-short.txt
 - spec/mocks/ticket-1-show-unauthenticated.txt
 - spec/mocks/ticket-1-show.txt
+- spec/mocks/ticket-100-show.txt
+- spec/mocks/ticket-100-update.txt
 - spec/mocks/ticket-3-links.txt
 - spec/mocks/ticket-99-show.txt
 - spec/mocks/ticket-create.txt
@@ -132,6 +134,8 @@ test_files:
 - spec/mocks/ticket-1-history-short.txt
 - spec/mocks/ticket-1-show-unauthenticated.txt
 - spec/mocks/ticket-1-show.txt
+- spec/mocks/ticket-100-show.txt
+- spec/mocks/ticket-100-update.txt
 - spec/mocks/ticket-3-links.txt
 - spec/mocks/ticket-99-show.txt
 - spec/mocks/ticket-create.txt