rotp 1.3.2 → 1.3.3

data/README.markdown

@@ -71,6 +71,15 @@ Now run the following and compare the output
     totp = ROTP::TOTP.new("JBSWY3DPEHPK3PXP")
     p "Current OTP: #{totp.now}"
 
+### Contributors
+
+    git shortlog -s -n
+
+        31  Mark Percival
+         3  David Vrensk
+         1  Micah Gates
+         1  Nathan Reynolds
+
 ### Changelog
 
 ####1.3.0

data/lib/rotp/hotp.rb

@@ -11,7 +11,7 @@ module ROTP
     # @param [String/Integer] otp the OTP to check against
     # @param [Integer] counter the counter of the OTP
     def verify(otp, counter)
-      otp == self.at(counter)
+      super(otp, self.at(counter))
     end
 
     # Returns the provisioning URI for the OTP

data/lib/rotp/otp.rb

@@ -36,6 +36,10 @@ module ROTP
 
     private
 
+    def verify(input, generated)
+      input.to_i == generated
+    end
+
     def byte_secret
       Base32.decode(@secret)
     end

data/lib/rotp/totp.rb

@@ -29,7 +29,7 @@ module ROTP
     # Verifies the OTP passed in against the current time OTP
     # @param [String/Integer] otp the OTP to check against
     def verify(otp, time = Time.now)
-      otp == self.at(time)
+      super(otp, self.at(time))
     end
 
     # Returns the provisioning URI for the OTP

data/lib/rotp/version.rb

@@ -1,3 +1,3 @@
 module ROTP
-  VERSION = "1.3.2"
+  VERSION = "1.3.3"
 end

data/rotp.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.email       = ["mark@markpercival.us"]
   s.homepage    = "http://github.com/mdp/rotp"
   s.summary     = %q{A Ruby library for generating and verifying one time passwords}
-  s.description = %q{Works for both HOTP and TOTP, and include QR Code provisioning}
+  s.description = %q{Works for both HOTP and TOTP, and includes QR Code provisioning}
 
   s.rubyforge_project = "rotp"
 

data/spec/base_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe "generating a random base32 secret" do
   it "should be 16 characters by default" do
     ROTP::Base32.random_base32.length.should == 16
-    ROTP::Base32.random_base32.should match /[a-z2-7].+/
+    ROTP::Base32.random_base32.should match /\A[a-z2-7]+\z/
   end
   it "should be allow a specific length" do
     ROTP::Base32.random_base32(32).length.should == 32

data/spec/hotp_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe ROTP::HOTP do
+  before(:all) { @now = Time.utc(2012,1,1).to_i / 30 }
+
+  subject { ROTP::HOTP.new('a' * 32) }
+
+  it "should generate a number given a time" do
+    subject.at(@now).should == 160864
+  end
+  it "should verify a number" do
+    subject.verify(160864, @now).should be_true
+  end
+  it "should verify a string" do
+    subject.verify("160864", @now).should be_true
+  end
+end

data/spec/totp_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe ROTP::TOTP do
+  before(:all) { @now = Time.utc(2012,1,1) }
+
+  subject { ROTP::TOTP.new('a' * 32) }
+
+  it "should generate a number given a number" do
+    subject.at(@now).should == 160864
+  end
+  it "should verify a number" do
+    subject.verify(160864, @now).should be_true
+  end
+  it "should verify a string" do
+    subject.verify("160864", @now).should be_true
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rotp
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 29
   prerelease: 
   segments: 
   - 1
   - 3
-  - 2
-  version: 1.3.2
+  - 3
+  version: 1.3.3
 platform: ruby
 authors: 
 - Mark Percival
@@ -15,11 +15,10 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-10-04 00:00:00 -07:00
-default_executable: 
+date: 2012-05-19 00:00:00 Z
 dependencies: []
 
-description: Works for both HOTP and TOTP, and include QR Code provisioning
+description: Works for both HOTP and TOTP, and includes QR Code provisioning
 email: 
 - mark@markpercival.us
 executables: []
@@ -61,8 +60,9 @@ files:
 - lib/rotp/version.rb
 - rotp.gemspec
 - spec/base_spec.rb
+- spec/hotp_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
+- spec/totp_spec.rb
 homepage: http://github.com/mdp/rotp
 licenses: 
 - MIT
@@ -92,10 +92,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: rotp
-rubygems_version: 1.6.2
+rubygems_version: 1.8.18
 signing_key: 
 specification_version: 3
 summary: A Ruby library for generating and verifying one time passwords
 test_files: 
 - spec/base_spec.rb
+- spec/hotp_spec.rb
 - spec/spec_helper.rb
+- spec/totp_spec.rb