roqua-support 0.1.22 → 0.1.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f36e6f001b52313927d2d638351d0b1f866de9a5
-  data.tar.gz: 72f97499903a15087ae6c1a503fcafb5c378de5f
+  metadata.gz: 2fb464998141d4c9bb13d54f8f903ea3dade2033
+  data.tar.gz: f45098dde3b0074ed78f7fa6ef645994cf43fa4b
 SHA512:
-  metadata.gz: 031b4f77a3cc0b9299e91b756bc601fdb873f1c2219e4f6e44ddd226bfe2db24264234c8a4420bce7f9de9af9d196081baa318e687e1a04959bb87cb87289260
-  data.tar.gz: a0f94165908da53045baf2c24707f3e9a06efb187a4fec939d64bc2f824e9b3da69d2aa0bd696a7a866f36ef16bebc1d14942b4f9424d1ec9de1f5d13753d532
+  metadata.gz: d16e482e6b371dd978c1dc590fa68fccb4dba5cbee9feff21c14fa2243d1cbfe3086cbf79df19c7addbad1d8f91b450055d6ccfbe9edb29f870cb3089cc3a8c3
+  data.tar.gz: 2d2b82cc4ff8e703c883b14bb1ec1c1429a8ba498d8713ff306c31e8009483f8200063fc04b3b8ec17a0806c54b0aa565c16cf6549845fbdfaea4cefa723d9a8

data/.gitlab-ci.yml

@@ -0,0 +1,21 @@
+image: "roqua/roqua-build-images:ruby-2.3.3-phantomjs-2.1.1-bundler-gemnasium"
+
+variables:
+  RAILS_ENV: "test"
+  
+before_script:
+  - bundle install
+  - gem install appraisal
+  - bundle exec appraisal
+
+rails_41:
+  script:
+    - bundle exec appraisal rails41 bundle exec rspec
+
+rails_42:
+  script:
+    - bundle exec appraisal rails42 bundle exec rspec
+
+rails_50:
+  script:
+    - bundle exec appraisal rails50 bundle exec rspec

data/Gemfile.lock

@@ -1,10 +1,11 @@
 PATH
   remote: .
   specs:
-    roqua-support (0.1.22)
+    roqua-support (0.1.23)
       active_interaction (~> 3.0)
       activesupport (>= 3.2, < 6)
       naught (~> 1.0)
+      rubocop (~> 0.49.1)
 
 GEM
   remote: https://rubygems.org/
@@ -35,6 +36,7 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
+    ast (2.3.0)
     builder (3.2.3)
     coderay (1.1.1)
     combustion (0.5.5)
@@ -76,6 +78,10 @@ GEM
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
+    parallel (1.11.2)
+    parser (2.4.0.0)
+      ast (~> 2.2)
+    powerpack (0.1.1)
     pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
@@ -94,6 +100,8 @@ GEM
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
+    rainbow (2.2.2)
+      rake
     rake (12.0.0)
     rb-fsevent (0.9.8)
     rb-inotify (0.9.7)
@@ -124,6 +132,14 @@ GEM
       rspec-mocks (~> 3.5.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
+    rubocop (0.49.1)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
     ruby_dep (1.5.0)
     shellany (0.0.1)
     slop (3.6.0)
@@ -131,6 +147,7 @@ GEM
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
+    unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
@@ -142,7 +159,7 @@ DEPENDENCIES
   bundler (~> 1.0)
   combustion (~> 0.5.2)
   guard-rspec (~> 4.2.6)
-  rake
+  rake (~> 12)
   responders
   roqua-support!
   rspec (>= 2.12.0, < 4.0)
@@ -150,4 +167,4 @@ DEPENDENCIES
   rspec-rails
 
 BUNDLED WITH
-   1.13.7
+   1.15.3

data/lib/roqua-support/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module Support
-    VERSION = '0.1.22'.freeze
+    VERSION = '0.1.23'.freeze
   end
 end

data/roqua-support.gemspec

@@ -22,7 +22,12 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'naught', '~> 1.0'
   gem.add_dependency 'active_interaction', '~> 3.0'
 
+  # We can't start the shared Rubocop file with .rubocop because of a bug related to inherit_gem.
+  # For more details:
+  # https://github.com/bbatsov/rubocop/issues/4154
+  gem.add_dependency 'rubocop', '~> 0.49.1'
+
   gem.add_development_dependency 'bundler', '~> 1.0'
-  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rake', '~> 12'
   gem.add_development_dependency 'rspec', '>= 2.12.0', '< 4.0'
 end

data/rubocop-rails-4.yml

@@ -0,0 +1,8 @@
+inherit_from:
+  - rubocop.yml
+
+Rails:
+  Enabled: true
+
+Rails/ApplicationRecord:
+  Enabled: false

data/rubocop-rails-5.yml

@@ -0,0 +1,5 @@
+inherit_from:
+  - rubocop.yml
+
+Rails:
+  Enabled: true

data/rubocop.yml

@@ -0,0 +1,218 @@
+# We can't start the shared Rubocop file with .rubocop because of a bug in combination with inherit_gem.
+# For more details:
+# https://github.com/bbatsov/rubocop/issues/4154
+
+AllCops:
+  TargetRubyVersion: 2.3
+  Exclude:
+    - 'bin/**/*'
+    - 'config/**/*'
+    - 'db/schema.rb'
+    - 'db/seeds/**/*'
+    - 'local/*'
+    - 'script/**/*'
+    - 'tmp/**/*'
+    - 'vendor/**/*'
+
+# ==================================== SECURITY ===========================================================================
+
+# Never ever use `Kernel#eval`. This however is handy in Guardfile.
+Security/Eval:
+  Enabled: true
+  Exclude:
+    - '**/Guardfile'
+
+# ==================================== LINT ===========================================================================
+
+# Explicit block alignment
+Lint/BlockAlignment:
+  Enabled: true
+  Exclude:
+    - 'spec/**/*'
+
+# Useless assignments are just useless. In specs however they lead to a better
+# understanding of what is being stubbed/factoried.
+Lint/UselessAssignment:
+  Enabled: true
+  Exclude:
+    - 'spec/**/*'
+
+Lint/AmbiguousBlockAssociation:
+  Enabled: true
+  Exclude:
+    - 'spec/**/*'
+
+# ==================================== METRICS ========================================================================
+
+# Set this to 10, forcing future methods to be not that complex. Skipping some
+# existing helper methods that are better off to be not refactored.
+# Note: used comments like
+#   # rubocop:disable CyclomaticComplexity
+#   [code]
+#   # rubocop:enable CyclomaticComplexity
+# to skip this check
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+# Limit lines to 120 characters.
+Metrics/LineLength:
+  Max: 120
+
+Metrics/ClassLength:
+  Max: 300 # As long as they're simple.
+
+Metrics/ModuleLength:
+  Exclude:
+    - 'spec/**/*'
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+
+# ==================================== STYLE ==========================================================================
+
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%i': ()
+    '%I': ()
+
+# Use do-end for multiline blocks and {} for single lines
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
+Style/BlockDelimiters:
+  Exclude:
+    - 'spec/**/*'
+
+Style/WordArray:
+  MinSize: 5
+  Exclude:
+    - 'spec/**/*'
+
+# ==================================== LAYOUT ==============================================
+
+# defs stick to each other is just unpretty. Turning this on for general code,
+# but still allowing testing/mocking one-line exceptions
+Layout/EmptyLineBetweenDefs:
+  Enabled: true
+  AllowAdjacentOneLineDefs: true
+
+# Intenting hash properly will provide a better code readablity. However there
+# some exceptions. For example defining validations in Rails models or stubbing
+# in a new rspec way with allows and expects.
+Layout/IndentHash:
+  Enabled: true
+  Exclude:
+    # Cause models can have very long validation definitions which we'd rather
+    # format in a readable to us manner.
+    - 'app/models/**/*'
+    # Also skipping spec files as the new allow/expect syntax of rspec can
+    # become bulky.
+    - 'spec/**/*'
+
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+  Enabled: true
+
+# ================================ DISABLED COPS ======================================================================
+
+# These cops are disabled because we think they are a Bad Idea. If you add one
+# here, make sure to add a comment describing what the cop does, and why this
+# is a bad idea.
+
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+Style/SymbolArray:
+  Enabled: false
+
+# Max 4 of parameters per method seems fair. Don't count keyword arguments though.
+Metrics/ParameterLists:
+  Max: 4
+  CountKeywordArgs: false
+
+# Use UTF-8 as the source file encoding.
+Style/Encoding:
+  Enabled: false
+
+# Avoid methods longer than 16 lines of code
+Metrics/MethodLength:
+  CountComments: false  # count full line comments?
+  Max: 16
+
+# When using \ for string concatenation line indents cause undesired whitespace in the string
+Style/LineEndConcatenation:
+  Enabled: false
+
+# Forces the argument names of the block given to #reduce to be `a, e`. Only
+# applies on single-line blocks, but why would we want to force people to use
+# less descriptive names?
+Style/SingleLineBlockParams:
+  Enabled: false
+
+# Complains than multiline ternary expressions should be if/else statements
+# Ternary are still often more readable.
+Style/MultilineTernaryOperator:
+  Enabled: false
+
+# disallows `class Quby::Items::Text` style definitions.
+# Why waste all that indentation?
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+# This is not universally a better idea, it depends greatly on whether the
+# condition is to handle an edge-case or not. We prefer leaving this up to
+# code review instead of Rubocop.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Use single quotes for strings that don't do string interpolation. Makes it
+# harder to later add an interpolated value.
+Style/StringLiterals:
+  Enabled: false
+
+# This forces the use of the English library instead of $: etc. We think that some
+# of these Perl-vars are quite succinct.
+Style/SpecialGlobalVars:
+  Enabled: false
+
+# This forces the use of %r{.. } when a regexp contains more than one slash.
+# If a regex is unreadable, code review will catch it, otherwise it's not
+# a function of how many slashes are in it.
+Style/RegexpLiteral:
+  Enabled: false
+
+# Do not agree on this one as Block Chains can be used to query/narrow/scope
+# the results. As we chain them, the query is easier to read and understand.
+Style/MultilineBlockChain:
+  Enabled: false
+
+# We do not want to force adding underscores between every 3 digits
+Style/NumericLiterals:
+  Enabled: false
+
+# Ruby provides a beautiful way to set and get the values. By setting
+# `attr_accessor :foo` provides us with `def foo=(foo)` and `def foo` which can
+# be used to set and get the value of `foo`. Using get_ and set_ `works around`
+# this idiom.
+#
+# Argumentation: We do not want Rubocop to enforce this style. Sometimes methods
+# starting with `get_` or `set_` provide better readability and understanding of code
+Style/AccessorMethodName:
+  Enabled: false
+
+# This forces comments to align with the code.
+# But like to indent stories to the right and indent multiline comments with the itself.
+Layout/CommentIndentation:
+  Enabled: false
+
+# This requires having multiline assignment values start on the same indentation level,
+# which is inconsistent with out standard for params methods, i.e.:
+# params.require(:foo)
+#       .permit(:bar)
+# disabled until https://github.com/bbatsov/rubocop/issues/1633 https://github.com/bbatsov/rubocop/pull/2493 has been fixed
+Layout/MultilineOperationIndentation:
+  Enabled: false
+
+# There is no good alternative for when you want to explicitly cast
+# a value to an actual boolean, which for JSON APIs is desirable.
+DoubleNegation:
+  Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-support
 version: !ruby/object:Gem::Version
-  version: 0.1.22
+  version: 0.1.23
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-26 00:00:00.000000000 Z
+date: 2017-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -58,6 +58,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.49.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.49.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -76,16 +90,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -113,6 +127,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".gitlab-ci.yml"
 - ".rspec"
 - ".travis.yml"
 - Appraisals
@@ -149,6 +164,9 @@ files:
 - lib/roqua/support/stats/hosted_graphite_backend.rb
 - lib/roqua/validators/subset_validator.rb
 - roqua-support.gemspec
+- rubocop-rails-4.yml
+- rubocop-rails-5.yml
+- rubocop.yml
 - spec/roqua/core_ext/active_interaction/date_time_as_unix_extension_spec.rb
 - spec/roqua/core_ext/active_interaction/duration_filter_spec.rb
 - spec/roqua/core_ext/active_interaction/rails_intrumentation_spec.rb