roqua-support 0.1.10 → 0.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 548055897fac03f26d5dddd82f144fa64d34d813
-  data.tar.gz: f497700a4fffb165d1b8b9a8d5ddc486bd77c841
+  metadata.gz: c0d83dcfdd5a8666dbfa15efa42dc41bc1286944
+  data.tar.gz: f4c169d8f8b96e4b578e4808c7212b0cb2ee1495
 SHA512:
-  metadata.gz: c8936bf834d18d7799e200de067c5739132b617c1aaf9e5cfe5fb44d2734ea277abad62ee3d7ecf7a60df0429b803919c757c1e9191fc8fcb02fe7726570b831
-  data.tar.gz: 6040338582c978cd5b0b00ff7d3bffdf728862c3551af1d7d517f579e57d3edb515d813c41ac9cab8b3acbb9c9247386d9514d1638b3599643b5394c1b991609
+  metadata.gz: a11b436cc2a870c201ec997a5e23f6d47148b54d9ce5978fc08b5ef248db4382de8e2d2c9b440085249b3b978123bb6bb21d7db3b41995f93d2a9777c0687069
+  data.tar.gz: 5de99e2f313f6c21e70f938db3d79ad0533dc025006cc8f57d6e8d69adb18a4ffd1917bb2adbf97cd3fb53137ac188df88c8d01126ed81201ed3fa51196bdce4

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.11 / 2014-11-06
+
+* Don't catch Mysql2 errors
+
 ## 0.1.10 / 2014-10-30
 
 * Added ActiveInteractionAwareResponder

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    roqua-support (0.1.9)
+    roqua-support (0.1.11)
       activesupport (>= 3.2, < 5.0)
 
 GEM

data/lib/roqua-support/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module Support
-    VERSION = "0.1.10"
+    VERSION = '0.1.11'
   end
 end

data/lib/roqua/core_ext/activerecord/uniq_find_or_create.rb

@@ -9,12 +9,6 @@ module ActiveRecord
     # containing the validation errors is returned instead.
     def self.uniq_find_or_create_by(attributes, &block)
       find_or_create_by(attributes, &block)
-    # When a real race condition occurs, activerecord has no clue about a uniqueness constraint
-    # being violated (this is exactly why validates :attribute, uniqueness: true does not work
-    # for these cases) and a plain Mysql2::Error exception is raised instead of
-    # ActiveRecord::RecordNotUnique
-    rescue Mysql2::Error => exception
-      find_by(attributes) || raise(exception)
     rescue ActiveRecord::RecordNotUnique => exception
       find_by(attributes) || raise(exception)
     end
@@ -23,12 +17,6 @@ module ActiveRecord
     # error other than uniqueness.
     def self.uniq_find_or_create_by!(attributes, &block)
       find_or_create_by!(attributes, &block)
-    # When a real race condition occurs, activerecord has no clue about a uniqueness constraint
-    # being violated (this is exactly why validates :attribute, uniqueness: true does not work
-    # for these cases) and a plain Mysql2::Error exception is raised instead of
-    # ActiveRecord::RecordNotUnique
-    rescue Mysql2::Error => exception
-      find_by(attributes) || raise(exception)
     rescue ActiveRecord::RecordNotUnique => exception
       find_by(attributes) || raise(exception)
     rescue ActiveRecord::RecordInvalid => exception

data/spec/roqua/core_ext/activerecord/uniq_find_or_create_spec.rb

@@ -13,11 +13,6 @@ module ActiveRecord
   end
 end
 
-module Mysql2
-  class Error < StandardError
-  end
-end
-
 describe ActiveRecord::Base do
   let(:attributes) { double('attributes') }
   let(:block)      { -> (*args){} }
@@ -41,13 +36,6 @@ describe ActiveRecord::Base do
       expect(ActiveRecord::Base.uniq_find_or_create_by attributes, &block).to eq(record)
     end
 
-    it 'returns a concurrenlty created record when activerecord is unaware of the uniqueness violation' do
-      allow(ActiveRecord::Base).to receive(:find_by).with(attributes).and_return record
-      allow(ActiveRecord::Base).to receive(:find_or_create_by).with(attributes, &block)
-                                                              .and_raise Mysql2::Error
-      expect(ActiveRecord::Base.uniq_find_or_create_by attributes, &block).to eq(record)
-    end
-
     it 'raises when a concurrent record is detected by the database but could not be queried for unknown reasons' do
       allow(ActiveRecord::Base).to receive(:find_by).with(attributes).and_return nil
       allow(ActiveRecord::Base).to receive(:find_or_create_by).with(attributes, &block)
@@ -82,13 +70,6 @@ describe ActiveRecord::Base do
       expect(ActiveRecord::Base.uniq_find_or_create_by! attributes, &block).to eq(record)
     end
 
-    it 'returns a concurrenlty created record when activerecord is unaware of the uniqueness violation' do
-      allow(ActiveRecord::Base).to receive(:find_by).with(attributes).and_return record
-      allow(ActiveRecord::Base).to receive(:find_or_create_by!).with(attributes, &block)
-                                                               .and_raise Mysql2::Error
-      expect(ActiveRecord::Base.uniq_find_or_create_by! attributes, &block).to eq(record)
-    end
-
     it 'raises when a concurrent record is detected by the database but could not be queried for unknown reasons' do
       allow(ActiveRecord::Base).to receive(:find_by).with(attributes).and_return nil
       allow(ActiveRecord::Base).to receive(:find_or_create_by!).with(attributes, &block)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-support
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.11
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-30 00:00:00.000000000 Z
+date: 2014-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -143,7 +143,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.3.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Helper objects and proxies used by a lot of RoQua applications
@@ -160,4 +160,3 @@ test_files:
 - spec/roqua/support/request_logger_spec.rb
 - spec/roqua/support_spec.rb
 - spec/spec_helper.rb
-has_rdoc: