roqua-healthy 1.4.3 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9671caf50e1efc23c7bf188c74fc55d5898c1a16
-  data.tar.gz: ad836d232fc0c15c81b866b3953eefd42f92e13d
+  metadata.gz: f3959d17316a51405355769df7a3bd596599676b
+  data.tar.gz: 4d4192a2c29410a69420e98e611c9c56ab590e3d
 SHA512:
-  metadata.gz: cb328e0dc13e579ec37a399aee4811d251703830693048d135eb6557313eb9847c16167a8289d0f4df51df951d7a91a02569f5aec6c7044c26efbd93137cb861
-  data.tar.gz: 920ee8298069a93fe883f13d882f9ed07ba4f2a3010bfc3e61c45eaaf99fa43b5adf0b61bcad8cfa268e68812e470c0b3bd9fc8f865330d5eefe2795340ecc1a
+  metadata.gz: 9977ba10cb3b7b6f267231f8f910713fb989614019d6d44b4cc2c09e6ca9671924b80373c30e33a78d331dae3599dd2761a2005fefa1cebba5c389220eac9df9
+  data.tar.gz: 7241aae05b61c2f276f86ba5ce34c24b3abd8ee788084ac1e7cd746788ef7469be58643084dd25c4790e0e8087a9fc704c680599e1296b266fede1a88f57a205

data/.gitignore

@@ -8,3 +8,4 @@ pkg/
 tmp/
 vendor/cache/*.gem
 tmp/rspec_guard_result
+coverage/

data/.rubocop.yml

@@ -22,3 +22,11 @@ MethodLength:
 
 SignalException:
   Enabled: False
+
+Style/EmptyLineAfterMagicComment:
+  Enabled: False
+
+Style/FileName:
+  Exclude:
+    - Appraisals
+

data/Appraisals

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 appraise "rails41" do
   gem "activesupport", "4.1"
 end

data/README.md

@@ -15,6 +15,13 @@ client = Healthy::A19::Client(a19_endpoint: 'https://...')
 client.fetch_a19(patient_identifier)
 ```
 
+or if the server you connect to needs http basic authentication:
+
+```ruby
+client = Healthy::A19::Client(a19_endpoint: 'https://...', a19_username: 'foo', a19_password: 'bar')
+client.fetch_a19(patient_identifier)
+```
+
 ### Adding integration tests
 
 If you find any A19 response that Healthy currently does not handle correctly, please add a fixture and integration test for it.

data/bin/parse_local_xml

@@ -5,6 +5,6 @@ require 'roqua_healthy'
 require 'pp'
 
 body    = ARGF.read
-message = Hash.from_xml(body).fetch("HL7Message") { Hash.new }
+message = Hash.from_xml(body).fetch("HL7Message", {})
 
 pp Roqua::Healthy::A19::Transformer.new(message).to_patient

data/lib/roqua/healthy/a19/fetcher.rb

@@ -27,6 +27,7 @@ module Roqua
         def mirth_response
           Net::HTTP.start(remote_url.host, remote_url.port, use_ssl: use_ssl?) do |http|
             request = Net::HTTP::Post.new(remote_url.path)
+            request.basic_auth(@client.a19_username, @client.a19_password) if @client.use_basic_auth?
             request.set_form_data(mirth_params)
             http.request request
           end

data/lib/roqua/healthy/a19/response_validator.rb

@@ -36,7 +36,7 @@ module Roqua
           case response_code
           when '200'
             validate_200
-          when '403'
+          when '401', '403'
             validate_403
           when '404'
             validate_404

data/lib/roqua/healthy/client.rb

@@ -4,16 +4,22 @@ module Roqua
     class Client
       include ::Roqua::Support::Instrumentation
 
-      attr_accessor :a19_endpoint
+      attr_accessor :a19_endpoint, :a19_username, :a19_password
 
       def initialize(options = {})
         @a19_endpoint = options[:a19_endpoint]
+        @a19_username = options[:a19_username]
+        @a19_password = options[:a19_password]
       end
 
       def a19_endpoint
         @a19_endpoint || Roqua::Healthy.a19_endpoint
       end
 
+      def use_basic_auth?
+        @a19_username.present? || @a19_password.present?
+      end
+
       def fetch_a19(patient_id)
         with_instrumentation 'hl7.a19', patient_id: patient_id do
           message = A19::Fetcher.new(patient_id, self).fetch

data/lib/roqua/healthy/version.rb

@@ -2,6 +2,6 @@
 module Roqua
   module Healthy
     # healthy version
-    VERSION = "1.4.3"
+    VERSION = "1.5.0"
   end
 end

data/spec/unit/a19/fetcher_spec.rb

@@ -67,6 +67,11 @@ describe Roqua::Healthy::A19::Fetcher do
     expect { subject.fetch }.to raise_exception(Roqua::Healthy::Timeout)
   end
 
+  it 'raises when upstream authentication fails' do
+    stub_mirth_response "<failure><error>Unauthorized</error></failure>", 401
+    expect { subject.fetch }.to raise_exception(Roqua::Healthy::AuthenticationFailure)
+  end
+
   it 'saves the client' do
     expect(subject.client).to eq client
   end

data/spec/unit/client_spec.rb

@@ -3,9 +3,18 @@ require 'spec_helper'
 
 describe Roqua::Healthy::Client do
   context 'fully configured client' do
-    subject { Roqua::Healthy::Client.new(a19_endpoint: 'http://a19_endpoint.dev') }
+    subject do
+      Roqua::Healthy::Client.new(
+        a19_endpoint: 'http://a19_endpoint.dev',
+        a19_username: 'foo',
+        a19_password: 'bar'
+      )
+    end
 
     it { expect(subject.a19_endpoint).to eq 'http://a19_endpoint.dev' }
+    it { expect(subject.a19_username).to eq 'foo' }
+    it { expect(subject.a19_password).to eq 'bar' }
+    it { expect(subject.use_basic_auth?).to be_truthy }
   end
 
   context 'unconfigured client' do
@@ -14,5 +23,7 @@ describe Roqua::Healthy::Client do
     it 'defaults to system wide config' do
       expect(subject.a19_endpoint).to eq Roqua::Healthy.a19_endpoint
     end
+
+    it { expect(subject.use_basic_auth?).to be_falsey }
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roqua-healthy
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.5.0
 platform: ruby
 authors:
 - Marten Veldthuis
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-26 00:00:00.000000000 Z
+date: 2017-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport