roqua-healthy 1.1.8 → 1.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2538fa7edc7b6c02be4a8460cdcd60bfaef74dff
-  data.tar.gz: f8c1b136292a2e0c94ccd6e96a73121b791ecb26
+  metadata.gz: 964fbac85a2be76b1cef6c67dbbc3709263bd075
+  data.tar.gz: 7ca7069b1a9f82c4bb8f219f2626c37373facc44
 SHA512:
-  metadata.gz: a1c97ffcbdbe6467698ae2fc1d314a44c0deb90fa72d45f4012307964686d7bdb5b4880ae10a4d06fbc5bd9bab5981ec8578f1a6640609b96177f06e8260dc17
-  data.tar.gz: 0e43ccf5a5973bc063406645e8e83e7143f7a1d8d1562414e2c745a5268962b21d029c19e17eb8c3251601048fb0e5d49e25ea81ddc253d20c81e0baf69ae8f3
+  metadata.gz: 5c90e5bcc6533683c1c3ebcd9b8b2b7c114bd45c077b673c02c80c7f4fcebe4895b311ca0b26c0a187af7de195dced3a5d6001d356de26df086ba814d33a019e
+  data.tar.gz: bcc1ab265d2aae32b9f3f391864c3fb53f0a51cc611b1b832bba5eef038e266e125a5bac1dcface2328327fe26e6976ca11de639ad20cb1f6ccc5c6121642d75

data/ChangeLog.md

@@ -1,3 +1,7 @@
+### 1.1.9
+
+* Handle upgraded mirth error messages
+
 ### 1.1.8
 
 * Handle new Impulse/User name format

data/lib/roqua/healthy/a19/response_validator.rb

@@ -46,9 +46,9 @@ module Roqua
 
         def validate_500
           failure = parser.fetch("failure")
-          raise ::Roqua::Healthy::Timeout, failure["error"]           if failure["error"] == "Timeout waiting for ACK"
+          raise ::Roqua::Healthy::Timeout, failure["error"]           if failure["error"] == "Timeout waiting for ACK" || failure["error"] == 'ERROR: Timeout waiting for response'
           raise ::Roqua::Healthy::Timeout, failure["error"]           if failure["error"] == "Unable to connect to destination\tSocketTimeoutException\tconnect timed out"
-          raise ::Roqua::Healthy::ConnectionRefused, failure["error"] if failure["error"] == "Unable to connect to destination\tConnectException\tConnection refused"
+          raise ::Roqua::Healthy::ConnectionRefused, failure["error"] if failure["error"] == "Unable to connect to destination\tConnectException\tConnection refused" || failure["error"] == 'ERROR: ConnectException: Connection refused'
           raise ::Roqua::Healthy::UnknownFailure, failure["error"]
         end
 

data/lib/roqua/healthy/version.rb

@@ -1,6 +1,6 @@
 module Roqua
   module Healthy
     # healthy version
-    VERSION = "1.1.8"
+    VERSION = "1.1.9"
   end
 end

data/spec/unit/a19/fetcher_spec.rb

@@ -12,7 +12,7 @@ describe Roqua::Healthy::A19::Fetcher do
 
   it "raises when upstream does not return HTTP 200" do
     stub_mirth_response "Request not successful", 500
-    expect { subject.fetch }.to raise_exception
+    expect { subject.fetch }.to raise_exception(Roqua::Healthy::IllegalMirthResponse)
   end
 
   it 'raises when upstream responds with illegal XML' do
@@ -23,21 +23,31 @@ describe Roqua::Healthy::A19::Fetcher do
     expect { subject.fetch }.to raise_error(Roqua::Healthy::IllegalMirthResponse)
   end
 
-  it "raises upstream is returning 'Timeout waiting for ACK' messages" do
+  it "raises upstream is returning old style 'Timeout waiting for ACK' messages" do
     stub_mirth_response "<failure><error>Timeout waiting for ACK</error></failure>", 500
     expect { subject.fetch }.to raise_exception(Roqua::Healthy::Timeout)
   end
 
+  it "raises upstream is returning new style 'Timeout waiting for response' messages" do
+    stub_mirth_response "<failure><error>ERROR: Timeout waiting for response</error></failure>", 500
+    expect { subject.fetch }.to raise_exception(Roqua::Healthy::Timeout)
+  end
+
   it "raises upstream is returning 'connection timeout' messages" do
     stub_mirth_response "<failure><error>Unable to connect to destination\tSocketTimeoutException\tconnect timed out</error></failure>", 500
     expect { subject.fetch }.to raise_exception(Roqua::Healthy::Timeout)
   end
 
-  it "raises upstream is returning 'connection refused' messages" do
+  it "raises if upstream is returning old style 'connection refused' messages" do
     stub_mirth_response "<failure><error>Unable to connect to destination\tConnectException\tConnection refused</error></failure>", 500
     expect { subject.fetch }.to raise_exception(Roqua::Healthy::ConnectionRefused)
   end
 
+  it "raises if upstream is returning new  style 'connection refused' messages" do
+    stub_mirth_response "<failure><error>ERROR: ConnectException: Connection refused</error></failure>", 500
+    expect { subject.fetch }.to raise_exception(Roqua::Healthy::ConnectionRefused)
+  end
+
   it "raises when upstream does not accept connections" do
     stub_mirth.to_raise Errno::ECONNREFUSED
     expect { subject.fetch }.to raise_exception(Roqua::Healthy::ConnectionRefused)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-healthy
 version: !ruby/object:Gem::Version
-  version: 1.1.8
+  version: 1.1.9
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-01 00:00:00.000000000 Z
+date: 2015-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport