roqua-healthy 1.1.3 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: abe2a3460e88fbddb7d47cb2a8c8376cc7ca8b35
-  data.tar.gz: b7b6732d28fc1a0243a167a479c67e2b00791853
+  metadata.gz: 07b9615104913124d488adcfe8dcd8fc2b7d8a39
+  data.tar.gz: e28bb319e0a7cb541000cc3426abc14f62c1f5cf
 SHA512:
-  metadata.gz: 910aaa5a1fa67d2e27628ff59023d0f07bc75d527ae7740a4797c8901c6f5e5bd2402ca0aa26e77048e7b36dd319270b781ed320affbe064379369616790f09e
-  data.tar.gz: ffb940fbcf3a9151e27e33871d720ee09adae059aff393a72b9859ef76ea8e91299be2ff3a93b67d6388f401cef050125da89ab2cc5e6eed68c748cae8d55b8b
+  metadata.gz: 2c9c06247100c245101a39333e520f52d64e0be29ad1302c5fe263f7c6851107ccf9256abb07282e9ccb314cec7c2f3e16247122ef890fc35b58843ab9c5bc85
+  data.tar.gz: 2b7deda3ee98b10f332c19a0379232c76e46a7ebd2f55994cfe76453270d259302eddd6a2d3287d1f3b87a939867ee04bd7af2e3f4a7382bf88abc4ed8889158

data/.rubocop.yml

@@ -29,8 +29,3 @@ FinalNewline:
 
 SignalException:
   Enabled: False
-
-# Gems typically have one file named the-gem-name.rb which can be autorequired by bundler
-FileName:
-  Exclude:
-      - lib/roqua-healthy.rb

data/ChangeLog.md

@@ -1,3 +1,11 @@
+### 1.1.4
+
+* Better handling for 403 and 404 responses.
+
+### 1.1.3
+
+* No idea. Someone forgot to update changelog
+
 ### 1.1.2
 
 * Fall back to PID.13.1 for cell_phone when type is undefined

data/lib/roqua/healthy/a19/response_validator.rb

@@ -18,6 +18,10 @@ module Roqua
           case response_code
           when '200'
             validate_200
+          when '403'
+            validate_403
+          when '404'
+            validate_404
           when '500'
             validate_500
           else
@@ -32,6 +36,14 @@ module Roqua
           true
         end
 
+        def validate_403
+          raise ::Roqua::Healthy::AuthenticationFailure
+        end
+
+        def validate_404
+          raise ::Roqua::Healthy::PatientNotFound
+        end
+
         def validate_500
           failure = parser.fetch("failure")
           raise ::Roqua::Healthy::Timeout, failure["error"]           if failure["error"] == "Timeout waiting for ACK"
@@ -42,4 +54,4 @@ module Roqua
       end
     end
   end
-end
+end

data/lib/roqua/healthy/errors.rb

@@ -11,6 +11,7 @@ module Roqua
     class UnknownFailure < Error; end
     class PatientIdNotInRemote < Error; end
     class PatientNotFound < Error; end
+    class AuthenticationFailure < Error; end
 
     module MirthErrors
       class WrongPatient < Error; end

data/lib/roqua/healthy/version.rb

@@ -1,6 +1,6 @@
 module Roqua
   module Healthy
     # healthy version
-    VERSION = "1.1.3"
+    VERSION = "1.1.4"
   end
 end

data/roqua-healthy.gemspec

@@ -34,7 +34,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'guard-rspec', '~> 4.2.4'
   gem.add_development_dependency 'listen', '~> 2.1'
   gem.add_development_dependency 'guard-rubocop', '~> 1.0.1'
-  gem.add_development_dependency 'rubocop', '~> 0.17'
+  gem.add_development_dependency 'rubocop', '= 0.17.0'
   gem.add_development_dependency 'fuubar'
 
   # Documentation generation

data/spec/integration/medo_spec.rb

@@ -23,4 +23,20 @@ describe 'Fetching A19 from Medo' do
     it { expect(subject[:gender]).to       eq('M') }
     it { expect(subject[:phone_cell]).to   eq('0698765432') }
   end
-end
+
+  describe 'authentication failure' do
+    before { stub_mirth_response '', 403, '12345678901' }
+
+    it 'raises AuthenticationFailure' do
+      expect { Roqua::Healthy::A19.fetch("12345678901") }.to raise_error(Roqua::Healthy::AuthenticationFailure)
+    end
+  end
+
+  describe 'a patient that does not exist' do
+    before { stub_mirth_response '', 404, '12345678901' }
+
+    it 'raises PatientNotFound' do
+      expect { Roqua::Healthy::A19.fetch("12345678901") }.to raise_error(Roqua::Healthy::PatientNotFound)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-healthy
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-07 00:00:00.000000000 Z
+date: 2014-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -188,16 +188,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.17'
+        version: 0.17.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.17'
+        version: 0.17.0
 - !ruby/object:Gem::Dependency
   name: fuubar
   requirement: !ruby/object:Gem::Requirement
@@ -322,7 +322,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Arranges communication between Mirth and RoQua