roodi 2.2.0 → 3.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 07d949870658795c4a909c32faf4e50b37f29813
+  data.tar.gz: 54f229d5e6901aa1246d5e314ab63fa462acb923
+SHA512:
+  metadata.gz: 94c41207f62016bd29d2eb1ada674d89772e9594cebd80bf96d750137048b0a9e16451dd54280f145e4a88019da2d9ecf6b56235d57ca4dec87ae1c54ac6ef8f
+  data.tar.gz: 6f31b01a3c5376860ad999fa8d0ff1de82847315f0d8257d19cd26b7c56ef024e725999737aebf9b541830b3fe5b5302a8b87412aaa150c5f22562fe6ddd742b

data/.gitignore

@@ -0,0 +1,3 @@
+doc
+pkg
+Gemfile.lock

data/.travis.yml

@@ -0,0 +1,11 @@
+language: ruby
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3
+  - 2.0.0
+  - jruby-18mode # JRuby in 1.8 mode
+  - jruby-19mode # JRuby in 1.9 mode
+  - rbx-18mode
+  - rbx-19mode
+  - ree

data/Gemfile

@@ -1,6 +1,6 @@
-source :rubygems
+source "https://rubygems.org"
 
 gemspec
 
 gem "rake"
-gem "rspec", "~> 1.3.2"
+gem "rspec", "~> 2.14.1"

data/History.txt

@@ -1,3 +1,13 @@
+= 3.0.0
+
+* Removed MissingForeignKeyIndexCheck, since it is specific to Rails/ActiveRecord and thus doesn't belong in Roodi
+* A build is now running on Travis for the following Ruby versions: 1.8, 1.9, 2.0, JRuby 1.8 mode, JRuby 1.9 mode, Rubinius 1.8 mode, Rubinius 1.9 mode, Ruby Enterprise Edition
+* Using ruby_parser 3.2.2
+* Better check if OS is windows (#2 Martin Gotink)
+* Accept 'next' in a rescue block (#1 Virgil Mihailovici)
+* Rescue line count when there are no lines
+* Pull down updates from https://github.com/zdennis/roodi that includes updates from https://github.com/hooroo/roodi and https://github.com/aselder/roodi re: pull request https://github.com/martinjandrews/roodi/pull/12 https://github.com/martinjandrews/roodi/pull/11
+
 = 2.0.1
 
 * Fixed a bug where roodi.yml was not being loaded.  Patch supplied by Rob Mitchell.

data/{README.txt → README.md}

@@ -1,56 +1,72 @@
-= roodi
+# roodi
 
-* http://roodi.rubyforge.org
+[![Build Status](https://travis-ci.org/roodi/roodi.png?branch=master)](https://travis-ci.org/roodi/roodi)
 
-== DESCRIPTION:
+## Description
 
 Roodi stands for Ruby Object Oriented Design Inferometer.  It parses your Ruby code and warns you about design issues you have based on the checks that is has configured.
 
-== INSTALL:
+## Install
 
-* sudo gem install roodi
+`$ sudo gem install roodi`
 
-== SYNOPSIS:
+## Synopsis
 
 To check one or more files using the default configuration that comes with Roodi, use:
-    roodi [-config=file] [pattern ...]
 
-=== EXAMPLE USAGE
+`$ roodi [-config=file] [pattern ...]`
+
+## Example Usage
 
 Check all ruby files in a rails app:
-    roodi "rails_app/**/*.rb"
+
+`$ roodi "rails_app/**/*.rb"`
 
 Check one controller and one model file in a rails app:
-    roodi app/controller/sample_controller.rb app/models/sample.rb
+
+`$ roodi app/controller/sample_controller.rb app/models/sample.rb`
 
 Check one controller and all model files in a rails app:
-    roodi app/controller/sample_controller.rb "app/models/*.rb"
+
+`$ roodi app/controller/sample_controller.rb "app/models/*.rb"`
 
 Check all ruby files in a rails app with a custom configuration file:
-    roodi -config=my_roodi_config.yml "rails_app/**/*.rb"
+
+`$ roodi -config=my_roodi_config.yml "rails_app/**/*.rb"`
 
 If you're writing a check, it is useful to see the structure of a file the way that Roodi tokenizes it (via ruby_parser). Use:
-    roodi-describe [filename]
 
-== CUSTOM CONFIGURATION
+`$ roodi-describe [filename]`
+
+## Custom Configuration
 
 To change the set of checks included, or to change the default values of the checks, you can provide your own config file.  The config file is a YAML file that lists the checks to be included.  Each check can optionally include a hash of options that are passed to the check to configure it.  For example, the default config file looks like this:
 
-    AssignmentInConditionalCheck:    { }
-    CaseMissingElseCheck:            { }
-    ClassLineCountCheck:             { line_count: 300 }
-    ClassNameCheck:                  { pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/ }
-    CyclomaticComplexityBlockCheck:  { complexity: 4 }
-    CyclomaticComplexityMethodCheck: { complexity: 8 }
-    EmptyRescueBodyCheck:            { }
-    ForLoopCheck:                    { }
-    MethodLineCountCheck:            { line_count: 20 }
-    MethodNameCheck:                 { pattern: !ruby/regexp /^[_a-z<>=\[\]|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/ }
-    ModuleLineCountCheck:            { line_count: 300 }
-    ModuleNameCheck:                 { pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/ }
-    ParameterNumberCheck:            { parameter_count: 5 }
-
-== SUPPORTED CHECKS:
+    AssignmentInConditionalCheck:
+    CaseMissingElseCheck:
+    ClassLineCountCheck:
+      line_count: 300
+    ClassNameCheck:
+      pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/
+    ClassVariableCheck:
+    CyclomaticComplexityBlockCheck:
+      complexity: 4
+    CyclomaticComplexityMethodCheck:
+      complexity: 8
+    EmptyRescueBodyCheck:
+    ForLoopCheck:
+    MethodLineCountCheck:
+      line_count: 20
+    MethodNameCheck:
+      pattern: !ruby/regexp /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/
+    ModuleLineCountCheck:
+      line_count: 300
+    ModuleNameCheck:
+      pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/
+    ParameterNumberCheck:
+      parameter_count: 5
+
+## Supported Checks
 
 * AssignmentInConditionalCheck - Check for an assignment inside a conditional.  It's probably a mistaken equality comparison.
 * CaseMissingElseCheck - Check that case statements have an else statement so that all cases are covered.
@@ -66,11 +82,11 @@ To change the set of checks included, or to change the default values of the che
 * ModuleNameCheck - Check that module names match convention.
 * ParameterNumberCheck - Check that the number of parameters on a method is below the threshold.
 
-== SUGGESTED CHECKS:
+## Suggested Checks
 
 * BlockVariableShadowCheck - Check that a block variable does not have the same name as a method parameter or local variable.  It may be mistakenly referenced within the block.
 
-== LICENSE:
+## License
 
 (The MIT License)
 

data/Rakefile

@@ -1,10 +1,8 @@
 require 'rake'
-require 'spec/rake/spectask'
+require 'rspec/core/rake_task'
 require 'bundler'
 require 'roodi'
 
-Bundler::GemHelper.install_tasks
-
 def roodi(ruby_files)
   roodi = Roodi::Core::Runner.new
   ruby_files.each { |file| roodi.check_file(file) }
@@ -13,9 +11,7 @@ def roodi(ruby_files)
 end
 
 desc "Run all specs"
-Spec::Rake::SpecTask.new('spec') do |t|
-  t.spec_files = FileList['spec/**/*spec.rb']
-end
+RSpec::Core::RakeTask.new(:spec)
 
 desc "Run Roodi against all source files"
 task :roodi do
@@ -23,4 +19,4 @@ task :roodi do
   roodi(Dir.glob(pattern))
 end
 
-task :default => :spec
+task :default => [:spec, :roodi]

data/lib/roodi/checks.rb

@@ -5,13 +5,13 @@ require 'roodi/checks/class_line_count_check'
 require 'roodi/checks/class_name_check'
 require 'roodi/checks/class_variable_check'
 require 'roodi/checks/control_coupling_check'
+require 'roodi/checks/core_method_override_check'
 require 'roodi/checks/cyclomatic_complexity_block_check'
 require 'roodi/checks/cyclomatic_complexity_method_check'
 require 'roodi/checks/empty_rescue_body_check'
 require 'roodi/checks/for_loop_check'
 require 'roodi/checks/method_line_count_check'
 require 'roodi/checks/method_name_check'
-require 'roodi/checks/missing_foreign_key_index_check'
 require 'roodi/checks/module_line_count_check'
 require 'roodi/checks/module_name_check'
 require 'roodi/checks/npath_complexity_method_check'

data/lib/roodi/checks/abc_metric_method_check.rb

@@ -3,7 +3,7 @@ require 'roodi/checks/check'
 module Roodi
   module Checks
     # TODO:  Add summary
-    # 
+    #
     # TODO:  Add detail
     class AbcMetricMethodCheck < Check
       # ASSIGNMENTS = [:attrasgn, :attrset, :dasgn_curr, :iasgn, :lasgn, :masgn]
@@ -11,18 +11,18 @@ module Roodi
       # BRANCHES = [:if, :else, :while, :until, :for, :rescue, :case, :when, :and, :or]
       BRANCHES = [:vcall, :call]
       # CONDITIONS = [:and, :or]
-      CONDITIONS = [:==, :<=, :>=, :<, :>]
+      CONDITIONS = [:==, :"!=", :<=, :>=, :<, :>]
       #  =  *=  /=  %=  +=  <<=  >>=  &=  |=  ^=
       OPERATORS = [:*, :/, :%, :+, :<<, :>>, :&, :|, :^]
       DEFAULT_SCORE = 10
-      
+
       attr_accessor :score
 
       def initialize
         super()
         self.score = DEFAULT_SCORE
       end
-      
+
       def interesting_nodes
         [:defn]
       end
@@ -35,7 +35,7 @@ module Roodi
         score = Math.sqrt(a*a + b*b + c*c)
         add_error "Method name \"#{method_name}\" has an ABC metric score of <#{a},#{b},#{c}> = #{score}.  It should be #{@score} or less." unless score <= @score
       end
-      
+
       private
 
       def count_assignments(node)
@@ -44,7 +44,7 @@ module Roodi
         node.children.each {|node| count += count_assignments(node)}
         count
       end
-      
+
       def count_branches(node)
         count = 0
         count = count + 1 if branch?(node)
@@ -58,22 +58,22 @@ module Roodi
         node.children.each {|node| count += count_conditionals(node)}
         count
       end
-      
+
       def assignment?(node)
         ASSIGNMENTS.include?(node.node_type)
       end
-      
+
       def branch?(node)
         BRANCHES.include?(node.node_type) && !conditional?(node) && !operator?(node)
       end
-      
+
       def conditional?(node)
-        (:call == node.node_type) && CONDITIONS.include?(node[2]) 
+        (:call == node.node_type) && CONDITIONS.include?(node[2])
       end
-      
+
       def operator?(node)
-        (:call == node.node_type) && OPERATORS.include?(node[2]) 
-      end      
+        (:call == node.node_type) && OPERATORS.include?(node[2])
+      end
     end
   end
 end

data/lib/roodi/checks/core_method_override_check.rb

@@ -0,0 +1,23 @@
+require 'roodi/checks/check'
+
+module Roodi
+  module Checks
+    # Checks a class to make sure it doesn't override core methods on Object.
+    #
+    # An example is when the 'class' method of a class is overriden.  This causes code
+    # that tests the class of an object to fail.
+    class CoreMethodOverrideCheck < Check
+
+      def interesting_nodes
+        [:defn]
+      end
+
+      def evaluate_start(node)
+        [ :class ].each do |core_name|
+          add_error("Class overrides method '#{core_name}'.") if node[1] == core_name
+        end
+      end
+
+    end
+  end
+end

data/lib/roodi/checks/empty_rescue_body_check.rb

@@ -7,7 +7,7 @@ module Roodi
     # When the body of a rescue block is empty, exceptions can get caught and swallowed without
     # any feedback to the user.
     class EmptyRescueBodyCheck < Check
-      STATEMENT_NODES = [:fcall, :return, :attrasgn, :vcall, :nil, :call, :lasgn, :true, :false]
+      STATEMENT_NODES = [:fcall, :return, :attrasgn, :vcall, :nil, :call, :lasgn, :true, :false, :next]
       
       def interesting_nodes
         [:resbody]

data/lib/roodi/checks/line_count_check.rb

@@ -3,7 +3,7 @@ require 'roodi/checks/check'
 module Roodi
   module Checks
     class LineCountCheck < Check
-      
+
       attr_accessor :line_count
 
       def evaluate_start(node)
@@ -12,9 +12,17 @@ module Roodi
       end
 
       protected
-  
+
       def count_lines(node)
-        node.last.line - node.line - 1
+        node.last.respond_to?(:line) ? node.last.line - node.line : 0
+
+        rescue NoMethodError => e
+          #TODO: Add spec for this, nothing breaks when removing it.
+          if ENV['DEBUG'] =~ /true/i
+            STDERR.puts "!! line counting error #{e.message}\t #{node.inspect}"
+            STDERR.puts "!! Does the node have any lines?"
+          end
+          0
       end
 
     end

data/lib/roodi/checks/parameter_number_check.rb

@@ -25,7 +25,7 @@ module Roodi
       def evaluate_start(node)
         method_name = node[1]
         arguments = node[2]
-        actual_parameter_count = arguments.inject(-1) { |count, each| count = count + (each.class == Symbol ? 1 : 0) }
+        actual_parameter_count = arguments.select {|arg| [Sexp, Symbol].include? arg.class}.count - 1
         add_error "Method name \"#{method_name}\" has #{actual_parameter_count} parameters.  It should have #{@parameter_count} or less." unless actual_parameter_count <= @parameter_count
       end
 

data/lib/roodi/core/parser.rb

@@ -1,5 +1,6 @@
 require 'rubygems'
 require 'ruby_parser'
+require 'rbconfig'
 
 module Roodi
   module Core
@@ -14,7 +15,7 @@ module Roodi
       
       def silence_stream(stream)
         old_stream = stream.dup
-        stream.reopen(RUBY_PLATFORM =~ /mswin/ ? 'NUL:' : '/dev/null')
+        stream.reopen(null_stream_output)
         stream.sync = true
         yield
       ensure
@@ -25,6 +26,23 @@ module Roodi
         @parser ||= RubyParser.new
         @parser.parse(content, filename)
       end
+      
+      def null_stream_output
+        null_output_for_platform(RbConfig::CONFIG['host_os'])
+      end
+      
+      def null_output_for_platform(host_os)
+        case host_os
+        when windows_host_os_matcher
+          'NUL:'
+        else
+          '/dev/null'
+        end
+      end
+      
+      def windows_host_os_matcher
+        /mingw|mswin32|cygwin/o
+      end
     end
   end
 end

data/lib/roodi/core/runner.rb

@@ -31,11 +31,12 @@ module Roodi
       end
   
       def check_file(filename)
+        return unless File.exists?(filename)
         check(filename, File.read(filename))
       end
   
       def print(filename, content)
-        node = parse(content, filename)
+        node = parse(filename, content)
         puts "Line: #{node.line}"
         pp node
       end

data/lib/roodi/version.rb

@@ -1,3 +1,3 @@
 module Roodi
-  VERSION = '2.2.0'
+  VERSION = '3.0.0'
 end

data/roodi.gemspec

@@ -6,13 +6,18 @@ Gem::Specification.new do |gem|
   gem.name = "roodi"
   gem.summary = "Roodi stands for Ruby Object Oriented Design Inferometer"
   gem.description = "Roodi stands for Ruby Object Oriented Design Inferometer"
-  gem.homepage = "http://roodi.rubyforge.org"
-  gem.authors = ["Marty Andrews"]
-  gem.email = "marty@cogent.co"
+  gem.homepage = "http://github.com/roodi/roodi"
+  gem.authors = ["Marty Andrews", "Peter Evjan"]
+  gem.email = "peter.evjan@gmail.com"
   gem.files = Dir['lib/**/*.rb'] + Dir['bin/*'] + Dir['[A-Za-z]*'] + Dir['spec/**/*']
   gem.version = Roodi::VERSION.dup
   gem.platform = Gem::Platform::RUBY
-  gem.add_runtime_dependency("ruby_parser", "~> 2.3.0")
+  gem.add_runtime_dependency("ruby_parser", "~> 3.2.2")
   gem.executables = ["roodi", "roodi-describe"]
+  gem.files              = `git ls-files`.split($\)
+  gem.test_files         =  gem.files.grep(%r{^(test|spec|features)/})
+  gem.executables        =  gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.require_paths = ["lib"]
+  gem.license     = 'MIT'
 
 end

data/roodi.yml

@@ -1,25 +1,23 @@
 AssignmentInConditionalCheck:
 CaseMissingElseCheck:
-ClassLineCountCheck:             
-  line_count: 300 
-ClassNameCheck:                  
+ClassLineCountCheck:
+  line_count: 300
+ClassNameCheck:
   pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/
 ClassVariableCheck:
-CyclomaticComplexityBlockCheck:  
+CyclomaticComplexityBlockCheck:
   complexity: 4
-CyclomaticComplexityMethodCheck: 
+CyclomaticComplexityMethodCheck:
   complexity: 8
 EmptyRescueBodyCheck:
 ForLoopCheck:
-MethodLineCountCheck:            
-  line_count: 20 
-MethodNameCheck:                 
-  pattern: !ruby/regexp /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/ 
-# MissingForeignKeyIndexCheck:
-ModuleLineCountCheck:            
+MethodLineCountCheck:
+  line_count: 20
+MethodNameCheck:
+  pattern: !ruby/regexp /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/
+ModuleLineCountCheck:
   line_count: 300
-ModuleNameCheck:          
+ModuleNameCheck:
   pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/
-ParameterNumberCheck:            
+ParameterNumberCheck:
   parameter_count: 5
- 

data/spec/roodi/checks/core_method_override_check_spec.rb

@@ -0,0 +1,31 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Roodi::Checks::CoreMethodOverrideCheck do
+  before(:each) do
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::CoreMethodOverrideCheck.new)
+  end
+
+  it "should accept a class with a method" do
+    content = <<-END
+    class WellBehavedClass
+      def well_behaved_method
+      end
+    end
+    END
+    @roodi.check_content(content)
+    @roodi.errors.should be_empty
+  end
+
+  it "should reject a class which overrides the class method" do
+    content = <<-END
+    class BadClass
+      def class
+      end
+    end
+    END
+    @roodi.check_content(content)
+    errors = @roodi.errors
+    errors.should_not be_empty
+    errors[0].to_s.should eql("dummy-file.rb:2 - Class overrides method 'class'.")
+  end
+end

data/spec/roodi/checks/empty_rescue_body_check_spec.rb

@@ -137,4 +137,18 @@ describe Roodi::Checks::EmptyRescueBodyCheck do
     errors = @roodi.errors
     errors.should be_empty
   end
+
+  it "should accept a rescue block that has only a next statement" do
+    content = <<-END
+    begin
+      call_method
+    rescue Exception => e
+      next
+    end
+    END
+    @roodi.check_content(content)
+    errors = @roodi.errors
+    errors.should be_empty
+  end
+
 end

data/spec/roodi/checks/npath_complexity_method_check_spec.rb

@@ -28,26 +28,4 @@ describe Roodi::Checks::NpathComplexityMethodCheck do
     END
     verify_content_complexity(content, 2)
   end
-  
-  it "should find nested if block" do
-    pending "NPath Complexity implementation that can support 'else' blocks"
-    content = <<-END
-    def method_name
-      if (value1)
-        foo
-      else
-        bar
-      end
-      if (value2)
-        bam
-      else
-        baz
-      end
-      if (value3)
-        one
-      end
-    end
-    END
-    verify_content_complexity(content, 8)
-  end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,3 @@
 $LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__) + "/../lib"))
 require 'roodi'
-require 'spec'
+require 'rspec'

metadata

@@ -1,40 +1,49 @@
 --- !ruby/object:Gem::Specification
 name: roodi
 version: !ruby/object:Gem::Version
-  version: 2.2.0
-  prerelease: 
+  version: 3.0.0
 platform: ruby
 authors:
 - Marty Andrews
+- Peter Evjan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-25 00:00:00.000000000 Z
+date: 2013-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 3.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 3.2.2
 description: Roodi stands for Ruby Object Oriented Design Inferometer
-email: marty@cogent.co
+email: peter.evjan@gmail.com
 executables:
 - roodi
 - roodi-describe
 extensions: []
 extra_rdoc_files: []
 files:
+- .gitignore
+- .travis.yml
+- Gemfile
+- History.txt
+- Manifest.txt
+- README.md
+- Rakefile
+- bin/roodi
+- bin/roodi-describe
+- lib/roodi.rb
+- lib/roodi/checks.rb
 - lib/roodi/checks/abc_metric_method_check.rb
 - lib/roodi/checks/assignment_in_conditional_check.rb
 - lib/roodi/checks/case_missing_else_check.rb
@@ -43,6 +52,7 @@ files:
 - lib/roodi/checks/class_name_check.rb
 - lib/roodi/checks/class_variable_check.rb
 - lib/roodi/checks/control_coupling_check.rb
+- lib/roodi/checks/core_method_override_check.rb
 - lib/roodi/checks/cyclomatic_complexity_block_check.rb
 - lib/roodi/checks/cyclomatic_complexity_check.rb
 - lib/roodi/checks/cyclomatic_complexity_method_check.rb
@@ -51,31 +61,20 @@ files:
 - lib/roodi/checks/line_count_check.rb
 - lib/roodi/checks/method_line_count_check.rb
 - lib/roodi/checks/method_name_check.rb
-- lib/roodi/checks/missing_foreign_key_index_check.rb
 - lib/roodi/checks/module_line_count_check.rb
 - lib/roodi/checks/module_name_check.rb
 - lib/roodi/checks/name_check.rb
 - lib/roodi/checks/npath_complexity_check.rb
 - lib/roodi/checks/npath_complexity_method_check.rb
 - lib/roodi/checks/parameter_number_check.rb
-- lib/roodi/checks.rb
+- lib/roodi/core.rb
 - lib/roodi/core/checking_visitor.rb
 - lib/roodi/core/error.rb
 - lib/roodi/core/parser.rb
 - lib/roodi/core/runner.rb
 - lib/roodi/core/visitable_sexp.rb
-- lib/roodi/core.rb
 - lib/roodi/version.rb
-- lib/roodi.rb
 - lib/roodi_task.rb
-- bin/roodi
-- bin/roodi-describe
-- Gemfile
-- Gemfile.lock
-- History.txt
-- Manifest.txt
-- Rakefile
-- README.txt
 - roodi.gemspec
 - roodi.yml
 - spec/roodi/checks/abc_metric_method_check_spec.rb
@@ -85,13 +84,13 @@ files:
 - spec/roodi/checks/class_name_check_spec.rb
 - spec/roodi/checks/class_variable_check_spec.rb
 - spec/roodi/checks/control_coupling_check_spec.rb
+- spec/roodi/checks/core_method_override_check_spec.rb
 - spec/roodi/checks/cyclomatic_complexity_block_check_spec.rb
 - spec/roodi/checks/cyclomatic_complexity_method_check_spec.rb
 - spec/roodi/checks/empty_rescue_body_check_spec.rb
 - spec/roodi/checks/for_loop_check_spec.rb
 - spec/roodi/checks/method_line_count_check_spec.rb
 - spec/roodi/checks/method_name_check_spec.rb
-- spec/roodi/checks/missing_foreign_key_index_check_spec.rb
 - spec/roodi/checks/module_line_count_check_spec.rb
 - spec/roodi/checks/module_name_check_spec.rb
 - spec/roodi/checks/npath_complexity_method_check_spec.rb
@@ -99,34 +98,49 @@ files:
 - spec/roodi/core/runner_spec.rb
 - spec/roodi/roodi.yml
 - spec/spec_helper.rb
-homepage: http://roodi.rubyforge.org
-licenses: []
+homepage: http://github.com/roodi/roodi
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -2141010416866692951
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -2141010416866692951
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Roodi stands for Ruby Object Oriented Design Inferometer
-test_files: []
+test_files:
+- spec/roodi/checks/abc_metric_method_check_spec.rb
+- spec/roodi/checks/assignment_in_conditional_check_spec.rb
+- spec/roodi/checks/case_missing_else_check_spec.rb
+- spec/roodi/checks/class_line_count_check_spec.rb
+- spec/roodi/checks/class_name_check_spec.rb
+- spec/roodi/checks/class_variable_check_spec.rb
+- spec/roodi/checks/control_coupling_check_spec.rb
+- spec/roodi/checks/core_method_override_check_spec.rb
+- spec/roodi/checks/cyclomatic_complexity_block_check_spec.rb
+- spec/roodi/checks/cyclomatic_complexity_method_check_spec.rb
+- spec/roodi/checks/empty_rescue_body_check_spec.rb
+- spec/roodi/checks/for_loop_check_spec.rb
+- spec/roodi/checks/method_line_count_check_spec.rb
+- spec/roodi/checks/method_name_check_spec.rb
+- spec/roodi/checks/module_line_count_check_spec.rb
+- spec/roodi/checks/module_name_check_spec.rb
+- spec/roodi/checks/npath_complexity_method_check_spec.rb
+- spec/roodi/checks/parameter_number_check_spec.rb
+- spec/roodi/core/runner_spec.rb
+- spec/roodi/roodi.yml
+- spec/spec_helper.rb

data/Gemfile.lock

@@ -1,22 +0,0 @@
-PATH
-  remote: .
-  specs:
-    roodi (2.2.0)
-      ruby_parser (~> 2.3.0)
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    rake (10.0.3)
-    rspec (1.3.2)
-    ruby_parser (2.3.0)
-      sexp_processor (~> 3.0)
-    sexp_processor (3.2.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  rake
-  roodi!
-  rspec (~> 1.3.2)

data/lib/roodi/checks/missing_foreign_key_index_check.rb

@@ -1,99 +0,0 @@
-require 'roodi/checks/check'
-require 'pathname'
-
-module Roodi
-  module Checks
-    # Checks to make sure for loops are not being used..
-    #
-    # Using a for loop is not idiomatic use of Ruby, and is usually a sign that someone with
-    # more experience in a different programming language is trying out Ruby.  Use
-    # Enumerable.each with a block instead.
-    class MissingForeignKeyIndexCheck < Check
-      def initialize
-        super()
-        @foreign_keys = {}
-        @indexes = {}
-      end
-
-      def interesting_nodes
-        [:call]
-      end
-
-      def evaluate_start_call(node)
-        if analyzing_schema(node)
-          if creating_table(node)
-            @current_table = create_table_name(node)
-          end
-
-          if creating_foreign_key(node)
-            @foreign_keys[@current_table] ||= []
-            @foreign_keys[@current_table] << foreign_key_column_name(node)
-          end
-
-          if adding_index(node)
-            @indexes[index_table_name(node)] ||= []
-            @indexes[index_table_name(node)] << index_column_name(node)
-          end
-        end
-      end
-      
-      def evaluate_end_call(node)
-        #ignored
-      end
-
-      def analyzing_schema(node)
-        pathname = Pathname.new(node.file)
-        @analyzing_schema ||= ("schema.rb" == pathname.basename.to_s)
-      end
-
-      def creating_table(node)
-        :create_table == node[2]
-      end
-
-      def create_table_name(node)
-        # Get table name out of this:
-        # s(:call, nil, :create_table, s(:arglist, s(:str, "duplicate_blocks"), s(:hash, s(:lit, :force), s(:true))))
-        node[3][1][1]
-      end
-
-      def creating_foreign_key(node)
-        #s(:call, s(:lvar, :t), :integer, s(:arglist, s(:str, "duplicate_set_id"), s(:hash, s(:lit, :null), s(:false))))
-        column_type = node[2]
-        column_name = node[3][1][1]
-        :integer == column_type && "_id" == column_name[-3,3]
-      end
-
-      def foreign_key_column_name(node)
-        #s(:call, s(:lvar, :t), :integer, s(:arglist, s(:str, "duplicate_set_id"), s(:hash, s(:lit, :null), s(:false))))
-        column_name = node[3][1][1]
-      end
-
-      def adding_index(node)
-        :add_index == node[2]
-      end
-
-      def index_table_name(node)
-        # Get table name out of this:
-        # s(:call, nil, :add_index, s(:arglist, s(:str, "duplicate_blocks"), s(:array, s(:str, "duplicate_set_id")), s(:hash, s(:lit, :name), s(:str, "index_duplicate_blocks_on_duplicate_set_id"))))
-        node[3][1][1]
-      end
-
-      def index_column_name(node)
-        # Get index column name out of this:
-        # s(:call, nil, :add_index, s(:arglist, s(:str, "duplicate_blocks"), s(:array, s(:str, "duplicate_set_id")), s(:hash, s(:lit, :name), s(:str, "index_duplicate_blocks_on_duplicate_set_id"))))
-        node[3][2][1][1]
-      end
-
-      def end_file(filename)
-        @foreign_keys.keys.each do |table|
-          foreign_keys = @foreign_keys[table] || []
-          indexes = @indexes[table] || []
-          missing_indexes = foreign_keys - indexes
-          missing_indexes.each do |fkey| 
-            add_error("Table '#{table}' is missing an index on the foreign key '#{fkey}'", filename, 1)
-          end
-        end
-      end
-    end
-  end
-end

data/spec/roodi/checks/missing_foreign_key_index_check_spec.rb

@@ -1,33 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Roodi::Checks::MissingForeignKeyIndexCheck do
-  before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::MissingForeignKeyIndexCheck.make)
-  end
-
-  it "should warn about a missing foreign key" do
-    content = <<-END
-ActiveRecord::Schema.define(:version => 20091215233604) do
-  create_table "projects", :force => true do |t|
-    t.string   "name"
-  end
-
-  create_table "revisions", :force => true do |t|
-    t.integer  "project_id"
-    t.string   "key"
-  end
-
-  add_index "revisions", ["project_id"], :name => "index_revisions_on_project_id"
-
-  create_table "source_files", :force => true do |t|
-    t.integer "revision_id"
-    t.string  "filename"
-  end
-end
-    END
-    @roodi.check_content(content, "schema.rb")
-    errors = @roodi.errors
-    errors.should_not be_empty
-    errors[0].to_s.should eql("schema.rb:1 - Table 'source_files' is missing an index on the foreign key 'revision_id'")
-  end
-end