roodi 2.1.0 → 2.2.0

data/Gemfile

@@ -0,0 +1,6 @@
+source :rubygems
+
+gemspec
+
+gem "rake"
+gem "rspec", "~> 1.3.2"

data/Gemfile.lock

@@ -0,0 +1,22 @@
+PATH
+  remote: .
+  specs:
+    roodi (2.2.0)
+      ruby_parser (~> 2.3.0)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    rake (10.0.3)
+    rspec (1.3.2)
+    ruby_parser (2.3.0)
+      sexp_processor (~> 3.0)
+    sexp_processor (3.2.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  rake
+  roodi!
+  rspec (~> 1.3.2)

data/History.txt

@@ -1,9 +1,3 @@
-= 2.1.0
-
-* Ruby 1.9 compatible.
-* New framework support to allow start and end file events.
-* Added MissingForeignKeyIndexCheck.  Still experimental for now.
-
 = 2.0.1
 
 * Fixed a bug where roodi.yml was not being loaded.  Patch supplied by Rob Mitchell.

data/Manifest.txt

@@ -22,7 +22,6 @@ lib/roodi/checks/for_loop_check.rb
 lib/roodi/checks/line_count_check.rb
 lib/roodi/checks/method_line_count_check.rb
 lib/roodi/checks/method_name_check.rb
-lib/roodi/checks/missing_foreign_key_index_check.rb
 lib/roodi/checks/module_line_count_check.rb
 lib/roodi/checks/module_name_check.rb
 lib/roodi/checks/name_check.rb
@@ -50,11 +49,8 @@ spec/roodi/checks/empty_rescue_body_check_spec.rb
 spec/roodi/checks/for_loop_check_spec.rb
 spec/roodi/checks/method_line_count_check_spec.rb
 spec/roodi/checks/method_name_check_spec.rb
-spec/roodi/checks/missing_foreign_key_index_check_spec.rb
 spec/roodi/checks/module_line_count_check_spec.rb
 spec/roodi/checks/module_name_check_spec.rb
 spec/roodi/checks/npath_complexity_method_check_spec.rb
 spec/roodi/checks/parameter_number_check_spec.rb
-spec/roodi/core/runner_spec.rb
-spec/roodi/roodi.yml
 spec/spec_helper.rb

data/Rakefile

@@ -1,16 +1,9 @@
-$:.unshift(File.join(File.dirname(__FILE__), 'lib'))
-
-require 'rubygems'
-require 'hoe'
 require 'rake'
 require 'spec/rake/spectask'
+require 'bundler'
 require 'roodi'
 
-Hoe.new('roodi', Roodi::VERSION) do |p|
-  p.developer('Marty Andrews', 'marty@cogentconsulting.com.au')
-  p.extra_deps = ['ruby_parser']
-  p.remote_rdoc_dir = ''
-end
+Bundler::GemHelper.install_tasks
 
 def roodi(ruby_files)
   roodi = Roodi::Core::Runner.new

data/lib/roodi.rb

@@ -1,6 +1,3 @@
 require 'roodi/checks'
 require 'roodi/core'
-
-module Roodi
-  VERSION = '2.1.0'
-end
+require 'roodi/version'

data/lib/roodi/checks/abc_metric_method_check.rb

@@ -16,9 +16,11 @@ module Roodi
       OPERATORS = [:*, :/, :%, :+, :<<, :>>, :&, :|, :^]
       DEFAULT_SCORE = 10
       
-      def initialize(options = {})
+      attr_accessor :score
+
+      def initialize
         super()
-        @score = options['score'] || DEFAULT_SCORE
+        self.score = DEFAULT_SCORE
       end
       
       def interesting_nodes

data/lib/roodi/checks/assignment_in_conditional_check.rb

@@ -7,10 +7,7 @@ module Roodi
     # A conditional containing an assignment is likely to be a mistyped equality check.  You
     # should either fix the typo or factor out the assignment so that the code is clearer.
     class AssignmentInConditionalCheck < Check
-      def initialize(options = {})
-        super()
-      end
-      
+
       def interesting_nodes
         [:if, :while]
       end
@@ -29,6 +26,7 @@ module Roodi
         end
         found_assignment
       end
+
     end
   end
 end

data/lib/roodi/checks/check.rb

@@ -3,8 +3,23 @@ require 'roodi/core/error'
 module Roodi
   module Checks
     class Check
+
       NODE_TYPES = [:defn, :module, :resbody, :lvar, :cvar, :class, :if, :while, :until, :for, :rescue, :case, :when, :and, :or]
 
+      class << self
+      
+        def make(options = nil)
+          check = new
+          if options
+            options.each do |name, value|
+              check.send("#{name}=", value)
+            end
+          end
+          check
+        end
+
+      end
+
       def initialize
         @errors = []
       end

data/lib/roodi/checks/class_line_count_check.rb

@@ -7,12 +7,22 @@ module Roodi
     # A class getting too large is a code smell that indicates it might be taking on too many 
     # responsibilities.  It should probably be refactored into multiple smaller classes. 
     class ClassLineCountCheck < LineCountCheck
+
       DEFAULT_LINE_COUNT = 300
       
-      def initialize(options = {})
-        line_count = options['line_count'] || DEFAULT_LINE_COUNT
-        super([:class], line_count, 'Class')
+      def initialize
+        super()
+        self.line_count = DEFAULT_LINE_COUNT
+      end
+
+      def interesting_nodes
+        [:class]
       end
+
+      def message_prefix
+        'Class'
+      end
+
     end
   end
 end

data/lib/roodi/checks/class_name_check.rb

@@ -6,16 +6,26 @@ module Roodi
     # 
     # Keeping to a consistent naming convention makes your code easier to read.
     class ClassNameCheck < NameCheck
+
       DEFAULT_PATTERN = /^[A-Z][a-zA-Z0-9]*$/
       
-      def initialize(options = {})
-        pattern = options['pattern'] || DEFAULT_PATTERN
-        super([:class], pattern, 'Class')
+      def initialize
+        super()
+        self.pattern = DEFAULT_PATTERN
       end
       
+      def interesting_nodes
+        [:class]
+      end
+
+      def message_prefix
+        'Class'
+      end
+
       def find_name(node)
         node[1].class == Symbol ? node[1] : node[1].last
       end
+
     end
   end
 end

data/lib/roodi/checks/cyclomatic_complexity_block_check.rb

@@ -12,11 +12,12 @@ module Roodi
     # Generally, for a block, 1-2 is considered good, 3-4 ok, 5-8 consider re-factoring, and 8+ 
     # re-factor now!
     class CyclomaticComplexityBlockCheck < CyclomaticComplexityCheck
+
       DEFAULT_COMPLEXITY = 4
       
-      def initialize(options = {})
-        complexity = options['complexity'] || DEFAULT_COMPLEXITY
-        super(complexity)
+      def initialize
+        super()
+        self.complexity = DEFAULT_COMPLEXITY
       end
       
       def interesting_nodes
@@ -34,6 +35,7 @@ module Roodi
       def evaluate_matching_end
         add_error "Block cyclomatic complexity is #{@count}.  It should be #{@complexity} or less." unless @count <= @complexity
       end
+
     end
   end
 end

data/lib/roodi/checks/cyclomatic_complexity_check.rb

@@ -3,11 +3,13 @@ require 'roodi/checks/check'
 module Roodi
   module Checks
     class CyclomaticComplexityCheck < Check
+      
       COMPLEXITY_NODE_TYPES = [:if, :while, :until, :for, :rescue, :case, :when, :and, :or]
 
-      def initialize(complexity)
+      attr_accessor :complexity
+
+      def initialize
         super()
-        @complexity = complexity
         @count = 0
         @counting = 0
       end
@@ -42,6 +44,7 @@ module Roodi
       def counting?
         @counting > 0
       end
+
     end
   end
 end

data/lib/roodi/checks/cyclomatic_complexity_method_check.rb

@@ -12,11 +12,12 @@ module Roodi
     # Generally, for a method, 1-4 is considered good, 5-8 ok, 9-10 consider re-factoring, and 
     # 11+ re-factor now!
     class CyclomaticComplexityMethodCheck < CyclomaticComplexityCheck
+      
       DEFAULT_COMPLEXITY = 8
       
-      def initialize(options = {})
-        complexity = options['complexity'] || DEFAULT_COMPLEXITY
-        super(complexity)
+      def initialize
+        super()
+        self.complexity = DEFAULT_COMPLEXITY
       end
       
       def interesting_nodes
@@ -35,6 +36,7 @@ module Roodi
       def evaluate_matching_end
         add_error "Method name \"#{@method_name}\" cyclomatic complexity is #{@count}.  It should be #{@complexity} or less." unless @count <= @complexity
       end
+
     end
   end
 end

data/lib/roodi/checks/line_count_check.rb

@@ -3,20 +3,12 @@ require 'roodi/checks/check'
 module Roodi
   module Checks
     class LineCountCheck < Check
-      def initialize(interesting_nodes, line_count, message_prefix)
-        super()
-        @interesting_nodes = interesting_nodes
-        @line_count = line_count
-        @message_prefix = message_prefix
-      end
-
-      def interesting_nodes
-        @interesting_nodes
-      end
+      
+      attr_accessor :line_count
 
       def evaluate_start(node)
         line_count = count_lines(node)
-        add_error "#{@message_prefix} \"#{node[1]}\" has #{line_count} lines.  It should have #{@line_count} or less." unless line_count <= @line_count
+        add_error "#{message_prefix} \"#{node[1]}\" has #{line_count} lines.  It should have #{@line_count} or less." unless line_count <= @line_count
       end
 
       protected
@@ -24,6 +16,7 @@ module Roodi
       def count_lines(node)
         node.last.line - node.line - 1
       end
+
     end
   end
 end

data/lib/roodi/checks/method_line_count_check.rb

@@ -8,12 +8,22 @@ module Roodi
     # thing and becoming hard to test.  It should probably be refactored into multiple methods 
     # that each do a single thing well. 
     class MethodLineCountCheck < LineCountCheck
+
       DEFAULT_LINE_COUNT = 20
       
-      def initialize(options = {})
-        line_count = options['line_count'] || DEFAULT_LINE_COUNT
-        super([:defn], line_count, 'Method')
+      def initialize
+        super()
+        self.line_count = DEFAULT_LINE_COUNT
+      end
+
+      def interesting_nodes
+        [:defn]
       end
+
+      def message_prefix
+        'Method'
+      end
+
     end
   end
 end

data/lib/roodi/checks/method_name_check.rb

@@ -6,16 +6,26 @@ module Roodi
     # 
     # Keeping to a consistent nameing convention makes your code easier to read.
     class MethodNameCheck < NameCheck
+
       DEFAULT_PATTERN = /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/
       
-      def initialize(options = {})
-        pattern = options['pattern'] || DEFAULT_PATTERN
-        super([:defn], pattern, 'Method')
+      def initialize
+        super()
+        self.pattern = DEFAULT_PATTERN
       end
       
+      def interesting_nodes
+        [:defn]
+      end
+
+      def message_prefix
+        'Method'
+      end
+
       def find_name(node)
         node[1]
       end
+
     end
   end
 end

data/lib/roodi/checks/missing_foreign_key_index_check.rb

@@ -10,6 +10,7 @@ module Roodi
     # Enumerable.each with a block instead.
     class MissingForeignKeyIndexCheck < Check
       def initialize
+        super()
         @foreign_keys = {}
         @indexes = {}
       end

data/lib/roodi/checks/module_line_count_check.rb

@@ -7,12 +7,22 @@ module Roodi
     # A module getting too large is a code smell that indicates it might be taking on too many 
     # responsibilities.  It should probably be refactored into multiple smaller modules. 
     class ModuleLineCountCheck < LineCountCheck
+
       DEFAULT_LINE_COUNT = 300
       
-      def initialize(options = {})
-        line_count = options['line_count'] || DEFAULT_LINE_COUNT
-        super([:module], line_count, 'Module')
+      def initialize
+        super()
+        self.line_count = DEFAULT_LINE_COUNT
+      end
+
+      def interesting_nodes
+        [:module]
       end
+
+      def message_prefix
+        'Module'
+      end
+
     end
   end
 end

data/lib/roodi/checks/module_name_check.rb

@@ -6,16 +6,26 @@ module Roodi
     # 
     # Keeping to a consistent nameing convention makes your code easier to read.
     class ModuleNameCheck < NameCheck
+
       DEFAULT_PATTERN = /^[A-Z][a-zA-Z0-9]*$/
       
-      def initialize(options = {})
-        pattern = options['pattern'] || DEFAULT_PATTERN
-        super([:module], pattern, 'Module')
+      def initialize
+        super()
+        self.pattern = DEFAULT_PATTERN
       end
-      
+
+      def interesting_nodes
+        [:module]
+      end
+
+      def message_prefix
+        'Module'
+      end
+
       def find_name(node)
         node[1].class == Symbol ? node[1] : node[1].last
       end
+
     end
   end
 end

data/lib/roodi/checks/name_check.rb

@@ -3,21 +3,14 @@ require 'roodi/checks/check'
 module Roodi
   module Checks
     class NameCheck < Check
-      def initialize(interesting_nodes, pattern, message_prefix)
-        super()
-        @interesting_nodes = interesting_nodes
-        @pattern = pattern
-        @message_prefix = message_prefix
-      end
 
-      def interesting_nodes
-        @interesting_nodes
-      end
+      attr_accessor :pattern
 
       def evaluate_start(node)
         name = find_name(node)
-        add_error "#{@message_prefix} name \"#{name}\" should match pattern #{@pattern.inspect}" unless name.to_s =~ @pattern
+        add_error "#{message_prefix} name \"#{name}\" should match pattern #{@pattern.inspect}" unless name.to_s =~ @pattern
       end
+
     end
   end
 end

data/lib/roodi/checks/npath_complexity_check.rb

@@ -8,6 +8,8 @@ module Roodi
       ADDING_NODE_TYPES = [:rescue]
       COMPLEXITY_NODE_TYPES = MULTIPLYING_NODE_TYPES + ADDING_NODE_TYPES
 
+      attr_accessor :complexity
+      
       def initialize(complexity)
         super()
         @complexity = complexity

data/lib/roodi/checks/npath_complexity_method_check.rb

@@ -4,11 +4,11 @@ module Roodi
   module Checks
     # Checks Npath complexity of a method against a specified limit. 
     class NpathComplexityMethodCheck < NpathComplexityCheck
+
       DEFAULT_COMPLEXITY = 8
       
-      def initialize(options = {})
-        complexity = options['complexity'] || DEFAULT_COMPLEXITY
-        super(complexity)
+      def initialize
+        super(DEFAULT_COMPLEXITY)
       end
       
       def interesting_nodes
@@ -23,6 +23,7 @@ module Roodi
       def evaluate_end_defn(node)
         add_error "Method name \"#{@method_name}\" n-path complexity is #{@current_value}.  It should be #{@complexity} or less." unless @current_value <= @complexity
       end
+
     end
   end
 end

data/lib/roodi/checks/parameter_number_check.rb

@@ -8,11 +8,14 @@ module Roodi
     # much, or that the parameters should be grouped into one or more objects of their own.  It
     # probably needs some refactoring. 
     class ParameterNumberCheck < Check
+      
       DEFAULT_PARAMETER_COUNT = 5
       
-      def initialize(options = {})
+      attr_accessor :parameter_count
+
+      def initialize
         super()
-        @parameter_count = options['parameter_count'] || DEFAULT_PARAMETER_COUNT
+        self.parameter_count = DEFAULT_PARAMETER_COUNT
       end
       
       def interesting_nodes
@@ -22,9 +25,10 @@ module Roodi
       def evaluate_start(node)
         method_name = node[1]
         arguments = node[2]
-        parameter_count = arguments.inject(-1) { |count, each| count = count + (each.class == Symbol ? 1 : 0) }
-        add_error "Method name \"#{method_name}\" has #{parameter_count} parameters.  It should have #{@parameter_count} or less." unless parameter_count <= @parameter_count
+        actual_parameter_count = arguments.inject(-1) { |count, each| count = count + (each.class == Symbol ? 1 : 0) }
+        add_error "Method name \"#{method_name}\" has #{actual_parameter_count} parameters.  It should have #{@parameter_count} or less." unless actual_parameter_count <= @parameter_count
       end
+
     end
   end
 end

data/lib/roodi/core/runner.rb

@@ -15,7 +15,6 @@ module Roodi
       def initialize(*checks)
         @config = DEFAULT_CONFIG
         @checks = checks unless checks.empty?
-        @parser = Parser.new
       end
       
       def check(filename, content)
@@ -36,7 +35,7 @@ module Roodi
       end
   
       def print(filename, content)
-        node = @parser.parse(content, filename)
+        node = parse(content, filename)
         puts "Line: #{node.line}"
         pp node
       end
@@ -59,7 +58,7 @@ module Roodi
       
       def parse(filename, content)
         begin
-          @parser.parse(content, filename)
+          Parser.new.parse(content, filename)
         rescue Exception => e
           puts "#{filename} looks like it's not a valid Ruby file.  Skipping..." if ENV["ROODI_DEBUG"]
           nil
@@ -69,12 +68,13 @@ module Roodi
       def load_checks
         check_objects = []
         checks = YAML.load_file @config
-        checks.each do |check| 
-          klass = eval("Roodi::Checks::#{check[0]}")
-          check_objects << (check[1].empty? ? klass.new : klass.new(check[1]))
+        checks.each do |check_class_name, options|
+          check_class = Roodi::Checks.const_get(check_class_name)
+          check_objects << check_class.make(options || {})
         end
         check_objects
       end
+
     end
   end
 end

data/lib/roodi/version.rb

@@ -0,0 +1,3 @@
+module Roodi
+  VERSION = '2.2.0'
+end

data/roodi.gemspec

@@ -0,0 +1,18 @@
+$: << File.expand_path("../lib", __FILE__)
+require "roodi/version"
+
+Gem::Specification.new do |gem|
+
+  gem.name = "roodi"
+  gem.summary = "Roodi stands for Ruby Object Oriented Design Inferometer"
+  gem.description = "Roodi stands for Ruby Object Oriented Design Inferometer"
+  gem.homepage = "http://roodi.rubyforge.org"
+  gem.authors = ["Marty Andrews"]
+  gem.email = "marty@cogent.co"
+  gem.files = Dir['lib/**/*.rb'] + Dir['bin/*'] + Dir['[A-Za-z]*'] + Dir['spec/**/*']
+  gem.version = Roodi::VERSION.dup
+  gem.platform = Gem::Platform::RUBY
+  gem.add_runtime_dependency("ruby_parser", "~> 2.3.0")
+  gem.executables = ["roodi", "roodi-describe"]
+
+end

data/roodi.yml

@@ -1,16 +1,25 @@
-AssignmentInConditionalCheck:    { }
-CaseMissingElseCheck:            { }
-ClassLineCountCheck:             { line_count: 300 }
-ClassNameCheck:                  { pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/ }
-ClassVariableCheck:              { }
-CyclomaticComplexityBlockCheck:  { complexity: 4 }
-CyclomaticComplexityMethodCheck: { complexity: 8 }
-EmptyRescueBodyCheck:            { }
-ForLoopCheck:                    { }
-MethodLineCountCheck:            { line_count: 20 }
-MethodNameCheck:                 { pattern: !ruby/regexp /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/ }
-# MissingForeignKeyIndexCheck:     { }
-ModuleLineCountCheck:            { line_count: 300 }
-ModuleNameCheck:                 { pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/ }
-ParameterNumberCheck:            { parameter_count: 5 }
+AssignmentInConditionalCheck:
+CaseMissingElseCheck:
+ClassLineCountCheck:             
+  line_count: 300 
+ClassNameCheck:                  
+  pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/
+ClassVariableCheck:
+CyclomaticComplexityBlockCheck:  
+  complexity: 4
+CyclomaticComplexityMethodCheck: 
+  complexity: 8
+EmptyRescueBodyCheck:
+ForLoopCheck:
+MethodLineCountCheck:            
+  line_count: 20 
+MethodNameCheck:                 
+  pattern: !ruby/regexp /^[_a-z<>=\[|+-\/\*`]+[_a-z0-9_<>=~@\[\]]*[=!\?]?$/ 
+# MissingForeignKeyIndexCheck:
+ModuleLineCountCheck:            
+  line_count: 300
+ModuleNameCheck:          
+  pattern: !ruby/regexp /^[A-Z][a-zA-Z0-9]*$/
+ParameterNumberCheck:            
+  parameter_count: 5
  

data/spec/roodi/checks/abc_metric_method_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::AbcMetricMethodCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::AbcMetricMethodCheck.new({'score' => 0}))
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::AbcMetricMethodCheck.make({'score' => 0}))
   end
 
   def verify_content_score(content, a, b, c)

data/spec/roodi/checks/assignment_in_conditional_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::AssignmentInConditionalCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::AssignmentInConditionalCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::AssignmentInConditionalCheck.make)
   end
   
   it "should accept an assignment before an if clause" do

data/spec/roodi/checks/case_missing_else_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::CaseMissingElseCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::CaseMissingElseCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::CaseMissingElseCheck.make)
   end
   
   it "should accept case statements that do have an else" do

data/spec/roodi/checks/class_line_count_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::ClassLineCountCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ClassLineCountCheck.new({'line_count' => 1}))
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ClassLineCountCheck.make({'line_count' => 1}))
   end
   
   it "should accept classes with less lines than the threshold" do

data/spec/roodi/checks/class_name_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::ClassNameCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ClassNameCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ClassNameCheck.make)
   end
   
   it "should accept camel case class names starting in capitals" do

data/spec/roodi/checks/class_variable_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::ClassVariableCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ClassVariableCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ClassVariableCheck.make)
   end
   
   it "should reject class variables" do

data/spec/roodi/checks/control_coupling_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::ControlCouplingCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ControlCouplingCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ControlCouplingCheck.make)
   end
   
   it "should reject methods with if checks using a parameter" do

data/spec/roodi/checks/cyclomatic_complexity_block_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::CyclomaticComplexityBlockCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::CyclomaticComplexityBlockCheck.new({'complexity' => 0}))
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::CyclomaticComplexityBlockCheck.make({'complexity' => 0}))
   end
 
   def verify_content_complexity(content, complexity)

data/spec/roodi/checks/cyclomatic_complexity_method_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::CyclomaticComplexityMethodCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::CyclomaticComplexityMethodCheck.new({'complexity' => 0}))
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::CyclomaticComplexityMethodCheck.make({'complexity' => 0}))
   end
 
   def verify_content_complexity(content, complexity)

data/spec/roodi/checks/empty_rescue_body_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::EmptyRescueBodyCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::EmptyRescueBodyCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::EmptyRescueBodyCheck.make)
   end
   
   it "should accept a rescue body with content and no parameter" do

data/spec/roodi/checks/for_loop_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::ForLoopCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ForLoopCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ForLoopCheck.make)
   end
   
   it "should reject for loops" do

data/spec/roodi/checks/method_line_count_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::MethodLineCountCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::MethodLineCountCheck.new({'line_count' => 1}))
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::MethodLineCountCheck.make({'line_count' => 1}))
   end
   
   it "should accept methods with less lines than the threshold" do

data/spec/roodi/checks/method_name_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::MethodNameCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::MethodNameCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::MethodNameCheck.make)
   end
   
   it "should accept method names with underscores" do

data/spec/roodi/checks/missing_foreign_key_index_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::MissingForeignKeyIndexCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::MissingForeignKeyIndexCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::MissingForeignKeyIndexCheck.make)
   end
 
   it "should warn about a missing foreign key" do

data/spec/roodi/checks/module_line_count_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::ModuleLineCountCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ModuleLineCountCheck.new({'line_count' => 1}))
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ModuleLineCountCheck.make({'line_count' => 1}))
   end
   
   it "should accept modules with less lines than the threshold" do

data/spec/roodi/checks/module_name_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::ModuleNameCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ModuleNameCheck.new)
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ModuleNameCheck.make)
   end
   
   it "should accept camel case module names starting in capitals" do

data/spec/roodi/checks/npath_complexity_method_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::NpathComplexityMethodCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::NpathComplexityMethodCheck.new({'complexity' => 0}))
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::NpathComplexityMethodCheck.make({'complexity' => 0}))
   end
 
   def verify_content_complexity(content, complexity)

data/spec/roodi/checks/parameter_number_check_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Roodi::Checks::ParameterNumberCheck do
   before(:each) do
-    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ParameterNumberCheck.new({'parameter_count' => 1}))
+    @roodi = Roodi::Core::Runner.new(Roodi::Checks::ParameterNumberCheck.make({'parameter_count' => 1}))
   end
   
   it "should accept methods with less lines than the threshold" do

data/spec/roodi/roodi.yml

@@ -1 +1,2 @@
-MethodNameCheck:                 { pattern: !ruby/regexp /^[A-Z]+$/ }
+MethodNameCheck:
+  pattern: !ruby/regexp /^[A-Z]+$/

metadata

@@ -1,58 +1,40 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: roodi
-version: !ruby/object:Gem::Version 
-  version: 2.1.0
+version: !ruby/object:Gem::Version
+  version: 2.2.0
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Marty Andrews
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2009-12-28 00:00:00 +11:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2013-01-25 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: ruby_parser
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.3.0
   type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
-    version: 
-- !ruby/object:Gem::Dependency 
-  name: hoe
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: 2.3.3
-    version: 
-description: Roodi stands for Ruby Object Oriented Design Inferometer.  It parses your Ruby code and warns you about design issues you have based on the checks that is has configured.
-email: 
-- marty@cogentconsulting.com.au
-executables: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.3.0
+description: Roodi stands for Ruby Object Oriented Design Inferometer
+email: marty@cogent.co
+executables:
 - roodi
 - roodi-describe
 extensions: []
-
-extra_rdoc_files: 
-- History.txt
-- Manifest.txt
-- README.txt
-files: 
-- History.txt
-- Manifest.txt
-- README.txt
-- Rakefile
-- bin/roodi
-- bin/roodi-describe
-- lib/roodi.rb
-- lib/roodi/checks.rb
+extra_rdoc_files: []
+files:
 - lib/roodi/checks/abc_metric_method_check.rb
 - lib/roodi/checks/assignment_in_conditional_check.rb
 - lib/roodi/checks/case_missing_else_check.rb
@@ -76,13 +58,25 @@ files:
 - lib/roodi/checks/npath_complexity_check.rb
 - lib/roodi/checks/npath_complexity_method_check.rb
 - lib/roodi/checks/parameter_number_check.rb
-- lib/roodi/core.rb
+- lib/roodi/checks.rb
 - lib/roodi/core/checking_visitor.rb
 - lib/roodi/core/error.rb
 - lib/roodi/core/parser.rb
 - lib/roodi/core/runner.rb
 - lib/roodi/core/visitable_sexp.rb
+- lib/roodi/core.rb
+- lib/roodi/version.rb
+- lib/roodi.rb
 - lib/roodi_task.rb
+- bin/roodi
+- bin/roodi-describe
+- Gemfile
+- Gemfile.lock
+- History.txt
+- Manifest.txt
+- Rakefile
+- README.txt
+- roodi.gemspec
 - roodi.yml
 - spec/roodi/checks/abc_metric_method_check_spec.rb
 - spec/roodi/checks/assignment_in_conditional_check_spec.rb
@@ -105,34 +99,34 @@ files:
 - spec/roodi/core/runner_spec.rb
 - spec/roodi/roodi.yml
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: http://roodi.rubyforge.org
 licenses: []
-
 post_install_message: 
-rdoc_options: 
-- --main
-- README.txt
-require_paths: 
+rdoc_options: []
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: -2141010416866692951
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: -2141010416866692951
 requirements: []
-
-rubyforge_project: roodi
-rubygems_version: 1.3.5
+rubyforge_project: 
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Roodi stands for Ruby Object Oriented Design Inferometer
 test_files: []
-