roodi 1.3.5 → 1.3.6

data/History.txt

@@ -1,3 +1,7 @@
+= 1.3.6
+
+* Added nil as a valid response for an empty rescue block
+
 = 1.3.5
 
 * Fixed bug in rake task

data/lib/roodi.rb

@@ -2,5 +2,5 @@ require 'roodi/checks'
 require 'roodi/core'
 
 module Roodi
-  VERSION = '1.3.5'
+  VERSION = '1.3.6'
 end

data/lib/roodi/checks/empty_rescue_body_check.rb

@@ -7,7 +7,7 @@ module Roodi
     # When the body of a rescue block is empty, exceptions can get caught and swallowed without
     # any feedback to the user.
     class EmptyRescueBodyCheck < Check
-      STATEMENT_NODES = [:fcall, :return, :attrasgn, :vcall]
+      STATEMENT_NODES = [:fcall, :return, :attrasgn, :vcall, :nil]
       
       def interesting_nodes
         [:resbody]

data/spec/roodi/checks/empty_rescue_body_check_spec.rb

@@ -90,6 +90,15 @@ describe Roodi::Checks::EmptyRescueBodyCheck do
     errors[0].to_s.should eql("dummy-file.rb:3 - Rescue block should not be empty.")
   end
 
+  it "should accept a rescue block with an explicit nil" do
+    content = <<-END
+    call_method rescue nil
+    END
+    @roodi.check_content(content)
+    errors = @roodi.errors
+    errors.should be_empty
+  end
+
   it "should reject an empty rescue block with a parameter" do
     content = <<-END
     begin

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: roodi
 version: !ruby/object:Gem::Version 
-  version: 1.3.5
+  version: 1.3.6
 platform: ruby
 authors: 
 - Marty Andrews
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-10 00:00:00 +10:00
+date: 2009-05-04 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency