roo_on_rails 2.1.0 → 2.1.2

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: d2087a16081bf1826323d093e4a69ed2e6242e10
4
- data.tar.gz: f48656fe62c5deb2c09cd137eb8cd1b73c94d4a6
3
+ metadata.gz: a4f7beb1235b80ea826919a641b7b44754702cda
4
+ data.tar.gz: 06aa080ac742fc3fb7a4154ea5c0311d3f67e70c
5
5
  SHA512:
6
- metadata.gz: c10e9b4be3c0a5151595a4e144d8b8a1c2eb4fab4736cb7941e388c59d4ff81722efcb76482c5466c55071e6fd78eeaf306a88cefa45971baa4dd2dadebf7d0e
7
- data.tar.gz: 39d2b995f0e7cdd65941e08949bd6b3e54c725829dd7b1e588e4f104c908187529da5cfb704b4ea156dde53ccc2827b1c2650d2ffee407b37a427413148ed46b
6
+ metadata.gz: f8afc738c99dc50e34e2e21acd8b531678a07c39d574352bcd8028df0defa0653ca3763b2480a8423e9711bfcb445bc68d2320fcfa5b11e94d5d591c6b7418a8
7
+ data.tar.gz: 43f9e982df0696736b88b8eb09ac73aaaec5b638163f777d04e6f832f408dbe0dd635391929c56466536747d985a4aca51507cb1d1f1f74717657f5b1e8da6a3
data/CHANGELOG.md CHANGED
@@ -1,3 +1,9 @@
1
+ # v2.1.2
2
+
3
+ Bug fix:
4
+
5
+ - fixes PopulateEnvFromJWT caching issue where a key that couldn't be fetched would be cached
6
+
1
7
  # v2.1.0
2
8
 
3
9
  Features:
data/README.md CHANGED
@@ -21,9 +21,6 @@
21
21
  - [Disabling SSL enforcement](#disabling-ssl-enforcement)
22
22
  - [Database configuration](#database-configuration)
23
23
  - [Sidekiq](#sidekiq)
24
- - [HireFire](#hirefire)
25
- - [For Web Dynos](#for-web-dynos)
26
- - [For Sidekiq Workers](#for-sidekiq-workers)
27
24
  - [Logging](#logging)
28
25
  - [Identity](#identity)
29
26
  - [Google OAuth authentication](#google-oauth-authentication)
@@ -137,48 +134,6 @@ NB. If you are migrating to SLA-based queue names, do not set `SIDEKIQ_ENABLED`
137
134
  to `true` before your old queues have finished processing (this will prevent
138
135
  Sidekiq from seeing the old queues at all).
139
136
 
140
- ### HireFire
141
-
142
- #### For Web Dynos
143
-
144
- Web dynos can be autoscaled by HireFire _only_ if it has been configured to use the `Web.Logplex.Load` source and the Heroku runtime metrics lab feature has been enabled:
145
-
146
- ```bash
147
- $ heroku labs:enable log-runtime-metrics -a your-service-name-here
148
- ```
149
-
150
- You will also need a log drain for HireFire, but the RooOnRails helper below should configure this for you. You can check with
151
-
152
- ```bash
153
- $ heroku drains | grep hirefire
154
- https://logdrain.hirefire.io (d.00000000-0000-0000-0000-000000000000)
155
-
156
- # No drain? Add with:
157
- $ heroku drains:add -a your-service-name-here https://logdrain.hirefire.io
158
- ```
159
-
160
- ([HireFire docs for set up](https://help.hirefire.io/guides/logplex/load-logplex))
161
-
162
- #### For Sidekiq Workers
163
-
164
- When `HIREFIRE_TOKEN` is set an endpoint will be mounted at `/hirefire` that
165
- reports the required worker count as a function of queue latency. By default we
166
- add queue names in the style 'within1day', so if we notice an average latency in
167
- that queue of more than an set threshold we'll request one more worker. If we
168
- notice less than a threshold we'll request one less worker. These settings can
169
- be customised via the following ENV variables
170
-
171
- - `WORKER_INCREASE_THRESHOLD` (default 0.5)
172
- - `WORKER_DECREASE_THRESHOLD` (default 0.1)
173
-
174
- When setting the manager up in the HireFire web ui, the following settings must
175
- be used:
176
-
177
- - name: 'worker'
178
- - type: 'Worker.HireFire.JobQueue'
179
- - ratio: 1
180
- - decrementable: 'true'
181
-
182
137
  ### Logging
183
138
 
184
139
  For clearer and machine-parseable log output, the Rails logger is replaced by an
@@ -382,6 +337,11 @@ The command is designed to fix issues in many cases.
382
337
  Pull requests are welcome on GitHub at
383
338
  `https://github.com/deliveroo/roo_on_rails`.
384
339
 
340
+ ## Releasing
341
+
342
+ 1. Bump the version number in `lib/roo_on_rails/version.rb
343
+ 1. Add an entry to the changelog
344
+ 1. After merging to master release e.g. `bundle exec rake release`
385
345
 
386
346
  ## License
387
347
 
@@ -22,7 +22,8 @@ module RooOnRails
22
22
  @app = app
23
23
  @logger = logger
24
24
  @url_mappings = url_mappings
25
- @keys = @mapped_urls = {}
25
+ @keys = {}
26
+ @mapped_urls = {}
26
27
 
27
28
  if skip_sig_verify && non_prod?
28
29
  @logger.warn "JWTs signature verifification has been switched off in development."
@@ -14,19 +14,9 @@ module RooOnRails
14
14
  end
15
15
 
16
16
  Rails.logger.debug '[roo_on_rails.sidekiq] loading'
17
- require 'hirefire-resource'
18
17
 
19
18
  config_sidekiq
20
19
  config_sidekiq_metrics
21
- config_hirefire(app)
22
- end
23
-
24
- def config_hirefire(app)
25
- unless ENV['HIREFIRE_TOKEN']
26
- Rails.logger.warn 'No HIREFIRE_TOKEN token set, auto scaling not enabled'
27
- return
28
- end
29
- add_middleware(app)
30
20
  end
31
21
 
32
22
  def config_sidekiq
@@ -1,3 +1,3 @@
1
1
  module RooOnRails
2
- VERSION = '2.1.0'.freeze
2
+ VERSION = '2.1.2'.freeze
3
3
  end
data/roo_on_rails.gemspec CHANGED
@@ -29,7 +29,6 @@ Gem::Specification.new do |spec|
29
29
  spec.add_runtime_dependency 'rack-timeout', '>= 0.4.0'
30
30
  spec.add_runtime_dependency 'rack-ssl-enforcer'
31
31
  spec.add_runtime_dependency 'octokit'
32
- spec.add_runtime_dependency 'hirefire-resource'
33
32
  spec.add_runtime_dependency 'sidekiq', '< 6.0.0'
34
33
  spec.add_runtime_dependency 'dogstatsd-ruby'
35
34
  spec.add_runtime_dependency 'omniauth-google-oauth2'
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: roo_on_rails
3
3
  version: !ruby/object:Gem::Version
4
- version: 2.1.0
4
+ version: 2.1.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - Julien Letessier
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2020-09-18 00:00:00.000000000 Z
11
+ date: 2021-06-01 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: dotenv-rails
@@ -122,20 +122,6 @@ dependencies:
122
122
  - - ">="
123
123
  - !ruby/object:Gem::Version
124
124
  version: '0'
125
- - !ruby/object:Gem::Dependency
126
- name: hirefire-resource
127
- requirement: !ruby/object:Gem::Requirement
128
- requirements:
129
- - - ">="
130
- - !ruby/object:Gem::Version
131
- version: '0'
132
- type: :runtime
133
- prerelease: false
134
- version_requirements: !ruby/object:Gem::Requirement
135
- requirements:
136
- - - ">="
137
- - !ruby/object:Gem::Version
138
- version: '0'
139
125
  - !ruby/object:Gem::Dependency
140
126
  name: sidekiq
141
127
  requirement: !ruby/object:Gem::Requirement