roo 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 97a621e940844c1142964501c7a78fa0cd054c86
-  data.tar.gz: 9db0bb973c120511a2bba167b152b3ff6dadb488
+  metadata.gz: 53d37d09a786f9536fd5bb00c7cacf9888c8b032
+  data.tar.gz: 284974b328b26668c58e3b952a12b8777439037f
 SHA512:
-  metadata.gz: 0831fd41e73b58b153b04ebda1ccbed591219b15d69070e4a5b50c4298c2b12a396feb0ffcd3f0d6a0b94ea6848897ae2324cd12cee721c38beea82c8e512b26
-  data.tar.gz: e409801f0e341dcde7333830ec08b4150ec7e8310924583fac260ace3816c2bb950bb419c3d2060578fbd1b7e129c34bb2f825ffcde60fdde1c4a9fb384f2937
+  metadata.gz: 4b0e6d58d52600710fc5feb49e7483fc81e4bca65fa9013a3fa1004f5526107392b02f982ae981676544e301056a0246b4b85e38d3959565174c247ce49695a9
+  data.tar.gz: 5c3beb6580bece8aa730d1f29b6316889ebb7ce5a7003d8f654edcb1c9800a9f939021fd0d88749489ffdee6ebf496739664e5fede43aeb0067a2a16ad46f2f5

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [2.1.1] - 2015-08-02
+### Fixed invalid new lines with _x000D_ character[#231](https://github.com/roo-rb/roo/pull/231)
+### Fixed missing URI issue. [#245](https://github.com/roo-rb/roo/pull/245)
+
 ## [2.1.0] - 2015-07-18
 ### Added
 - Added support for Excel 2007 `xlsm` files. [#232](https://github.com/roo-rb/roo/pull/232)

data/README.md

@@ -3,14 +3,11 @@
 [![Build Status](https://img.shields.io/travis/roo-rb/roo.svg?style=flat-square)](https://travis-ci.org/roo-rb/roo) [![Code Climate](https://img.shields.io/codeclimate/github/roo-rb/roo.svg?style=flat-square)](https://codeclimate.com/github/roo-rb/roo) [![Coverage Status](https://img.shields.io/coveralls/roo-rb/roo.svg?style=flat-square)](https://coveralls.io/r/roo-rb/roo) [![Gem Version](https://img.shields.io/gem/v/roo.svg?style=flat-square)](https://rubygems.org/gems/roo)
 
 Roo implements read access for all common spreadsheet types. It can handle:
-
-* Excelx
-* OpenOffice / LibreOffice
+* Excel 2007 - 2013 formats (xlsx, xlsm)
+* LibreOffice / OpenOffice.org formats (ods)
 * CSV
-
-## Additional Libraries
-
-In addition, the [roo-xls](https://github.com/roo-rb/roo-xls) and [roo-google](https://github.com/roo-rb/roo-google) gems exist to extend Roo to support reading classic Excel formats (i.e. `.xls` and ``Excel2003XML``) and read/write access for Google spreadsheets.
+* Excel 97, Excel 2002 XML, and Excel 2003 XML formats when using the [roo-xls](https://github.com/roo-rb/roo-xls) gem (xls, xml)
+* Google spreadsheets with read/write access when using [roo-google](https://github.com/roo-rb/roo-google)
 
 ## Installation
 

data/lib/roo/base.rb

@@ -91,7 +91,7 @@ class Roo::Base
       first_column = [first_column, key.last.to_i].min
       last_column = [last_column, key.last.to_i].max
     end if @cell[sheet]
-    {first_row: first_row, first_column: first_column, last_row: last_row, last_column: last_column}
+    { first_row: first_row, first_column: first_column, last_row: last_row, last_column: last_column }
   end
 
   %w(first_row last_row first_column last_column).each do |key|
@@ -117,22 +117,23 @@ class Roo::Base
     result = "--- \n"
     from_row.upto(to_row) do |row|
       from_column.upto(to_column) do |col|
-        unless empty?(row, col, sheet)
-          result << "cell_#{row}_#{col}: \n"
-          prefix.each do|k, v|
-            result << "  #{k}: #{v} \n"
-          end
-          result << "  row: #{row} \n"
-          result << "  col: #{col} \n"
-          result << "  celltype: #{celltype(row, col, sheet)} \n"
-          value = cell(row, col, sheet)
-          if celltype(row, col, sheet) == :time
-            value = integer_to_timestring(value)
-          end
-          result << "  value: #{value} \n"
+        next if empty?(row, col, sheet)
+
+        result << "cell_#{row}_#{col}: \n"
+        prefix.each do|k, v|
+          result << "  #{k}: #{v} \n"
+        end
+        result << "  row: #{row} \n"
+        result << "  col: #{col} \n"
+        result << "  celltype: #{celltype(row, col, sheet)} \n"
+        value = cell(row, col, sheet)
+        if celltype(row, col, sheet) == :time
+          value = integer_to_timestring(value)
         end
+        result << "  value: #{value} \n"
       end
     end
+
     result
   end
 
@@ -170,7 +171,7 @@ class Roo::Base
   end
 
   def inspect
-    "<##{ self.class }:#{ self.object_id.to_s(8) } #{ self.instance_variables.join(' ') }>"
+    "<##{self.class}:#{object_id.to_s(8)} #{instance_variables.join(' ')}>"
   end
 
   # find a row either by row number or a condition
@@ -217,7 +218,7 @@ class Roo::Base
     row, col = normalize(row, col)
     cell_type = cell_type_by_value(value)
     set_value(row, col, value, sheet)
-    set_type(row, col, cell_type , sheet)
+    set_type(row, col, cell_type, sheet)
   end
 
   def cell_type_by_value(value)
@@ -225,7 +226,7 @@ class Roo::Base
     when Fixnum then :float
     when String, Float then :string
     else
-      raise ArgumentError, "Type for #{value} not set"
+      fail ArgumentError, "Type for #{value} not set"
     end
   end
 
@@ -256,13 +257,13 @@ class Roo::Base
       sheets.each do|sheet|
         self.default_sheet = sheet
         result << 'Sheet ' + n.to_s + ":\n"
-        unless first_row
-          result << '  - empty -'
-        else
+        if first_row
           result << "  First row: #{first_row}\n"
           result << "  Last row: #{last_row}\n"
           result << "  First column: #{::Roo::Utils.number_to_letter(first_column)}\n"
           result << "  Last column: #{::Roo::Utils.number_to_letter(last_column)}"
+        else
+          result << '  - empty -'
         end
         result << "\n" if sheet != sheets.last
         n += 1
@@ -282,12 +283,12 @@ class Roo::Base
               # sonst gibt es Fehler bei leeren Blaettern
               first_row.upto(last_row) do |row|
                 first_column.upto(last_column) do |col|
-                  unless empty?(row, col)
-                    x.cell(cell(row, col),
+                  next if empty?(row, col)
+
+                  x.cell(cell(row, col),
                            row: row,
                            column: col,
                            type: celltype(row, col))
-                  end
                 end
               end
             end
@@ -318,7 +319,7 @@ class Roo::Base
   # access different worksheets by calling spreadsheet.sheet(1)
   # or spreadsheet.sheet('SHEETNAME')
   def sheet(index, name = false)
-    self.default_sheet = String === index ? index : sheets[index]
+    self.default_sheet = index.is_a?(::String) ? index : sheets[index]
     name ? [default_sheet, self] : self
   end
 
@@ -352,25 +353,23 @@ class Roo::Base
   # control characters and white spaces around columns
 
   def each(options = {})
-    if block_given?
-      if options.empty?
-        1.upto(last_row) do |line|
-          yield row(line)
-        end
-      else
-        clean_sheet_if_need(options)
-        search_or_set_header(options)
-        headers = @headers ||
-                  Hash[(first_column..last_column).map do |col|
-                    [cell(@header_line, col), col]
-                  end]
-
-        @header_line.upto(last_row) do |line|
-          yield(Hash[headers.map { |k, v| [k, cell(line, v)] }])
-        end
+    return to_enum(:each, options) unless block_given?
+
+    if options.empty?
+      1.upto(last_row) do |line|
+        yield row(line)
       end
     else
-      to_enum(:each, options)
+      clean_sheet_if_need(options)
+      search_or_set_header(options)
+      headers = @headers ||
+                Hash[(first_column..last_column).map do |col|
+                  [cell(@header_line, col), col]
+                end]
+
+      @header_line.upto(last_row) do |line|
+        yield(Hash[headers.map { |k, v| [k, cell(line, v)] }])
+      end
     end
   end
 
@@ -409,23 +408,24 @@ class Roo::Base
       filename = File.basename(filename, File.extname(filename))
     end
 
-    if uri?(filename) && qs_begin = filename.rindex('?')
+    if uri?(filename) && (qs_begin = filename.rindex('?'))
       filename = filename[0..qs_begin - 1]
     end
     exts = Array(exts)
-    if !exts.include?(File.extname(filename).downcase)
-      case warning_level
-      when :error
-        warn file_type_warning_message(filename, exts)
-        fail TypeError, "#{filename} is not #{name} file"
-      when :warning
-        warn "are you sure, this is #{name} spreadsheet file?"
-        warn file_type_warning_message(filename, exts)
-      when :ignore
-        # ignore
-      else
-        fail "#{warning_level} illegal state of file_warning"
-      end
+
+    return if exts.include?(File.extname(filename).downcase)
+
+    case warning_level
+    when :error
+      warn file_type_warning_message(filename, exts)
+      fail TypeError, "#{filename} is not #{name} file"
+    when :warning
+      warn "are you sure, this is #{name} spreadsheet file?"
+      warn file_type_warning_message(filename, exts)
+    when :ignore
+      # ignore
+    else
+      fail "#{warning_level} illegal state of file_warning"
     end
   end
 
@@ -476,9 +476,9 @@ class Roo::Base
     return if is_stream?(filename)
     filename = download_uri(filename, tmpdir) if uri?(filename)
     filename = unzip(filename, tmpdir) if packed == :zip
-    unless File.file?(filename)
-      fail IOError, "file #{filename} does not exist"
-    end
+
+    fail IOError, "file #{filename} does not exist" unless File.file?(filename)
+
     filename
   end
 
@@ -536,11 +536,8 @@ class Roo::Base
   end
 
   def make_tmpdir(prefix = nil, root = nil, &block)
-    prefix = if prefix
-      TEMP_PREFIX + prefix
-    else
-      TEMP_PREFIX
-    end
+    prefix = "#{TEMP_PREFIX}#{prefix}"
+
     ::Dir.mktmpdir(prefix, root || ENV['ROO_TMP'], &block).tap do |result|
       block_given? || track_tmpdir!(result)
     end
@@ -588,9 +585,9 @@ class Roo::Base
         fail ArgumentError
       end
     end
-    if col.is_a?(::String)
-      col = ::Roo::Utils.letter_to_number(col)
-    end
+
+    col = ::Roo::Utils.letter_to_number(col) if col.is_a?(::String)
+
     [row, col]
   end
 
@@ -641,7 +638,7 @@ class Roo::Base
         fail RangeError, "sheet index #{sheet} not found"
       end
     when String
-      unless sheets.include? sheet
+      unless sheets.include?(sheet)
         fail RangeError, "sheet '#{sheet}' not found"
       end
     else
@@ -670,14 +667,14 @@ class Roo::Base
   # parameter is nil the output goes to STDOUT
   def write_csv_content(file = nil, sheet = nil, separator = ',')
     file ||= STDOUT
-    if first_row(sheet) # sheet is not empty
-      1.upto(last_row(sheet)) do |row|
-        1.upto(last_column(sheet)) do |col|
-          file.print(separator) if col > 1
-          file.print cell_to_csv(row, col, sheet)
-        end
-        file.print("\n")
-      end # sheet not empty
+    return unless first_row(sheet) # The sheet is empty
+
+    1.upto(last_row(sheet)) do |row|
+      1.upto(last_column(sheet)) do |col|
+        file.print(separator) if col > 1
+        file.print cell_to_csv(row, col, sheet)
+      end
+      file.print("\n")
     end
   end
 
@@ -729,9 +726,9 @@ class Roo::Base
   # converts an integer value to a time string like '02:05:06'
   def integer_to_timestring(content)
     h = (content / 3600.0).floor
-    content = content - h * 3600
+    content -= h * 3600
     m = (content / 60.0).floor
-    content = content - m * 60
+    content -= m * 60
     s = content
     sprintf('%02d:%02d:%02d', h, m, s)
   end

data/lib/roo/excelx/shared_strings.rb

@@ -13,9 +13,19 @@ module Roo
 
       private
 
+      def fix_invalid_shared_strings(doc)
+        invalid = { '_x000D_'  => "\n" }
+        xml = doc.to_s
+
+        if xml[/#{invalid.keys.join('|')}/]
+          @doc = ::Nokogiri::XML(xml.gsub(/#{invalid.keys.join('|')}/, invalid))
+        end
+      end
+
       def extract_shared_strings
         return [] unless doc_exists?
 
+        fix_invalid_shared_strings(doc)
         # read the shared strings xml document
         doc.xpath('/sst/si').map do |si|
           shared_string = ''

data/lib/roo/spreadsheet.rb

@@ -1,3 +1,5 @@
+require 'uri'
+
 module Roo
   class Spreadsheet
     class << self

data/lib/roo/version.rb

@@ -1,3 +1,3 @@
 module Roo
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/helpers.rb

@@ -0,0 +1,5 @@
+module Helpers
+  def yaml_entry(row,col,type,value)
+    "cell_#{row}_#{col}: \n  row: #{row} \n  col: #{col} \n  celltype: #{type} \n  value: #{value} \n"
+  end
+end

data/spec/lib/roo/base_spec.rb

@@ -1,4 +1,216 @@
 require 'spec_helper'
 
 describe Roo::Base do
+  let(:klass) do
+    Class.new(Roo::Base) do
+      def initialize(filename, data = {})
+        super(filename)
+        @data ||= data
+      end
+
+      def read_cells(sheet = default_sheet)
+        return if @cells_read[sheet]
+        type_map = { String => :string, Date => :date, Numeric => :float }
+
+        @cell[sheet] = @data
+        @cell_type[sheet] = Hash[@data.map { |k, v| [k, type_map.find {|type,_| v.is_a?(type) }.last ] }]
+        @first_row[sheet] = @data.map { |k, _| k[0] }.min
+        @last_row[sheet] = @data.map { |k, _| k[0] }.max
+        @first_column[sheet] = @data.map { |k, _| k[1] }.min
+        @last_column[sheet] = @data.map { |k, _| k[1] }.max
+        @cells_read[sheet] = true
+      end
+
+      def cell(row, col, sheet = nil)
+        sheet ||= default_sheet
+        read_cells(sheet)
+        @cell[sheet][[row, col]]
+      end
+
+      def celltype(row, col, sheet = nil)
+        sheet ||= default_sheet
+        read_cells(sheet)
+        @cell_type[sheet][[row, col]]
+      end
+
+      def sheets
+        ['my_sheet', 'blank sheet']
+      end
+    end
+  end
+
+  let(:spreadsheet_data) do
+    {
+      [5, 1] => Date.civil(1961, 11, 21),
+
+      [8, 3] => 'thisisc8',
+      [8, 7] => 'thisisg8',
+
+      [12, 1] => 41.0,
+      [12, 2] => 42.0,
+      [12, 3] => 43.0,
+      [12, 4] => 44.0,
+      [12, 5] => 45.0,
+
+      [15, 3] => 43.0,
+      [15, 4] => 44.0,
+      [15, 5] => 45.0,
+
+      [16, 2] => '"Hello world!"',
+      [16, 3] => 'forty-three',
+      [16, 4] => 'forty-four',
+      [16, 5] => 'forty-five'
+    }
+  end
+
+  let(:spreadsheet) { klass.new('some_file', spreadsheet_data) }
+
+  describe '#uri?' do
+    it 'should return true when passed a filename starting with http(s)://' do
+      expect(spreadsheet.send(:uri?, 'http://example.com/')).to be_truthy
+      expect(spreadsheet.send(:uri?, 'https://example.com/')).to be_truthy
+    end
+
+    it 'should return false when passed a filename which does not start with http(s)://' do
+      expect(spreadsheet.send(:uri?, 'example.com')).to be_falsy
+    end
+
+    it 'should return false when passed non-String object such as Tempfile' do
+      expect(spreadsheet.send(:uri?, Tempfile.new('test'))).to be_falsy
+    end
+  end
+
+  describe '#set' do
+    it 'should not update cell when setting an invalid type' do
+      spreadsheet.set(1, 1, 1)
+      expect { spreadsheet.set(1, 1, :invalid_type) }.to raise_error(ArgumentError)
+      expect(spreadsheet.cell(1, 1)).to eq(1)
+      expect(spreadsheet.celltype(1, 1)).to eq(:float)
+    end
+  end
+
+  describe '#first_row' do
+    it 'should return the first row' do
+      expect(spreadsheet.first_row).to eq(5)
+    end
+  end
+
+  describe '#last_row' do
+    it 'should return the last row' do
+      expect(spreadsheet.last_row).to eq(16)
+    end
+  end
+
+  describe '#first_column' do
+    it 'should return the first column' do
+      expect(spreadsheet.first_column).to eq(1)
+    end
+  end
+
+  describe '#first_column_as_letter' do
+    it 'should return the first column as a letter' do
+      expect(spreadsheet.first_column_as_letter).to eq('A')
+    end
+  end
+
+  describe '#last_column' do
+    it 'should return the last column' do
+      expect(spreadsheet.last_column).to eq(7)
+    end
+  end
+
+  describe '#last_column_as_letter' do
+    it 'should return the last column as a letter' do
+      expect(spreadsheet.last_column_as_letter).to eq('G')
+    end
+  end
+
+  describe '#row' do
+    it 'should return the specified row' do
+      expect(spreadsheet.row(12)).to eq([41.0, 42.0, 43.0, 44.0, 45.0, nil, nil])
+      expect(spreadsheet.row(16)).to eq([nil, '"Hello world!"', 'forty-three', 'forty-four', 'forty-five', nil, nil])
+    end
+  end
+
+  describe '#empty?' do
+    it 'should return true when empty' do
+      expect(spreadsheet.empty?(1, 1)).to be_truthy
+      expect(spreadsheet.empty?(8, 3)).to be_falsy
+      expect(spreadsheet.empty?('A', 11)).to be_truthy
+      expect(spreadsheet.empty?('A', 12)).to be_falsy
+    end
+  end
+
+  describe '#reload' do
+    it 'should return reinitialize the spreadsheet' do
+      spreadsheet.reload
+      expect(spreadsheet.instance_variable_get(:@cell).empty?).to be_truthy
+    end
+  end
+
+  describe '#each' do
+    it 'should return an enumerator with all the rows' do
+      each = spreadsheet.each
+      expect(each).to be_a(Enumerator)
+      expect(each.to_a.last).to eq([nil, '"Hello world!"', 'forty-three', 'forty-four', 'forty-five', nil, nil])
+    end
+  end
+
+  describe '#to_yaml' do
+    it 'should convert the spreadsheet to yaml' do
+      expect(spreadsheet.to_yaml({}, 5, 1, 5, 1)).to eq("--- \n" + yaml_entry(5, 1, 'date', '1961-11-21'))
+      expect(spreadsheet.to_yaml({}, 8, 3, 8, 3)).to eq("--- \n" + yaml_entry(8, 3, 'string', 'thisisc8'))
+
+      expect(spreadsheet.to_yaml({}, 12, 3, 12, 3)).to eq("--- \n" + yaml_entry(12, 3, 'float', 43.0))
+
+      expect(spreadsheet.to_yaml({}, 12, 3, 12)).to eq(
+        "--- \n" + yaml_entry(12, 3, 'float', 43.0) +
+        yaml_entry(12, 4, 'float', 44.0) +
+        yaml_entry(12, 5, 'float', 45.0))
+
+      expect(spreadsheet.to_yaml({}, 12, 3)).to eq(
+      "--- \n" + yaml_entry(12, 3, 'float', 43.0) +
+        yaml_entry(12, 4, 'float', 44.0) +
+        yaml_entry(12, 5, 'float', 45.0) +
+        yaml_entry(15, 3, 'float', 43.0) +
+        yaml_entry(15, 4, 'float', 44.0) +
+        yaml_entry(15, 5, 'float', 45.0) +
+        yaml_entry(16, 3, 'string', 'forty-three') +
+        yaml_entry(16, 4, 'string', 'forty-four') +
+        yaml_entry(16, 5, 'string', 'forty-five'))
+    end
+  end
+
+  let(:expected_csv) do
+    <<EOS
+,,,,,,
+,,,,,,
+,,,,,,
+,,,,,,
+1961-11-21,,,,,,
+,,,,,,
+,,,,,,
+,,"thisisc8",,,,"thisisg8"
+,,,,,,
+,,,,,,
+,,,,,,
+41,42,43,44,45,,
+,,,,,,
+,,,,,,
+,,43,44,45,,
+,"""Hello world!""","forty-three","forty-four","forty-five",,
+EOS
+  end
+
+  let(:expected_csv_with_semicolons) { expected_csv.gsub(/\,/, ';') }
+
+  describe '#to_csv' do
+    it 'should convert the spreadsheet to csv' do
+      expect(spreadsheet.to_csv).to eq(expected_csv)
+    end
+
+    it 'should convert the spreadsheet to csv using the separator when is passed on the parameter' do
+      expect(spreadsheet.to_csv(nil, ';')).to eq(expected_csv_with_semicolons)
+    end
+  end
 end

data/spec/lib/roo/excelx_spec.rb

@@ -454,4 +454,11 @@ describe Roo::Excelx do
       end
     end
   end
+
+  describe '_x000D_' do
+    let(:path) { 'test/files/x000D.xlsx' }
+    it 'does not contain _x000D_' do
+      expect(subject.cell(2, 9)).not_to include('_x000D_')
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,8 +1,13 @@
 require 'simplecov'
 require 'roo'
-
 require 'vcr'
 
+require 'helpers'
+
+RSpec.configure do |c|
+  c.include Helpers
+end
+
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/fixtures/vcr_cassettes'
   c.hook_into :webmock # or :fakeweb

data/test/test_helper.rb

@@ -45,10 +45,6 @@ def file_diff(fn1,fn2)
   result
 end
 
-def yaml_entry(row,col,type,value)
-  "cell_#{row}_#{col}: \n  row: #{row} \n  col: #{col} \n  celltype: #{type} \n  value: #{value} \n"
-end
-
 class File
   def File.delete_if_exist(filename)
     if File.exist?(filename)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roo
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Thomas Preymesser
@@ -11,17 +11,17 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-20 00:00:00.000000000 Z
+date: 2015-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1'
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -29,7 +29,6 @@ dependencies:
         version: '1'
 - !ruby/object:Gem::Dependency
   name: rubyzip
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -39,6 +38,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 2.0.0
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -49,13 +49,13 @@ dependencies:
         version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: rake
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -63,7 +63,6 @@ dependencies:
         version: '10.1'
 - !ruby/object:Gem::Dependency
   name: minitest
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -73,6 +72,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 5.4.3
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -131,6 +131,7 @@ files:
 - spec/fixtures/vcr_cassettes/google_drive.yml
 - spec/fixtures/vcr_cassettes/google_drive_access_token.yml
 - spec/fixtures/vcr_cassettes/google_drive_set.yml
+- spec/helpers.rb
 - spec/lib/roo/base_spec.rb
 - spec/lib/roo/csv_spec.rb
 - spec/lib/roo/excelx/format_spec.rb
@@ -141,7 +142,6 @@ files:
 - spec/lib/roo/utils_spec.rb
 - spec/spec_helper.rb
 - test/all_ss.rb
-- test/test_generic_spreadsheet.rb
 - test/test_helper.rb
 - test/test_roo.rb
 homepage: http://github.com/roo-rb/roo
@@ -164,8 +164,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Roo can access the contents of various spreadsheet files.
 test_files: []
+has_rdoc: 

data/test/test_generic_spreadsheet.rb

@@ -1,237 +0,0 @@
-# -*- encoding: utf-8 -*-
-require File.dirname(__FILE__) + '/test_helper'
-
-class TestBase < Minitest::Test
-  def setup
-    @klass = Class.new(Roo::Base) do
-      def initialize(filename = 'some_file')
-        super
-        @filename = filename
-      end
-
-      def read_cells(sheet = nil)
-        @cells_read[sheet] = true
-      end
-
-      def cell(row, col, sheet = nil)
-        sheet ||= default_sheet
-        @cell[sheet][[row, col]]
-      end
-
-      def celltype(row, col, sheet = nil)
-        sheet ||= default_sheet
-        @cell_type[sheet][[row, col]]
-      end
-
-      def sheets
-        ['my_sheet', 'blank sheet']
-      end
-    end
-    @oo = @klass.new
-    setup_test_sheet(@oo)
-  end
-
-  context 'private method Roo::Base.uri?(filename)' do
-    should 'return true when passed a filename starts with http(s)://' do
-      assert_equal true, @oo.send(:uri?, 'http://example.com/')
-      assert_equal true, @oo.send(:uri?, 'https://example.com/')
-    end
-
-    should 'return false when passed a filename which does not start with http(s)://' do
-      assert_equal false, @oo.send(:uri?, 'example.com')
-    end
-
-    should 'return false when passed non-String object such as Tempfile' do
-      assert_equal false, @oo.send(:uri?, Tempfile.new('test'))
-    end
-  end
-
-  def test_setting_invalid_type_does_not_update_cell
-    @oo.set(1, 1, 1)
-    assert_raises(ArgumentError) { @oo.set(1, 1, :invalid_type) }
-    assert_equal 1, @oo.cell(1, 1)
-    assert_equal :float, @oo.celltype(1, 1)
-  end
-
-  def test_first_row
-    assert_equal 5, @oo.first_row
-  end
-
-  def test_last_row
-    assert_equal 16, @oo.last_row
-  end
-
-  def test_first_column
-    assert_equal 1, @oo.first_column
-  end
-
-  def test_first_column_as_letter
-    assert_equal 'A', @oo.first_column_as_letter
-  end
-
-  def test_last_column
-    assert_equal 7, @oo.last_column
-  end
-
-  def test_last_column_as_letter
-    assert_equal 'G', @oo.last_column_as_letter
-  end
-
-  def test_rows
-    assert_equal [41.0, 42.0, 43.0, 44.0, 45.0, nil, nil], @oo.row(12)
-    assert_equal [nil, '"Hello world!"', 'dreiundvierzig', 'vierundvierzig', 'fuenfundvierzig', nil, nil], @oo.row(16)
-  end
-
-  def test_empty_eh
-    assert @oo.empty?(1, 1)
-    assert !@oo.empty?(8, 3)
-    assert @oo.empty?('A', 11)
-    assert !@oo.empty?('A', 12)
-  end
-
-  def test_reload
-    @oo.reload
-    assert @oo.instance_variable_get(:@cell).empty?
-  end
-
-  def test_each
-    oo_each = @oo.each
-    assert_instance_of Enumerator, oo_each
-    assert_equal [nil, '"Hello world!"', 'dreiundvierzig', 'vierundvierzig', 'fuenfundvierzig', nil, nil], oo_each.to_a.last
-  end
-
-  def test_to_yaml
-    assert_equal "--- \n" + yaml_entry(5, 1, 'date', '1961-11-21'), @oo.to_yaml({}, 5, 1, 5, 1)
-    assert_equal "--- \n" + yaml_entry(8, 3, 'string', 'thisisc8'), @oo.to_yaml({}, 8, 3, 8, 3)
-    assert_equal "--- \n" + yaml_entry(12, 3, 'float', 43.0), @oo.to_yaml({}, 12, 3, 12, 3)
-    assert_equal \
-      "--- \n" + yaml_entry(12, 3, 'float', 43.0) +
-        yaml_entry(12, 4, 'float', 44.0) +
-        yaml_entry(12, 5, 'float', 45.0), @oo.to_yaml({}, 12, 3, 12)
-    assert_equal \
-      "--- \n" + yaml_entry(12, 3, 'float', 43.0) +
-        yaml_entry(12, 4, 'float', 44.0) +
-        yaml_entry(12, 5, 'float', 45.0) +
-        yaml_entry(15, 3, 'float', 43.0) +
-        yaml_entry(15, 4, 'float', 44.0) +
-        yaml_entry(15, 5, 'float', 45.0) +
-        yaml_entry(16, 3, 'string', 'dreiundvierzig') +
-        yaml_entry(16, 4, 'string', 'vierundvierzig') +
-        yaml_entry(16, 5, 'string', 'fuenfundvierzig'), @oo.to_yaml({}, 12, 3)
-  end
-
-  def test_to_csv
-    assert_equal expected_csv, @oo.to_csv
-  end
-
-  def test_to_csv_with_separator
-    assert_equal expected_csv_with_semicolons, @oo.to_csv(nil, ';')
-  end
-
-  protected
-
-  def setup_test_sheet(workbook = nil)
-    workbook ||= @oo
-    set_sheet_values(workbook)
-    set_sheet_types(workbook)
-    set_cells_read(workbook)
-  end
-
-  def set_sheet_values(workbook)
-    workbook.instance_variable_get(:@cell)[workbook.default_sheet] = {
-      [5, 1] => Date.civil(1961, 11, 21).to_s,
-
-      [8, 3] => 'thisisc8',
-      [8, 7] => 'thisisg8',
-
-      [12, 1] => 41.0,
-      [12, 2] => 42.0,
-      [12, 3] => 43.0,
-      [12, 4] => 44.0,
-      [12, 5] => 45.0,
-
-      [15, 3] => 43.0,
-      [15, 4] => 44.0,
-      [15, 5] => 45.0,
-
-      [16, 2] => '"Hello world!"',
-      [16, 3] => 'dreiundvierzig',
-      [16, 4] => 'vierundvierzig',
-      [16, 5] => 'fuenfundvierzig'
-    }
-  end
-
-  def set_sheet_types(workbook)
-    workbook.instance_variable_get(:@cell_type)[workbook.default_sheet] = {
-      [5, 1] => :date,
-
-      [8, 3] => :string,
-      [8, 7] => :string,
-
-      [12, 1] => :float,
-      [12, 2] => :float,
-      [12, 3] => :float,
-      [12, 4] => :float,
-      [12, 5] => :float,
-
-      [15, 3] => :float,
-      [15, 4] => :float,
-      [15, 5] => :float,
-
-      [16, 2] => :string,
-      [16, 3] => :string,
-      [16, 4] => :string,
-      [16, 5] => :string
-    }
-  end
-
-  def set_first_row(workbook)
-    row_hash = workbook.instance_variable_get(:@first_row)
-    row_hash[workbook.default_sheet] = workbook.instance_variable_get(:@cell)[workbook.default_sheet].map { |k, _v| k[0] }.min
-  end
-
-  def set_last_row(workbook)
-    row_hash = workbook.instance_variable_get(:@last_row)
-    row_hash[workbook.default_sheet] = workbook.instance_variable_get(:@cell)[workbook.default_sheet].map { |k, _v| k[0] }.max
-  end
-
-  def set_first_col(workbook)
-    col_hash = workbook.instance_variable_get(:@first_column)
-    col_hash[workbook.default_sheet] = workbook.instance_variable_get(:@cell)[workbook.default_sheet].map { |k, _v| k[1] }.min
-  end
-
-  def set_last_col(workbook)
-    col_hash = workbook.instance_variable_get(:@last_column)
-    col_hash[workbook.default_sheet] = workbook.instance_variable_get(:@cell)[workbook.default_sheet].map { |k, _v| k[1] }.max
-  end
-
-  def set_cells_read(workbook)
-    read_hash = workbook.instance_variable_get(:@cells_read)
-    read_hash[workbook.default_sheet] = true
-  end
-
-  def expected_csv
-    <<EOS
-,,,,,,
-,,,,,,
-,,,,,,
-,,,,,,
-1961-11-21,,,,,,
-,,,,,,
-,,,,,,
-,,"thisisc8",,,,"thisisg8"
-,,,,,,
-,,,,,,
-,,,,,,
-41,42,43,44,45,,
-,,,,,,
-,,,,,,
-,,43,44,45,,
-,"""Hello world!""","dreiundvierzig","vierundvierzig","fuenfundvierzig",,
-EOS
-  end
-
-  def expected_csv_with_semicolons
-    expected_csv.gsub(/\,/, ';')
-  end
-end