roo-xls 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5497f8b6a9779fc588a2a111be208b15b161980a742db7aa51bf493a1aa97cd6
-  data.tar.gz: 40589a5d46b9134aa6dfe7fd8e93fc38d1409e1c318fef7d93cd958ff95b8cbf
+  metadata.gz: 7b4b59a55cac5820c24bfd0ccf4bfb0edd18e88cc46516ea84157b8d92d9d399
+  data.tar.gz: 2c97afde22e182df8921f4435efd18ecaa63c6ab37d600fd4e5c88b1d34afffb
 SHA512:
-  metadata.gz: 7024a683484e5a679df01b9a4d7a4a62eb6a11a826e68fe51e9ab0ef3019e103349d1d097a52d51cf188fcb78ad67acad7fa827cdf7c4f7e58615c052f6c9d8f
-  data.tar.gz: b3d528dee5ea5771d1f394701bee2fc305f5064c688a1f5df4595fd4c811c2d3568a5e2d10a2b0558432bc03191edd5f6a6c1a67de74e9a3bd6ac563740f4edb
+  metadata.gz: 2c776ca11c9f604871b78e9a6ea45c09314de98ec662ebefd47922ec6f366458c685094004fcfd14e7b99138c010fd5893d6ce10f6c1d6941a55f77a0d119254
+  data.tar.gz: 37f20fc518a273c1adf7f81e137d2d99b679670b69898dd4caf368716eebca6245252ca275eadf750ddacf7ba01a42eab3235723f841b76ede9aeb848f31e525

data/.github/issue_template.md

@@ -0,0 +1,16 @@
+Thanks for filing an issue. Following these instructions will help us solve your problem sooner.
+
+### Steps to reproduce
+
+1. Create an executable test case for this issue ([sample test case](https://gist.github.com/tgturner/4e2b590e0218d3b261269aa662b6a7cb))
+2. You can share your executable test case as a [gist](https://gist.github.com), or simply paste the content into the issue description.
+  - You can execute the test case by running `ruby the_file.rb` in your terminal. If all goes well, you should see your test case failing.
+3. Please provide a stripped down version of the offending spreadsheet.
+
+### Issue
+Describe the issue
+
+### System configuration
+**Roo::Xls version**:
+
+**Ruby version**:

data/.github/pull_request_template.md

@@ -0,0 +1,14 @@
+### Summary
+
+Provide a general description of the code changes in your pull
+request... were there any bugs you had fixed? If so, mention them. If
+these bugs have open GitHub issues, be sure to tag them here as well,
+to keep the conversation linked together.
+
+### Other Information
+
+If there's anything else that's important and relevant to your pull
+request, mention that information here. This could include
+benchmarks, or other information.
+
+Thanks for contributing to Roo!

data/.github/workflows/release-please.yml

@@ -0,0 +1,52 @@
+name: Release Please
+
+on:
+  push:
+    branches:
+      - master
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  release-please:
+    runs-on: ubuntu-latest
+    outputs:
+      release_created: ${{ steps.release.outputs.release_created }}
+      tag_name: ${{ steps.release.outputs.tag_name }}
+    steps:
+      - uses: googleapis/release-please-action@v4
+        id: release
+        with:
+          config-file: release-please-config.json
+          manifest-file: .release-please-manifest.json
+
+  publish:
+    needs: release-please
+    if: ${{ needs.release-please.outputs.release_created }}
+    runs-on: ubuntu-latest
+    environment: PUBLISH
+    permissions:
+      contents: write
+      id-token: write
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ needs.release-please.outputs.tag_name }}
+          fetch-tags: true
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.4'
+          bundler-cache: true
+
+      - name: Publish to RubyGems
+        uses: rubygems/release-gem@v1
+
+      - name: Upload Gem to GitHub Release
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: gh release upload ${{ needs.release-please.outputs.tag_name }} ./*.gem --clobber

data/.github/workflows/ruby.yml

@@ -0,0 +1,40 @@
+name: Ruby
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - '3.1'
+          - '3.2'
+          - '3.3'
+          - '3.4'
+          - '4.0'
+          - ruby-head
+          - jruby-9.4.10.0
+        include:
+          - ruby: ruby-head
+            env:
+              RUBYOPT: '--jit'
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: bundle exec rake
+        env:
+          LONG_RUN: true

data/.gitignore

@@ -14,3 +14,7 @@
 mkmf.log
 .idea
 .DS_Store
+
+# Appraisal
+/gemfiles/.bundle/
+/gemfiles/*.gemfile.lock

data/.release-please-manifest.json

@@ -0,0 +1,3 @@
+{
+  ".": "2.0.0"
+}

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# Changelog
+
+## [2.0.0](https://github.com/roo-rb/roo-xls/compare/v1.2.0...v2.0.0) (2026-01-05)
+
+
+### Miscellaneous Chores
+
+* release 2.0.0 ([7e85b93](https://github.com/roo-rb/roo-xls/commit/7e85b93f27573351edb90ce9c480ec36b23eb6af))

data/Gemfile

@@ -3,21 +3,20 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in roo-xls.gemspec
 gemspec
 
-if ENV['TRAVIS']
+if ENV['CI']
   gem 'roo', '>= 2.0.0beta1', git: 'https://github.com/roo-rb/roo.git'
 else
-  gem 'roo', '>= 2.0.0beta1', path: ::File.expand_path('../../roo', __FILE__)
+  gem 'roo', '>= 2.0.0beta1', '< 3'
 end
 
-gem 'activesupport', '~> 4.2.0' if RUBY_VERSION < '2.2'
-
 group :test do
   # additional testing libs
   gem 'webmock'
   gem 'shoulda'
   gem 'rspec', '>= 3.0.0'
-  gem 'simplecov', '>= 0.9.0', :require => false
-  gem 'coveralls', :require => false
+  gem 'simplecov', '>= 0.21', require: false
+  gem 'simplecov-lcov', '>= 0.8', require: false
+  gem 'coveralls', require: false
 end
 
 group :local_development do
@@ -28,5 +27,4 @@ group :local_development do
   gem 'guard-rubocop', require: false
   gem 'guard-reek', git: 'https://github.com/pericles/guard-reek', require: false
   gem 'pry'
-  gem 'transpec'
 end

data/Rakefile

@@ -18,6 +18,12 @@ RSpec::Core::RakeTask.new(:spec)
 Coveralls::RakeTask.new
 
 default_task = [:test, :spec]
-default_task << 'coveralls:push' if ENV['TRAVIS']
+default_task << 'coveralls:push' if ENV['CI']
 
-task default: default_task
+if !ENV["APPRAISAL_INITIALIZED"] && !ENV['CI']
+  task :default do
+    sh "appraisal install && appraisal rake"
+  end
+else
+  task default: default_task
+end

data/lib/roo/xls/excel.rb

@@ -48,8 +48,6 @@ module Roo
       @fonts = {}
     end
 
-    attr_reader :workbook
-
     def worksheets
       @worksheets ||= workbook.worksheets
     end
@@ -285,7 +283,7 @@ module Roo
       format = row.format(idx)
       if format.date_or_time?
         cell = read_cell_content(row, idx)
-        true if Float(cell) > 0 rescue false
+        true if (Float(cell, exception: false) || 0) > 0
       else
         false
       end
@@ -309,7 +307,13 @@ module Roo
       else
         datetime =
           if row.at(idx).class == ::Spreadsheet::Formula
-            row.send(:_datetime, cell)
+            if row.respond_to?(:set_datetime, true)
+              # 1.3.4+
+              row.send(:set_datetime, cell)
+            else
+              # 1.3.3-
+              row.send(:_datetime, cell)
+            end
           else
             row.datetime(idx)
           end
@@ -322,7 +326,13 @@ module Roo
           value_type = :date
           value =
             if row.at(idx).class == ::Spreadsheet::Formula
-              row.send(:_date, cell)
+              if row.respond_to?(:set_date, true)
+                # 1.3.4+
+                row.send(:set_date, cell)
+              else
+                # 1.3.3-
+                row.send(:_date, cell)
+              end
             else
               row.date(idx)
             end

data/lib/roo/xls/version.rb

@@ -1,5 +1,5 @@
 module Roo
   module Xls
-    VERSION = '1.2.0'
+    VERSION = '2.0.0'
   end
 end

data/release-please-config.json

@@ -0,0 +1,12 @@
+{
+  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
+  "packages": {
+    ".": {
+      "version-file": "lib/roo/xls/version.rb",
+      "release-type": "ruby",
+      "changelog-path": "CHANGELOG.md",
+      "include-component-in-tag": false,
+      "include-v-in-tag": true
+    }
+  }
+}

data/roo-xls.gemspec

@@ -10,22 +10,25 @@ Gem::Specification.new do |spec|
   spec.email         = ["ruby.ruby.ruby.roo@gmail.com"]
   spec.summary       = "Roo::Excel can access the contents of classic xls files."
   spec.description   = "Roo can access the contents of various spreadsheet files. It can handle\n* OpenOffice\n* Excel\n* Google spreadsheets\n* Excelx\n* LibreOffice\n* CSV"
+  spec.homepage      = "https://github.com/roo-rb/roo-xls"
   spec.license       = "MIT"
+  spec.metadata["changelog_uri"] = spec.homepage + '/blob/master/CHANGELOG.md'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "roo", ">= 2.0.0", "< 3"
-  spec.add_dependency "spreadsheet", "> 0.9.0"
+  spec.required_ruby_version  = ">= 3.1.0"
 
-  if RUBY_VERSION >= '2.1'
-    spec.add_dependency "nokogiri"
-  else
-    spec.add_dependency "nokogiri", "~> 1.6.0"
-  end
+  spec.add_dependency "roo", ">= 2.0.0", "< 4"
+  spec.add_dependency "spreadsheet", ">= 1.3.4", "< 2"
+  spec.add_dependency "csv"
+
+  spec.add_dependency "nokogiri"
 
   spec.add_development_dependency "bundler", ">= 1.7"
   spec.add_development_dependency "rake", ">= 10.0"
+  spec.add_development_dependency "minitest", ">= 5.19.0"
+  spec.add_development_dependency "matrix"
 end

data/test/test_excel_2003_xml.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class TestRooExcel < MiniTest::Test
+class TestExcel2013XML < Minitest::Test
   def with_xml_spreadsheet(name)
     yield ::Roo::Excel2003XML.new(File.join(TESTDIR, "#{name}.xml"))
   end
@@ -25,15 +25,15 @@ class TestRooExcel < MiniTest::Test
   # This test just checks for that exception to make sure it's not raised in this case
   def test_date_to_float_conversion
     with_xml_spreadsheet('datetime_floatconv') do |oo|
-      assert_nothing_raised(NoMethodError) do
-        oo.cell('a', 1)
-        oo.cell('a', 2)
-      end
+      oo.default_sheet = oo.sheets.first
+      assert oo.cell('a', 1)
+      assert oo.cell('a', 2)
     end
   end
 
   def test_ruby_spreadsheet_formula_bug
     with_xml_spreadsheet('formula_parse_error') do |oo|
+      oo.default_sheet = oo.sheets.first
       assert_equal '5026', oo.cell(2, 3)
       assert_equal '5026', oo.cell(3, 3)
     end

data/test/test_roo_excel.rb

@@ -2,7 +2,7 @@
 require 'test_helper'
 require 'stringio'
 
-class TestRooExcel < MiniTest::Test
+class TestRooExcel < Minitest::Test
   def with_spreadsheet(name)
     yield ::Roo::Spreadsheet.open(File.join(TESTDIR, "#{name}.xls"))
   end
@@ -628,14 +628,14 @@ Sheet 3:
   def test_bug_to_xml_with_empty_sheets
     with_spreadsheet('emptysheets') do |oo|
       oo.sheets.each do |sheet|
-        assert_equal nil, oo.first_row, "first_row not nil in sheet #{sheet}"
-        assert_equal nil, oo.last_row, "last_row not nil in sheet #{sheet}"
-        assert_equal nil, oo.first_column, "first_column not nil in sheet #{sheet}"
-        assert_equal nil, oo.last_column, "last_column not nil in sheet #{sheet}"
-        assert_equal nil, oo.first_row(sheet), "first_row not nil in sheet #{sheet}"
-        assert_equal nil, oo.last_row(sheet), "last_row not nil in sheet #{sheet}"
-        assert_equal nil, oo.first_column(sheet), "first_column not nil in sheet #{sheet}"
-        assert_equal nil, oo.last_column(sheet), "last_column not nil in sheet #{sheet}"
+        assert_nil oo.first_row, "first_row not nil in sheet #{sheet}"
+        assert_nil oo.last_row, "last_row not nil in sheet #{sheet}"
+        assert_nil oo.first_column, "first_column not nil in sheet #{sheet}"
+        assert_nil oo.last_column, "last_column not nil in sheet #{sheet}"
+        assert_nil oo.first_row(sheet), "first_row not nil in sheet #{sheet}"
+        assert_nil oo.last_row(sheet), "last_row not nil in sheet #{sheet}"
+        assert_nil oo.first_column(sheet), "first_column not nil in sheet #{sheet}"
+        assert_nil oo.last_column(sheet), "last_column not nil in sheet #{sheet}"
       end
       oo.to_xml
     end

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: roo-xls
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Thomas Preymesser
 - Hugh McGowan
 - Ben Woosley
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-26 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: roo
@@ -21,7 +20,7 @@ dependencies:
         version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -31,21 +30,41 @@ dependencies:
         version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: spreadsheet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.4
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.4
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '2'
+- !ruby/object:Gem::Dependency
+  name: csv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -88,6 +107,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.19.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.19.0
+- !ruby/object:Gem::Dependency
+  name: matrix
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |-
   Roo can access the contents of various spreadsheet files. It can handle
   * OpenOffice
@@ -102,10 +149,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/issue_template.md"
+- ".github/pull_request_template.md"
+- ".github/workflows/release-please.yml"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
+- ".release-please-manifest.json"
 - ".rubocop.yml"
 - ".simplecov"
-- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -116,6 +168,7 @@ files:
 - lib/roo/xls/excel_2003_xml.rb
 - lib/roo/xls/spreadsheet_extensions.rb
 - lib/roo/xls/version.rb
+- release-please-config.json
 - roo-xls.gemspec
 - spec/lib/roo/xls/excel2003xml_spec.rb
 - spec/lib/roo/xls/excel_spec.rb
@@ -186,11 +239,11 @@ files:
 - test/test_excel_2003_xml.rb
 - test/test_helper.rb
 - test/test_roo_excel.rb
-homepage: 
+homepage: https://github.com/roo-rb/roo-xls
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  changelog_uri: https://github.com/roo-rb/roo-xls/blob/master/CHANGELOG.md
 rdoc_options: []
 require_paths:
 - lib
@@ -198,16 +251,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Roo::Excel can access the contents of classic xls files.
 test_files:

data/.travis.yml

@@ -1,16 +0,0 @@
-language: ruby
-rvm:
-  - 2.0
-  - 2.1
-  - 2.2
-  - 2.3
-  - 2.4
-  - 2.5
-  - ruby-head
-  - jruby-19mode # JRuby in 1.9 mode
-  - rbx-2
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: rbx-2
-bundler_args: --without local_development