romo 0.20.3 → 0.20.4

checksums.yaml

@@ -1,7 +1,7 @@
 --- 
 SHA512: 
-  metadata.gz: 5aeadbefd98f8b82e409d936c583ad53939f70db564b5079fd3105507db499427278c209837da5c28b697ac96e803ff77873dded7640bd1d3cb3dbd12d1680e6
-  data.tar.gz: c34dae4264fd7b9f278da8123578aebcead9ea5b3645ce2be3258ed795fc1df3148af4f58ab4f97976364b63802f7c8677d4d71b99314722b62cbbb40a11be71
+  metadata.gz: fc92a94417b75d8dcd13b5f9e48fd5f7d00789e18bb9969a1b21ab55f85e572c70a17ac3a80e62c31e0abca1989e4be6d48e2746a8ea0d44719c5cbf08e13dd3
+  data.tar.gz: 16c16fbf9a5fc4bf11c0b71cd8944b131a36e5c19e4ffcef3a03e6274564fd4a73ce5473eaa24fb9dd9421ed652bad4490f123237ba9282c38db5b65965b43ec
 SHA1: 
-  metadata.gz: 6b2439dc448fe66da286d45dc2d964c0a41a177a
-  data.tar.gz: eb90ed22e98caa51444b2fc2b799807fef755d3f
+  metadata.gz: 753cd71f80760176c3b62b6ae4920c3a21067017
+  data.tar.gz: 300d46042e20b7b35e1ba5706a32b86318bdf01e

data/assets/js/romo/base.js

@@ -967,11 +967,12 @@ RomoPopupStack.prototype.addStyleClass = function(styleClass) {
 }
 
 RomoPopupStack.prototype.addElem = function(popupElem, boundOpenFn, boundCloseFn, boundPlaceFn) {
-  this.items.push(new this.itemClass(popupElem, boundCloseFn, boundPlaceFn));
-
   // allow any body click events to propagate and run first.  This ensures
   // any existing stack is in the appropriate state before opening a new popup.
-  Romo.pushFn(boundOpenFn);
+  Romo.pushFn(Romo.proxy(function() {
+    this.items.push(new this.itemClass(popupElem, boundCloseFn, boundPlaceFn));
+    boundOpenFn();
+  }, this));
 }
 
 RomoPopupStack.prototype.closeThru = function(popupElem) {
@@ -1042,7 +1043,7 @@ RomoPopupStack.prototype._onBodyClick = function(e) {
   if (Romo.is(e.target, this.popupSelector)) {
     popupElem = e.target;
   } else {
-    popupElem = Romo.parents(e.target, this.popupSelector)[0];
+    popupElem = Romo.closest(e.target, this.popupSelector);
   }
 
   if (popupElem === undefined || !this._includes(popupElem)) {

data/assets/js/romo/dropdown.js

@@ -111,8 +111,8 @@ RomoDropdown.prototype._openPopup = function() {
   Romo.on(Romo.scrollableParents(this.elem), 'scroll', this._onScrollableParentsScroll);
 
   if (Romo.data(this.elem, 'romo-dropdown-content-elem') !== undefined) {
-    var contentElem = Romo.elems(Romo.data(this.elem, 'romo-dropdown-content-elem'))[0];
-    this._loadBodySuccess(contentElem.outerHTML);
+    var contentElem = Romo.f(Romo.data(this.elem, 'romo-dropdown-content-elem'))[0];
+    this._loadBodySuccess(contentElem.innerHTML);
   } else {
     this.romoAjax.doInvoke();
   }

data/assets/js/romo/form.js

@@ -211,7 +211,12 @@ RomoForm.prototype._getXhrDataType = function() {
 RomoForm.prototype.romoEvFn._onSubmitClick = function(e) {
   e.preventDefault();
 
-  var submitElem = e.target;
+  var submitElem;
+  if (Romo.is(e.target, '[data-romo-form-submit]')) {
+    submitElem = e.target;
+  } else {
+    submitElem = Romo.closest(e.target, '[data-romo-form-submit]');
+  }
   if (!Romo.hasClass(submitElem, 'disabled')) {
     if (Romo.data(submitElem, 'romo-form-submit') === 'confirm') {
       Romo.trigger(this.elem, 'romoForm:confirmSubmit', [this]);

data/assets/js/romo/inline_form.js

@@ -67,7 +67,7 @@ RomoInlineForm.prototype._bindForm = function() {
     Romo.on(formElem, 'romoForm:ready', Romo.proxy(function(e, romoForm) {
       Romo.trigger(this.elem, 'romoInlineForm:romoForm:ready', [romoForm, this]);
     }, this));
-    Romo.on(formElem, 'romoForm:confirmSubmit', Romo.proxy(function(e, form) {
+    Romo.on(formElem, 'romoForm:confirmSubmit', Romo.proxy(function(e, romoForm) {
       Romo.trigger(this.elem, 'romoInlineForm:romoForm:confirmSubmit', [romoForm, this]);
     }, this));
     Romo.on(formElem, 'romoForm:beforeSubmit', Romo.proxy(function(e, romoForm) {

data/assets/js/romo/modal.js

@@ -73,8 +73,8 @@ RomoModal.prototype.doPlacePopupElem = function() {
 
 RomoModal.prototype._openPopup = function() {
   if (Romo.data(this.elem, 'romo-modal-content-elem') !== undefined) {
-    var contentElem = Romo.elems(Romo.data(this.elem, 'romo-modal-content-elem'))[0];
-    this._loadBodySuccess(contentElem.outerHTML);
+    var contentElem = Romo.f(Romo.data(this.elem, 'romo-modal-content-elem'))[0];
+    this._loadBodySuccess(contentElem.innerHTML);
   } else {
     this.romoAjax.doInvoke();
   }

data/assets/js/romo/spinner.js

@@ -11,6 +11,10 @@ var RomoSpinner = RomoComponent(function(elem) {
 });
 
 RomoSpinner.prototype.doStart = function(customBasisSize) {
+  if (this.spinner !== undefined) {
+    return;
+  }
+
   var basisSize = (
     customBasisSize                                 ||
     Romo.data(this.elem, 'romo-spinner-basis-size') ||
@@ -51,6 +55,10 @@ RomoSpinner.prototype.doStart = function(customBasisSize) {
 }
 
 RomoSpinner.prototype.doStop = function() {
+  if (this.spinner === undefined) {
+    return;
+  }
+
   if (this.spinner !== undefined) {
     this.spinner.stop();
     this.spinner = undefined;

data/lib/romo/version.rb

@@ -1,3 +1,3 @@
 module Romo
-  VERSION = "0.20.3"
+  VERSION = "0.20.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: romo
 version: !ruby/object:Gem::Version 
-  version: 0.20.3
+  version: 0.20.4
 platform: ruby
 authors: 
 - Kelly Redding
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2017-12-04 00:00:00 Z
+date: 2017-12-07 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: assert