romanianvalidators 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50f809f30c598ff70bffc2683360837c69732452
-  data.tar.gz: bb39cbd87e1494b6e5339250bdc3c3dd5a7673da
+  metadata.gz: b6f0345b9d1c418dd361412bdcf98b68134a099b
+  data.tar.gz: 9c44ad509cbed0a6ffb8456995ce78099b122714
 SHA512:
-  metadata.gz: 19b479580c2a090b11a03a2a94c6de981e7c977d73d08983d506ff50e8ecd54ea9d722c4826a7f26926912a7fea664f01f9d3b5a779e79af8ede6bf543830de6
-  data.tar.gz: c92272d645cbb299d26eecf8a45df1d130b30b9b6e7b34c76cbf1bf0187ed8e982902cdf91ae4fe4005f594a6e9eaa943134c0ea728f9dfc2904397fc019f3e9
+  metadata.gz: 6ca4dc092344fe15b1803c86f48df7de87b3373ae6c5074903d04c11dca5618f44af1201543d58a9112b1187c176c3d1b4608f938166ee794ff65147c13f5b0f
+  data.tar.gz: b2bc80c161f204a22b82d572b4d753dc824302481dc58e3a11ef0d499f42bdc13185ae115e4f95077f4e9d1d8ae7e353e75c5d225da6ac2adbd1bda45b98cce0

data/.travis.yml

@@ -1,9 +1,5 @@
 language: ruby
 rvm:
-  - 1.8.7
-  - ree
-  - rbx-18mode
-  - 1.9.2
   - 1.9.3
   - rbx-19mode
   - ruby-head

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+### 0.1.6 (2014-12-16)
+ * bugfix for CNP validation
+
 ### 0.1.4 (2013-04-29)
  * bugfix
 

data/lib/active_model/validations/cnp_validator.rb

@@ -1,8 +1,7 @@
 module ActiveModel
   module Validations
     class CnpValidator < EachValidator
-
-      TEST_KEY = "279146358279"
+      TEST_KEY = '279146358279'.each_char.map(&:to_i)
 
       include ActiveModel::Validations::EmptyBlankEachValidator
 
@@ -15,12 +14,16 @@ module ActiveModel
       # Se foloseste cheia de testare "279146358279". Primele douasprezece cifre se inmultesc pe rand de la
       # stanga spre dreapta cu cifra corespunzatoare din cheia de testare.
       #
-      # Pas 2: Cele douasprezece produse obtinute se aduna si suma obtinuta se imparte la 11. Restul impartirii
-      # reprezinta cifra de control. Pentru un CNP valid acest rest va trebui sa coincida cu cifra de pe
-      # pozitia treisprezece din CNP-ul initial.
+      # Pas 2: Cele douasprezece produse obtinute se aduna si suma obtinuta se imparte la 11.
+      #   * Daca restul impartirii la 11 este mai mic ca 10, atunci acesta va reprezenta cifra de control.
+      #   * Daca restul impartirii este 10 atunci cifra de control este 1.
+      # Restul impartirii reprezinta cifra de control. Pentru un CNP valid acest rest va trebui
+      # sa coincida cu cifra de pe pozitia treisprezece din CNP-ul initial.
       def valid?(cnp)
         return false unless well_formed?(cnp) && valid_birthdate?(cnp)
-        (0..11).inject(0){|sum, n| sum += TEST_KEY[n].chr.to_i * cnp[n].chr.to_i} % 11 == cnp[12].chr.to_i
+        control = (0..11).reduce(0) { |a, e| a + TEST_KEY[e] * cnp[e].chr.to_i } % 11
+        control = 1 if control == 10
+        control == cnp[12].chr.to_i
       end
 
     private
@@ -32,10 +35,10 @@ module ActiveModel
       def valid_birthdate?(cnp)
         year_code = cnp[0].chr.to_i
         year = case year_code
-               when 1..2 then "19"
-               when 3..4 then "18"
-               when 5..6 then "20"
-               when 9    then "19" # oare se sare peste un an bisect intre 1800-2099 ?
+               when 1..2 then '19'
+               when 3..4 then '18'
+               when 5..6 then '20'
+               when 9    then '19' # oare se sare peste un an bisect intre 1800-2099 ?
                else return false
                end
         year = (year + cnp[1..2]).to_i
@@ -43,7 +46,6 @@ module ActiveModel
       rescue ArgumentError
         return false
       end
-
     end
   end
-end
+end

data/romanianvalidators.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name        = 'romanianvalidators'
-  s.version     = '0.1.5'
+  s.version     = '0.1.6'
   s.authors     = ['Mihai Târnovan']
   s.email       = ['mihai.tarnovan@cubus.ro']
   s.homepage    = 'http://github.com/mtarnovan/romanianvalidators'

data/test/data/valid_cnps.txt

@@ -3,4 +3,60 @@
 1910320258878
 1900731088752
 1911104133697
-1920822296090
+1920822296090
+2891208132051
+1920304263831
+1891217192767
+1921011092055
+1860109269659
+1900601056845
+1880604103415
+1880721136275
+1850525122042
+1861218247359
+1881015253624
+1870516244583
+1860712316588
+1880604291702
+1850720124541
+1851005206236
+1860421127483
+1860802176257
+1880722023772
+1920821238709
+1920513112249
+1891116203323
+1870526416985
+1901222053823
+1910222155466
+1891103357563
+1851112026144
+1861004286635
+1881106241130
+1850917352822
+1870626195295
+1860726329931
+1901028015659
+1860607177247
+1910807246873
+1890419224870
+1860423292119
+1910209225248
+1890712354318
+1920828092680
+1860404127309
+1860718234273
+1920205386704
+1920813346694
+1930517148179
+1850302286199
+1890507112448
+1900119416106
+1921207191179
+1870827113584
+1930401155693
+1920404023634
+1870807402772
+1920316217606
+1920603061730
+1890628151821

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: romanianvalidators
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Mihai Târnovan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-08 00:00:00.000000000 Z
+date: 2014-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler