roman_numbers 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6daa393f9570d95a67b67cd1a84a135998311b4b
-  data.tar.gz: 60cc1370d2fc105f826ad919e2338c20078db105
+  metadata.gz: 27973d5bbc313c37e4508cdeadcbfa53b0b667cc
+  data.tar.gz: 5d225eb7a22504978a130c4a1f80a494fa4b909b
 SHA512:
-  metadata.gz: 3033cdc3ec59fd57255b2c13534c5f418c36a7874d0cb53e81e7f19f098aa4887af93cdba16ab19c0773ea71c4b7618c49168c5a204fc29e747889e6d9a9db97
-  data.tar.gz: 222fc3d1e1555efc9f1384db184c8097885204d510971d19993f6a7453a2a2db25502c457e8542289d77f6b5d3dea47f70d76ad73aef776193a7a642ce7790e7
+  metadata.gz: afcdcbb98fb0304c6faabd6f553dfa645c38c52805d29fc435104862b25f70495ebdb42e949cd701935559844b7687d9080991dc09a1952ca2bc0c81451d029d
+  data.tar.gz: 37ba09d44403228e0e421fc9df56dccb8fca78a82942f64efa4e2a3b22e149841447ad8c9b1894fd2ae96bfa6c328c419a0a2565dda677c708f5a3c85c10b776

data/README.md

@@ -2,6 +2,33 @@
 
 Conversion between Integers and Roman Numbers
 
+Roman numerals are based on seven symbols:
+
+| Symbol      | Value     |
+|:----------- |:--------- |
+| I           | 1         |
+| V           | 5         |
+| X           | 10        |
+| L           | 50        |
+| C           | 100       |
+| D           | 500       |
+| M           | 1000      |
+
+
+Numbers are formed by combining symbols together and adding the values. For example, MMVI is 1000 + 1000 + 5 + 1 = 2006.
+
+Generally, symbols are placed in order of value, starting with the largest values. When smaller values precede larger values, the smaller values are subtracted from the larger values, and the result is added to the total. For example MCMXLIV = 1000 + (1000 − 100) + (50 − 10) + (5 − 1) = 1944.
+
+* The symbols "I", "X", "C", and "M" can be repeated three times in succession, but no more. (They may appear four times if the third and fourth are separated by a smaller value, such as XXXIX.) "D", "L", and "V" can never be repeated.
+
+* "I" can be subtracted from "V" and "X" only. "X" can be subtracted from "L" and "C" only. "C" can be subtracted from "D" and "M" only. "V", "L", and "D" can never be subtracted.
+
+* Only one small-value symbol may be subtracted from any large-value symbol.
+
+* A number written in Arabic numerals can be broken into digits. For example, 1903 is composed of 1, 9, 0, and 3. To write the Roman numeral, each of the non-zero digits should be treated separately. In the above example, 1,000 = M, 900 = CM, and 3 = III. Therefore, 1903 = MCMIII.
+
+Refer: http://en.wikipedia.org/wiki/Roman_numerals
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -18,26 +45,45 @@ Or install it yourself as:
 
 ## Usage
 
-Some Examples:
+By explicitly using RomanNumber class:
+
+
+    > require 'roman_numbers'
+
 
     > RomanNumbers::RomanNumber.new(3999).convert_decimal_to_roman
+
     "MMMCMXCIX"
 
+
     > RomanNumbers::RomanNumber.new('MMMCMXCIX').convert_roman_to_decimal
+
     3999
 
+
+By directly on String and Integer objects:
+
+
     > 'MCMXLIV'.from_roman_to_integer
+
     1944
 
+
     > 1944.to_roman
+
     "MCMXLIV"
 
+
     > 'MMMMMX'.from_roman_to_integer
+
     RomanNumbers::InvalidInputError
 
+
     > 999383.to_roman
+
     RomanNumbers::InvalidInputError
 
+
 ## Contributing
 
 1. Fork it

data/lib/roman_numbers/version.rb

@@ -1,3 +1,3 @@
 module RomanNumbers
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/roman_numbers.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 2.14"
   spec.add_development_dependency "autotest"
   spec.add_development_dependency "simplecov"
+  spec.required_ruby_version = '>= 1.9'
 end

data/spec/helpers.rb

@@ -0,0 +1,28 @@
+module Helpers
+  def self.valid_inputs
+    [
+        [1, 'I'],
+        [5, 'V'],
+        [10, 'X'],
+        [50, 'L'],
+        [100, 'C'],
+        [500, 'D'],
+        [1000, 'M'],
+        [4, 'IV'],
+        [9, 'IX'],
+        [40, 'XL'],
+        [90, 'XC'],
+        [400, 'CD'],
+        [900, 'CM'],
+        [207, 'CCVII'],
+        [1066, 'MLXVI'],
+        [44, 'XLIV'],
+        [49, 'XLIX'],
+        [904, 'CMIV'],
+        [944, 'CMXLIV'],
+        [1904, 'MCMIV'],
+        [1944, 'MCMXLIV'],
+        [3999, 'MMMCMXCIX'],
+    ]
+  end
+end

data/spec/roman_numbers/roman_number_spec.rb

@@ -2,35 +2,34 @@ require_relative '../spec_helper'
 
 module RomanNumbers
   describe RomanNumber do # EXAMPLE GROUP
+
     before(:each) do
       @roman_number = RomanNumber.new(1)
     end
+
     describe '#largest_repeatable_element' do
-      it 'works for "3999" as input' do
-        output = @roman_number.largest_repeatable_element(3999)
-        output.should == {:reduced_integer => 999, :largest_element => {:unit => :M, :value => 1000}, :times => 3}
-      end
-      it 'works for "1066" as input' do
-        output = @roman_number.largest_repeatable_element(1066)
-        output.should == {:reduced_integer => 66, :largest_element => {:unit => :M, :value => 1000}, :times => 1}
-      end
-      it 'works for "207" as input' do
-        output = @roman_number.largest_repeatable_element(207)
-        output.should == {:reduced_integer => 7, :largest_element => {:unit => :C, :value => 100}, :times => 2}
-      end
-      it 'works for "10" as input' do
-        output = @roman_number.largest_repeatable_element(10)
-        output.should == {:reduced_integer => 0, :largest_element => {:unit => :X, :value => 10}, :times => 1}
-      end
-      it 'raises StartsWithNonRepeatableRomanUnitError for 999 as input' do
-        expect {
-          @roman_number.largest_repeatable_element(999)
-        }.to raise_error(StartsWithNonRepeatableRomanUnitError)
-      end
-      it 'raises StartsWithNonRepeatableRomanUnitError for 44 as input' do
-        expect {
-          @roman_number.largest_repeatable_element(44)
-        }.to raise_error(StartsWithNonRepeatableRomanUnitError)
+      # set 1
+      [
+          [3999, {:reduced_integer => 999, :largest_element => {:unit => :M, :value => 1000}, :times => 3}],
+          [1066, {:reduced_integer => 66, :largest_element => {:unit => :M, :value => 1000}, :times => 1}],
+          [207, {:reduced_integer => 7, :largest_element => {:unit => :C, :value => 100}, :times => 2}],
+          [10, {:reduced_integer => 0, :largest_element => {:unit => :X, :value => 10}, :times => 1}],
+      ].each do |exp_input, exp_output|
+        it %Q{works for #{exp_input} as input} do
+          output = @roman_number.largest_repeatable_element(exp_input)
+          output.should == exp_output
+        end
+      end
+      # set 2
+      [
+          [999, StartsWithNonRepeatableRomanUnitError],
+          [44, StartsWithNonRepeatableRomanUnitError],
+      ].each do |exp_input, exp_output|
+        it %Q{raises #{exp_output} for #{exp_input} as input} do
+          expect {
+            @roman_number.largest_repeatable_element(exp_input)
+          }.to raise_error(exp_output)
+        end
       end
     end
 
@@ -38,212 +37,57 @@ module RomanNumbers
       before(:each) do
         @roman_number = RomanNumber.new(1)
       end
-      it 'works for "999" as input' do
-        output = @roman_number.largest_non_repeatable_element(999)
-        output.should == {:reduced_integer => 99, :largest_element => {:unit => :CM, :value => 900}, :times => 1}
-      end
-      it 'works for "900" as input' do
-        output = @roman_number.largest_non_repeatable_element(900)
-        output.should == {:reduced_integer => 0, :largest_element => {:unit => :CM, :value => 900}, :times => 1}
-      end
-      it 'works for "44" as input' do
-        output = @roman_number.largest_non_repeatable_element(44)
-        output.should == {:reduced_integer => 4, :largest_element => {:unit => :XL, :value => 40}, :times => 1}
-      end
-      it 'works for "49" as input' do
-        output = @roman_number.largest_non_repeatable_element(49)
-        output.should == {:reduced_integer => 9, :largest_element => {:unit => :XL, :value => 40}, :times => 1}
+      [
+          [999, {:reduced_integer => 99, :largest_element => {:unit => :CM, :value => 900}, :times => 1}],
+          [900, {:reduced_integer => 0, :largest_element => {:unit => :CM, :value => 900}, :times => 1}],
+          [44, {:reduced_integer => 4, :largest_element => {:unit => :XL, :value => 40}, :times => 1}],
+          [49, {:reduced_integer => 9, :largest_element => {:unit => :XL, :value => 40}, :times => 1}],
+      ].each do |exp_input, exp_output|
+        it %Q{works for #{exp_input} as input} do
+          output = @roman_number.largest_non_repeatable_element(exp_input)
+          output.should == exp_output
+        end
       end
     end
 
     describe '#convert_arabic_to_roman' do
-      context 'For Very Simple Integers' do
-        it 'returns I for 1' do
-          RomanNumber.new(1).convert_decimal_to_roman.should == 'I'
-        end
-        it 'returns V for 5' do
-          RomanNumber.new(5).convert_decimal_to_roman.should == 'V'
-        end
-        it 'returns X for 10' do
-          RomanNumber.new(10).convert_decimal_to_roman.should == 'X'
-        end
-        it 'returns L for 50' do
-          RomanNumber.new(50).convert_decimal_to_roman.should == 'L'
-        end
-        it 'returns C for 100' do
-          RomanNumber.new(100).convert_decimal_to_roman.should == 'C'
-        end
-        it 'returns D for 500' do
-          RomanNumber.new(500).convert_decimal_to_roman.should == 'D'
-        end
-        it 'returns M for 1000' do
-          RomanNumber.new(1000).convert_decimal_to_roman.should == 'M'
-        end
-      end
-      context 'For Simple Integers' do
-        it 'returns IV for 4' do
-          RomanNumber.new(4).convert_decimal_to_roman.should == 'IV'
-        end
-        it 'returns IX for 9' do
-          RomanNumber.new(9).convert_decimal_to_roman.should == 'IX'
-        end
-        it 'returns XL for 40' do
-          RomanNumber.new(40).convert_decimal_to_roman.should == 'XL'
-        end
-        it 'returns XC for 90' do
-          RomanNumber.new(90).convert_decimal_to_roman.should == 'XC'
-        end
-        it 'returns CD for 400' do
-          RomanNumber.new(400).convert_decimal_to_roman.should == 'CD'
-        end
-        it 'returns CM for 900' do
-          RomanNumber.new(900).convert_decimal_to_roman.should == 'CM'
-        end
-        it 'returns CCVII for 207' do
-          RomanNumber.new(207).convert_decimal_to_roman.should == 'CCVII'
-        end
-        it 'returns MLXVI for 1066' do
-          RomanNumber.new(1066).convert_decimal_to_roman.should == 'MLXVI'
-        end
-      end
-      context 'For Complex Integers' do
-        it 'returns XLIV for 44' do
-          RomanNumber.new(44).convert_decimal_to_roman.should == 'XLIV'
-        end
-        it 'returns XLIX for 49' do
-          RomanNumber.new(49).convert_decimal_to_roman.should == 'XLIX'
-        end
-        it 'returns CMIV for 904' do
-          RomanNumber.new(904).convert_decimal_to_roman.should == 'CMIV'
-        end
-        it 'returns CMXLIV for 944' do
-          RomanNumber.new(944).convert_decimal_to_roman.should == 'CMXLIV'
-        end
-        it 'returns MCMIV for 1904' do
-          RomanNumber.new(1904).convert_decimal_to_roman.should == 'MCMIV'
-        end
-        it 'returns MCMXLIV for 1944' do
-          RomanNumber.new(1944).convert_decimal_to_roman.should == 'MCMXLIV'
-        end
-      end
-      context 'For Very Simple Integers' do
-        it 'returns MMMCMXCIX for 3999' do
-          RomanNumber.new(3999).convert_decimal_to_roman.should == 'MMMCMXCIX'
+      context 'For Valid Input' do
+        Helpers.valid_inputs.each do |exp_input, exp_output|
+          it %Q{returns #{exp_output} for #{exp_input} as input} do
+            RomanNumber.new(exp_input).convert_decimal_to_roman.should == exp_output
+          end
         end
       end
       context 'For Invalid Input' do
-        it 'raises InvalidInputError for 4000 as input' do
-          expect {
-            RomanNumber.new(4000).convert_decimal_to_roman
-          }.to raise_error(InvalidInputError)
-        end
-        it 'raises InvalidInputError for 0 as input' do
-          expect {
-            RomanNumber.new(0).convert_decimal_to_roman
-          }.to raise_error(InvalidInputError)
-        end
-        it 'raises InvalidInputError for -10 as input' do
-          expect {
-            RomanNumber.new(-10).convert_decimal_to_roman
-          }.to raise_error(InvalidInputError)
-        end
-        it 'raises InvalidInputError for "10" as input' do
-          expect {
-            RomanNumber.new('10').convert_decimal_to_roman
-          }.to raise_error(InvalidInputError)
+        exp_output = InvalidInputError
+        [
+            4000, 0, -10, '10'
+        ].each do |exp_input|
+          it %Q{raises #{exp_output} for #{exp_input} as input} do
+            expect {
+              RomanNumber.new(exp_input).convert_decimal_to_roman
+            }.to raise_error(exp_output)
+          end
         end
       end
     end
 
     describe '#convert_roman_to_arabic' do
-      context 'For Simple Romans' do
-        it 'returns 1 for I' do
-          RomanNumber.new('I').convert_roman_to_decimal.should == 1
-        end
-        it 'returns 5 for V' do
-          RomanNumber.new('V').convert_roman_to_decimal.should == 5
-        end
-        it 'returns 10 for X' do
-          RomanNumber.new('X').convert_roman_to_decimal.should == 10
-        end
-        it 'returns 50 for L' do
-          RomanNumber.new('L').convert_roman_to_decimal.should == 50
-        end
-        it 'returns 100 for C' do
-          RomanNumber.new('C').convert_roman_to_decimal.should == 100
-        end
-        it 'returns 500 for D' do
-          RomanNumber.new('D').convert_roman_to_decimal.should == 500
-        end
-        it 'returns 1000 for M' do
-          RomanNumber.new('M').convert_roman_to_decimal.should == 1000
-        end
-        it 'returns 4 for IV' do
-          RomanNumber.new('IV').convert_roman_to_decimal.should == 4
-        end
-        it 'returns 9 for IX' do
-          RomanNumber.new('IX').convert_roman_to_decimal.should == 9
-        end
-        it 'returns 40 for XL' do
-          RomanNumber.new('XL').convert_roman_to_decimal.should == 40
-        end
-        it 'returns 90 for XC' do
-          RomanNumber.new('XC').convert_roman_to_decimal.should == 90
-        end
-        it 'returns 400 for CD' do
-          RomanNumber.new('CD').convert_roman_to_decimal.should == 400
-        end
-        it 'returns 900 for CM' do
-          RomanNumber.new('CM').convert_roman_to_decimal.should == 900
-        end
-      end
-      context 'For Complex Romans' do
-        it 'returns 207 for CCVII' do
-          RomanNumber.new('CCVII').convert_roman_to_decimal.should == 207
-        end
-        it 'returns 1066 for MLXVI' do
-          RomanNumber.new('MLXVI').convert_roman_to_decimal.should == 1066
-        end
-        it 'returns 44 for XLIV' do
-          RomanNumber.new('XLIV').convert_roman_to_decimal.should == 44
-        end
-        it 'returns 49 for XLIX' do
-          RomanNumber.new('XLIX').convert_roman_to_decimal.should == 49
-        end
-        it 'returns 904 for CMIV' do
-          RomanNumber.new('CMIV').convert_roman_to_decimal.should == 904
-        end
-        it 'returns 944 for CMXLIV' do
-          RomanNumber.new('CMXLIV').convert_roman_to_decimal.should == 944
-        end
-        it 'returns 1904 for MCMIV' do
-          RomanNumber.new('MCMIV').convert_roman_to_decimal.should == 1904
-        end
-        it 'returns 1944 for MCMXLIV' do
-          RomanNumber.new('MCMXLIV').convert_roman_to_decimal.should == 1944
-        end
-        it 'returns 30 for XXX' do
-          RomanNumber.new('XXX').convert_roman_to_decimal.should == 30
-        end
-        it 'returns 3999 for MMMCMXCIX' do
-          RomanNumber.new('MMMCMXCIX').convert_roman_to_decimal.should == 3999
+      context 'For Valid Input' do
+        Helpers.valid_inputs.each do |exp_output, exp_input|
+          it %Q{returns #{exp_output} for #{exp_input} as input} do
+            RomanNumber.new(exp_input).convert_roman_to_decimal.should == exp_output
+          end
         end
       end
       context 'For Invalid Input' do
-        it 'raises InvalidInputError for ABCDE as input' do
-          expect {
-            RomanNumber.new('ABCDE').convert_roman_to_decimal
-          }.to raise_error(InvalidInputError)
-        end
-        it 'raises InvalidInputError for CCCCVII as input' do
-          expect {
-            RomanNumber.new('CCCCVII').convert_roman_to_decimal
-          }.to raise_error(InvalidInputError)
-        end
-        it 'raises InvalidInputError for CCVVVVI as input' do
-          expect {
-            RomanNumber.new('CCVVVVI').convert_roman_to_decimal
-          }.to raise_error(InvalidInputError)
+        exp_output = InvalidInputError
+        %w(ABCDE CCCCVII CCVVVVI XXM).each do |exp_input|
+          it %Q{raises #{exp_output} for #{exp_input} as input} do
+            expect {
+              RomanNumber.new(exp_input).convert_roman_to_decimal
+            }.to raise_error(exp_output)
+          end
         end
       end
     end

data/spec/spec_helper.rb

@@ -7,6 +7,7 @@ rescue LoadError
 end
 
 # source
+require_relative 'helpers'
 require_relative '../lib/roman_numbers'
 
 # gems used

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roman_numbers
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Munish Goyal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-01 00:00:00.000000000 Z
+date: 2014-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -112,6 +112,7 @@ files:
 - lib/roman_numbers/roman_number.rb
 - lib/roman_numbers/version.rb
 - roman_numbers.gemspec
+- spec/helpers.rb
 - spec/roman_numbers/roman_number_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/goyalmunish/roman_numbers
@@ -126,7 +127,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - '>='
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - '>='
@@ -139,5 +140,6 @@ signing_key:
 specification_version: 4
 summary: Conversion between Integers and Roman Numbers
 test_files:
+- spec/helpers.rb
 - spec/roman_numbers/roman_number_spec.rb
 - spec/spec_helper.rb