rom 3.3.2 → 3.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 351889d2541ad18d05c029e555b635919c68c50c
-  data.tar.gz: c66be9ee892b0ee4c4f2c7ec6505739d9a811df1
+  metadata.gz: 6668c7efb86e5ea164b03271cedf244574e9bde7
+  data.tar.gz: 2a7403db878177957d12db58803a0e8acda09fea
 SHA512:
-  metadata.gz: 451aa0e25642c399e67eda6cddd8db5c67b801bbea371f291094913d693e9f226ed5defe783df59dfebebf4b1fd67a3577096df13c91a63faec8a2260bf0eeed
-  data.tar.gz: 41db751db49169072c52b16ffd07f4cbd694463dd2a64b484553d1a9542e47db81492b17d0e1914e489c4cf02dfa8f49ffd4bad905f271b4fc45177c760b7580
+  metadata.gz: 4dc7c86d402ca351d91da62a1c4b2d24ce2f0b9203ed021ebe5a80943e9c0ad145b85502ec3b787d99f98793ba9488a726586f9523b9cbc0d7ec84e40e81450d
+  data.tar.gz: 6effb40c6e224f3a9eb398bff9a984b521559dbbb3103b3d3c7f389d367e3e8b45f0f68657a546fcc98ce09ba2fe63de59cd11e0172a92dac49ce4dcf7140856

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# v3.3.3 2017-10-19
+
+### Fixed
+
+* Fix warnings issued by redefining JSON types (graywolf)
+
+[Compare v3.3.2...v3.3.3](https://github.com/rom-rb/rom/compare/v3.3.2...v3.3.3)
+
 # v3.3.2 2017-10-14
 
 ### Fixed

data/lib/rom/types.rb

@@ -7,10 +7,6 @@ module ROM
 
     def self.included(other)
       other.extend(Methods)
-      other::Coercible.extend(CoercibleMethods)
-      other::Coercible.const_set('JSON', other::Coercible.JSON)
-      other::Coercible.const_set('JSONHash', other::Coercible.JSONHash)
-      other::Coercible.const_set('HashJSON', other::Coercible.HashJSON)
       super
     end
 
@@ -28,29 +24,26 @@ module ROM
       end
     end
 
-    module CoercibleMethods
-      def JSONHash(symbol_keys: false, type: Types::Hash)
-        Types.Constructor(type) do |value|
-          next Hash[value] if value.respond_to?(:to_hash)
-
-          begin
-            ::JSON.parse(value.to_s, symbolize_names: symbol_keys)
-          rescue ::JSON::ParserError
-            value
-          end
+    def Coercible.JSONHash(symbol_keys: false, type: Types::Hash)
+      Types.Constructor(type) do |value|
+        begin
+          ::JSON.parse(value.to_s, symbolize_names: symbol_keys)
+        rescue ::JSON::ParserError
+          value
         end
       end
+    end
 
-      def HashJSON(type: Types::String)
-        Types.Constructor(type) do |value|
-          next value unless value.respond_to?(:to_hash)
-          ::JSON.dump(value)
-        end
-      end
+    def Coercible.HashJSON(type: Types::String)
+      Types.Constructor(type) { |value| ::JSON.dump(value) }
+    end
 
-      def JSON(symbol_keys: false)
-        self.HashJSON.meta(read: self.JSONHash(symbol_keys: symbol_keys))
-      end
+    def Coercible.JSON(symbol_keys: false)
+      self.HashJSON.meta(read: self.JSONHash(symbol_keys: symbol_keys))
     end
+
+    Coercible::JSON = Coercible.JSON
+    Coercible::JSONHash = Coercible.JSONHash
+    Coercible::HashJSON = Coercible.HashJSON
   end
 end

data/lib/rom/version.rb

@@ -1,3 +1,3 @@
 module ROM
-  VERSION = '3.3.2'.freeze
+  VERSION = '3.3.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rom
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.3.3
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-14 00:00:00.000000000 Z
+date: 2017-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby