rom-rails 0.5.0.beta1 → 0.5.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e97b52065b6d47076303cb3e7b01bf0b2b26b2d2
-  data.tar.gz: 3a20e700c19316431532ea0780e176597e964a04
+  metadata.gz: 2a0fecb21539dab24cc3b9dc09fd911b1be12a9d
+  data.tar.gz: 8aebc8697715bb34f06a4e4a71af39d4d90b56fc
 SHA512:
-  metadata.gz: cf5e13ef79c24653c6fb3a83b93de8a01c11a3f9883b7f2dfb1cf0a6030a95bced0b82432d62c174bc05c48f1ef416fce6a50653d80005fee31e2a7c335741d7
-  data.tar.gz: 2b939dbc62be89dbaee3e7e9ccafcaa8f93e036b61ad3d9820024d374a8e8fb4e0a75b958c9eef37f93ffc6309daf5cb63c1e341e92bcc4f13866c2830a95a26
+  metadata.gz: 1df2b00473fbeeddfbc89a8f86464f0b3a1bce5f129b89ef21be1ebc453459835a32a13e1dfffabec190c39bb46bc6da22f8b7b30412288236bfbe3384a6f66a
+  data.tar.gz: 7170c0882c07630adfce78a90b2f3268625f425ad179fb44fe4a8983933fca4adea37787ee1b474047699602f1712fe5c185ed639fda4d01ee1e853ae5ccc6b6

data/Gemfile

@@ -4,7 +4,7 @@ gemspec
 
 RAILS_VERSION = '4.2.1'
 
-%w(railties activemodel actionview actionpack activerecord).each do |name|
+%w(railties actionview actionpack activerecord).each do |name|
   gem name, RAILS_VERSION
 end
 

data/README.md

@@ -30,10 +30,6 @@ To run tests:
     RAILS_ENV=test bundle exec rake db:migrate
     bundle exec rake
 
-## Issues
-
-Please report any issues in the main [rom-rb/rom](https://github.com/rom-rb/rom/issues) issue tracker.
-
 ## Resources
 
 You can read more about ROM and Rails on the official website:

data/lib/rom-rails.rb

@@ -1,6 +1,5 @@
-require 'active_model'
-
 require 'rom'
+
 require 'rom/rails/version'
 require 'rom/rails/railtie'
-require 'rom/model'
+require 'rom/rails/model/form'

data/lib/rom/rails/model/form.rb

@@ -1,3 +1,5 @@
+require 'rom-model'
+
 require 'rom/rails/model/form/class_interface'
 require 'rom/rails/model/form/error_proxy'
 

data/lib/rom/rails/version.rb

@@ -1,5 +1,5 @@
 module ROM
   module Rails
-    VERSION = '0.5.0.beta1'.freeze
+    VERSION = '0.5.0.rc1'.freeze
   end
 end

data/rom-rails.gemspec

@@ -17,7 +17,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'rom', '~> 0.9.0.beta1'
+  spec.add_runtime_dependency 'rom', '~> 0.9.0.rc1'
+  spec.add_runtime_dependency 'rom-model', '~> 0.1', '>= 0.1.0'
   spec.add_runtime_dependency 'addressable', '~> 2.3'
   spec.add_runtime_dependency 'charlatan', '~> 0.1'
   spec.add_runtime_dependency 'virtus', '~> 1.0', '>= 1.0.5'

data/spec/dummy/lib/rom/test_adapter.rb

@@ -1,6 +1,7 @@
 module ROM
   module TestAdapter
     class Relation < ROM::Relation
+      adapter :test_adapter
     end
 
     class Gateway < ROM::Gateway

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rom-rails
 version: !ruby/object:Gem::Version
-  version: 0.5.0.beta1
+  version: 0.5.0.rc1
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-10 00:00:00.000000000 Z
+date: 2015-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rom
@@ -16,14 +16,34 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0.beta1
+        version: 0.9.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0.beta1
+        version: 0.9.0.rc1
+- !ruby/object:Gem::Dependency
+  name: rom-model
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.0
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
@@ -164,17 +184,13 @@ files:
 - lib/generators/rom/relation/templates/relation.rb.erb
 - lib/generators/rom/relation_generator.rb
 - lib/rom-rails.rb
-- lib/rom/model.rb
 - lib/rom/rails/active_record/configuration.rb
 - lib/rom/rails/configuration.rb
 - lib/rom/rails/controller_extension.rb
 - lib/rom/rails/inflections.rb
-- lib/rom/rails/model/attributes.rb
 - lib/rom/rails/model/form.rb
 - lib/rom/rails/model/form/class_interface.rb
 - lib/rom/rails/model/form/error_proxy.rb
-- lib/rom/rails/model/validator.rb
-- lib/rom/rails/model/validator/uniqueness_validator.rb
 - lib/rom/rails/railtie.rb
 - lib/rom/rails/tasks/db.rake
 - lib/rom/rails/version.rb
@@ -243,7 +259,6 @@ files:
 - spec/integration/initializer_spec.rb
 - spec/integration/logger_spec.rb
 - spec/integration/new_user_form_spec.rb
-- spec/integration/user_attributes_spec.rb
 - spec/integration/user_commands_spec.rb
 - spec/integration/user_model_mapping_spec.rb
 - spec/lib/active_record/configuration_spec.rb
@@ -253,8 +268,6 @@ files:
 - spec/lib/generators/relation_generator_spec.rb
 - spec/spec_helper.rb
 - spec/unit/form_spec.rb
-- spec/unit/validator/embedded_spec.rb
-- spec/unit/validator_spec.rb
 homepage: http://rom-rb.org
 licenses:
 - MIT
@@ -344,7 +357,6 @@ test_files:
 - spec/integration/initializer_spec.rb
 - spec/integration/logger_spec.rb
 - spec/integration/new_user_form_spec.rb
-- spec/integration/user_attributes_spec.rb
 - spec/integration/user_commands_spec.rb
 - spec/integration/user_model_mapping_spec.rb
 - spec/lib/active_record/configuration_spec.rb
@@ -354,5 +366,3 @@ test_files:
 - spec/lib/generators/relation_generator_spec.rb
 - spec/spec_helper.rb
 - spec/unit/form_spec.rb
-- spec/unit/validator/embedded_spec.rb
-- spec/unit/validator_spec.rb

data/lib/rom/model.rb

@@ -1,14 +0,0 @@
-require 'charlatan'
-
-module ROM
-  module Model
-    class ValidationError < CommandError
-      include Charlatan.new(:errors)
-      include Equalizer.new(:errors)
-    end
-  end
-end
-
-require 'rom/rails/model/attributes'
-require 'rom/rails/model/validator'
-require 'rom/rails/model/form'

data/lib/rom/rails/model/attributes.rb

@@ -1,133 +0,0 @@
-require 'virtus'
-require 'active_model/conversion'
-
-module ROM
-  module Model
-    # Mixin for validatable and coercible parameters
-    #
-    # @example
-    #
-    #   class UserAttributes
-    #     include ROM::Model::Attributes
-    #
-    #     attribute :email, String
-    #     attribute :age, Integer
-    #
-    #     validates :email, :age, presence: true
-    #   end
-    #
-    #   user_attrs = UserAttributes.new(email: '', age: '18')
-    #
-    #   user_attrs.email # => ''
-    #   user_attrs.age # => 18
-    #
-    #   user_attrs.valid? # => false
-    #   user_attrs.errors # => #<ActiveModel::Errors:0x007fd2423fadb0 ...>
-    #
-    # @api public
-    module Attributes
-      VirtusModel = Virtus.model(nullify_blank: true)
-
-      # Inclusion hook used to extend a class with required interfaces
-      #
-      # @api private
-      def self.included(base)
-        base.class_eval do
-          include VirtusModel
-          include ActiveModel::Conversion
-        end
-        base.extend(ClassMethods)
-      end
-
-      # Return model name for the attributes class
-      #
-      # The model name object is configurable using `set_model_name` macro
-      #
-      # @see ClassMethods#set_model_name
-      #
-      # @return [ActiveModel::Name]
-      #
-      # @api public
-      def model_name
-        self.class.model_name
-      end
-
-      # Class extensions for an attributes class
-      #
-      # @api public
-      module ClassMethods
-        # Default timestamp attribute names used by `timestamps` method
-        DEFAULT_TIMESTAMPS = [:created_at, :updated_at].freeze
-
-        # Process input and return attributes instance
-        #
-        # @example
-        #   class UserAttributes
-        #     include ROM::Model::Attributes
-        #
-        #     attribute :name, String
-        #   end
-        #
-        #   UserAttributes[name: 'Jane']
-        #
-        # @param [Hash,#to_hash] input The input params
-        #
-        # @return [Attributes]
-        #
-        # @api public
-        def [](input)
-          input.is_a?(self) ? input : new(input)
-        end
-
-        # Macro for defining ActiveModel::Name object on the attributes class
-        #
-        # This is essential for rails helpers to work properly when generating
-        # form input names etc.
-        #
-        # @example
-        #   class UserAttributes
-        #     include ROM::Model::Attributes
-        #
-        #     set_model_name 'User'
-        #   end
-        #
-        # @return [undefined]
-        #
-        # @api public
-        def set_model_name(name)
-          class_eval <<-RUBY
-            def self.model_name
-              @model_name ||= ActiveModel::Name.new(self, nil, #{name.inspect})
-            end
-          RUBY
-        end
-
-        # Shortcut for defining timestamp attributes like created_at etc.
-        #
-        # @example
-        #   class NewPostAttributes
-        #     include ROM::Model::Attributes
-        #
-        #     # provide name(s) explicitly
-        #     timestamps :published_at
-        #
-        #     # defaults to :created_at, :updated_at without args
-        #     timestamps
-        #   end
-        #
-        # @api public
-        def timestamps(*attrs)
-          if attrs.empty?
-            DEFAULT_TIMESTAMPS.each do |t|
-              attribute t, DateTime, default: proc { DateTime.now }
-            end
-          else
-            attrs.each do |attr|
-              attribute attr, DateTime, default: proc { DateTime.now }
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rom/rails/model/validator.rb

@@ -1,191 +0,0 @@
-require 'rom/rails/model/validator/uniqueness_validator'
-require 'rom/support/class_macros'
-
-module ROM
-  module Model
-    # Mixin for ROM-compliant validator objects
-    #
-    # @example
-    #
-    #
-    #   class UserAttributes
-    #     include ROM::Model::Attributes
-    #
-    #     attribute :name
-    #
-    #     validates :name, presence: true
-    #   end
-    #
-    #   class UserValidator
-    #     include ROM::Model::Validator
-    #   end
-    #
-    #   attrs = UserAttributes.new(name: '')
-    #   UserValidator.call(attrs) # raises ValidationError
-    #
-    # @api public
-    module Validator
-      # Inclusion hook that extends a class with required interfaces
-      #
-      # @api private
-      def self.included(base)
-        base.class_eval do
-          extend ClassMethods
-          extend ROM::ClassMacros
-
-          include ActiveModel::Validations
-          include Equalizer.new(:attributes, :errors)
-
-          base.defines :embedded_validators
-
-          embedded_validators({})
-        end
-      end
-
-      # @return [Model::Attributes]
-      #
-      # @api private
-      attr_reader :attributes
-
-      # @api private
-      attr_reader :attr_names
-
-      delegate :model_name, to: :attributes
-
-      # @api private
-      def initialize(attributes)
-        @attributes = attributes
-        @attr_names = self.class.validators.map(&:attributes).flatten.uniq
-      end
-
-      # @return [Model::Attributes]
-      #
-      # @api public
-      def to_model
-        attributes
-      end
-
-      # Trigger validations and return attributes on success
-      #
-      # @raises ValidationError
-      #
-      # @return [Model::Attributes]
-      #
-      # @api public
-      def call
-        raise ValidationError, errors unless valid?
-        attributes
-      end
-
-      private
-
-      # This is needed for ActiveModel::Validations to work properly
-      # as it expects the object to provide attribute values. Meh.
-      #
-      # @api private
-      def method_missing(name, *args, &block)
-        if attr_names.include?(name)
-          attributes[name]
-        else
-          super
-        end
-      end
-
-      module ClassMethods
-        # Set relation name for a validator
-        #
-        # This is needed for validators that require database access
-        #
-        # @example
-        #
-        #   class UserValidator
-        #     include ROM::Model::Validator
-        #
-        #     relation :users
-        #
-        #     validates :name, uniqueness: true
-        #   end
-        #
-        # @return [Symbol]
-        #
-        # @api public
-        def relation(name = nil)
-          @relation = name if name
-          @relation
-        end
-
-        # @api private
-        def set_model_name(name)
-          class_eval <<-RUBY
-            def self.model_name
-              @model_name ||= ActiveModel::Name.new(self, nil, #{name.inspect})
-            end
-          RUBY
-        end
-
-        # Trigger validation for specific attributes
-        #
-        # @param [Model::Attributes] attributes The attributes for validation
-        #
-        # @raises [ValidationError]
-        #
-        # @return [Model::Attributes]
-        def call(attributes)
-          validator = new(attributes)
-          validator.call
-        end
-
-        # Specify an embedded validator for nested structures
-        #
-        # @example
-        #   class UserValidator
-        #     include ROM::Model::Validator
-        #
-        #     set_model_name 'User'
-        #
-        #     embedded :address do
-        #       validates :city, :street, :zipcode, presence: true
-        #     end
-        #
-        #     emebdded :tasks do
-        #       validates :title, presence: true
-        #     end
-        #   end
-        #
-        #   validator = UserAttributes.new(address: {}, tasks: {})
-        #
-        #   validator.valid? # false
-        #   validator.errors[:address].first # errors for address
-        #   validator.errors[:tasks] # errors for tasks
-        #
-        # @api public
-        def embedded(name, &block)
-          validator_class = Class.new { include ROM::Model::Validator }
-          validator_class.class_eval(&block)
-          validator_class.set_model_name(name.to_s.classify)
-
-          embedded_validators[name] = validator_class
-
-          validates name, presence: true
-
-          validate do
-            value = attributes[name]
-
-            if value.present?
-              Array([value]).flatten.each do |object|
-                validator = validator_class.new(object)
-                validator.validate
-
-                if validator.errors.any?
-                  errors.add(name, validator.errors)
-                else
-                  errors.add(name, [])
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rom/rails/model/validator/uniqueness_validator.rb

@@ -1,83 +0,0 @@
-require 'active_model/validator'
-
-module ROM
-  module Model
-    module Validator
-      # Uniqueness validation
-      #
-      # @api public
-      class UniquenessValidator < ActiveModel::EachValidator
-        # Relation validator class
-        #
-        # @api private
-        attr_reader :klass
-
-        # error message
-        #
-        # @return [String, Symbol]
-        #
-        # @api private
-        attr_reader :message
-
-        # @api private
-        def initialize(options)
-          super
-          @klass = options.fetch(:class)
-          @message = options.fetch(:message) { :taken }
-          @scope_keys = options[:scope]
-        end
-
-        # Hook called by ActiveModel internally
-        #
-        # @api private
-        def validate_each(validator, name, value)
-          scope = Array(@scope_keys).each_with_object({}) do |key, scope|
-            scope[key] = validator.to_model[key]
-          end
-          validator.errors.add(name, message) unless unique?(name, value, scope)
-        end
-
-        private
-
-        # Get relation object from the rom env
-        #
-        # @api private
-        def relation
-          if relation_name
-            rom.relations[relation_name]
-          else
-            raise "relation must be specified to use uniqueness validation"
-          end
-        end
-
-        # Relation name defined on the validator class
-        #
-        # @api private
-        def relation_name
-          klass.relation
-        end
-
-        # Shortcut to access global rom env
-        #
-        # @return [ROM::Env]
-        #
-        # @api private
-        def rom
-          ROM.env
-        end
-
-        # Ask relation if a given attribute value is unique
-        #
-        # This uses `Relation#unique?` interface that not all adapters can
-        # implement.
-        #
-        # @return [TrueClass,FalseClass]
-        #
-        # @api private
-        def unique?(name, value, scope)
-          relation.unique?({name => value}.merge(scope))
-        end
-      end
-    end
-  end
-end

data/spec/integration/user_attributes_spec.rb

@@ -1,48 +0,0 @@
-require 'spec_helper'
-
-describe ROM::Model::Attributes do
-  let(:attributes) do
-    Class.new do
-      include ROM::Model::Attributes
-
-      attribute :name, String
-
-      timestamps
-    end
-  end
-
-  describe '.timestamps' do
-    it 'provides a way to specify timestamps with default values' do
-      expect(attributes.new.created_at).to be_a(DateTime)
-      expect(attributes.new.updated_at).to be_a(DateTime)
-    end
-
-    context 'passing in arbritrary names' do
-      it 'excludes :created_at when passing in :updated_at' do
-        attributes = Class.new {
-          include ROM::Model::Attributes
-
-          timestamps(:updated_at)
-        }
-
-        model = attributes.new
-
-        expect(model).not_to respond_to(:created_at)
-        expect(model).to respond_to(:updated_at)
-      end
-
-      it 'accepts multiple timestamp attribute names' do
-        attributes = Class.new {
-          include ROM::Model::Attributes
-
-          timestamps(:published_at, :revised_at)
-        }
-
-        model = attributes.new
-
-        expect(model).to respond_to(:published_at)
-        expect(model).to respond_to(:revised_at)
-      end
-    end
-  end
-end

data/spec/unit/validator/embedded_spec.rb

@@ -1,118 +0,0 @@
-require 'spec_helper'
-
-describe 'Embedded validators' do
-  it 'allows defining a validator for a nested hash' do
-    user_validator = Class.new do
-      include ROM::Model::Validator
-
-      set_model_name 'User'
-
-      validates :name, presence: true
-
-      embedded :address do
-        set_model_name 'Address'
-
-        validates :street, :city, :zipcode, presence: true
-      end
-    end
-
-    attributes = { name: '', address: { street: '', city: '', zipcode: '' } }
-
-    expect { user_validator.call(attributes) }.to raise_error(
-      ROM::Model::ValidationError)
-
-    validator = user_validator.new(attributes)
-
-    expect(validator).to_not be_valid
-
-    expect(validator.errors[:name]).to include("can't be blank")
-
-    address_errors = validator.errors[:address].first
-
-    expect(address_errors).to_not be_empty
-
-    expect(address_errors[:street]).to include("can't be blank")
-    expect(address_errors[:city]).to include("can't be blank")
-    expect(address_errors[:zipcode]).to include("can't be blank")
-  end
-
-  it 'allows defining a validator for a nested array' do
-    user_validator = Class.new do
-      include ROM::Model::Validator
-
-      set_model_name 'User'
-
-      validates :name, presence: true
-
-      embedded :tasks do
-        set_model_name 'Task'
-
-        validates :title, presence: true
-      end
-    end
-
-    attributes = {
-      name: '',
-      tasks: [
-        { title: '' },
-        { title: 'Two' }
-      ]
-    }
-
-    expect { user_validator.call(attributes) }.to raise_error(
-      ROM::Model::ValidationError)
-
-    validator = user_validator.new(attributes)
-
-    expect(validator).to_not be_valid
-
-    expect(validator.errors[:name]).to include("can't be blank")
-
-    task_errors = validator.errors[:tasks]
-
-    expect(task_errors).to_not be_empty
-
-    expect(task_errors[0][:title]).to include("can't be blank")
-    expect(task_errors[1]).to be_empty
-  end
-
-  it 'validates presence of the nested structure' do
-    user_validator = Class.new do
-      include ROM::Model::Validator
-
-      set_model_name 'User'
-
-      validates :name, presence: true
-
-      embedded :tasks do
-        set_model_name 'Task'
-
-        validates :title, presence: true
-      end
-    end
-
-    validator = user_validator.new(name: '')
-    validator.validate
-
-    expect(validator.errors[:name]).to include("can't be blank")
-    expect(validator.errors[:tasks]).to include("can't be blank")
-  end
-
-  it 'exposes registered validators in embedded_validators hash' do
-    user_validator = Class.new do
-      include ROM::Model::Validator
-
-      set_model_name 'User'
-
-      validates :name, presence: true
-
-      embedded :tasks do
-        set_model_name 'Task'
-
-        validates :title, presence: true
-      end
-    end
-
-    expect(user_validator.embedded_validators[:tasks]).to be_present
-  end
-end

data/spec/unit/validator_spec.rb

@@ -1,163 +0,0 @@
-require 'spec_helper'
-
-describe 'Validation' do
-  subject(:validator) { user_validator.new(attributes) }
-
-  let(:user_attrs) do
-    Class.new {
-      include ROM::Model::Attributes
-
-      set_model_name 'User'
-
-      attribute :name, String
-      attribute :email, String
-      attribute :birthday, Date
-    }
-  end
-
-  let(:user_validator) do
-    Class.new {
-      include ROM::Model::Validator
-
-      relation :users
-
-      validates :name, presence: true, uniqueness: { message: 'TAKEN!' }
-      validates :email, uniqueness: true
-
-      def self.name
-        'User'
-      end
-    }
-  end
-
-  describe '#call' do
-    let(:attributes) { user_attrs.new }
-
-    it 'raises validation error when attributes are not valid' do
-      expect { validator.call }.to raise_error(ROM::Model::ValidationError)
-    end
-  end
-
-  describe "#validate" do
-    let(:attributes) { user_attrs.new }
-
-    it "sets errors when attributes are not valid" do
-      validator.validate
-      expect(validator.errors[:name]).to eql(["can't be blank"])
-    end
-  end
-
-  describe ':presence' do
-    let(:attributes) { user_attrs.new(name: '') }
-
-    it 'sets error messages' do
-      expect(validator).to_not be_valid
-      expect(validator.errors[:name]).to eql(["can't be blank"])
-    end
-  end
-
-  describe ':uniqueness' do
-    let(:attributes) { user_attrs.new(name: 'Jane', email: 'jane@doe.org') }
-
-    it 'sets default error messages' do
-      rom.relations.users.insert(name: 'Jane', email: 'jane@doe.org')
-
-      expect(validator).to_not be_valid
-      expect(validator.errors[:email]).to eql(['has already been taken'])
-    end
-
-    it 'sets custom error messages' do
-      rom.relations.users.insert(name: 'Jane', email: 'jane@doe.org')
-
-      expect(validator).to_not be_valid
-      expect(validator.errors[:name]).to eql(['TAKEN!'])
-    end
-
-    context 'with unique attributes within a scope' do
-      let(:user_validator) do
-        Class.new {
-          include ROM::Model::Validator
-
-          relation :users
-
-          validates :email, uniqueness: {scope: :name}
-
-          def self.name
-            'User'
-          end
-        }
-      end
-
-      let(:doubly_scoped_validator) do
-        Class.new {
-          include ROM::Model::Validator
-
-          relation :users
-
-          validates :email, uniqueness: {scope: [:name, :birthday]}
-
-          def self.name
-            'User'
-          end
-        }
-      end
-
-      it 'does not add errors' do
-        rom.relations.users.insert(name: 'Jane', email: 'jane+doe@doe.org')
-        attributes = user_attrs.new(name: 'Jane', email: 'jane@doe.org', birthday: Date.parse('2014-12-12'))
-        validator = user_validator.new(attributes)
-        expect(validator).to be_valid
-      end
-
-      it 'adds an error when the doubly scoped validation fails' do
-        attributes = user_attrs.new(name: 'Jane', email: 'jane@doe.org', birthday: Date.parse('2014-12-12'))
-        validator = doubly_scoped_validator.new(attributes)
-        expect(validator).to be_valid
-
-        rom.relations.users.insert(attributes.attributes)
-        expect(validator).to_not be_valid
-
-        attributes = user_attrs.new(name: 'Jane', email: 'jane+doe@doe.org', birthday: Date.parse('2014-12-12'))
-        validator = doubly_scoped_validator.new(attributes)
-        expect(validator).to be_valid
-      end
-    end
-
-    describe 'with missing relation' do
-      let(:user_validator) do
-        Class.new {
-          include ROM::Model::Validator
-
-          validates :email, uniqueness: true
-
-          def self.name
-            'User'
-          end
-        }
-      end
-
-      it 'raises a helpful error' do
-        validator = user_validator.new(user_attrs.new)
-        expect {
-          validator.valid?
-        }.to raise_error(/relation must be specified/)
-      end
-    end
-  end
-
-  describe '#method_missing' do
-    let(:attributes) { { name: 'Jane' } }
-
-    it 'returns attribute value if present' do
-      expect(validator.name).to eql('Jane')
-    end
-
-    it 'returns nil if attribute is not present' do
-      expect(validator.email).to be(nil)
-    end
-
-    it 'raises error when name does not match any of the attributes' do
-      expect { validator.foobar }.to raise_error(NoMethodError, /foobar/)
-    end
-  end
-end