rom-ldap 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d55b8ce14fb58a188849c42fe14bd2f544f6dfd92baed22b6f51e7606912f962
-  data.tar.gz: aab10466f1913470ffee5d8f11920ebe7b47c28a4ab06af3a48b41c65406c03d
+  metadata.gz: 7a44f158c5722e35b88676f3cdb5585b95cd1045ad2803777ce285795dce41f9
+  data.tar.gz: ef185f9d9829d8624351c1c43153f5fad0c8995cd1c2f9a80c7b6435ebac21ab
 SHA512:
-  metadata.gz: 3adec0a51363520adea1d39cd4c47adb697428390315bc282651299e840c59ea7c4c0eea05668a90cee8d49246fe4f77b4d1b63d482b3a693fde4462870b83b2
-  data.tar.gz: c137ac63e72a7ca07d01e978acf2990dd2f5d49e3bf8a0ee2f869d593bb844839ed491d51a231e4cdb971439fe51f9d472fcb0e4c6023cba5305f13b10b05608
+  metadata.gz: 9b647474a05f2721cd4cf888c9c86514330f993f7dd0f31040f29d3853b0b4f465c8b9a7dc1a7ea2084e18607a84e92a1617f2d6b83f24bd18711864d6eb2085
+  data.tar.gz: 7595c3ec810a35feefda806cc85910a76e3e9e3d48b5ef0bbda0ba5127cf9c6630b89d75267b3cdcaa142debb8cf77745b3e5d291361323494713d9191b00c72

data/CHANGELOG.md

@@ -1,8 +1,24 @@
 ## unreleased
 
 <!-- TODO -->
-[Compare v0.2.1...master](https://gitlab.com/peterdavidhamilton/rom-ldap/compare/v0.2.1...master)
+[Compare v0.2.3...master](https://gitlab.com/peterdavidhamilton/rom-ldap/compare/v0.2.3...master)
 
+# 0.2.3 / 2021-02-23
+
+### Fixed
+
+- Compatibility with pre-release ROM 6.0 and Ruby 3.0
+
+[Compare v0.2.2...v0.2.3](https://gitlab.com/peterdavidhamilton/rom-ldap/compare/v0.2.2...0.2.3)
+
+# 0.2.2 / 2021-02-21
+
+### Changed
+
+- CI/CD pipeline was failing because OpenDJ service requires more memory than the shared runners provide.
+- Yanked 0.2.1 to edit the gem description and credit Net::LDAP team for their part in this gem.
+
+[Compare v0.2.1...v0.2.2](https://gitlab.com/peterdavidhamilton/rom-ldap/compare/v0.2.1...0.2.2)
 
 # 0.2.1 / 2021-02-19
 

data/README.md

@@ -10,7 +10,7 @@ This gem makes it easier to use LDAP in your project or even as your primary dat
 
 ## Requirements
 
-[ROM-LDAP][rom-ldap] is compatible with versions of [Ruby][ruby] from 2.4 to 2.7.
+[ROM-LDAP][rom-ldap] is compatible with versions of [Ruby][ruby] 2.4 and above.
 
 
 
@@ -169,4 +169,4 @@ for a skeleton version of this same example applied to the [Ruby on Rails][rails
 [rom-rb]: https://rom-rb.org
 [rom-sql]: https://rom-rb.org/5.0/learn/sql
 [ruby]: https://www.ruby-lang.org/en/downloads
-[sequel]: http://sequel.jeremyevans.net
+[sequel]: http://sequel.jeremyevans.net

data/TODO.md

@@ -21,13 +21,17 @@
     Simple rudimentary RDMS.
     <https://www.openldap.org/doc/admin24/intro.html#LDAP%20vs%20RDBMS>
 
-7. Directory instrumentation using dry-monitor to replace debug logging.
+7. **Logging**
+   Directory instrumentation using dry-monitor to replace debug logging.
 
-8. `rom/devtools` integration.
+8. **ROM-RB**
+   Keep pace with other rom-rb improvements like `rom/devtools` integration.
 
+9. **CI/CD**
+   Speed up testing by only using OpenLDAP, with other vendors as optional extras (including Microsoft AD LDS).
 
 ## ONGOING
 
-- Improve Rspec coverage, currently 90% complete @ v0.1.0
-- Improve Yard docs, currently 72% complete @ v0.1.0
+- Improve Rspec coverage, currently 90% complete @ v0.2.3
+- Improve Yard docs, currently 76% complete @ v0.2.3
 - Ensure Rubocop style compliance

data/lib/dry/monitor/ldap/logger.rb

@@ -44,8 +44,8 @@ module Dry
         end
 
         def subscribe(notifications)
-          notifications.subscribe(:ldap) do |time:, name:, query:|
-            log_query(time, name, query)
+          notifications.subscribe(:ldap) do |ldap|
+            log_query(ldap[:time], ldap[:name], ldap[:query])
           end
         end
 

data/lib/rom/ldap/client.rb

@@ -43,7 +43,7 @@ module ROM
       # @raise [BindError, SecureBindError]
       def open
         unless alive?
-          @socket = Socket.new(options).call
+          @socket = Socket.new(**options).call
 
           # tls
           if ssl
@@ -51,7 +51,7 @@ module ROM
             sasl_bind # (mechanism:, credentials:, challenge:)
           end
 
-          bind(auth) unless auth.nil? # simple auth
+          bind(**auth) unless auth.nil? # simple auth
         end
 
         yield(@socket)

data/lib/rom/ldap/client/authentication.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Lint/SuppressedException
 begin
   # TODO: Windows NTLM authentication
   # @see https://github.com/winrb/rubyntlm
@@ -8,8 +7,6 @@ begin
 rescue LoadError
   # ntlm_bind
 end
-# rubocop:enable Lint/SuppressedException
-
 module ROM
   module LDAP
     # @api private

data/lib/rom/ldap/client/operations.rb

@@ -24,8 +24,9 @@ module ROM
         # @yield [Hash] :search_referrals
         #
         # @api private
-        def search(return_refs: true, **params)
-          search_request = SearchRequest.new(params)
+        def search(**params)
+          return_refs    = params.fetch(:return_refs, true)
+          search_request = SearchRequest.new(**params)
           request_type   = pdu_lookup(:search_request)
           result_pdu     = nil
 

data/lib/rom/ldap/dataset.rb

@@ -96,7 +96,7 @@ module ROM
       #
       # @api public
       def with(overrides)
-        self.class.new(options.merge(overrides))
+        self.class.new(**options.merge(overrides))
       end
 
       # @return [Hash] internal options

data/lib/rom/ldap/directory.rb

@@ -55,7 +55,7 @@ module ROM
       # @return [Client]
       #
       def client
-        @client ||= Client.new(env.to_h)
+        @client ||= Client.new(**env.to_h)
       end
 
       # Expected method inside gateway.

data/lib/rom/ldap/directory/env.rb

@@ -16,7 +16,6 @@ module ROM
       # @see https://ldapwiki.com/wiki/LDAP%20URL
       # @see https://docs.oracle.com/cd/E19957-01/816-6402-10/url.htm
       #
-      # rubocop:disable Lint/UriEscapeUnescape
       #
       # @api private
       class ENV
@@ -114,7 +113,6 @@ module ROM
           dn = config.fetch(:username, ::ENV['LDAPBINDDN']) || uri.user
           dn.gsub(PERCENT_SPACE, SPACE) if dn
         end
-        # rubocop:enable Lint/UriEscapeUnescape
 
         # Override LDAPURI password with options or LDAPBINDPW
         #

data/lib/rom/ldap/directory/operations.rb

@@ -25,9 +25,11 @@ module ROM
         #
         # @api public
         #
-        def query(filter: DEFAULT_FILTER, **options)
+        def query(**options)
           set, counter = [], 0
 
+          filter = options.delete(:filter) || DEFAULT_FILTER
+
           # TODO: pageable and search referrals
           params = {
             base: base,
@@ -39,8 +41,7 @@ module ROM
             # https://tools.ietf.org/html/rfc4511#section-4.5.3
           }
 
-          # pdu = client.search(params) do |search_referrals: |
-          pdu = client.search(params) do |dn, attributes|
+          pdu = client.search(**params) do |dn, attributes|
             counter += 1
             logger.debug("#{counter}: #{dn}") if ::ENV['DEBUG']
 

data/lib/rom/ldap/expression.rb

@@ -22,7 +22,7 @@ module ROM
       # @api public
       def to_ber
         require 'rom/ldap/expression_encoder'
-        ExpressionEncoder.new(options).call
+        ExpressionEncoder.new(**options).call
       end
 
       # Unbracketed filter string

data/lib/rom/ldap/extensions.rb

@@ -34,7 +34,6 @@ module ROM
       require 'rom/ldap/extensions/optimised_json'
     end
 
-
     #=======================================
     # Autoloaded for Rails
     #=======================================

data/lib/rom/ldap/pdu.rb

@@ -151,7 +151,7 @@ module ROM
       def result_controls
         ctrls.map do |control|
           oid, level, value = control
-          value, level = level, false if level&.is_a?(String)
+          value, level = level, false if level.is_a?(String)
           ::OpenStruct.new(oid: oid, criticality: level, value: value)
         end
       end

data/lib/rom/ldap/schema/type_builder.rb

@@ -61,7 +61,7 @@ module ROM
         # @api public
         def call(attribute_name, schema)
           attribute = find_attribute(attribute_name)
-          primitive = map_type(attribute)
+          primitive = map_type(**attribute)
           ruby_type = Types.const_get(primitive)
           read_type = !attribute[:single] ? Types.const_get(Inflector.pluralize(primitive)) : ruby_type
 

data/lib/rom/ldap/transaction.rb

@@ -16,13 +16,11 @@ module ROM
         @directory = directory
       end
 
-      # rubocop:disable Lint/SuppressedException
       def run(opts = EMPTY_OPTS)
         directory.transaction(opts) { yield(self) }
       rescue ::ROM::Transaction::Rollback
         # noop
       end
-      # rubocop:enable Lint/SuppressedException
 
     end
   end

data/lib/rom/ldap/version.rb

@@ -9,7 +9,7 @@ module ROM
     MINOR = 2
 
     # The tiny version of ROM-LDAP. Only bumped for bugfix releases.
-    TINY  = 2
+    TINY  = 3
 
     # The version of ROM-LDAP, as a string (e.g. "2.11.0")
     VERSION = [MAJOR, MINOR, TINY].join('.').freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rom-ldap
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Peter Hamilton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-21 00:00:00.000000000 Z
+date: 2021-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-transformer
@@ -39,19 +39,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.1'
 - !ruby/object:Gem::Dependency
-  name: rom-core
+  name: rom
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -94,9 +94,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
-description: |
-  ROM-LDAP is a Ruby Object Mapper gateway adapter for LDAP.
-  This gem is a reworking of NET::LDAP for use with ROM.
+description: LDAP support for ROM
 email:
 - pete@peterdavidhamilton.com
 executables: []
@@ -208,14 +206,24 @@ files:
 homepage: https://rom-rb.org
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  source_code_uri: https://gitlab.com/peterdavidhamilton/rom-ldap
+  bug_tracker_uri: https://gitlab.com/peterdavidhamilton/rom-ldap/issues
+  wiki_uri: https://gitlab.com/peterdavidhamilton/rom-ldap/wikis
+  documentation_uri: https://pdhamilton.uk/projects/rom-ldap
+  mailing_list_uri: https://discourse.rom-rb.org/
+post_install_message: |
+  ROM-LDAP would not be possible without the hard work of contributors
+  to the ruby-net-ldap gem, whose code it is inspired by.
+
+  THANK YOU
+  https://pdhamilton.uk
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
       version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
@@ -224,8 +232,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
-summary: lightweight directory adapter for ROM
+summary: LDAP support for ROM
 test_files: []