rom-kafka 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d9a99ade5720d02866116b79501fe55db215d7b
-  data.tar.gz: 158384e1135ce7d407432a5aaba796b11c31e60f
+  metadata.gz: 3d8631833883999ca97e9adf2b6380a3e196af95
+  data.tar.gz: 79d40d534a95243e578606d73c177abd70ecddb8
 SHA512:
-  metadata.gz: ac20ac252417b721d88d75be5e83896311429f155d2e1317e100e4c32f8d384739e471b512167a04bb7cedcdfaf4516c32b0f262cabe212681e3de84a160bff0
-  data.tar.gz: a5bcca9a39c7a45b6c6862cfe6f919c44f02d33a80137d663d6176bf05da44d3d3c00f9d9535f66f20af25a45159bc2fa5fd607caa10d9b2304679e0f25084a0
+  metadata.gz: 979b7e2bc84945296660524cb654e934024d8154dae17c3eeb940399b3e679b0b1c14e1c1410181a690cb216622fb67eae94a9a85aa0fb5f96666a67f12b8804
+  data.tar.gz: f6779f28c402cb6dfddf92aecb0bf00557a685e62e904107504803affba54cc038174cd86165e9dc3eff3f3a49740222fa30a40d7bc4b1689eaa865216182389

data/.travis.yml

@@ -17,16 +17,12 @@ before_install:
   - ./bin/kafka-topics.sh --zookeeper localhost:2181 --create --topic scholars --partitions 3 --replication-factor 1
   - cd ../
 rvm:
-  - '1.9.3'
-  - '2.0'
   - '2.1'
   - '2.2'
+  - '2.3.0'
   - ruby-head
-  - rbx-2 --1.9
-  - rbx-2 --2.1
-  - jruby-1.7-19mode
-  - jruby-1.7-21mode
-  - jruby-9.0.0.0
+  - rbx-2
+  - jruby-9000
   - jruby-head
 matrix:
   allow_failures:

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v0.0.2 to be released
+
+### Added
+
+* Thread-safety for connections (both producer and consumer) (nepalez)
+
+[Compare v0.0.1...HEAD](https://github.com/rom-rb/rom-kafka/compare/v0.0.1...HEAD)
+
 ## v0.0.1 2015-09-16
 
 First public alpha-release.

data/Guardfile

@@ -11,4 +11,4 @@ guard :rspec, cmd: "bundle exec rspec", all_on_start: true do
   watch("lib/rom-kafka.rb")    { "spec" }
   watch("spec/spec_helper.rb") { "spec" }
 
-end # guard :rspec
+end

data/README.md

@@ -44,7 +44,7 @@ Compatibility
 
 Compatible to [ROM][rom] 0.9+, [Apache Kafka][kafka] 0.8+.
 
-Tested under [rubies compatible to MRI 1.9.3+][rubies].
+Tested under [rubies supported by ROM][rubies].
 
 Uses [RSpec][rspec] 3.0+ for testing and [hexx-suit][hexx-suit] for dev/test tools collection.
 

data/lib/rom-kafka.rb

@@ -1,3 +1 @@
-# encoding: utf-8
-
 require_relative "rom/kafka"

data/lib/rom/kafka.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 require "attributes_dsl"
 require "poseidon"
 require "rom"
@@ -8,22 +7,18 @@ require "rom"
 # @see http://rom-rb.org/
 #
 module ROM
-
   # Apache Kafka support for ROM
   #
   # @see http://kafka.apache.org/
   #
   module Kafka
-
     require_relative "kafka/brokers"
     require_relative "kafka/connection"
     require_relative "kafka/dataset"
     require_relative "kafka/gateway"
     require_relative "kafka/relation"
     require_relative "kafka/create"
-
-  end # module Kafka
+  end
 
   register_adapter(:kafka, Kafka)
-
-end # module ROM
+end

data/lib/rom/kafka/brokers.rb

@@ -1,9 +1,6 @@
-# encoding: utf-8
-
 require_relative "brokers/broker"
 
 module ROM::Kafka
-
   # Value object describing a collection of brokers (host:port)
   #
   # Knows how to extract brokers from address lines and options
@@ -23,7 +20,6 @@ module ROM::Kafka
   # @author Andrew Kozin <Andrew.Kozin@gmail.com>
   #
   class Brokers
-
     include Equalizer.new(:to_a)
 
     # @!method initialize(lines, options)
@@ -37,11 +33,9 @@ module ROM::Kafka
     # @option options [#to_s, Array<#to_s>] :hosts
     # @option options [#to_i] :port
     #
-    def initialize(*lines)
+    def initialize(*lines) # @todo: refactor using factories
       hosts, port = extract_hosts_and_port(lines)
       @brokers    = extract_brokers(hosts, port)
-
-      IceNine.deep_freeze(self)
     end
 
     # Returns array of string representations of brokers
@@ -66,7 +60,5 @@ module ROM::Kafka
       brokers = hosts.map { |host| Broker.new(host: host, port: port) }
       brokers.any? ? brokers : [Broker.new]
     end
-
-  end # class Brokers
-
-end # module ROM::Kafka
+  end
+end

data/lib/rom/kafka/brokers/broker.rb

@@ -1,9 +1,5 @@
-# encoding: utf-8
-
 module ROM::Kafka
-
   class Brokers
-
     # Describes an address to a brocker
     #
     # @example
@@ -19,7 +15,6 @@ module ROM::Kafka
     # @author Andrew Kozin <Andrew.Kozin@gmail.com>
     #
     class Broker
-
       include Equalizer.new(:port, :host)
 
       # Regex to extract host from address line
@@ -49,8 +44,6 @@ module ROM::Kafka
         line  = options.fetch(:host) { "localhost" }
         @host = line[HOST]
         @port = (line[PORT] || options.fetch(:port) { 9092 }).to_i
-
-        IceNine.deep_freeze(self)
       end
 
       # Returns the string representation of the broker in "host:port" format
@@ -60,9 +53,6 @@ module ROM::Kafka
       def to_s
         "#{host}:#{port}"
       end
-
-    end # class Broker
-
-  end # class Brokers
-
-end # module ROM::Kafka
+    end
+  end
+end

data/lib/rom/kafka/connection.rb

@@ -1,7 +1,4 @@
-# encoding: utf-8
-
 module ROM::Kafka
-
   # Describes the connection to Kafka cluster
   #
   # This is a base abstract class for producer and concumer connections.
@@ -11,12 +8,9 @@ module ROM::Kafka
   # @author Andrew Kozin <Andrew.Kozin@gmail.com>
   #
   class Connection
-
     extend AttributesDSL
 
     require_relative "connection/producer"
     require_relative "connection/consumer"
-
-  end # class Connection
-
-end # module ROM::Kafka
+  end
+end

data/lib/rom/kafka/connection/consumer.rb

@@ -1,9 +1,5 @@
-# encoding: utf-8
-
 module ROM::Kafka
-
   class Connection
-
     # The consumer-specific connection to Kafka cluster
     #
     # It is wrapped around `Poseidon::Consumer` driver, and responsible for
@@ -16,7 +12,6 @@ module ROM::Kafka
     # @api private
     #
     class Consumer < Connection
-
       include Enumerable
 
       # The 'poseidon'-specific class describing consumers
@@ -60,10 +55,12 @@ module ROM::Kafka
       #   How long to block until the server sends data.
       #   NOTE: This is only enforced if min_bytes is > 0.
       #
+      # @todo: refactor usinng factory method Connection.build_consumer
       def initialize(opts)
         super # takes declared attributes from options
         args = opts.values_at(:client_id, :brokers, :topic, :partition, :offset)
         @connection = DRIVER.consumer_for_partition(*args, attributes)
+        @mutex = Mutex.new
       end
 
       # Fetches a single portion of messages and converts them to tuple
@@ -71,8 +68,7 @@ module ROM::Kafka
       # @return [Array<Hash{Symbol => String, Integer}>]
       #
       def fetch
-        result = @connection.fetch
-        result.map(&method(:tuple))
+        @mutex.synchronize { @connection.fetch }.map(&method(:tuple))
       end
 
       # Iterates through Kafka messages
@@ -97,9 +93,6 @@ module ROM::Kafka
       def tuple(msg)
         { value: msg.value, topic: msg.topic, key: msg.key, offset: msg.offset }
       end
-
-    end # class Consumer
-
-  end # class Connection
-
-end # module ROM::Kafka
+    end
+  end
+end

data/lib/rom/kafka/connection/producer.rb

@@ -1,9 +1,5 @@
-# encoding: utf-8
-
 module ROM::Kafka
-
   class Connection
-
     # The producer-specific connection to Kafka cluster
     #
     # It is wrapped around `Poseidon::Producer` driver, and responsible for
@@ -73,11 +69,12 @@ module ROM::Kafka
       # @option options [Integer] :socket_timeout_ms (10_000)
       #   How long the producer/consumer socket waits for any reply from server.
       #
-      def initialize(options)
+      def initialize(options) # @todo: Refactor using factory method Connection.build_producer
         super # takes declared attributes only, skipping brokers and client_id
-        brokers    = options.fetch(:brokers)
-        client     = options.fetch(:client_id)
+        brokers     = options.fetch(:brokers)
+        client      = options.fetch(:client_id)
         @connection = DRIVER.new(brokers, client, attributes)
+        @mutex      = Mutex.new
       end
 
       # Sends tuples to the underlying connection
@@ -90,9 +87,9 @@ module ROM::Kafka
       #   The list of published tuples
       #
       def publish(*data)
-        tuples = data.flatten.map(&method(:stringify_keys))
-        @connection.send_messages tuples.map(&method(:message))
-
+        tuples   = data.flatten.map(&method(:stringify_keys))
+        messages = tuples.map(&method(:message))
+        @mutex.synchronize { @connection.send_messages messages }
         tuples
       end
 
@@ -106,9 +103,6 @@ module ROM::Kafka
       def message(tuple)
         MESSAGE.new(*tuple.values_at(:topic, :value, :key))
       end
-
-    end # class Producer
-
-  end # class Connection
-
-end # module ROM::Kafka
+    end
+  end
+end

data/lib/rom/kafka/create.rb

@@ -1,11 +1,7 @@
-# encoding: utf-8
-
 module ROM::Kafka
-
   # The namespace for Kafka-specific ROM commands
   #
   module Commands
-
     # The Kafka-specific implementation of ROM::Commands::Create
     #
     # @example
@@ -67,9 +63,6 @@ module ROM::Kafka
       def tuple(text)
         { value: text.to_s, topic: dataset.topic, key: key }
       end
-
-    end # class Create
-
-  end # module Commands
-
-end # module ROM::Kafka
+    end
+  end
+end

data/lib/rom/kafka/dataset.rb

@@ -1,7 +1,4 @@
-# encoding: utf-8
-
 module ROM::Kafka
-
   # The dataset describes Kafka topic
   #
   # @api private
@@ -75,7 +72,7 @@ module ROM::Kafka
       @topic    = topic.to_s
       @gateway  = gateway
       @producer = gateway.producer
-      @consumer = prepare_consumer
+      @consumer = prepare_consumer # @todo: refactor using a factory
     end
 
     # Returns a new dataset with updated consumer attributes
@@ -126,7 +123,5 @@ module ROM::Kafka
       enum = consumer.each
       limit.times { yield(enum.next) }
     end
-
-  end # class Dataset
-
-end # module ROM::Kafka
+  end
+end

data/lib/rom/kafka/gateway.rb

@@ -1,7 +1,4 @@
-# encoding: utf-8
-
 module ROM::Kafka
-
   # Describes the gateway to Kafka
   #
   # The gateway has 3 responsibilities:
@@ -112,12 +109,12 @@ module ROM::Kafka
     #   How long to block until the server sends data.
     #   NOTE: This is only enforced if min_bytes is > 0.
     #
-    def initialize(*addresses)
+    def initialize(*addresses) # @todo: refactor the fat initializer
       options = Hash[addresses.pop]
-      brokers = Brokers.new(addresses, options).to_a
+      brokers = Brokers.new(addresses, options).to_a   # @todo: refactor using a factory
       super options.merge(brokers: brokers) # prepares #attributes
 
-      @producer = Connection::Producer.new(attributes)
+      @producer = Connection::Producer.new(attributes) # @todo: refactor using a factory
       @datasets = {}
     end
 
@@ -159,7 +156,5 @@ module ROM::Kafka
     def dataset?(topic)
       self[topic] ? true : false
     end
-
-  end # class Gateway
-
-end # module ROM::Kafka
+  end
+end

data/lib/rom/kafka/relation.rb

@@ -1,7 +1,4 @@
-# encoding: utf-8
-
 module ROM::Kafka
-
   # The Kafka-specific implementation of ROM::Relation
   #
   # @example
@@ -22,6 +19,7 @@ module ROM::Kafka
   class Relation < ROM::Relation
 
     adapter :kafka
+    forward :using
 
     # Kafka-specific alias for the ROM `.dataset` helper method.
     #
@@ -62,17 +60,5 @@ module ROM::Kafka
     def limit(value)
       using(limit: value)
     end
-
-    # Returns new relation where dataset is updated with given attributes
-    #
-    # @param [Hash] attributes
-    #
-    # @return [ROM::Kafka::Relation]
-    #
-    def using(attributes)
-      self.class.new dataset.using(attributes)
-    end
-
-  end # class Relation
-
-end # module ROM::Kafka
+  end
+end

data/rom-kafka.gemspec

@@ -1,12 +1,6 @@
-# encoding: utf-8
-lib = File.expand_path("../lib", __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "rom/kafka/version"
-
 Gem::Specification.new do |gem|
-
   gem.name             = "rom-kafka"
-  gem.version          = ROM::Kafka::VERSION.dup
+  gem.version          = "0.0.2"
   gem.author           = ["Andrew Kozin"]
   gem.email            = ["andrew.kozin@gmail.com"]
   gem.summary          = "Kafka support for Ruby Object Mapper"
@@ -14,20 +8,19 @@ Gem::Specification.new do |gem|
   gem.homepage         = "https://rom-rb.org"
   gem.license          = "MIT"
 
-  gem.files            = `git ls-files -z`.split("\x0")
+  gem.files            = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   gem.executables      = gem.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  gem.test_files       = gem.files.grep(%r{^(test|spec|features)/})
-  gem.extra_rdoc_files = Dir["README.md", "LICENSE"]
+  gem.test_files       = gem.files.grep(/^spec/)
+  gem.extra_rdoc_files = Dir["README.md", "LICENSE", "CHANGELOG.md"]
   gem.require_paths    = ["lib"]
 
-  gem.required_ruby_version = "~> 1.9", ">= 1.9.3"
+  gem.required_ruby_version = ">= 1.9.3"
 
-  gem.add_runtime_dependency "rom", "~> 0.9", ">= 0.9.1"
-  gem.add_runtime_dependency "poseidon", "~> 0.0", ">= 0.0.5"
-  gem.add_runtime_dependency "attributes_dsl", "~> 0.0", ">= 0.0.2"
+  gem.add_runtime_dependency "rom", "~> 1.0"
+  gem.add_runtime_dependency "poseidon", "~> 0.0.5"
+  gem.add_runtime_dependency "attributes_dsl", "~> 0.1.0", ">= 0.1.1"
 
   gem.add_development_dependency "hexx-rspec", "~> 0.5"
   gem.add_development_dependency "inflecto", "~> 0.0", ">= 0.0.2"
   gem.add_development_dependency "timecop", "~> 0.8"
-
-end # Gem::Specification
+end

data/spec/integration/basic_usage_spec.rb

@@ -1,8 +1,6 @@
-# encoding: utf-8
 require "shared/scholars_topic"
 
 describe "Basic Usage" do
-
   include_context :scholars_topic
 
   let(:add_scholars) { insert.with(key: 0) }
@@ -54,5 +52,4 @@ describe "Basic Usage" do
     # To start from the next offset, we should set it explicitly.
     expect(scholars.call.to_a).to eql []
   end
-
-end # describe Basic Usage
+end

data/spec/integration/keys_usage_spec.rb

@@ -1,8 +1,6 @@
-# encoding: utf-8
 require "shared/scholars_topic"
 
 describe "Keys Usage" do
-
   include_context :scholars_topic
 
   it "works" do
@@ -30,5 +28,4 @@ describe "Keys Usage" do
       { value: "Philip", topic: "scholars", key: "5", offset: 1 }
     ]
   end
-
-end # describe Keys Usage
+end

data/spec/shared/scholars_topic.rb

@@ -1,28 +1,19 @@
-# encoding: utf-8
-
 shared_examples :scholars_topic do
-
   let!(:rom) do
-    env = ROM::Environment.new
-    env.use :auto_registration
-
-    setup = env.setup(
-      :kafka, "localhost:9092",
+    options = {
       client_id: "admin",
-      # use the number of partition as a key
-      partitioner: -> key, total { key.to_i % total }
-    )
+      partitioner: proc { |key, total| key.to_i % total }
+    }
+    ROM.container(:kafka, "localhost:9092", options) do |config|
+      config.use(:macros)
 
-    setup.relation(:scholars)
-    setup.commands(:scholars) do
-      define(:create)
+      config.relation(:scholars)
+      config.commands(:scholars) do
+        define(:create)
+      end
     end
-
-    setup.finalize
-    setup.env
   end
 
   let(:scholars) { rom.relation(:scholars) }
   let(:insert)   { rom.command(:scholars).create }
-
-end # shared_examples
+end

data/spec/spec_helper.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 begin
   require "hexx-suit"
   Hexx::Suit.load_metrics_for(self)

data/spec/unit/brokers/broker_spec.rb

@@ -1,15 +1,7 @@
-# encoding: utf-8
-
 describe ROM::Kafka::Brokers::Broker do
 
   let(:broker) { described_class.new }
 
-  describe ".new" do
-    subject { broker }
-
-    it { is_expected.to be_frozen }
-  end # describe .new
-
   describe "#host" do
     subject { broker.host }
 
@@ -28,7 +20,7 @@ describe ROM::Kafka::Brokers::Broker do
 
       it { is_expected.to eql "localhost" }
     end
-  end # describe #host
+  end
 
   describe "#port" do
     subject { broker.port }
@@ -56,13 +48,13 @@ describe ROM::Kafka::Brokers::Broker do
         expect(subject).to eql 9092
       end
     end
-  end # describe #port
+  end
 
   describe "#to_s" do
     subject { described_class.new(host: :"127.0.0.1:9093").to_s }
 
     it { is_expected.to eql "127.0.0.1:9093" }
-  end # describe #to_s
+  end
 
   describe "#==" do
     subject { broker == other }
@@ -84,6 +76,5 @@ describe ROM::Kafka::Brokers::Broker do
 
       it { is_expected.to eql false }
     end
-  end # describe #==
-
-end # describe ROM::Kafka::Brokers::Broker
+  end
+end

data/spec/unit/brokers_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 describe ROM::Kafka::Brokers do
 
   let(:default_brokers) { described_class.new }
@@ -7,12 +5,6 @@ describe ROM::Kafka::Brokers do
     described_class.new "foo", "bar:9093", hosts: ["baz:9092"], port: 9094
   end
 
-  describe ".new" do
-    subject { default_brokers }
-
-    it { is_expected.to be_frozen }
-  end # describe .new
-
   describe "#to_a" do
     context "by default" do
       subject { default_brokers.to_a }
@@ -25,7 +17,7 @@ describe ROM::Kafka::Brokers do
 
       it { is_expected.to eql ["foo:9094", "bar:9093", "baz:9092"] }
     end
-  end # describe #to_a
+  end
 
   describe "#==" do
     subject { default_brokers == other }
@@ -41,6 +33,5 @@ describe ROM::Kafka::Brokers do
 
       it { is_expected.to eql false }
     end
-  end # describe #==
-
-end # describe ROM::Kafka::Brokers
+  end
+end

data/spec/unit/connection/consumer_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 describe ROM::Kafka::Connection::Consumer do
 
   # ============================================================================
@@ -34,7 +32,7 @@ describe ROM::Kafka::Connection::Consumer do
     subject { consumer }
 
     it { is_expected.to be_kind_of Enumerable }
-  end # describe .new
+  end
 
   describe "#connection" do
     subject { consumer.connection }
@@ -46,7 +44,7 @@ describe ROM::Kafka::Connection::Consumer do
 
       expect(subject).to eql(connection)
     end
-  end # describe #connection
+  end
 
   describe "#fetch" do
     subject { consumer.fetch }
@@ -57,7 +55,7 @@ describe ROM::Kafka::Connection::Consumer do
       expect(connection).to receive(:fetch)
       expect(subject).to eql [tuple]
     end
-  end # describe #fetch
+  end
 
   describe "#each" do
 
@@ -85,6 +83,5 @@ describe ROM::Kafka::Connection::Consumer do
         expect(subject).to eq [tuple, tuple]
       end
     end
-  end # describe #each
-
-end # describe ROM::Kafka::Connection::Consumer
+  end
+end

data/spec/unit/connection/producer_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 describe ROM::Kafka::Connection::Producer do
 
   # ============================================================================
@@ -44,7 +42,7 @@ describe ROM::Kafka::Connection::Producer do
       expect(driver).to receive(:new).with(brokers, client, attributes)
       expect(subject).to eql(connection)
     end
-  end # describe #connection
+  end
 
   describe "#publish" do
     subject { producer.publish(*input) }
@@ -74,6 +72,5 @@ describe ROM::Kafka::Connection::Producer do
     it "returns the plain array of tuples" do
       expect(subject).to eql output
     end
-  end # describe #publish
-
-end # describe ROM::Kafka::Connection::Producer
+  end
+end

data/spec/unit/create_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 describe ROM::Kafka::Commands::Create do
 
   let(:command)  { described_class.new relation }
@@ -12,19 +10,19 @@ describe ROM::Kafka::Commands::Create do
     subject { described_class.adapter }
 
     it { is_expected.to eql(:kafka) }
-  end # describe .adapter
+  end
 
   describe ".new" do
     subject { command }
 
     it { is_expected.to be_kind_of ROM::Commands::Create }
-  end # describe .new
+  end
 
   describe "#key" do
     subject { command.key }
 
     it { is_expected.to be_nil }
-  end # describe #key
+  end
 
   describe "#with" do
     subject { command.with(key: "foo") }
@@ -40,7 +38,7 @@ describe ROM::Kafka::Commands::Create do
     it "updates the key" do
       expect(subject.key).to eql("foo")
     end
-  end # describe #using
+  end
 
   describe "#call" do
     subject { command.call(:bar, ["baz"]) }
@@ -74,6 +72,5 @@ describe ROM::Kafka::Commands::Create do
         expect(subject).to eql output
       end
     end
-  end # describe #call
-
-end # describe ROM::Kafka::Relation
+  end
+end

data/spec/unit/dataset_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 describe ROM::Kafka::Dataset do
 
   let(:gateway_class)  { ROM::Kafka::Gateway }
@@ -17,7 +15,7 @@ describe ROM::Kafka::Dataset do
     it "is initialized" do
       expect(subject).to eql gateway
     end
-  end # describe #gateway
+  end
 
   describe "#topic" do
     subject { dataset.topic }
@@ -25,7 +23,7 @@ describe ROM::Kafka::Dataset do
     it "is initialized" do
       expect(subject).to eql topic
     end
-  end # describe #topic
+  end
 
   describe "#attributes" do
     subject { dataset.attributes }
@@ -64,7 +62,7 @@ describe ROM::Kafka::Dataset do
         expect(subject).to eql attributes
       end
     end
-  end # describe #attributes
+  end
 
   describe "#producer" do
     subject { dataset.producer }
@@ -72,7 +70,7 @@ describe ROM::Kafka::Dataset do
     it "is taken from #gateway" do
       expect(subject).to eql gateway.producer
     end
-  end # describe #producer
+  end
 
   describe "#consumer" do
     subject { dataset.consumer }
@@ -102,7 +100,7 @@ describe ROM::Kafka::Dataset do
       expect(consumer_class).to receive(:new).with(options)
       expect(subject).to eql consumer
     end
-  end # describe #consumer
+  end
 
   describe "#using" do
     subject { dataset.using(update) }
@@ -125,7 +123,7 @@ describe ROM::Kafka::Dataset do
     it "updates attributes" do
       expect(subject.attributes).to eql(dataset.attributes.merge(update))
     end
-  end # describe #using
+  end
 
   describe "#each" do
     subject { dataset.to_a }
@@ -160,6 +158,5 @@ describe ROM::Kafka::Dataset do
 
       it { is_expected.to be_kind_of Enumerator }
     end
-  end # describe #each
-
-end # describe ROM::Kafka::Dataset
+  end
+end

data/spec/unit/gateway_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 describe ROM::Kafka::Gateway do
 
   let(:gateway) { described_class.new(client_id: :foo) }
@@ -18,7 +16,7 @@ describe ROM::Kafka::Gateway do
         expect { subject }.to raise_error ArgumentError
       end
     end
-  end # describe .new
+  end
 
   describe "#brokers" do
     subject { gateway.brokers }
@@ -48,7 +46,7 @@ describe ROM::Kafka::Gateway do
 
       it { is_expected.to eql brokers }
     end
-  end # describe #hosts
+  end
 
   describe "#attributes" do
     subject { gateway.attributes }
@@ -98,13 +96,13 @@ describe ROM::Kafka::Gateway do
 
       it { is_expected.to eql attributes }
     end
-  end # describe #attributes
+  end
 
   describe "#[]" do
     subject { gateway[:foo] }
 
     it { is_expected.to eql(nil) }
-  end # describe #[]
+  end
 
   describe "#dataset?" do
     before do
@@ -122,7 +120,7 @@ describe ROM::Kafka::Gateway do
 
       it { is_expected.to eql false }
     end
-  end # describe #dataset
+  end
 
   describe "#dataset" do
     subject { gateway.dataset topic }
@@ -149,7 +147,7 @@ describe ROM::Kafka::Gateway do
     it "returns a dataset" do
       expect(subject).to eql(dataset)
     end
-  end # describe #dataset
+  end
 
   describe "#producer" do
     subject { gateway.producer }
@@ -166,6 +164,5 @@ describe ROM::Kafka::Gateway do
       expect(subject).to eql producer
       expect(attributes).to eql gateway.attributes
     end
-  end # describe #producer
-
-end # describe ROM::Kafka::Gateway
+  end
+end

data/spec/unit/relation_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 describe ROM::Kafka::Relation do
 
   let(:relation) { described_class.new dataset }
@@ -10,7 +8,7 @@ describe ROM::Kafka::Relation do
     subject { described_class.adapter }
 
     it { is_expected.to eql(:kafka) }
-  end # describe .adapter
+  end
 
   describe ".topic" do
     subject { described_class.topic :foo }
@@ -21,19 +19,19 @@ describe ROM::Kafka::Relation do
       expect(described_class).to receive(:dataset).with(:foo)
       subject
     end
-  end # describe .topic
+  end
 
   describe ".new" do
     subject { relation }
 
     it { is_expected.to be_kind_of ROM::Relation }
-  end # describe .new
+  end
 
   describe "#dataset" do
     subject { relation.dataset }
 
     it { is_expected.to eql(dataset) }
-  end # describe #dataset
+  end
 
   describe "#using" do
     subject { relation.using(options) }
@@ -48,7 +46,7 @@ describe ROM::Kafka::Relation do
       expect(dataset).to receive(:using).with(options)
       expect(subject.dataset).to eql(updated)
     end
-  end # describe #using
+  end
 
   describe "#offset" do
     subject { relation.offset(value) }
@@ -63,7 +61,7 @@ describe ROM::Kafka::Relation do
       expect(dataset).to receive(:using).with(offset: value)
       expect(subject.dataset).to eql(updated)
     end
-  end # describe #offset
+  end
 
   describe "#limit" do
     subject { relation.limit(value) }
@@ -78,7 +76,7 @@ describe ROM::Kafka::Relation do
       expect(dataset).to receive(:using).with(limit: value)
       expect(subject.dataset).to eql(updated)
     end
-  end # describe #limit
+  end
 
   describe "#from" do
     subject { relation.from(3) }
@@ -91,6 +89,5 @@ describe ROM::Kafka::Relation do
       expect(dataset).to receive(:using).with(partition: 3)
       expect(subject.dataset).to eql(updated)
     end
-  end # describe #where
-
-end # describe ROM::Kafka::Relation
+  end
+end

metadata

@@ -1,121 +1,109 @@
 --- !ruby/object:Gem::Specification
 name: rom-kafka
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Andrew Kozin
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-09-16 00:00:00.000000000 Z
+date: 2016-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rom
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.9.1
-  type: :runtime
+        version: '1.0'
+  name: rom
   prerelease: false
+  type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0.9'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.1
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: poseidon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.0.5
-  type: :runtime
+  name: poseidon
   prerelease: false
+  type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.0.5
 - !ruby/object:Gem::Dependency
-  name: attributes_dsl
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
+        version: 0.1.0
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.0.2
-  type: :runtime
+        version: 0.1.1
+  name: attributes_dsl
   prerelease: false
+  type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
+        version: 0.1.0
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.0.2
+        version: 0.1.1
 - !ruby/object:Gem::Dependency
-  name: hexx-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.5'
-  type: :development
+  name: hexx-rspec
   prerelease: false
+  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.5'
 - !ruby/object:Gem::Dependency
-  name: inflecto
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.0'
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.0.2
-  type: :development
+  name: inflecto
   prerelease: false
+  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.0'
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.0.2
 - !ruby/object:Gem::Dependency
-  name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
-  type: :development
+  name: timecop
   prerelease: false
+  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
 description: Kafka support for Ruby Object Mapper
@@ -126,14 +114,15 @@ extensions: []
 extra_rdoc_files:
 - README.md
 - LICENSE
+- CHANGELOG.md
 files:
-- ".coveralls.yml"
-- ".gitignore"
-- ".metrics"
-- ".rspec"
-- ".rubocop.yml"
-- ".travis.yml"
-- ".yardopts"
+- .coveralls.yml
+- .gitignore
+- .metrics
+- .rspec
+- .rubocop.yml
+- .travis.yml
+- .yardopts
 - CHANGELOG.md
 - Gemfile
 - Guardfile
@@ -162,7 +151,6 @@ files:
 - lib/rom/kafka/dataset.rb
 - lib/rom/kafka/gateway.rb
 - lib/rom/kafka/relation.rb
-- lib/rom/kafka/version.rb
 - rom-kafka.gemspec
 - spec/integration/basic_usage_spec.rb
 - spec/integration/keys_usage_spec.rb
@@ -180,27 +168,24 @@ homepage: https://rom-rb.org
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
-    - !ruby/object:Gem::Version
-      version: '1.9'
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.8
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.4.5
+signing_key:
 specification_version: 4
 summary: Kafka support for Ruby Object Mapper
 test_files:
@@ -216,4 +201,3 @@ test_files:
 - spec/unit/dataset_spec.rb
 - spec/unit/gateway_spec.rb
 - spec/unit/relation_spec.rb
-has_rdoc: 

data/lib/rom/kafka/version.rb

@@ -1,13 +0,0 @@
-# encoding: utf-8
-
-module ROM
-
-  module Kafka
-
-    # The semantic version of the module.
-    # @see http://semver.org/ Semantic versioning 2.0
-    VERSION = "0.0.1".freeze
-
-  end # module Kafka
-
-end # module ROM