rollout 2.2.4 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3784af8ad4c004b68a7a82919b817aa8bbc7d2be
-  data.tar.gz: 576389f114e7a59c035dd1a32e5de72d696a1bc9
+  metadata.gz: f64f1c9012cf7fed3496317cec7542d606c1b7b7
+  data.tar.gz: af8ead4306e97cd5038a16cc88b495e4dc68c9ca
 SHA512:
-  metadata.gz: 48f5979f7396375cbdd583bf90bb50137169ef0796f1298e25ef65577ab6b5cdeaaa657f7ec9fabf6b2a40deb036efe43a154f50a3147b2b554f16b16a5f45b6
-  data.tar.gz: a379d25c430a815a84e17e406f587560c6ec67c0832e8458523bdde5bb477383a6380779f25f42506a8f26c4872aed62eb210d9773807694c8406019f054cf5b
+  metadata.gz: 6972dfe9065234da74ed4f260a8d73ca837828b83793fc7b12ea8327c45fc463af2ab89782ec79a0f8988a0fbcc7af7291e3c829452c8d373a27f72494ba7db7
+  data.tar.gz: e82e2f6c194edd80142e88b54419c4d466910438a3b92ee243e2edbd71ea546178b72fedc34749c9ca114851e862221f2009f23e8adedd2fa65213736fbda5b6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rollout (2.2.4)
+    rollout (2.3.0)
 
 GEM
   remote: https://rubygems.org/
@@ -45,4 +45,4 @@ DEPENDENCIES
   rspec
 
 BUNDLED WITH
-   1.10.6
+   1.12.5

data/lib/rollout.rb

@@ -13,7 +13,7 @@ class Rollout
 
       if string
         raw_percentage,raw_users,raw_groups = string.split("|")
-        @percentage = raw_percentage.to_i
+        @percentage = raw_percentage.to_f
         @users = (raw_users || "").split(",").map(&:to_s).to_set
         @groups = (raw_groups || "").split(",").map(&:to_sym).to_set
       else
@@ -85,7 +85,7 @@ class Rollout
       end
 
       def user_in_percentage?(user)
-        Zlib.crc32(user_id_for_percentage(user)) % 100 < @percentage
+        Zlib.crc32(user_id_for_percentage(user)) % 100_000 < @percentage * 1_000
       end
 
       def user_id_for_percentage(user)

data/lib/rollout/version.rb

@@ -1,3 +1,3 @@
 class Rollout
-  VERSION = "2.2.4"
+  VERSION = "2.3.0"
 end

data/spec/rollout_spec.rb

@@ -227,7 +227,7 @@ RSpec.describe "Rollout" do
     end
 
     it "activates the feature for that percentage of the users" do
-      expect((1..120).select { |id| @rollout.active?(:chat, double(id: id)) }.length).to be_within(1).of(20)
+      expect((1..100).select { |id| @rollout.active?(:chat, double(id: id)) }.length).to be_within(2).of(20)
     end
   end
 
@@ -237,7 +237,7 @@ RSpec.describe "Rollout" do
     end
 
     it "activates the feature for that percentage of the users" do
-      expect((1..200).select { |id| @rollout.active?(:chat, double(id: id)) }.length).to be_within(5).of(40)
+      expect((1..200).select { |id| @rollout.active?(:chat, double(id: id)) }.length).to be_within(4).of(40)
     end
   end
 
@@ -251,6 +251,16 @@ RSpec.describe "Rollout" do
     end
   end
 
+  describe "activating a feature for a percentage of users" do
+    before do
+      @rollout.activate_percentage(:chat, 0.1)
+    end
+
+    it "activates the feature for that percentage of the users" do
+      expect((1..10_000).to_set.select { |id| @rollout.active?(:chat, double(id: id)) }.length).to be_within(2).of(10)
+    end
+  end
+
   describe "activating a feature for a percentage of users" do
     before do
       @rollout.activate_percentage(:chat, 20)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollout
 version: !ruby/object:Gem::Version
-  version: 2.2.4
+  version: 2.3.0
 platform: ruby
 authors:
 - James Golick
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-14 00:00:00.000000000 Z
+date: 2016-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec