rollbar 2.19.1 → 2.19.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1d54624ee13b6f4c7a4968c1c9067e516c66df6
-  data.tar.gz: 38c693e582396f395edf19b2de6632f0a2d6e2a1
+  metadata.gz: 903833e1801aaeef919e56c575720bd7c4ae6498
+  data.tar.gz: 2c7ee9fe31c1163a36da244d74390f9465515348
 SHA512:
-  metadata.gz: 0edbc15fcb61dabaccdd2cfd6ba523e467df93a65c140324b54cd4374ba58d89346f83a5c176b8447eed1039f112b7c429434fe4f0722cf70b17b1392431dbe3
-  data.tar.gz: ffd8f7ff56381063666b9889656790c310b00dc5de74d2c10e9be12a47183da27efe66a90a87747fa12f78bceab90e581442a5cfadbb84acb0c58f2c497d7940
+  metadata.gz: 56d9ca0996cee011a87113a6a9271067286492c8c36537da01b93049784b072256982ba77efeb88938e2464f3e9771e6af1da5926e2dba02cf8cb07de4fe4628
+  data.tar.gz: a4c0e26eb7def5137bc2737d0a837cab42677f24cc7983055ecd8586754222834e6095ee5a859c55443cdfb43c0c33e4ab6f98dfdb31adc20064d6fb25bf6b3f

data/lib/rollbar/capistrano3.rb

@@ -10,21 +10,21 @@ namespace :rollbar do
   desc 'Send deployment started notification to Rollbar.'
   task :deploy_started do
     on primary fetch(:rollbar_role) do
-      ::Rollbar::CapistranoTasks.deploy_started(self, self, dry_run?)
+      ::Rollbar::CapistranoTasks.deploy_started(self, self, false)
     end
   end
 
   desc 'Send deployment succeeded notification to Rollbar.'
   task :deploy_succeeded do
     on primary fetch(:rollbar_role) do
-      ::Rollbar::CapistranoTasks.deploy_succeeded(self, self, dry_run?)
+      ::Rollbar::CapistranoTasks.deploy_succeeded(self, self, false)
     end
   end
 
   desc 'Send deployment failed notification to Rollbar.'
   task :deploy_failed do
     on primary fetch(:rollbar_role) do
-      ::Rollbar::CapistranoTasks.deploy_failed(self, self, dry_run?)
+      ::Rollbar::CapistranoTasks.deploy_failed(self, self, false)
     end
   end
 

data/lib/rollbar/capistrano_tasks.rb

@@ -10,12 +10,12 @@ module Rollbar
         deploy_task(logger, :desc => 'Notifying Rollbar of deployment start') do
           result = report_deploy_started(capistrano, dry_run)
 
-          info_request_response(logger, result)
+          debug_request_response(logger, result)
 
           capistrano.set(:rollbar_deploy_id, 123) if dry_run
 
           skip_in_dry_run(logger, dry_run) do
-            if (deploy_id = result[:data][:deploy_id])
+            if (deploy_id = result[:data] && result[:data][:deploy_id])
               capistrano.set :rollbar_deploy_id, deploy_id
             else
               logger.error 'Unable to report deploy to Rollbar'
@@ -49,7 +49,7 @@ module Rollbar
           depend_on_deploy_id(capistrano, logger) do
             result = yield
 
-            info_request_response(logger, result)
+            debug_request_response(logger, result)
 
             skip_in_dry_run(logger, dry_run) do
               if result[:response].is_a?(Net::HTTPSuccess)
@@ -122,9 +122,10 @@ module Rollbar
         end
       end
 
-      def info_request_response(logger, result)
-        logger.info result[:request_info]
-        logger.info result[:response_info] if result[:response_info]
+      def debug_request_response(logger, result)
+        # NOTE: in Capistrano debug messages go to log/capistrano.log but not to stdout even if log_level == :debug
+        logger.debug result[:request_info]
+        logger.debug result[:response_info] if result[:response_info]
       end
     end
   end

data/lib/rollbar/configuration.rb

@@ -8,6 +8,7 @@ module Rollbar
     attr_accessor :async_handler
     attr_accessor :branch
     attr_reader :before_process
+    attr_accessor :capture_uncaught
     attr_accessor :code_version
     attr_accessor :custom_data_method
     attr_accessor :delayed_job_enabled
@@ -72,6 +73,7 @@ module Rollbar
     def initialize
       @async_handler = nil
       @before_process = []
+      @capture_uncaught = nil
       @code_version = nil
       @custom_data_method = nil
       @default_logger = lambda { ::Logger.new(STDERR) }

data/lib/rollbar/deploy.rb

@@ -6,6 +6,8 @@ module Rollbar
     ENDPOINT = 'https://api.rollbar.com/api/1/deploy/'.freeze
 
     def self.report(opts = {}, access_token:, environment:, revision:)
+      return {} unless access_token && !access_token.empty?
+
       opts[:status] ||= :started
 
       uri = URI.parse(::Rollbar::Deploy::ENDPOINT)
@@ -21,6 +23,8 @@ module Rollbar
     end
 
     def self.update(opts = {}, deploy_id:, access_token:, status:)
+      return {} unless access_token && !access_token.empty?
+
       uri = URI.parse(
         ::Rollbar::Deploy::ENDPOINT +
         deploy_id.to_s +

data/lib/rollbar/exception_reporter.rb

@@ -1,10 +1,11 @@
 module Rollbar
-  module ExceptionReporter
+  module ExceptionReporter # :nodoc:
     def report_exception_to_rollbar(env, exception)
-      exception_message = exception.respond_to?(:message) ? exception.message : 'No Exception Message'
-      Rollbar.log_debug "[Rollbar] Reporting exception: #{exception_message}"
+      return unless capture_uncaught?
+
+      log_exception_message(exception)
 
-      exception_data = Rollbar.log(Rollbar.configuration.uncaught_exception_level, exception, :use_exception_level_filters => true)
+      exception_data = exception_data(exception)
 
       if exception_data.is_a?(Hash)
         env['rollbar.exception_uuid'] = exception_data[:uuid]
@@ -14,8 +15,21 @@ module Rollbar
       elsif exception_data == 'ignored'
         Rollbar.log_debug '[Rollbar] Exception not reported because it was ignored'
       end
-    rescue => e
+    rescue StandardError => e
       Rollbar.log_warning "[Rollbar] Exception while reporting exception to Rollbar: #{e.message}"
     end
+
+    def capture_uncaught?
+      Rollbar.configuration.capture_uncaught != false
+    end
+
+    def log_exception_message(exception)
+      exception_message = exception.respond_to?(:message) ? exception.message : 'No Exception Message'
+      Rollbar.log_debug "[Rollbar] Reporting exception: #{exception_message}"
+    end
+
+    def exception_data(exception)
+      Rollbar.log(Rollbar.configuration.uncaught_exception_level, exception, :use_exception_level_filters => true)
+    end
   end
 end

data/lib/rollbar/item.rb

@@ -12,6 +12,7 @@ require 'rollbar/util'
 require 'rollbar/encoding'
 require 'rollbar/truncation'
 require 'rollbar/json'
+require 'rollbar/scrubbers/params'
 
 module Rollbar
   # This class represents the payload to be sent to the API.

data/lib/rollbar/notifier.rb

@@ -126,7 +126,7 @@ module Rollbar
     #   Rollbar.log(e, 'This is a description of the exception')
     #
     def log(level, *args)
-      return 'disabled' unless configuration.enabled
+      return 'disabled' unless enabled?
 
       message, exception, extra, context = extract_arguments(args)
       use_exception_level_filters = use_exception_level_filters?(extra)
@@ -185,6 +185,11 @@ module Rollbar
       log('critical', *args)
     end
 
+    def enabled?
+      # Require access_token so we don't try to send events when unconfigured.
+      configuration.enabled && configuration.access_token && !configuration.access_token.empty?
+    end
+
     def process_item(item)
       if configuration.write_to_file
         if configuration.use_async

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = '2.19.1'
+  VERSION = '2.19.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.19.1
+  version: 2.19.2
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-24 00:00:00.000000000 Z
+date: 2019-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json