rollbar 2.13.1 → 2.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4a27c812bcbc48208ec5968eaae3a20ef863b43a
-  data.tar.gz: f6d8171c122522d4f9f44caf1971fb0fa7e1fd94
+  metadata.gz: 8800f7b1709a4ea49c5bb9e3e34f700969f565ec
+  data.tar.gz: 5d30db66f500e836d98758c3583647c0be60c5d8
 SHA512:
-  metadata.gz: ed6a83b65c5a09f55c5605c94adcc18d015bb9691f1ca608c5bb2c0d869ae2ac1f720b12fcb4c50df26fd8c316757c9f5914574ca98dd724f70e6ca30fddfdc0
-  data.tar.gz: 776e79159576228d00a385c4650499da8e7ae7e5bda62e342f27eb94ec7f7b651335b9a477a29db0cda2634f456c35eb828fb81ea1ef5d1ed411bbb58cf77ecb
+  metadata.gz: f63851372ea962c2d438321bbeb19b9caab293ef9c0146a6a672eef6ba9a12c74d67a08679743edc5703a4edffb0bd97b0439e29bc0e9ca7a684f4ed1a08a25d
+  data.tar.gz: 0a8ec4b9c0b849ab53b040668d74cd7f527b5e4594076031e0ccbdbdca0c257307a8bab62d39bbeadadf0f8385d3a07c77cf3250e73d3734b44f4b377a6e096f

data/CHANGELOG.md

@@ -4,6 +4,17 @@
 
 Fixes:
 
+- Fix URL scrubbing with spaces in the query. See [#532](https://github.com/rollbar/rollbar-gem/pull/532).
+- Use :use_exception_level_filters in ActiveJob plugin. See [#533](https://github.com/rollbar/rollbar-gem/pull/533).
+
+Other:
+
+- Add docs for custom scrubbing with transform hook. See [#526](https://github.com/rollbar/rollbar-gem/pull/526).
+
+## 2.13.1
+
+Fixes:
+
 - Inherit test controller from ActionController::Base
 - Fix test rake task when Rack::MockRequest is not defined
 - Fix docs for Sinatra middleware

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.13.1)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.13.2)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 [Rollbar](https://rollbar.com) is an error tracking service for Ruby and other languages. The Rollbar service will alert you of problems with your code and help you understand them in a ways never possible before. We love it and we hope you will too.
@@ -484,6 +484,20 @@ If you want to obfuscate the user IP reported to the Rollbar API you can configu
 Rollbar.configuration.user_ip_obfuscator_secret = "a-private-secret-here"
 ```
 
+The fields in `scrub_fields` will be used to scrub the values for the matching keys in the GET, POST, raw body and route params and also in cookies and session. If you want to customize better exactly which part of the request data is scrubbed you can use the [Transform hook](#transform-hook).
+
+Example:
+
+```
+config.transform << proc do |options|
+  data = options[:payload]['data']
+  data[:request][:session][:key] = Rollbar::Scrubbers.scrub_value(data[:request][:session][:key])
+end
+```
+
+In the previous example we are scrubbing the `key` value inside the session data.
+
+
 ## Including additional runtime data
 
 You can provide a callable that will be called for each exception or message report.  ```custom_data_method``` should be a lambda that takes no arguments and returns a hash.

data/lib/rollbar/plugins/active_job.rb

@@ -3,7 +3,10 @@ module Rollbar
   module ActiveJob
     def self.included(base)
       base.send :rescue_from, Exception do |exception|
-        Rollbar.error(exception, :job => self.class.name, :job_id => job_id)
+        Rollbar.error(exception,
+                      :job => self.class.name,
+                      :job_id => job_id,
+                      :use_exception_level_filters => true)
         raise exception
       end
     end

data/lib/rollbar/scrubbers/url.rb

@@ -60,7 +60,7 @@ module Rollbar
         encoded_query = encode_www_form(filter_query_params(params, regex, randomize_scrub_length))
 
         # We want this to rebuild array params like foo[]=1&foo[]=2
-        CGI.unescape(encoded_query)
+        URI.escape(CGI.unescape(encoded_query))
       end
 
       def decode_www_form(query)

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = '2.13.1'.freeze
+  VERSION = '2.13.2'
 end

data/spec/rollbar/plugins/active_job_spec.rb

@@ -23,7 +23,11 @@ describe Rollbar::ActiveJob do
   let(:job_id) { "123" }
 
   it "reports the error to Rollbar" do
-    expected_params = { :job => "TestJob", :job_id => job_id }
+    expected_params = {
+      :job => "TestJob",
+      :job_id => job_id,
+      :use_exception_level_filters => true
+    }
     expect(Rollbar).to receive(:error).with(exception, expected_params)
     TestJob.new.perform(exception, job_id) rescue nil
   end

data/spec/rollbar/scrubbers/url_spec.rb

@@ -111,6 +111,26 @@ describe Rollbar::Scrubbers::URL do
           expect(subject.call(options)).to be_eql(url)
         end
       end
+
+      context 'with URL with spaces and arrays' do
+        let(:url) do
+          'https://server.com/api/v1/assignments/4430038?user_id=1&assignable_id=2&starts_at=Wed%20Jul%2013%202016%2000%3A00%3A00%20GMT-0700%20(PDT)&ends_at=Fri%20Jul%2029%202016%2000%3A00%3A00%20GMT-0700%20(PDT)&allocation_mode=hours_per_day&percent=&fixed_hours=&hours_per_day=0&auth=REMOVED&___uidh=2228207862&password[]=mypassword'
+        end
+        let(:options) do
+          {
+            :url => url,
+            :scrub_fields => [:passwd, :password, :password_confirmation, :secret, :confirm_password, :secret_token, :api_key, :access_token, :auth, :SAMLResponse, :password, :auth],
+            :scrub_user => true,
+            :scrub_password => true,
+            :randomize_scrub_length => true
+          }
+        end
+
+        it 'doesnt logs error' do
+          expect(Rollbar.logger).not_to receive(:error).and_call_original
+          subject.call(options)
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.13.1
+  version: 2.13.2
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-21 00:00:00.000000000 Z
+date: 2016-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -276,7 +276,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.3.0
 signing_key: 
 specification_version: 4
 summary: Reports exceptions to Rollbar