rollbar 2.13.0 → 2.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d7a60c8f3a1929550de7236c1f2cad3f06d686ef
-  data.tar.gz: 7c91ff957d85efa7387384948174d1ea6f745b00
+  metadata.gz: 4a27c812bcbc48208ec5968eaae3a20ef863b43a
+  data.tar.gz: f6d8171c122522d4f9f44caf1971fb0fa7e1fd94
 SHA512:
-  metadata.gz: a53c437380edf552740dec8ece8c8bf90f774b5c1ba420ac8526f8a11eaf8bd502ec6798f70da4ce056cbadae215ebef4629cd75e81742164cc78838fc89a0ba
-  data.tar.gz: f5bda5da6010fa1a5d6d4d1571c5973e78d42fba2523731be1f5c38295cf808c7f2e9bfdb9035da143963fdb65dc8c586b739e91b4200a2a70f4f7fbafc5eea9
+  metadata.gz: ed6a83b65c5a09f55c5605c94adcc18d015bb9691f1ca608c5bb2c0d869ae2ac1f720b12fcb4c50df26fd8c316757c9f5914574ca98dd724f70e6ca30fddfdc0
+  data.tar.gz: 776e79159576228d00a385c4650499da8e7ae7e5bda62e342f27eb94ec7f7b651335b9a477a29db0cda2634f456c35eb828fb81ea1ef5d1ed411bbb58cf77ecb

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Change Log
 
+## 2.13.1
+
+Fixes:
+
+- Inherit test controller from ActionController::Base
+- Fix test rake task when Rack::MockRequest is not defined
+- Fix docs for Sinatra middleware
+- Fix few basic rubocop offenses
+
 ## 2.13.0
 
 Features:

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.13.0)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.13.1)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 [Rollbar](https://rollbar.com) is an error tracking service for Ruby and other languages. The Rollbar service will alert you of problems with your code and help you understand them in a ways never possible before. We love it and we hope you will too.
@@ -153,6 +153,8 @@ end
 Then mount the middleware in your app, like:
 
 ```ruby
+require 'rollbar/middleware/sinatra'
+
 class MyApp < Sinatra::Base
   use Rollbar::Middleware::Sinatra
   # other middleware/etc

data/lib/rollbar/notifier.rb

@@ -11,6 +11,8 @@ require 'rollbar/logger_proxy'
 require 'rollbar/item'
 
 module Rollbar
+  # The notifier class. It has the core functionality
+  # for sending reports to the API.
   class Notifier
     attr_accessor :configuration
     attr_accessor :last_report
@@ -140,7 +142,7 @@ module Rollbar
 
       begin
         report(level, message, exception, extra)
-      rescue Exception => e
+      rescue StandardError, SystemStackError => e
         report_internal_error(e)
 
         'error'
@@ -180,9 +182,9 @@ module Rollbar
     def process_item(item)
       if configuration.write_to_file
         if configuration.use_async
-          @file_semaphore.synchronize {
+          @file_semaphore.synchronize do
             write_item(item)
-          }
+          end
         else
           write_item(item)
         end
@@ -383,26 +385,26 @@ module Rollbar
     # Rollbar project. We'll first attempt to provide a report including the exception traceback.
     # If that fails, we'll fall back to a more static failsafe response.
     def report_internal_error(exception)
-      log_error "[Rollbar] Reporting internal error encountered while sending data to Rollbar."
+      log_error '[Rollbar] Reporting internal error encountered while sending data to Rollbar.'
 
       begin
-        item = build_item('error', nil, exception, {:internal => true})
+        item = build_item('error', nil, exception, :internal => true)
       rescue => e
-        send_failsafe("build_item in exception_data", e)
+        send_failsafe('build_item in exception_data', e)
         return
       end
 
       begin
         process_item(item)
       rescue => e
-        send_failsafe("error in process_item", e)
+        send_failsafe('error in process_item', e)
         return
       end
 
       begin
         log_instance_link(item['data'])
       rescue => e
-        send_failsafe("error logging instance link", e)
+        send_failsafe('error logging instance link', e)
         return
       end
     end
@@ -475,7 +477,7 @@ module Rollbar
       if uri.scheme == 'https'
         http.use_ssl = true
         # This is needed to have 1.8.7 passing tests
-        http.ca_file = ENV['ROLLBAR_SSL_CERT_FILE'] if ENV.has_key?('ROLLBAR_SSL_CERT_FILE')
+        http.ca_file = ENV['ROLLBAR_SSL_CERT_FILE'] if ENV.key?('ROLLBAR_SSL_CERT_FILE')
         http.verify_mode = ssl_verify_mode
       end
 
@@ -526,9 +528,9 @@ module Rollbar
 
     def write_item(item)
       if configuration.use_async
-        @file_semaphore.synchronize {
+        @file_semaphore.synchronize do
           do_write_item(item)
-        }
+        end
       else
         do_write_item(item)
       end
@@ -541,13 +543,12 @@ module Rollbar
       return unless body
 
       begin
-        unless @file
-          @file = File.open(configuration.filepath, "a")
-        end
+        @file ||= File.open(configuration.filepath, 'a')
 
         @file.puts(body)
         @file.flush
-        log_info "[Rollbar] Success"
+
+        log_info '[Rollbar] Success'
       rescue IOError => e
         log_error "[Rollbar] Error opening/writing to file: #{e}"
       end
@@ -563,16 +564,18 @@ module Rollbar
 
           exception_info = exception.class.name
           # #to_s and #message defaults to class.to_s. Add message only if add valuable info.
-          exception_info += %Q{: "#{exception.message}"} if exception.message != exception.class.to_s
+          exception_info += %(: "#{exception.message}") if exception.message != exception.class.to_s
           exception_info += " in #{nearest_frame}" if nearest_frame
 
           body += "#{exception_info}: #{message}"
         rescue
+          log_error('[Rollbar] Error building failsafe exception message')
         end
       else
         begin
           body += message.to_s
         rescue
+          log_error('[Rollbar] Error building failsafe message')
         end
       end
 
@@ -604,7 +607,7 @@ module Rollbar
     def process_async_item(item)
       configuration.async_handler ||= default_async_handler
       configuration.async_handler.call(item.payload)
-    rescue => e
+    rescue
       if configuration.failover_handlers.empty?
         log_error '[Rollbar] Async handler failed, and there are no failover handlers configured. See the docs for "failover_handlers"'
         return

data/lib/rollbar/rake_tasks.rb

@@ -1,5 +1,8 @@
 require 'rollbar'
-require 'rack/mock'
+begin
+  require 'rack/mock'
+rescue LoadError
+end
 require 'logger'
 
 namespace :rollbar do
@@ -39,60 +42,52 @@ namespace :rollbar do
       end
     end
 
-    if defined?(Rails)
-      begin
-        require './app/controllers/application_controller'
-      rescue LoadError
-      end
-
-      unless defined?(ApplicationController)
-        puts 'No ApplicationController found, using ActionController::Base instead'
-        class ApplicationController < ActionController::Base; end
-      end
+    if defined?(Rack::MockRequest)
+      if defined?(Rails)
+        puts 'Setting up the controller.'
 
-      puts 'Setting up the controller.'
+        class RollbarTestController < ActionController::Base
+          include RollbarTest
 
-      class RollbarTestController < ApplicationController
-        include RollbarTest
+          def verify
+            test_rollbar
+          end
 
-        def verify
-          test_rollbar
+          def logger
+            nil
+          end
         end
 
-        def logger
-          nil
+        Rails.application.routes_reloader.execute_if_updated
+        Rails.application.routes.draw do
+          get 'verify' => 'rollbar_test#verify', :as => 'verify'
         end
-      end
 
-      Rails.application.routes_reloader.execute_if_updated
-      Rails.application.routes.draw do
-        get 'verify' => 'rollbar_test#verify', :as => 'verify'
-      end
-
-      # from http://stackoverflow.com/questions/5270835/authlogic-activation-problems
-      if defined? Authlogic
-        Authlogic::Session::Base.controller = Authlogic::ControllerAdapters::RailsAdapter.new(self)
-      end
+        # from http://stackoverflow.com/questions/5270835/authlogic-activation-problems
+        if defined? Authlogic
+          Authlogic::Session::Base.controller = Authlogic::ControllerAdapters::RailsAdapter.new(self)
+        end
 
-      protocol = (defined? Rails.application.config.force_ssl && Rails.application.config.force_ssl) ? 'https' : 'http'
-      app = Rails.application
-    else
-      protocol = 'http'
-      app = Class.new do
-        include RollbarTest
+        protocol = (defined? Rails.application.config.force_ssl && Rails.application.config.force_ssl) ? 'https' : 'http'
+        app = Rails.application
+      else
+        protocol = 'http'
+        app = Class.new do
+          include RollbarTest
 
-        def self.call(_env)
-          new.test_rollbar
+          def self.call(_env)
+            new.test_rollbar
+          end
         end
       end
-    end
 
-    puts 'Processing...'
-    env = Rack::MockRequest.env_for("#{protocol}://www.example.com/verify")
-    status, = app.call(env)
+      puts 'Processing...'
+      env = Rack::MockRequest.env_for("#{protocol}://www.example.com/verify")
+      status, = app.call(env)
 
-    unless status.to_i == 500
-      puts 'Test failed! You may have a configuration issue, or you could be using a gem that\'s blocking the test. Contact support@rollbar.com if you need help troubleshooting.'
+      unless status.to_i == 500
+        puts 'Test failed! You may have a configuration issue, or you could be using a gem that\'s blocking the test. Contact support@rollbar.com if you need help troubleshooting.'
+      end
     end
   end
 end

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = '2.13.0'.freeze
+  VERSION = '2.13.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.13.0
+  version: 2.13.1
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-15 00:00:00.000000000 Z
+date: 2016-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json