rollbar 0.12.19 → 0.12.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9c34abc097642e5062e12ace61155d9381834ac1
-  data.tar.gz: e0695d97edf52dfedc5dd44d8b15c38c69b6ed59
+  metadata.gz: a174b1d884a3719e380c721e3f31176157b55895
+  data.tar.gz: 8a848c8705970c1ff53a45f763a89068b3f6f6c9
 SHA512:
-  metadata.gz: b577a5b47d117c01698fcc7779352c001e3ecd18aa5eebf56cb79d9003f9c48e598d52d606769b16494777eea497ab01146e4bd35a0a702bf842be0bc6ddca8a
-  data.tar.gz: 07c9afdd236c9d9f2655678c76a2b955cc3b21aa9162cf10370b621ab1300a0f8d07f7da5f395be7c624d564a1d27be34a67afef7aed46ad831e339366a552de
+  metadata.gz: 4f00108d55e33e68bc513f6f7493b7707a3b87e8d4bbdeeb2190172829e091f410acd5bac8533232b6297311a98639e5c60ed58bc7076cafb23738fef74104f7
+  data.tar.gz: 59414c7223324364962285a981007b5a0934ea3aef2c3d68b435a7aacfc56d8d416ec05a55bbd096f031b80e0ffdd14c7564f60f653de4e85ab7f9e5552dc6c1

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+**0.12.20**
+- Fix asynchronous reports with sidekiq version < 2.3.2
+- Support for specifying multiple project_gems with regex [#114](https://github.com/rollbar/rollbar-gem/pull/114)
+
 **0.12.19**
 - Fix rake test task in production
 - Report an additional simple error message in the rake test task

data/lib/rollbar/configuration.rb

@@ -104,14 +104,11 @@ module Rollbar
       @project_gem_paths = []
 
       gems.each { |name|
-        begin
-          spec = Gem::Specification.find_by_name(name.to_s)
-          gem_root = spec.gem_dir
-
-          @project_gem_paths.push gem_root
-        rescue Gem::LoadError
-          puts "[Rollbar] #{name} gem not found"
-        end
+        Gem::Specification.find_all_by_name(name).tap{ |results|
+          puts "[Rollbar] No gems found matching #{name.inspect}" if results.empty?
+        }.each{ |gem|
+          @project_gem_paths.push gem.gem_dir
+        }
       }
     end
 

data/lib/rollbar/delay/sidekiq.rb

@@ -3,7 +3,7 @@ require 'sidekiq'
 module Rollbar
   module Delay
     class Sidekiq
-      OPTIONS = { 'queue' => 'rollbar', 'class' => self.name }.freeze
+      OPTIONS = { 'queue' => 'rollbar', 'class' => Rollbar::Delay::Sidekiq }.freeze
 
       def initialize(*args)
         @options = (opts = args.shift) ? OPTIONS.merge(opts) : OPTIONS

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "0.12.19" 
+  VERSION = "0.12.20"
 end

data/spec/rollbar_spec.rb

@@ -145,14 +145,14 @@ describe Rollbar do
       }
       Rollbar.report_exception(@exception, {}, person_data)
     end
-    
+
     it 'should not ignore non-ignored persons' do
       Rollbar.configure do |config|
         config.ignored_person_ids += [1]
       end
-      
+
       Rollbar.last_report = nil
-      
+
       person_data = {
         :id => 1,
         :username => "test",
@@ -160,7 +160,7 @@ describe Rollbar do
       }
       Rollbar.report_exception(@exception, {}, person_data)
       Rollbar.last_report.should be_nil
-      
+
       person_data = {
         :id => 2,
         :username => "test2",
@@ -248,13 +248,13 @@ describe Rollbar do
       Rollbar.stub(:schedule_payload) do |*args|
         payload = MultiJson.load(args[0])
       end
-      
+
       Rollbar.report_exception(@exception)
-      
+
       payload["data"]["level"].should == 'error'
-      
+
       Rollbar.report_exception(@exception, nil, nil, 'debug')
-      
+
       payload["data"]["level"].should == 'debug'
     end
   end
@@ -324,7 +324,7 @@ describe Rollbar do
       end
     end
   end
-  
+
   context 'report_message_with_request' do
     before(:each) do
       configure
@@ -340,32 +340,32 @@ describe Rollbar do
       logger_mock.should_receive(:info).with('[Rollbar] Scheduling payload')
       logger_mock.should_receive(:info).with('[Rollbar] Success')
       Rollbar.report_message_with_request("Test message")
-      
+
       Rollbar.last_report[:request].should be_nil
       Rollbar.last_report[:person].should be_nil
     end
-    
+
     it 'should report messages with request, person data and extra data' do
       Rollbar.last_report = nil
-      
+
       logger_mock.should_receive(:info).with('[Rollbar] Scheduling payload')
       logger_mock.should_receive(:info).with('[Rollbar] Success')
-      
+
       request_data = {
         :params => {:foo => 'bar'}
       }
-      
+
       person_data = {
         :id => 123,
         :username => 'username'
       }
-      
+
       extra_data = {
         :extra_foo => 'extra_bar'
       }
-      
+
       Rollbar.report_message_with_request("Test message", 'info', request_data, person_data, extra_data)
-      
+
       Rollbar.last_report[:request].should == request_data
       Rollbar.last_report[:person].should == person_data
       Rollbar.last_report[:body][:message][:extra_foo].should == 'extra_bar'
@@ -658,35 +658,35 @@ describe Rollbar do
         config.logger = logger_mock
       end
     end
-    
+
     let(:logger_mock) { double("Rails.logger").as_null_object }
-    
+
     it 'should build valid json' do
       json = Rollbar.send(:build_payload, {:foo => {:bar => "baz"}})
       hash = MultiJson.load(json)
       hash["data"]["foo"]["bar"].should == "baz"
     end
-    
+
     it 'should truncate large strings if the payload is too big' do
       json = Rollbar.send(:build_payload, {:foo => {:bar => "baz"}, :large => 'a' * (128 * 1024), :small => 'b' * 1024})
       hash = MultiJson.load(json)
       hash["data"]["large"].should == '%s...' % ('a' * 1021)
       hash["data"]["small"].should == 'b' * 1024
     end
-    
+
     it 'should send a failsafe message if the payload cannot be reduced enough' do
       logger_mock.should_receive(:error).with(/Sending failsafe response due to Could not send payload due to it being too large after truncating attempts/)
       logger_mock.should_receive(:info).with('[Rollbar] Success')
-      
+
       orig_max = Rollbar::MAX_PAYLOAD_SIZE
-      
+
       Rollbar::MAX_PAYLOAD_SIZE = 1
       Rollbar.report_exception(@exception)
-      
+
       Rollbar::MAX_PAYLOAD_SIZE = orig_max
     end
   end
-  
+
   context 'truncate_payload' do
     it 'should truncate all nested strings in the payload' do
       payload = {
@@ -698,26 +698,26 @@ describe Rollbar do
           :array => ['12345678', '12', {:inner_inner => '123456789'}]
         }
       }
-      
+
       payload_copy = payload.clone
       Rollbar.send(:truncate_payload, payload_copy, 6)
-      
+
       payload_copy[:truncated].should == '123...'
       payload_copy[:not_truncated].should == '123456'
       payload_copy[:hash][:inner_truncated].should == '123...'
       payload_copy[:hash][:inner_not_truncated].should == '567'
       payload_copy[:hash][:array].should == ['123...', '12', {:inner_inner => '123...'}]
     end
-    
+
     it 'should truncate utf8 strings properly' do
       payload = {
         :truncated => 'Ŝǻмρļẻ śţяịņģ',
         :not_truncated => '123456',
       }
-      
+
       payload_copy = payload.clone
       Rollbar.send(:truncate_payload, payload_copy, 6)
-      
+
       payload_copy[:truncated].should == "Ŝǻм..."
       payload_copy[:not_truncated].should == '123456'
     end
@@ -813,6 +813,35 @@ describe Rollbar do
         path.should == gem_paths[index]
       }
     end
+
+    it "should handle regex gem patterns" do
+      gems = ["rack", /rspec/]
+      gem_paths = []
+
+      Rollbar.configure do |config|
+        config.project_gems = gems
+      end
+
+      gem_paths = gems.map{|gem| Gem::Specification.find_all_by_name(gem).map(&:gem_dir) }.flatten.compact.uniq
+      gem_paths.length.should > 1
+
+      data = Rollbar.send(:message_data, 'test', 'info', {})
+      data[:project_package_paths].kind_of?(Array).should == true
+      data[:project_package_paths].length.should == gem_paths.length
+      (data[:project_package_paths] - gem_paths).length.should == 0
+    end
+
+    it "should not break on non-existent gems" do
+      gems = ["this_gem_does_not_exist", "rack"]
+
+      Rollbar.configure do |config|
+        config.project_gems = gems
+      end
+
+      data = Rollbar.send(:message_data, 'test', 'info', {})
+      data[:project_package_paths].kind_of?(Array).should == true
+      data[:project_package_paths].length.should == 1
+    end
   end
 
   context "report_internal_error" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 0.12.19
+  version: 0.12.20
 platform: ruby
 authors:
 - Brian Rue