rollbar 0.10.7 → 0.10.8

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+**0.10.8**
+- Better handling of internal errors. Internal errors (errors that occur while reporting something to Rollbar) are now themselves reported to Rollbar. If that fails, a failsafe message will be reported, and if that fails, the error will be logged as it is now.
+- Fix bug reporting exceptions with backtraces containing frames that don't match our regex.
+
 **0.10.7**
 - Add ability to report form validation errors
 - Add MIT license to gemspec

data/lib/rollbar.rb

@@ -1,4 +1,5 @@
 require 'net/https'
+
 require 'securerandom' if defined?(SecureRandom)
 require 'socket'
 require 'thread'
@@ -89,7 +90,7 @@ module Rollbar
       log_instance_link(data)
       data
     rescue => e
-      logger.error "[Rollbar] Error reporting exception to Rollbar: #{e}"
+      report_internal_error(e)
       'error'
     end
 
@@ -113,7 +114,7 @@ module Rollbar
       log_instance_link(data)
       data
     rescue => e
-      logger.error "[Rollbar] Error reporting message to Rollbar: #{e}"
+      report_internal_error(e)
       'error'
     end
 
@@ -140,7 +141,7 @@ module Rollbar
           send_payload(payload)
         end
       rescue => e
-        logger.error "[Rollbar] Error reporting message to Rollbar: #{e}"
+        log_error "[Rollbar] Error processing payload: #{e}"
       end
     end
 
@@ -154,9 +155,9 @@ module Rollbar
       require 'rollbar/rake' if defined?(Rake)
       require 'rollbar/better_errors' if defined?(BetterErrors)
     end
-
+    
     def log_instance_link(data)
-      logger.info "[Rollbar] Details: #{configuration.web_base}/instance/uuid?uuid=#{data[:uuid]} (only available if report was successful)"
+      log_info "[Rollbar] Details: #{configuration.web_base}/instance/uuid?uuid=#{data[:uuid]} (only available if report was successful)"
     end
 
     def ignored?(exception)
@@ -199,7 +200,11 @@ module Rollbar
         frames = exception.backtrace.map { |frame|
           # parse the line
           match = frame.match(/(.*):(\d+)(?::in `([^']+)')?/)
-          { :filename => match[1], :lineno => match[2].to_i, :method => match[3] }
+          if match
+            { :filename => match[1], :lineno => match[2].to_i, :method => match[3] }
+          else
+            { :filename => "<unknown>", :lineno => 0, :method => frame }
+          end
         }
         # reverse so that the order is as rollbar expects
         frames.reverse!
@@ -241,7 +246,7 @@ module Rollbar
     end
 
     def do_write_payload(payload)
-      logger.info '[Rollbar] Writing payload to file'
+      log_info '[Rollbar] Writing payload to file'
 
       begin
         unless @file
@@ -250,9 +255,9 @@ module Rollbar
 
         @file.puts payload
         @file.flush
-        logger.info "[Rollbar] Success"
+        log_info "[Rollbar] Success"
       rescue IOError => e
-        logger.error "[Rollbar] Error opening/writing to file: #{e}"
+        log_error "[Rollbar] Error opening/writing to file: #{e}"
       end
     end
 
@@ -260,20 +265,20 @@ module Rollbar
       req = EventMachine::HttpRequest.new(configuration.endpoint).post(:body => payload)
       req.callback do
         if req.response_header.status == 200
-          logger.info '[Rollbar] Success'
+          log_info '[Rollbar] Success'
         else
-          logger.warn "[Rollbar] Got unexpected status code from Rollbar.io api: #{req.response_header.status}"
-          logger.info "[Rollbar] Response: #{req.response}"
+          log_warning "[Rollbar] Got unexpected status code from Rollbar.io api: #{req.response_header.status}"
+          log_info "[Rollbar] Response: #{req.response}"
         end
       end
       req.errback do
-        logger.warn "[Rollbar] Call to API failed, status code: #{req.response_header.status}"
-        logger.info "[Rollbar] Error's response: #{req.response}"
+        log_warning "[Rollbar] Call to API failed, status code: #{req.response_header.status}"
+        log_info "[Rollbar] Error's response: #{req.response}"
       end
     end
 
     def send_payload(payload)
-      logger.info '[Rollbar] Sending payload'
+      log_info '[Rollbar] Sending payload'
 
       if configuration.use_eventmachine
         send_payload_using_eventmachine(payload)
@@ -292,15 +297,15 @@ module Rollbar
       response = http.request(request)
 
       if response.code == '200'
-        logger.info '[Rollbar] Success'
+        log_info '[Rollbar] Success'
       else
-        logger.warn "[Rollbar] Got unexpected status code from Rollbar api: #{response.code}"
-        logger.info "[Rollbar] Response: #{response.body}"
+        log_warning "[Rollbar] Got unexpected status code from Rollbar api: #{response.code}"
+        log_info "[Rollbar] Response: #{response.body}"
       end
     end
 
     def schedule_payload(payload)
-      logger.info '[Rollbar] Scheduling payload'
+      log_info '[Rollbar] Scheduling payload'
 
       if configuration.use_async
         unless configuration.async_handler
@@ -375,11 +380,105 @@ module Rollbar
 
         @queue.push(payload)
       else
-        logger.warn '[Rollbar] girl_friday not found to handle async call, falling back to Thread'
+        log_warning '[Rollbar] girl_friday not found to handle async call, falling back to Thread'
         Thread.new { process_payload(payload) }
       end
     end
+
+    # wrappers around logger methods
+    def log_error(message)
+      begin
+        logger.error message
+      rescue => e
+        puts "[Rollbar] Error logging error:"
+        puts "[Rollbar] #{message}"
+      end
+    end
+    
+    def log_info(message)
+      begin
+        logger.info message
+      rescue => e
+        puts "[Rollbar] Error logging info:"
+        puts "[Rollbar] #{message}"
+      end
+    end
+
+    def log_warning(message)
+      begin
+        logger.warn message
+      rescue => e
+        puts "[Rollbar] Error logging warning:"
+        puts "[Rollbar] #{message}"
+      end
+    end
+    
+    # Reports an internal error in the Rollbar library. This will be reported within the configured
+    # Rollbar project. We'll first attempt to provide a report including the exception traceback.
+    # If that fails, we'll fall back to a more static failsafe response.
+    def report_internal_error(exception)
+      log_error "[Rollbar] Reporting internal error encountered while sending data to Rollbar." 
+
+      begin
+        data = exception_data(exception, 'error')
+      rescue => e
+        send_failsafe("error in exception_data", e)
+        return
+      end
+
+      data[:internal] = true
+      
+      begin
+        payload = build_payload(data)
+      rescue => e
+        send_failsafe("error in build_payload", e) 
+        return
+      end
+        
+      begin
+        schedule_payload(payload)
+      rescue => e
+        send_failsafe("erorr in schedule_payload", e)
+        return
+      end
+
+      begin
+        log_instance_link(data)
+      rescue => e
+        send_failsafe("error logging instance link", e)
+        return
+      end
+    end
+
+    def send_failsafe(message, exception)
+      log_error "[Rollbar] Sending failsafe response."
+      log_error "[Rollbar] #{message} #{exception}"
+
+      config = configuration
+      environment = config.environment
+      
+      failsafe_payload = <<-eos
+      {"access_token": "#{config.access_token}",
+       "data": {
+         "level": "error",
+         "environment": "#{config.environment}",
+         "body": { "message": { "body": "Failsafe from rollbar-gem: #{message}" } },
+         "notifier": { "name": "rollbar-gem", "version": "#{VERSION}" },
+         "internal": true,
+         "failsafe": true
+       }
+      }
+      eos
+
+      begin
+        schedule_payload(failsafe_payload)
+      rescue => e
+        log_error "[Rollbar] Error sending failsafe : #{e}"
+      end
+    end
+  
   end
+
 end
 
 # Setting Ratchetio as an alias to Rollbar for ratchetio-gem backwards compatibility

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "0.10.7"
+  VERSION = "0.10.8"
 end

data/spec/rollbar_spec.rb

@@ -154,6 +154,25 @@ describe Rollbar do
         exception_data[:uuid].should_not be_nil
       end
     end
+
+    it 'should report exception objects with nonstandard backtraces' do
+      payload = nil
+      Rollbar.stub(:schedule_payload) do |*args|
+        payload = MultiJson.load(args[0])
+      end
+
+      class CustomException < StandardError
+        def backtrace
+          ["custom backtrace line"]
+        end
+      end
+
+      exception = CustomException.new("oops")
+
+      Rollbar.report_exception(exception)
+      
+      payload["data"]["body"]["trace"]["frames"][0]["method"].should == "custom backtrace line"
+    end
   end
 
   context 'report_message' do
@@ -198,7 +217,8 @@ describe Rollbar do
       c = { :b => b }
       a[:c] = c
 
-      logger_mock.should_receive(:error).with(/\[Rollbar\] Error reporting message to Rollbar: (nesting of \d+ is too deep|object references itself)/)
+      logger_mock.should_receive(:error).with(/\[Rollbar\] Reporting internal error encountered while sending data to Rollbar./)
+
       Rollbar.report_message("Test message with circular extra data", 'debug', a)
     end
 
@@ -578,6 +598,30 @@ describe Rollbar do
     end
   end
 
+  context "report_internal_error" do
+    it "should not crash when given an exception object" do
+      begin
+        1 / 0
+      rescue => e
+        Rollbar.send(:report_internal_error, e)
+      end
+    end
+  end
+
+  context "send_failsafe" do
+    it "should not crash when given a message and exception" do
+      begin
+        1 / 0
+      rescue => e
+        Rollbar.send(:send_failsafe, "test failsafe", e)
+      end
+    end
+
+    it "should not crash when given all nils" do
+      Rollbar.send(:send_failsafe, nil, nil)
+    end
+  end
+
   # configure with some basic params
   def configure
     Rollbar.reconfigure do |config|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 0.10.7
+  version: 0.10.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-05 00:00:00.000000000 Z
+date: 2013-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -288,4 +288,3 @@ test_files:
 - spec/requests/home_spec.rb
 - spec/rollbar_spec.rb
 - spec/spec_helper.rb
-has_rdoc: