roku_builder 4.9.2 → 4.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bc0f25a2308dd590a02ad47120860ed27d2034ec
-  data.tar.gz: 156f82b7949d6ab909a8958ad27406d863c1c746
+  metadata.gz: 36d7f8916f1accf419e300cf40cc9d7764c0f86f
+  data.tar.gz: 2fb64f3f10a5f731115bc8bd0d7b40777c99abc7
 SHA512:
-  metadata.gz: c08044d6035efaef54ea9c8ecb36515db3b63d57e36be385c38a839467c6230df903ece8884e0b2709c8bbfe57480481f2f7108aeb000d2cf729a4328ca58a3c
-  data.tar.gz: f1da45a41abdf6ee9b8acec4eab8080ba9bebc0e1b48d657dbebe827aff3de9f0473b1ee927eb1e0a34419ef77a7f275652e3c7ed0bbce8931acc322635dec00
+  metadata.gz: 2aabf35295f5317f61d74384ade158e1f7d4cf22047e285014ae24c68e2c850722bd6016067fa0876e6c6f121f08b0ef1a836af57e418f69460aec8bc05ec3f3
+  data.tar.gz: 58a14f12786f9e49cba4bd54c9283d96f371af444e32a3e549e59286e11568fe00ee72b2a2c4e0ad8555a8ed62647a54c5cb0268f921e66bee361aa388dc321e

data/CHANGELOG

@@ -1,3 +1,9 @@
+ = 4.9.3 =
+
+ - Fix crash on invlaid config
+ - Prevent loading incompatable file types
+ - Update Analyzer results for API access
+
  = 4.9.2 =
 
  - Cosmetic fixes

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    roku_builder (4.9.2)
+    roku_builder (4.9.3)
       faraday (~> 0.13)
       faraday-digestauth (~> 0.2)
       git (~> 1.3)

data/lib/roku_builder/config.rb

@@ -182,7 +182,7 @@ module RokuBuilder
     end
 
     def fix_config_symbol_values
-      if @config[:devices]
+      if @config[:devices] and @config[:devices][:default]
         @config[:devices][:default] = @config[:devices][:default].to_sym
       end
       if @config[:projects]
@@ -192,7 +192,9 @@ module RokuBuilder
     end
 
     def fix_project_config_symbol_values
-      @config[:projects][:default] = @config[:projects][:default].to_sym
+      if @config[:projects] [:default]
+        @config[:projects][:default] = @config[:projects][:default].to_sym
+      end
       @config[:projects].each_pair do |key,value|
         next if is_skippable_project_key? key
         if value[:stage_method]

data/lib/roku_builder/plugins/analyzer.rb

@@ -65,7 +65,8 @@ module RokuBuilder
           add_warning(warning: :packageSourceDirectory, path: "source")
         end
         @warnings.concat(raf_inspector.run(analyzer_config[:inspectors]))
-        print_warnings(dir) unless quiet
+        format_messages(dir)
+        print_warnings unless quiet
       end
       @warnings
     end
@@ -86,20 +87,15 @@ module RokuBuilder
       @warnings.last[:path] = path
     end
 
-    def print_warnings(dir)
+    def print_warnings
       logger = ::Logger.new(STDOUT)
       logger.level  = @logger.level
       logger.formatter = proc {|severity, _datetime, _progname, msg|
         "%5s: %s\n\r" % [severity, msg]
       }
+      @logger.unknown "====== Analysis Results ======"
       @warnings.each do |warning|
         message = warning[:message]
-        if warning[:path]
-          warning[:path].slice!(dir) if dir
-          warning[:path].slice!(/^\//)
-          message += ". pkg:/"+warning[:path]
-          message += ":"+(warning[:line]+1).to_s if warning[:line]
-        end
         case(warning[:severity])
         when "error"
           logger.error(message)
@@ -110,6 +106,17 @@ module RokuBuilder
         end
       end
     end
+
+    def format_messages(dir)
+      @warnings.each do |warning|
+        if warning[:path]
+          warning[:path].slice!(dir) if dir
+          warning[:path].slice!(/^\//)
+          warning[:message] += ". pkg:/"+warning[:path]
+          warning[:message] += ":"+(warning[:line]+1).to_s if warning[:line]
+        end
+      end
+    end
   end
   RokuBuilder.register_plugin(Analyzer)
 end

data/lib/roku_builder/plugins/loader.rb

@@ -154,7 +154,12 @@ module RokuBuilder
         else
           unless excludes.include?(zipFilePath)
             if File.exist?(diskFilePath)
-              io.get_output_stream(zipFilePath) { |f| f.puts(File.open(diskFilePath, "rb").read()) }
+              # Deny filetypes that aren't compatible with Roku to avoid Certification issues.
+              if !zipFilePath.end_with?(".pkg", ".md", ".zip")
+                io.get_output_stream(zipFilePath) { |f| f.puts(File.open(diskFilePath, "rb").read()) }
+              else
+                @logger.warn "Ignored file with invalid Roku filetype " + File.basename(diskFilePath)
+              end
             else
               @logger.warn "Missing File: #{diskFilePath}"
             end

data/lib/roku_builder/version.rb

@@ -2,5 +2,5 @@
 
 module RokuBuilder
   # Version of the RokuBuilder Gem
-  VERSION = "4.9.2"
+  VERSION = "4.9.3"
 end

data/test/roku_builder/plugins/test_analyzer.rb

@@ -316,7 +316,7 @@ module RokuBuilder
     def test_performance_aa_string_ref
       warnings = test_file(text: "aa[\"test\"] = \"test\"")
       assert_equal 1, warnings.count
-      assert_match(/String referance/, warnings[0][:message])
+      assert_match(/String reference/, warnings[0][:message])
     end
     def test_performance_for_loop
       warnings = test_file(text: "FOR i=0 TO 10\n ? i\nEND FOR")

data/test/roku_builder/test_config.rb

@@ -298,5 +298,15 @@ module RokuBuilder
       refute_nil config.input_mappings
       assert_equal ["home", "Home"], config.input_mappings[:a]
     end
+    def test_config_no_default_device
+      options = build_options({config: File.join(test_files_path(ConfigTest), "no_default_project.json"), validate: true})
+      config = Config.new(options: options)
+      config.load
+    end
+    def test_config_no_default_project
+      options = build_options({config: File.join(test_files_path(ConfigTest), "no_default_device.json"), validate: true})
+      config = Config.new(options: options)
+      config.load
+    end
   end
 end

data/test/roku_builder/test_files/config_test/no_default_device.json

@@ -0,0 +1,31 @@
+{
+  "devices": {
+    "roku": {
+      "ip": "111.222.333.444",
+      "user": "user",
+      "password": "pass"
+    }
+  },
+  "projects": {
+    "default": "p1",
+    "p1": {
+      "directory": "/tmp",
+      "folders": ["resources","source"],
+      "files": ["manifest"],
+      "app_name": "app",
+      "stage_method": "git",
+      "stages":{
+        "production": {
+          "branch": "master",
+          "key": {
+            "keyed_pkg": "/tmp/package.pkg",
+            "password": "password"
+          }
+        }
+      }
+    }
+  },
+  "input_mappings": {
+    "a": ["home", "Home"]
+  }
+}

data/test/roku_builder/test_files/config_test/no_default_project.json

@@ -0,0 +1,31 @@
+{
+  "devices": {
+    "default": "roku",
+    "roku": {
+      "ip": "111.222.333.444",
+      "user": "user",
+      "password": "pass"
+    }
+  },
+  "projects": {
+    "p1": {
+      "directory": "/tmp",
+      "folders": ["resources","source"],
+      "files": ["manifest"],
+      "app_name": "app",
+      "stage_method": "git",
+      "stages":{
+        "production": {
+          "branch": "master",
+          "key": {
+            "keyed_pkg": "/tmp/package.pkg",
+            "password": "password"
+          }
+        }
+      }
+    }
+  },
+  "input_mappings": {
+    "a": ["home", "Home"]
+  }
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roku_builder
 version: !ruby/object:Gem::Version
-  version: 4.9.2
+  version: 4.9.3
 platform: ruby
 authors:
 - greeneca
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-19 00:00:00.000000000 Z
+date: 2018-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -554,6 +554,8 @@ files:
 - test/roku_builder/test_files/config_test/config.json
 - test/roku_builder/test_files/config_test/local.json
 - test/roku_builder/test_files/config_test/multi_repeat_stages.json
+- test/roku_builder/test_files/config_test/no_default_device.json
+- test/roku_builder/test_files/config_test/no_default_project.json
 - test/roku_builder/test_files/config_test/non_json.json
 - test/roku_builder/test_files/config_test/parent.json
 - test/roku_builder/test_files/config_test/parent_projects.json
@@ -677,6 +679,8 @@ test_files:
 - test/roku_builder/test_files/config_test/config.json
 - test/roku_builder/test_files/config_test/local.json
 - test/roku_builder/test_files/config_test/multi_repeat_stages.json
+- test/roku_builder/test_files/config_test/no_default_device.json
+- test/roku_builder/test_files/config_test/no_default_project.json
 - test/roku_builder/test_files/config_test/non_json.json
 - test/roku_builder/test_files/config_test/parent.json
 - test/roku_builder/test_files/config_test/parent_projects.json