roku_builder 4.17.0 → 4.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0f330332e0ec4f1832974dee629495887c1f3be1
-  data.tar.gz: 3b3f9230bfaaffc212e746465754489efcf39bf3
+SHA256:
+  metadata.gz: 114ba37cf715600a090d737d83c708b116b2f609c7e261edc235f08c925f0ece
+  data.tar.gz: 2d67e30e939dbe815bccc49be7da543331b78291c6c87c75d2fceaf70cfb7ee6
 SHA512:
-  metadata.gz: 840ef1b935ba37594e9134b11736513b856add2e99741d5161f8b5fdd8c78e7b705ef25763eeedc838c1280777d9b639fbf2c983a60575ecf608910e0a3e5a1c
-  data.tar.gz: 18e06f83b9720f426c4ed6d2b4980b95692a0205f3747cd5405d2d28e2a34be66953e888d63aa32e447169be918d383dceae43e6b60ec3dbcb8c0902783a991f
+  metadata.gz: 81a51cb1b9af95b7aade298176f544747b08f300eb553b9bd171da5a006fce7f40fd16bf5330e4f8d257da7ea5f97312f7d54eeb6ea3e1fbafc75f0f4eb8f24c
+  data.tar.gz: '0369e150700a626cf96b7651704cf52c581c194562ac41dc8f066a0015c8aa08505f252c81f870dd2a9318e1c0c3613a465b5c45a437ff3607ca840ddb966afe'

data/CHANGELOG

@@ -1,3 +1,8 @@
+ = 4.17.1 =
+
+ - Remove requirement for project default in config
+ - Remove testing of sd icon resolution
+
  = 4.17.0 =
 
  - Add ability to convert a package to squashfs

data/lib/roku_builder/config_parser.rb

@@ -46,9 +46,10 @@ module RokuBuilder
         project = current_project
         if project
           @options[:project] = project
-        else
+        elsif @config[:projects][:default]
           @options[:project] = @config[:projects][:default]
         end
+        raise ArgumentError, "A project is required for that command" unless @options[:project]
       end
     end
 

data/lib/roku_builder/config_validator.rb

@@ -113,8 +113,7 @@ module RokuBuilder
         [MISSING_DEVICES, !@config[:devices]],
         [MISSING_DEVICES_DEFAULT, (@config[:devices] and !@config[:devices][:default])],
         [DEVICE_DEFAULT_BAD, (@config[:devices] and @config[:devices][:default] and !@config[:devices][:default].is_a?(Symbol))],
-        [MISSING_PROJECTS_DEFAULT, (@config[:projects] and !@config[:projects][:default])],
-        [MISSING_PROJECTS_DEFAULT, (@config[:projects] and @config[:projects][:default] == "<project id>".to_sym)],
+        [MISSING_PROJECTS_DEFAULT, (@config[:projects] and @config[:projects][:default] and @config[:projects][:default] == "<project id>".to_sym)],
         [PROJECTS_DEFAULT_BAD, (@config[:projects] and @config[:projects][:default] and !@config[:projects][:default].is_a?(Symbol))]
       ]
       process_errors(errors: errors)

data/lib/roku_builder/plugins/manifest_attributes.json

@@ -33,12 +33,7 @@
     "resolution": [336, 210]
   },
   "mm_icon_focus_sd": {
-    "required": true,
-    "validations": {
-      "starts_with": "pkg:/"
-    },
-    "isResource": true,
-    "resolution": [246, 140]
+    "required": true
   },
   "splash_screen_fhd": {
     "validations": {

data/lib/roku_builder/version.rb

@@ -2,5 +2,5 @@
 
 module RokuBuilder
   # Version of the RokuBuilder Gem
-  VERSION = "4.17.0"
+  VERSION = "4.17.1"
 end

data/test/roku_builder/plugins/test_analyzer.rb

@@ -160,6 +160,10 @@ module RokuBuilder
       assert_equal 5, warnings[0][:line]
       assert_equal "manifest", warnings[0][:path]
     end
+    def test_manifest_sd_image_resolution
+      warnings = test_manifest("manifest_sd_image_resolution")
+      assert_equal 0, warnings.count
+    end
     def test_line_inspector_depricated_component
       warnings = test_file(text: "\"roVideoScreen\"")
       assert_equal 1, warnings.count

data/test/roku_builder/plugins/test_packager.rb

@@ -95,7 +95,7 @@ module RokuBuilder
       logger.expect(:debug, nil, [String])
       io.expect(:each_line, nil)
       logger.expect(:info, nil) do |message|
-        assert_match(/\/tmp\//, message)
+        assert_match(/#{tmp_folder}/, message)
       end
 
       Logger.class_variable_set(:@@instance, logger)
@@ -143,7 +143,7 @@ module RokuBuilder
       logger.expect(:debug, nil, [String])
       io.expect(:each_line, nil)
       logger.expect(:info, nil) do |message|
-        assert_match(/\/tmp\//, message)
+        assert_match(/#{tmp_folder}/, message)
       end
 
       Logger.class_variable_set(:@@instance, logger)

data/test/roku_builder/test_config_parser.rb

@@ -186,7 +186,7 @@ module RokuBuilder
       config[:projects][:project2][:directory] = "project2"
 
       configs = nil
-      Pathname.stub(:pwd, Pathname.new("/tmp/project2")) do
+      Pathname.stub(:pwd, Pathname.new("/tmp/project2").realdirpath) do
         Dir.stub(:exist?, true) do
           configs = ConfigParser.parse(options: options, config: config)
         end
@@ -289,7 +289,7 @@ module RokuBuilder
       refute_nil parsed[:out]
       refute_nil parsed[:out][:folder]
       assert_nil parsed[:out][:file]
-      assert_equal "/tmp", parsed[:out][:folder]
+      assert_equal tmp_folder, parsed[:out][:folder]
     end
     def test_outfile_config_folder
       config = good_config(ConfigParserTest)
@@ -342,7 +342,7 @@ module RokuBuilder
       refute_nil parsed[:out]
       refute_nil parsed[:out][:folder]
       refute_nil parsed[:out][:file]
-      assert_equal "/tmp", parsed[:out][:folder]
+      assert_equal tmp_folder, parsed[:out][:folder]
       assert_equal "file.jpg", parsed[:out][:file]
     end
   end

data/test/roku_builder/test_config_validator.rb

@@ -100,13 +100,6 @@ module RokuBuilder
       assert validator.is_valid?
     end
 
-    def test_config_manager_validate_projects_default
-      config = good_config
-      config[:projects][:default] = nil
-      validator = ConfigValidator.new(config: config)
-      assert_equal [5], validator.instance_variable_get(:@codes)
-    end
-
     def test_config_manager_validate_projects_default_default_value
       config = good_config
       config[:projects][:default] = "<project id>".to_sym

data/test/roku_builder/test_files/analyzer_test/manifest_sd_image_resolution

@@ -0,0 +1,9 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=01
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/too_small.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png
+splash_color=#121212

data/test/roku_builder/test_helper.rb

@@ -61,6 +61,10 @@ def build_options(options = {validate: true}, empty_plugins = true)
   options
 end
 
+def tmp_folder()
+  Dir.tmpdir()
+end
+
 def good_config(klass=nil)
   root_dir = "/tmp"
   root_dir = test_files_path(klass) if klass

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roku_builder
 version: !ruby/object:Gem::Version
-  version: 4.17.0
+  version: 4.17.1
 platform: ruby
 authors:
 - greeneca
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-26 00:00:00.000000000 Z
+date: 2019-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -546,6 +546,7 @@ files:
 - test/roku_builder/test_files/analyzer_test/manifest_missing_attribute
 - test/roku_builder/test_files/analyzer_test/manifest_missing_file
 - test/roku_builder/test_files/analyzer_test/manifest_raf
+- test/roku_builder/test_files/analyzer_test/manifest_sd_image_resolution
 - test/roku_builder/test_files/analyzer_test/manifest_template
 - test/roku_builder/test_files/analyzer_test/test.pkg
 - test/roku_builder/test_files/config_parser_test/test.pkg
@@ -629,7 +630,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.9
 signing_key: 
 specification_version: 4
 summary: Build Tool for Roku Apps
@@ -672,6 +673,7 @@ test_files:
 - test/roku_builder/test_files/analyzer_test/manifest_missing_attribute
 - test/roku_builder/test_files/analyzer_test/manifest_missing_file
 - test/roku_builder/test_files/analyzer_test/manifest_raf
+- test/roku_builder/test_files/analyzer_test/manifest_sd_image_resolution
 - test/roku_builder/test_files/analyzer_test/manifest_template
 - test/roku_builder/test_files/analyzer_test/test.pkg
 - test/roku_builder/test_files/config_parser_test/test.pkg