roku_builder 4.15.2 → 4.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 15c7285bfc47e89eef7a69a1e1545f04900f8925
-  data.tar.gz: 44e0ecbd3633f060d3953ab1331daeb13c6476d7
+  metadata.gz: b6a3e4bd8c77f11f513140b9429bf590bd7d61a1
+  data.tar.gz: 0b816aab48e6ffe5303ba740b068b1cf55416682
 SHA512:
-  metadata.gz: 4b4a17b345696de133524d62ddfc57f92f88b62d8349778be77846d70c7f44516b6d315ecf23a8f3ed852c76535de437f53099bcedc72bf2d2018086f72c6f8a
-  data.tar.gz: f844562a43f291e0423db7874a3e8a1eb10bc5218396bec0213f623e972570f18c712def2fcc8dd77493ee360734bbfcc0fa3fa38dfcc5c7fa7f18568dc0d603
+  metadata.gz: 5eede887d08c2505cdde41e30839795a61b07b7f98a50ffcdf7521169f76e367fa58364dc94503a2f59a55606854d07a6e4cd2871cf994111135167272ee411a
+  data.tar.gz: b62a5ded206dd32074409f89f4f52126b2b9d6b091a808f7723f702fe61e01a9bf64ee3076ba6d1a5d4ba5d15089411206932a48f14150fec781c28d0227c778

data/.travis.yml

@@ -1,3 +1,5 @@
 language: ruby
 rvm:
   - "2.4.1"
+before_install:
+    - gem install bundler

data/CHANGELOG

@@ -1,3 +1,11 @@
+ = 4.16.1 =
+
+ - Fixes for indentation checker
+
+ = 4.16.0 =
+
+ - Allow plugins to validate themselves
+
  = 4.15.2 =
 
  - Allow linter checks to check comments

data/lib/roku_builder.rb

@@ -87,6 +87,7 @@ module RokuBuilder
   def self.setup_plugins
     load_plugins
     process_plugins
+    validate_plugins
   end
 
   def self.load_plugins
@@ -145,6 +146,12 @@ module RokuBuilder
     end
   end
 
+  def self.validate_plugins
+    @@plugins.each do |plugin|
+      plugin.validate
+    end
+  end
+
   def self.initialize_logger
     if @@options[:debug]
       Logger.set_debug

data/lib/roku_builder/plugin.rb

@@ -26,5 +26,9 @@ module RokuBuilder
     def dependencies
       []
     end
+
+    def validate
+      # No default validations
+    end
   end
 end

data/lib/roku_builder/plugins/indentation_inspector.rb

@@ -42,6 +42,8 @@ module RokuBuilder
             # Don't change indentation
           elsif @prev_line =~ /[\{\[\(:]$/
             @ind += @count
+          elsif @prev_line =~ /:\s*\bfunction\b|:\s*\bsub\b/i
+            @ind += @count
           elsif @prev_line =~ /^\s*\bfunction\b|^\s*\bsub\b/i
             @ind += @count
           elsif @prev_line =~ /^\s*#?if\b|^\s*#?else\b/i

data/lib/roku_builder/plugins/performance_config.json

@@ -1,6 +1,6 @@
 [
   {
-    "regex": "\\sas\\s(Object|Boolean|String|Integer|LongInteger|Double|Float|Function|Dynamic)",
+    "regex": "\\sas\\s+(Object|Boolean|String|Integer|LongInteger|Double|Float|Function|Dynamic)",
     "severity": "warning",
     "message": "Found function return type. Consider removing"
   } ,

data/lib/roku_builder/version.rb

@@ -2,5 +2,5 @@
 
 module RokuBuilder
   # Version of the RokuBuilder Gem
-  VERSION = "4.15.2"
+  VERSION = "4.16.1"
 end

data/test/roku_builder/test_plugin.rb

@@ -30,6 +30,14 @@ module RokuBuilder
       assert_equal Array, TestClass2.dependencies.class
       assert_equal TestClass, TestClass2.dependencies[0]
     end
+    def test_module_validate_none
+      TestClass.validate
+    end
+    def test_module_validate_failure
+      assert_raises InvalidConfig do
+        TestClass2.validate
+      end
+    end
   end
   class TestClass
     extend Plugin
@@ -43,6 +51,9 @@ module RokuBuilder
     def self.dependencies
       [TestClass]
     end
+    def self.validate
+      raise InvalidConfig
+    end
   end
 end
 

data/test/roku_builder/test_roku_builder.rb

@@ -210,6 +210,16 @@ module RokuBuilder
       end
       config.verify
     end
+    def test_roku_builder_validate_success
+      RokuBuilder.register_plugin(TestPlugin)
+      RokuBuilder.validate_plugins
+    end
+    def test_roku_builder_validate_failure
+      RokuBuilder.register_plugin(TestPlugin5)
+      assert_raises InvalidConfig do
+        RokuBuilder.validate_plugins
+      end
+    end
   end
   class TestPlugin
     extend Plugin
@@ -235,5 +245,14 @@ module RokuBuilder
       {test: {}}
     end
   end
+  class TestPlugin5
+    extend Plugin
+    def self.commands
+      {}
+    end
+    def self.validate
+      raise InvalidConfig
+    end
+  end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roku_builder
 version: !ruby/object:Gem::Version
-  version: 4.15.2
+  version: 4.16.1
 platform: ruby
 authors:
 - greeneca
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-06 00:00:00.000000000 Z
+date: 2019-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip